[PATCH 0/2] qemu: Match firmware with fully resolved and canonicalized paths

2025-08-01 Thread Michal Privoznik via Devel
As promised, this is a resend of previous patches: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/XVHIWFXSF5NOPUL4LTU7IGXZWTH43BBC/ Diff to v1: - new patch 1/2 which fixes the mocking. James Le Cuirot (1): qemu: Match firmware with fully resolved and canonicalized paths

Re: [PATCH 0/2] qemu: Match firmware with fully resolved and canonicalized paths

2025-07-29 Thread Michal Prívozník via Devel
On 7/29/25 13:08, Daniel P. Berrangé wrote: > On Tue, Jul 29, 2025 at 01:02:18PM +0200, Peter Krempa via Devel wrote: >> On Tue, Jul 29, 2025 at 10:42:09 +0200, Michal Prívozník via Devel wrote: >>> On 7/24/25 15:49, James Le Cuirot wrote: From: James Le Cuirot Distros may provide c

Re: [PATCH 0/2] qemu: Match firmware with fully resolved and canonicalized paths

2025-07-29 Thread Daniel P . Berrangé via Devel
On Tue, Jul 29, 2025 at 01:02:18PM +0200, Peter Krempa via Devel wrote: > On Tue, Jul 29, 2025 at 10:42:09 +0200, Michal Prívozník via Devel wrote: > > On 7/24/25 15:49, James Le Cuirot wrote: > > > From: James Le Cuirot > > > > > > Distros may provide compatibility symlinks after moving firmware

Re: [PATCH 0/2] qemu: Match firmware with fully resolved and canonicalized paths

2025-07-29 Thread Peter Krempa via Devel
On Tue, Jul 29, 2025 at 10:42:09 +0200, Michal Prívozník via Devel wrote: > On 7/24/25 15:49, James Le Cuirot wrote: > > From: James Le Cuirot > > > > Distros may provide compatibility symlinks after moving firmware files > > around, but they won't work for existing VMs when doing a straight > >

Re: [PATCH 0/2] qemu: Match firmware with fully resolved and canonicalized paths

2025-07-29 Thread Michal Prívozník via Devel
On 7/24/25 15:49, James Le Cuirot wrote: > From: James Le Cuirot > > Distros may provide compatibility symlinks after moving firmware files > around, but they won't work for existing VMs when doing a straight > string comparison. > > virFileComparePaths has been used to do this, but it was previ

[PATCH 0/2] qemu: Match firmware with fully resolved and canonicalized paths

2025-07-25 Thread James Le Cuirot
From: James Le Cuirot Distros may provide compatibility symlinks after moving firmware files around, but they won't work for existing VMs when doing a straight string comparison. virFileComparePaths has been used to do this, but it was previously only resolving the last path component, despite w