Re: [PATCH] qemuSnapshotDeleteValidate: Fix crash when disk is not found in VM definition

2025-04-24 Thread Peter Krempa via Devel
On Tue, Apr 22, 2025 at 18:51:18 +0800, jungleman759 wrote: > Hi > Thanks for following up, and sorry for the delay in getting back to you. > You're right to suspect the issue might be related to device changes. Here’s > how the crash can be triggered: > The VM initially uses a SATA controller, wi

Re: [PATCH] qemuSnapshotDeleteValidate: Fix crash when disk is not found in VM definition

2025-04-22 Thread jungleman759
Hi Thanks for following up, and sorry for the delay in getting back to you. You're right to suspect the issue might be related to device changes. Here’s how the crash can be triggered: The VM initially uses a SATA controller, with a disk defined as: xml 复制编辑 A snapshot is created at this p

Re: [PATCH] qemuSnapshotDeleteValidate: Fix crash when disk is not found in VM definition

2025-04-22 Thread jungleman759
Hi Thanks for following up, and sorry for the delay in getting back to you. You're right to suspect the issue might be related to device changes. Here’s how the crash can be triggered: The VM initially uses a SATA controller, with a disk defined as: xml 复制编辑 A snapshot is created at this p

Re: [PATCH] qemuSnapshotDeleteValidate: Fix crash when disk is not found in VM definition

2025-01-29 Thread Peter Krempa
On Fri, Nov 29, 2024 at 22:56:45 +0800, kaihuan wrote: > qemuDomainDiskByName() can return a NULL pointer on failure. > But this returned value in qemuSnapshotDeleteValidate is not checked.It will > make libvirtd crash. > > Signed-off-by: kaihuan > --- > src/qemu/qemu_snapshot.c | 15 ++

Re: [PATCH] qemuSnapshotDeleteValidate: Fix crash when disk is not found in VM definition

2025-01-29 Thread Peter Krempa
On Wed, Jan 22, 2025 at 14:05:18 +0100, Martin Kletzander wrote: > On Fri, Nov 29, 2024 at 10:56:45PM +0800, kaihuan wrote: > > qemuDomainDiskByName() can return a NULL pointer on failure. > > But this returned value in qemuSnapshotDeleteValidate is not checked.It > > will make libvirtd crash. > >

Re: [PATCH] qemuSnapshotDeleteValidate: Fix crash when disk is not found in VM definition

2025-01-22 Thread Martin Kletzander
On Fri, Nov 29, 2024 at 10:56:45PM +0800, kaihuan wrote: qemuDomainDiskByName() can return a NULL pointer on failure. But this returned value in qemuSnapshotDeleteValidate is not checked.It will make libvirtd crash. Hi, looking through old unreviewed patches I found this one. Sorry for the w

[PATCH] qemuSnapshotDeleteValidate: Fix crash when disk is not found in VM definition

2024-11-29 Thread kaihuan
qemuDomainDiskByName() can return a NULL pointer on failure. But this returned value in qemuSnapshotDeleteValidate is not checked.It will make libvirtd crash. Signed-off-by: kaihuan --- src/qemu/qemu_snapshot.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a