Re: [PATCH v2] virsh: Provide completer for some pool-X-as commands

2024-07-23 Thread atp exp
On Tue, 23 Jul 2024 at 12:42, Martin Kletzander wrote: > On Wed, May 29, 2024 at 06:49:06AM -0400, Abhiram Tilak wrote: > >Provides completers for auth-type and source-format commands for > >virsh pool-create-as and pool-define-as commands. Use Empty completers > >for options where completions ar

Re: [PATCH] virsh: Provide completer for some pool-X-as commands

2024-05-29 Thread atp exp
On Tue, 28 May 2024 at 17:35, Peter Krempa wrote: > On Mon, May 27, 2024 at 18:34:38 +, Abhiram Tilak wrote: > > Provides completers for auth-type and source-format commands for > > virsh pool-create-as and pool-define-as commands. Use Empty completers > > for options where completions are no

Re: [PATCH] virsh: Provide completer for some pool-X-as commands

2024-05-28 Thread atp exp
This patch was considerably old (like 10 days), it got stuck in the mailing list and had to resend this. I didn't rebase this to master before sending, hence the conflicts. On Tue, 28 May 2024 at 00:06, Abhiram Tilak wrote: > Provides completers for auth-type and source-format commands for > vir

Re: [PATCH v2] network: add modify-or-add feature to net-update

2024-05-21 Thread atp exp
nvm, the command was not working due to a different reason. The indexes used in delete and modify were still `i` need to update that. On Tue, 21 May 2024 at 15:31, atp exp wrote: > > On Wed, 15 May 2024 at 15:43, Abhiram Tilak wrote: > >> The current way of updating a networ

Re: [PATCH v2] network: add modify-or-add feature to net-update

2024-05-21 Thread atp exp
On Wed, 15 May 2024 at 15:43, Abhiram Tilak wrote: > The current way of updating a network configuration uses `virsh > net-update` to add, delete or modify entries. But with such a mechansim > one should know if an entry with current info already exists. Adding > modify-or-add option automaticall

Re: [PATCH v2] network: add modify-or-add feature to net-update

2024-05-20 Thread atp exp
Please ignore this, forgot to add v2 in `git-send-email` On Wed, 15 May 2024 at 15:41, Abhiram Tilak wrote: > The current way of updating a network configuration uses `virsh > net-update` to add, delete or modify entries. But with such a mechansim > one should know if an entry with current info

Re: [PATCH] network: add modify-or-add feature to net-update

2024-05-20 Thread atp exp
On Tue, 14 May 2024 at 18:33, Martin Kletzander wrote: > On Sat, Mar 16, 2024 at 01:43:52AM +0530, Abhiram Tilak wrote: > >The current way of updating a network configuration uses `virsh > >net-update` to add, delete or modify entries. But with such a mechansim > >one should know if an entry with

Re: [PATCH v2] docs: formatsnapshot: add docs for snapshotDeleteInProgress

2024-05-20 Thread atp exp
Alright. I will check it out. On Wed, 15 May 2024 at 12:03, Peter Krempa wrote: > On Mon, May 13, 2024 at 20:37:53 +0530, Abhiram Tilak wrote: > > Adds documentation for the element to > > the libvirt snapshot format XML reference. The > > > element, introduced at commit 565bcb5d79, ensures th

Re: [PATCH] docs: mention migrate-setmaxdowntime's impact on snapshot-create

2024-05-14 Thread atp exp
On Mon, 13 May 2024 at 13:38, Peter Krempa wrote: > On Mon, May 13, 2024 at 01:36:27 +0530, Abhiram Tilak wrote: > > The migrate-setmaxdowntime command sets the max allowed downtime during > > live-migration, but since `snapshot-create` performs qmp migration, it > also > > affects the downtime d

Re: [PATCH] "docs: formatsnapshot: add docs for snapshotDeleteInProgress"

2024-05-14 Thread atp exp
On Mon, 13 May 2024 at 13:39, Peter Krempa wrote: >> + ``snapshotDeleteInProgress`` >> + >> + If a the snapshot is marked for deletion, the disk is invalidated. The >> + sub-element ``snapshotDeleteInProgress`` marks the disk in the snapshot >> + as invalid until the

Re: [PATCH] network: add modify-or-add feature to net-update

2024-05-13 Thread atp exp
ping, it's been a while since i have put this out. On Sat, 16 Mar 2024 at 01:51, Abhiram Tilak wrote: > The current way of updating a network configuration uses `virsh > net-update` to add, delete or modify entries. But with such a mechansim > one should know if an entry with current info alread

Re: [PATCH v2] storage: Upgrade default qcow2 verion to 1.1

2024-03-06 Thread atp exp
Apparently, if you change the commit message, patchew doesn't pick up v2 and mark the v1 as old (O). Sorry for the inconvenience if there is a patch, with a changed commit message [1], please ignore it and consider the present one. [1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.

Re: [PATCH 1/2] storage: change assigning qcow2 compat to 1.1 from 0.10 automatically

2024-03-05 Thread atp exp
On Tue, 5 Mar 2024 at 14:00, Peter Krempa wrote: > > Just a note, please don't CC random people from the mailing list in the > libvirt project. In projects with faster patch frequencies, I typically CC maintainers for efficient communication. However, considering there's no separate MAINTAINERS f