Re: [PATCH] tests: Record negative tests as pass instead of expected-fail

On Mon, 2025-02-10 at 12:44 +0100, Peter Krempa wrote: > On Mon, Feb 10, 2025 at 11:30:24 +0100, Peter Krempa wrote: > > On Mon, Feb 10, 2025 at 11:25:55 +0100, Tim Wiederhake wrote: > > > meson's "test()" function provides a "should_fail: bool" argume

[PATCH] tests: Record negative tests as pass instead of expected-fail

OK 0.03s ... Ok: 300 Expected Fail: 0 Fail: 0 Unexpected Pass:0 Skipped: 0 Timeout:0 Signed-off-by: Tim Wiederhake --- tests/expected-fail | 13 + tests/

[PATCH] cpu_map: Add missing feature "bhi-no"

Introduced in qemu commit b611931d4f70b9a3e49e39c405c63b3b5e9c0df1. Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index d06d60e230..08519a37bf 100644 --- a/src

[PATCH] cpu_map: Add SierraForest CPU model

This was added in qemu commit 6e82d3b6220777667968a04c87e1667f164ebe88. Signed-off-by: Tim Wiederhake --- src/cpu_map/index.xml | 1 + src/cpu_map/x86_SierraForest.xml | 177 ++ .../domaincapsdata/qemu_9.1.0-q35.x86_64.xml | 1

[PATCH] cpu_map: Add missing feature "avx-vnni-int16"

Introduced in qemu commit 138c3377a9b27accec516b2c0da90dedef98a780. Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 19904f2e22..08bf014604 100644 --- a/src

Re: [PATCH 1/2] hyperv: Support hv-emsr-bitmap enlightenment

On Wed, 2024-08-21 at 12:19 +0200, Martin Kletzander wrote: > On Thu, Aug 15, 2024 at 03:57:35PM +0200, Tim Wiederhake wrote: > > qemu supports this enlightenment since version 7.10. > > > > From the qemu commit: > >    The newly introduced enlightenment allow L0

[PATCH 2/2] hyperv: Support hv-xmm-input enlightenment

KVM can avoid reading guest's memory. Signed-off-by: Tim Wiederhake --- docs/formatdomain.rst | 2 ++ src/conf/domain_conf.c | 4 src/conf/domain_conf.h | 1 + src/conf/schemas/domaincommon.rng

[PATCH 1/2] hyperv: Support hv-emsr-bitmap enlightenment

qemu supports this enlightenment since version 7.10. >From the qemu commit: The newly introduced enlightenment allow L0 (KVM) and L1 (Hyper-V) hypervisors to collaborate to avoid unnecessary updates to L2 MSR-Bitmap upon vmexits. Signed-off-by: Tim Wiederhake --- d

[PATCH 0/2] Add support for new hv enlightenments

Both were added in qemu 7.10. Add support for libvirt. Note that the feature names use dashes in qemu but underscores in libvirt domain conf xml to match other hv features, e.g. "vendor_id". Tim Wiederhake (2): hyperv: Support hv-emsr-bitmap enlightenment hyperv: Support hv

Re: [PATCH 1/2] virMutex: Warn on error

On Thu, 2024-07-04 at 08:10 +0100, Daniel P. Berrangé wrote: > On Wed, Jul 03, 2024 at 02:44:37PM +0200, Tim Wiederhake wrote: > > `pthread_mutex_destroy`, `pthread_mutex_lock` and > > `pthread_mutex_unlock` > > return an error code that is currently ignored. > > >

Re: [PATCH] cpu_map: Add libcpuinfo as optional data source

ping On Fri, 2024-06-21 at 15:24 +0200, Tim Wiederhake wrote: > This adds an option to use libcpuinfo [1] as data source for > libvirt's list of x86 cpu features. This is purely optional and > does not change the script's behavior if libcpuinfo is not > installed. >

[PATCH 1/2] sync_qemu_models_i386.py: Add missing features

This brings the tool's list of features in sync with qemu commit 37fbfda8f4145ba1700f63f0cb7be4c108d545de. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_models_i386.py | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cpu_map/sync_qemu_models_i386.py b/src/cp

[PATCH 2/2] cpu_map: Add GraniteRapids CPU model

This was added in qemu commit 6d5e9694ef. Signed-off-by: Tim Wiederhake --- src/cpu_map/index.xml | 1 + src/cpu_map/meson.build | 1 + src/cpu_map/x86_GraniteRapids.xml | 200 ++ .../domaincapsdata/qemu_8.1.0-q35

[PATCH 0/2] Add Granite Rapids cpu model

Also, update the sync tool with new features introduced in qemu. Tim Wiederhake (2): sync_qemu_models_i386.py: Add missing features cpu_map: Add GraniteRapids CPU model src/cpu_map/index.xml | 1 + src/cpu_map/meson.build | 1 + src/cpu_map

[PATCH 2/2] DO NOT MERGE: virMutex: Fail loudly

* qemumonitorjsontest * qemusecuritytest * qemuxmlconftest Signed-off-by: Tim Wiederhake --- src/util/virthread.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util/virthread.c b/src/util/virthread.c index 14116a2221..dc51144d48 100644 --- a/src/util/virthread.c +++ b/src/util/virthread.c

[PATCH 1/2] virMutex: Warn on error

considered undefined behavior. Signed-off-by: Tim Wiederhake --- src/util/virthread.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/util/virthread.c b/src/util/virthread.c index 5422bb74fd..14116a2221 100644 --- a/src/util/virthread.c +++ b/src/util

[PATCH 0/2] Warn on pthread errors

libvirt currently exhibits undefined behavior due to pthread mutex misuse, e.g. destroying a locked mutex or attempting to unlock an already unlocked mutex. Add a warning if such a case is detected, so we can start on fixing the issues. Tim Wiederhake (2): virMutex: Warn on error DO NOT

[PATCH] cpu_map: Add libcpuinfo as optional data source

at has the capability to replace libvirt's dependence on qemu's cpu feature list. [1] https://gitlab.com/twiederh/libcpuinfo Signed-off-by: Tim Wiederhake --- src/cpu_map/libcpuinfo_aliases.xml | 75 + src/cpu_map/sync_qemu_features_i386.py | 77 +++

[PATCH 10/10] cpu_map: Ignore feature "kvm-asyncpf-vmexit"

Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_features_i386.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cpu_map/sync_qemu_features_i386.py b/src/cpu_map/sync_qemu_features_i386.py index e4b1f7275a..1b09532b13 100755 --- a/src/cpu_map/sync_qemu_features_i386.py +++ b/src

[PATCH 09/10] cpu_map: Add missing feature "vmx-nested-exception"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 36e5386c74..19904f2e22 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -829,6

[PATCH 08/10] cpu_map: Add missing feature "rfds-clear"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 9814a16347..36e5386c74 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -815,6

[PATCH 07/10] cpu_map: Add missing feature "rfds-no"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ tests/domaincapsdata/qemu_9.1.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_9.1.0.x86_64.xml | 1 + .../cpu-host-model-fallback-kvm.x86_64-latest.args

[PATCH 06/10] cpu_map: Add missing feature "succor"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 + tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core

[PATCH 05/10] cpu_map: Add missing feature "overflow-recov"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 5 + .../cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 + tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core

[PATCH 04/10] cpu_map: Add missing feature "lam"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index dcf01f2581..738684aab2 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -449,6

[PATCH 03/10] cpu_map: Add missing feature "wrmsrns"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 13051ddf83..dcf01f2581 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -440,6

[PATCH 02/10] cpu_map: Add missing feature "lkgs"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 63f20a4bb8..13051ddf83 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -437,6

[PATCH 01/10] cpu_map: Add missing feature "fred"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index da71a3a6a0..63f20a4bb8 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -434,6

[PATCH 00/10] Sync cpu features with qemu

This brings libvirt in sync qith qemu commit 02d9c38236cf8c9826e5c5be61780ccb4ae0. Tim Wiederhake (10): cpu_map: Add missing feature "fred" cpu_map: Add missing feature "lkgs" cpu_map: Add missing feature "wrmsrns" cpu_map: Add missing feature "

Re: [PATCH 05/22] cpu_map: Do not ignore VMX features in sync_qemu_models script

On Wed, 2024-03-13 at 10:01 +0100, Peter Krempa wrote: > On Tue, Mar 12, 2024 at 18:06:45 +0100, Jiri Denemark wrote: > > As you didn't mention how you've achieved this I'll leave this one > for > Tim to review. This and series

Re: [PATCH] cpu_map: Drop 'mpx' from x86 cpu models

On Wed, 2024-02-14 at 12:39 +0100, Jiri Denemark wrote: > On Wed, Feb 14, 2024 at 12:07:46 +0100, Michal Prívozník wrote: > > On 2/9/24 11:52, Tim Wiederhake wrote: > > > The mpx feature was removed from the corresponding qemu cpu > > > models. > > > With mp

[PATCH] cpu_map: Drop 'mpx' from x86 cpu models

mentioned vmx-* features: ... ... Resolve the issue by removing mpx from libvirt's cpu models as well. Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_Cascadelake-Server-noTSX.xml| 2 +- src/cpu_map/x86_Cascadelake-Server.xml | 2 +- src/cpu_ma

Re: [PATCH v2 4/4] cpu_map: Rewrite feature sync script

On Mon, 2024-02-05 at 11:44 +0100, Tim Wiederhake wrote: > Previously, the script would only detect differences between > libvirt's and qemu's list of x86 features, adding those features > to libvirt was a manual and error prone procedure. > > Replace with a script th

[PATCH v2 2/4] cpu_map: Format register values

Use "0x%08x" as format for all values: sed \ -e "s/'0x\(..\)'/'0x00\\1'/g" \ -e "s/'0x\(...\)'/'0x0\\1'/g" Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 538 +++

[PATCH v2 4/4] cpu_map: Rewrite feature sync script

Previously, the script would only detect differences between libvirt's and qemu's list of x86 features, adding those features to libvirt was a manual and error prone procedure. Replace with a script that can generate libvirt's feature list directly from qemu source code. --- src/cpu_map/sync_qemu

[PATCH v2 3/4] cpu_map: Format comments

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 50 1 file changed, 33 insertions(+), 17 deletions(-) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index b89bd5a2fa..8d1dbe68e8 100644 --- a/src/cpu_map

[PATCH v2 0/4] Rewrite x86 feature sync script

OUIXIBYAUI/#TWABWR5L7TSU33BQUXHNWWAYESOR2UUJ changes since v1: * rebased to current master (some conflicts in tests/ due to 8c07850c18) * dropped patch 4 ("cpu_map: Remove unused alias information") * adjusted patch 5 to generate "" entries Tim Wiederhake (4): cpu_map: Sort cpu featu

[PATCH 2/5] cpu_map: Format register values

Use "0x%08x" as format for all values: sed \ -e "s/'0x\(..\)'/'0x00\\1'/g" \ -e "s/'0x\(...\)'/'0x0\\1'/g" Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 538 +++

[PATCH 5/5] cpu_map: Rewrite feature sync script

Previously, the script would only detect differences between libvirt's and qemu's list of x86 features, adding those features to libvirt was a manual and error prone procedure. Replace with a script that can generate libvirt's feature list directly from qemu source code. --- src/cpu_map/sync_qemu

[PATCH 4/5] cpu_map: Remove unused alias information

These were introduced in 1d946ac794 in an attempt to make this information usable for libvirt. This did not work out and has been unused since. Remove from x86_features.xml as this data is preserved in the feature name translation tables in sync_qemu_features_i386.py. Signed-off-by: Tim

[PATCH 3/5] cpu_map: Format comments

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 50 1 file changed, 33 insertions(+), 17 deletions(-) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index b89bd5a2fa..8d1dbe68e8 100644 --- a/src/cpu_map

[PATCH 0/5] Rewrite x86 feature sync script

his script with a version that reads the feature names and their cpuid / msr data from qemu source code directly and generate the libvirt feature list, thus avoiding potential for human error. Tim Wiederhake (5): cpu_map: Sort cpu features cpu_map: Format register values cpu_map: Format comments

[pushed][libvirt PATCH] Fix cpu-host-model test data

This was broken by the recent addition of vmx-* features. Signed-off-by: Tim Wiederhake --- .../cpu-host-model-fallback-kvm.x86_64-4.2.0.args | 2 +- .../cpu-host-model-fallback-kvm.x86_64-5.0.0.args | 2 +- .../cpu-host-model-fallback-kvm.x86_64-latest.args

[libvirt PATCH 11/12] cpu_map: Add missing vmx features from MSR 0x490

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 25 +++ .../x86_64-cpuid-Atom-P5362-enabled.xml | 1 + .../x86_64-cpuid-Atom-P5362-json.xml | 4 +++ .../x86_64-cpuid-Cooperlake-enabled.xml | 1 + .../x86_64-cpuid

[libvirt PATCH 10/12] cpu_map: Add missing vmx features from MSR 0x48F

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 34 +++ .../x86_64-cpuid-Atom-P5362-enabled.xml | 1 + .../x86_64-cpuid-Atom-P5362-json.xml | 7 .../x86_64-cpuid-Cooperlake-enabled.xml | 1 + .../x86_64-cpuid

[libvirt PATCH 12/12] cpu_map: Add missing vmx features from MSR 0x491

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 4 tests/cputestdata/x86_64-cpuid-Atom-P5362-enabled.xml | 1 + tests/cputestdata/x86_64-cpuid-Atom-P5362-json.xml| 1 + tests/cputestdata/x86_64-cpuid-Cooperlake

[libvirt PATCH 08/12] cpu_map: Add missing vmx features from MSR 0x48D

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 16 .../x86_64-cpuid-Atom-P5362-enabled.xml | 1 + .../cputestdata/x86_64-cpuid-Atom-P5362-json.xml | 5 + .../x86_64-cpuid-Cooperlake-enabled.xml | 1 + .../cputestdata

[libvirt PATCH 09/12] cpu_map: Add missing vmx features from MSR 0x48E

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 64 +++ .../x86_64-cpuid-Atom-P5362-enabled.xml | 1 + .../x86_64-cpuid-Atom-P5362-json.xml | 21 ++ .../x86_64-cpuid-Cooperlake-enabled.xml | 1 + .../x86_64-cpuid

[libvirt PATCH 06/12] cpu_map: Add missing vmx features from MSR 0x48B

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 64 +++ .../x86_64-cpuid-Atom-P5362-enabled.xml | 1 + .../x86_64-cpuid-Atom-P5362-json.xml | 16 + .../x86_64-cpuid-Cooperlake-enabled.xml | 1 + .../x86_64-cpuid

[libvirt PATCH 07/12] cpu_map: Add missing vmx features from MSR 0x48C

lled "vmx-invept-single-context" in qemu. This is the name of the feature associated with bit 25 in both libvirt and qemu. * "vmx-invvpid-single-context-noglobals" (bit 43) is erroneously called "vmx-invept-single-context-noglobals". Use the correct name.

[libvirt PATCH 05/12] cpu_map: Add missing vmx features from MSR 0x485

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 19 +++ .../x86_64-cpuid-Atom-P5362-enabled.xml | 1 + .../x86_64-cpuid-Atom-P5362-json.xml | 3 +++ .../x86_64-cpuid-Cooperlake-enabled.xml | 1 + .../x86_64-cpuid

[libvirt PATCH 04/12] cpu_map: Add missing vmx features from MSR 0x480

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 10 ++ tests/cputestdata/x86_64-cpuid-Atom-P5362-enabled.xml | 1 + tests/cputestdata/x86_64-cpuid-Atom-P5362-json.xml | 2 ++ tests/cputestdata/x86_64-cpuid-Cooperlake-enabled.xml | 1

[libvirt PATCH 03/12] cpu_map: No longer ignore vmx- features in sync_qemu_features_i386.py

"model": { "name": "Skylake-Client-v1", "props": { "xsaves": true } `# set to "true" or "false"` } } } { "execute": "quit" } EOF with xsaves "fal

[libvirt PATCH 02/12] cpu_map: Add missing feature "amx-complex"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index d136d78368..978b04e615 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -444,6

[libvirt PATCH 00/12] Add vmx-* features from qemu

ync with qemu commit ad6ef0a42e. Tim Wiederhake (12): cpu_map: Add missing feature "gds-no" cpu_map: Add missing feature "amx-complex" cpu_map: No longer ignore vmx- features in sync_qemu_features_i386.py cpu_map: Add missing vmx features from MSR 0x480 cpu_map: Add missi

[libvirt PATCH 01/12] cpu_map: Add missing feature "gds-no"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ tests/domaincapsdata/qemu_8.2.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.2.0.x86_64.xml | 1 + tests/qemuxml2argvdata/cpu-host-model.x86_64-latest.args | 2 +- 4