Re: [PATCH 0/2] libxl_conf: Fix crashes in libxl config generation

ping

[PATCH 2/2] libxl_conf: Add check for unsupported graphics type

early on in libxlMakeVfb. As a safeguard, we also initialize both vnc enable and sdl enable defbools as false early. Signed-off-by: Rayhan Faizel --- src/libxl/libxl_conf.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl

[PATCH 1/2] libxl_conf: Fix config generation for multiple serial devices

libxlMakeChrdevStr which causes a segmentation fault. To fix this, we simply allocate an array of char * instead of libxl_string_list. This patch also adds testcases to extend coverage over both single serial and multiple serial cases. Signed-off-by: Rayhan Faizel --- src/libxl/libxl_conf.c

[PATCH 0/2] libxl_conf: Fix crashes in libxl config generation

This patch series includes fixes for config generation of multiple serial devices and handling of unsupported graphics types. Both of these were discovered some time back using fuzzing techniques. Rayhan Faizel (2): libxl_conf: Fix config generation for multiple serial devices libxl_conf: Add

Re: [RFC PATCH] docs: add documentation for the AFL Fuzzing method

https://gitlab.com/Skryptonyte/libvirt/-/tree/gsoc_fuzz_final_forreal/tests/fuzz?ref_type=heads>`__ > + I noticed you included my project as a reference. Could you link to the gsoc_fuzz branch instead? That's a bit more up to date. -- Rayhan Faizel

Re: [PATCH 00/14] Introduce fuzzing of XML formats

On Tue, Aug 27, 2024 at 1:51 PM Martin Kletzander wrote: > > On Tue, Aug 27, 2024 at 12:08:27PM +0300, Rayhan Faizel wrote: > > > >All the existing code is indeed still compiled as C. Only the fuzzing > >executables (under tests/fuzz/) are compiled in C++ and linked t

Re: [PATCH 00/14] Introduce fuzzing of XML formats

s PoV, even with C linkage. There are still some other code modifications in tests/ and src/ for a few other fuzzers (mostly hotplug and CH) to make fuzzing easier. I agree that we could keep it as a separate repo, perhaps a subproject. I have seen some projects keep their fuzzing code separate (mostly on oss-fuzz). -- Rayhan Faizel

[PATCH 14/14] docs: Document the fuzzers

Document the fuzzers in two ways. 1. Explain the high level working of the fuzzers under docs/kbase. 2. Add README to explain general setup of the fuzzer and its usage. Signed-off-by: Rayhan Faizel --- docs/kbase/index.rst | 3 + docs/kbase/internals/meson.build | 1

[PATCH 13/14] fuzz: Implement NWFilter XML fuzzer

, ARP opcode, state flags, etc. Signed-off-by: Rayhan Faizel --- scripts/relaxng-to-proto.py | 16 +++ tests/fuzz/meson.build| 34 ++ tests/fuzz/proto_custom_datatypes.cc | 88 +++ tests/fuzz/proto_header_common.h | 4 + tests/fuzz/protos

[PATCH 12/14] fuzz: Implement libXL XML domain fuzzer

to llvm-symbolizer which is undesirable and causes various undefined symbol errors. We add a wrapper binary which execs the real llvm-symbolizer with the environment unset. However, LD_PRELOAD still breaks parallel fuzzing so it is disabled for the time being. Signed-off-by: Rayhan Faizel

[PATCH 11/14] fuzz: Implement VMX XML domain fuzzer

This patch adds the harness for the VMX driver to fuzz XML parsing and VMX config generation. VMX config generation is done with a hardcoded version of 13. Signed-off-by: Rayhan Faizel --- tests/fuzz/meson.build| 16 +++ tests/fuzz/proto_to_xml.cc| 18 +++ tests/fuzz

[PATCH 10/14] fuzz: Implement CH XML domain fuzzer

This patch implements the harness for the Cloud-Hypervisor driver to fuzz XML parsing and XML-to-JSON generation including virCHMonitorBuildVMJson and virCHMonitorBuildNetJson. Signed-off-by: Rayhan Faizel --- src/ch/ch_monitor.c | 2 +- src/ch/ch_monitor.h | 3

[PATCH 09/14] ch: Remove unused variables

Unused variables in ch_process.c cause compilation errors so remove them. Signed-off-by: Rayhan Faizel --- src/ch/ch_process.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/ch/ch_process.c b/src/ch/ch_process.c index 9816509e49..12da020c7b 100644 --- a/src/ch/ch_process.c +++ b/src

[PATCH 08/14] fuzz: Implement QEMU XML hotplug fuzzer

architecture selected, some controllers may be omitted or modified. LeakSanitizer slows down the fuzzer severely, so we disable it in run_fuzz for now. Signed-off-by: Rayhan Faizel --- src/conf/domain_conf.h | 2 + src/qemu/qemu_hotplug.c | 4 + tests/fuzz/meson.build

[PATCH 07/14] fuzz: Implement QEMU XML domain fuzzer

, xml_domain_disk_only and xml_domain_interface_only. This is useful to acheive deeper coverage of interfaces and disk definitions. The fuzzers also have the fake network, storage and secret drivers set up. Signed-off-by: Rayhan Faizel --- tests/fuzz/meson.build | 20 +++ tests/fuzz

[PATCH 06/14] fuzz: Implement base fuzzing setup for XML domain

: Most of the XML domain format 2. xml_domain_disk_only: Only the definition 3. xml_domain_interface_only: Only the definition Signed-off-by: Rayhan Faizel --- meson.build | 44 meson_options.txt | 2 + tests/fuzz/meson.build

[PATCH 05/14] scripts: Add script to convert relaxNG to protobuf

fuzzers to mutate protobuf data and serialize them to XML. Signed-off-by: Rayhan Faizel --- build-aux/syntax-check.mk | 1 + scripts/meson.build | 1 + scripts/relaxng-to-proto.py | 505 3 files changed, 507 insertions(+) create mode 100644

[PATCH 04/14] schemas: Refactor relaxNG schema to ease protobuf conversion

relaxng-to-proto script does not handle regexes, so convert some of them to containing . Signed-off-by: Rayhan Faizel --- src/conf/schemas/basictypes.rng| 20 ++-- src/conf/schemas/domaincommon.rng | 11 +++ src/conf/schemas/networkcommon.rng | 14 -- 3

[PATCH 03/14] tests: Export handlers for fake secondary drivers

This patch exports handlers for fake network, storage and secret drivers which will be used by the QEMU XML domain fuzzer. Signed-off-by: Rayhan Faizel --- tests/qemuxmlconftest.c | 249 -- tests/testutilsqemu.c | 256

[PATCH 02/14] meson: Add support for clang/LLVM coverage instrumentation

coverage. Signed-off-by: Rayhan Faizel --- meson.build | 11 +++ meson_options.txt | 3 ++- tests/commandhelper.c | 8 ++-- 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index f31485c395..904524abc6 100644 --- a/meson.build +++ b

[PATCH 01/14] src: Tweak source code to allow C++ compilation

allowed under C++. 3. G_NO_INLINE works differently under C++. Some compile errors occur because of this. To work around this, we rearrange G_NO_INLINE to allow compilation while allowing libvirt to compile normally as before without fuzzing enabled. Signed-off-by: Rayhan Faizel --- sr

[PATCH 00/14] Introduce fuzzing of XML formats

ted at the end of the series (patch 14). Rayhan Faizel (14): src: Tweak source code to allow C++ compilation meson: Add support for clang/LLVM coverage instrumentation tests: Export handlers for fake secondary drivers schemas: Refactor relaxNG schema to ease protobuf conversion scripts:

Re: [PATCH] conf: Fix out-of-bounds write during cleanup of virDomainNumaDefNodeDistanceParseXML

Sorry for the double post, seems git send-email sent it twice for some reason. Disregard this one.

[PATCH] conf: Fix out-of-bounds write during cleanup of virDomainNumaDefNodeDistanceParseXML

patch also adds a testcase which would be picked up by ASAN, if this portion regresses. Fixes: 742494eed8dbdde8b1d05a306032334e6226beea Signed-off-by: Rayhan Faizel --- src/conf/numa_conf.c | 30 ++- ...ance-nonexistent-sibling.x86_64-latest.err | 1

[PATCH] conf: Fix out-of-bounds write during cleanup of virDomainNumaDefNodeDistanceParseXML

patch also adds a testcase which would be picked up by ASAN, if this portion regresses. Signed-off-by: Rayhan Faizel --- src/conf/numa_conf.c | 30 ++- ...ance-nonexistent-sibling.x86_64-latest.err | 1 + .../cpu-numa-distance-nonexistent-sibling.xml | 29

[PATCH v2] tests: Move domainEventState initialization to qemuTestDriverInit

est to qemuTestDriverInit in testutilsqemu (Credit goes to Michal Privoznik as he had already provided the diff). An additional test case is added to test dropping of disks with startupPolicy set as optional. Signed-off-by: Rayhan Faizel --- As the patch title has completely changed, v1:

[PATCH v2] conf: Fix rawio/sgio checks for non-scsi hostdev devices

o test cases to exercise both scenarios. Fixes: bdb95b520c53f9bacc6504fc51381bac4813be38 Signed-off-by: Rayhan Faizel --- [Changes in v2] - Reworked fix to use temporary variables instead of xpath queries. - Added comments for future reference. - Mention fixed commit. src/con

[PATCH] conf: Fix rawio/sgio checks for non-scsi hostdev devices

tes. This patch also adds two test cases to exercise both scenarios. Signed-off-by: Rayhan Faizel --- src/conf/domain_conf.c| 33 --- ...scsi-vhost-rawio-invalid.x86_64-latest.err | 1 + .../hostdev-scsi-vhost-rawio-invalid.xml | 41 +++

Re: [PATCH] qemu_domain: Check if driver->domainEventState is NULL

ping

Re: [PATCH v2] qemu_block: Validate number of hosts for iSCSI disk device

ping v2

[PATCH] qemu_domain: Check if driver->domainEventState is NULL

along with a testcase exercising the dropping of disks with startupPolicy set as 'optional'. Signed-off-by: Rayhan Faizel --- src/qemu/qemu_domain.c| 3 +- ...tuppolicy-optional-drop.x86_64-latest.args | 33 ...rtuppolicy-optional-drop.x86_64

Re: [PATCH v2] qemu_block: Validate number of hosts for iSCSI disk device

ping

[PATCH v2] qemu_block: Validate number of hosts for iSCSI disk device

Signed-off-by: Rayhan Faizel --- This crashing XML was detected by the WIP fuzzer which is being developed as part of Google Summer of Code 2024. [Changes in v2] - Added testcase for iSCSI disk definitions with zero hosts src/qemu/qemu_block.c

[PATCH] qemu_block: Validate number of hosts for iSCSI disk device

Signed-off-by: Rayhan Faizel --- This crashing XML was detected by the WIP fuzzer which is being developed as part of Google Summer of Code 2024. src/qemu/qemu_block.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_block.c b/src/qemu

[PATCH] qemu: Optimize monitor event name lookup with hash tables

makes gperf a requirement for compiling libvirt if the QEMU driver is enabled. Signed-off-by: Rayhan Faizel --- docs/kbase/internals/qemu-event-handlers.rst | 13 +- meson.build | 2 + src/qemu/meson.build | 9 + src/qemu

[PATCH 2/2] qemuhotplugtest: Add testcases for hotplugging evdev input devices

This patch adds testcases to exercise hotplugging/hotunplugging evdev input devices. Signed-off-by: Rayhan Faizel --- tests/qemuhotplugtest.c | 5 ++ .../qemuhotplug-input-evdev.xml | 3 + .../qemuhotplug-base-live+input-evdev.xml | 58

[PATCH 1/2] qemu: Implement support for hotplugging evdev input devices

es. Signed-off-by: Rayhan Faizel --- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_command.h | 3 ++ src/qemu/qemu_hotplug.c | 95 + 3 files changed, 71 insertions(+), 29 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c i

[PATCH 0/2] Add support for hotplugging evdev input devices

This patch series extends the current evdev device implementation to allow hotplugging, including live attachment and detachment. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/529 Rayhan Faizel (2): qemu: Implement support for hotplugging evdev input devices qemuhotplugtest: Add

Re: [PATCH v2] qemu_hotplug: Properly assign USB address to hotplugged usb-net device

On Tue, May 14, 2024 at 12:45 PM Michal Prívozník wrote: > > On 5/13/24 15:55, Rayhan Faizel wrote: > > Previously, the network device hotplug logic would try to ensure only CCW or > > PCI addresses. With recent support for the usb-net model, this patch will > > ensure U

[PATCH v2] qemu_hotplug: Properly assign USB address to hotplugged usb-net device

already resolved but hotplugging is mentioned in one of the comments) Resolves: https://gitlab.com/libvirt/libvirt/-/issues/14 Signed-off-by: Rayhan Faizel --- src/qemu/qemu_hotplug.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu

[PATCH] qemu_hotplug: Properly assign USB address to hotplugged usb-net device

Signed-off-by: Rayhan Faizel --- src/qemu/qemu_hotplug.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 774962b0df..3b39941780 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1159,8

[PATCH] NEWS: Announce virtio sound model support

Signed-off-by: Rayhan Faizel --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index d72c15bf10..a0e82fcc02 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -22,6 +22,12 @@ v10.4.0 (unreleased) It is now possible to set on/off ``ras`` feature in the domain

Re: [PATCH v2 0/3] qemu: Add support for virtio sound model

ping v3 -- Rayhan Faizel ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH v2 0/3] qemu: Add support for virtio sound model

Ping v2 On Thu, Apr 18, 2024 at 11:48 AM Rayhan Faizel wrote: > > Hi, > > A week has passed, so I'm bumping this. -- Rayhan Faizel ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH v2 0/3] qemu: Add support for virtio sound model

Hi, A week has passed, so I'm bumping this. ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

[PATCH v2 3/3] qemu: Generate command line for sound devices with model 'virtio'

Allow generation of command line for virtio-sound-pci and virtio-sound-device devices along with additional virtio options. A new testcase is added to test virtio-sound-pci. The arm-vexpressa9-virtio testcase is also extended to test virtio-sound-device. Signed-off-by: Rayhan Faizel --- src

[PATCH v2 2/3] conf: Introduce support for virtio-sound devices

meters but these are currently stubbed, hence they are excluded in this patch series. Signed-off-by: Rayhan Faizel --- docs/formatdomain.rst | 11 +-- src/conf/domain_conf.c| 25 + src/conf/domain_conf.h| 4 src/conf/domain_p

[PATCH v2 1/3] qemu_capabilities: Add QEMU_CAPS_DEVICE_VIRTIO_SOUND capability

Signed-off-by: Rayhan Faizel --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml | 1 + tests

[PATCH v2 0/3] qemu: Add support for virtio sound model

went overlooked. Rayhan Faizel (3): qemu_capabilities: Add QEMU_CAPS_DEVICE_VIRTIO_SOUND capability conf: Introduce support for virtio-sound devices qemu: Generate command line for sound devices with model 'virtio' docs/formatdomain.rst | 11 -

[PATCH 3/3] qemu: Generate command line for sound devices with model 'virtio'

Allow generation of command line for virtio-sound-pci and virtio-sound-device devices along with additional virtio options. A new testcase is added to test virtio-sound-pci. The arm-vexpressa9-virtio testcase is also extended to test virtio-sound-device. Signed-off-by: Rayhan Faizel --- src

[PATCH 2/3] conf: Introduce support for virtio-sound devices

meters but these are currently stubbed, hence they are excluded in this patch series. Signed-off-by: Rayhan Faizel --- docs/formatdomain.rst | 11 +-- src/conf/domain_conf.c| 25 + src/conf/domain_conf.h| 4 src/conf/domain_p

[PATCH 0/3] qemu: Add support for virtio sound model

virtio-sound-pci and virtio-sound-device were recently introduced in QEMU 8.2.0. The full documentation of the virtio sound implementation in QEMU can be found here: https://www.qemu.org/docs/master/system/devices/virtio-snd.html Example: Rayhan Faizel (3): qemu_capabilities: Add

[PATCH 1/3] qemu_capabilities: Add QEMU_CAPS_DEVICE_VIRTIO_SOUND capability

Signed-off-by: Rayhan Faizel --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml | 1 + tests

[PATCH v2 2/2] tests: Add testcase for usb-net

Add small test case to demonstrate use of usb-net with user networking backend. Signed-off-by: Rayhan Faizel --- .../net-usb.x86_64-latest.args| 35 +++ .../qemuxmlconfdata/net-usb.x86_64-latest.xml | 35 +++ tests/qemuxmlconfdata/net-usb.xml

[PATCH v2 1/2] conf: Automatically assign address to usb-net device

This patch will allow usb-net devices to be automatically assigned a USB address (and skip any attempt to assign a PCI one). Signed-off-by: Rayhan Faizel --- docs/formatdomain.rst | 1 + src/conf/domain_conf.c | 9 - src/qemu/qemu_domain_address.c | 4 3 files

[PATCH v2 0/2] qemu: Improve support for usb-net devices

ent 2. New testcase [Changes in v2] 1. Drop qemu_capabilities patch 2. Fix documentation to reflect correct version. 3. Remove unnecessary comment. 4. Fix commit subject. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/14 Rayhan Faizel (2): conf: Automatically assign address to usb-net devi

[PATCH 3/3] tests: Add testcase for usb-net

Add small test case to demonstrate use of usb-net with user networking backend. Signed-off-by: Rayhan Faizel --- .../net-usb.x86_64-latest.args| 35 +++ .../qemuxmlconfdata/net-usb.x86_64-latest.xml | 35 +++ tests/qemuxmlconfdata/net-usb.xml

[PATCH 2/3] conf: Improve parsing of usb-net devices

This patch will allow usb-net devices to be automatically assigned a USB address (and skip any attempt to assign a PCI one). Signed-off-by: Rayhan Faizel --- docs/formatdomain.rst | 2 +- src/conf/domain_conf.c | 9 - src/qemu/qemu_domain_address.c | 5 + 3 files

[PATCH 1/3] qemu_capabilities: Re-add QEMU_CAPS_DEVICE_USB_NET capability

This capability was previously prefixed with X_ due to not being in use. Signed-off-by: Rayhan Faizel --- src/qemu/qemu_capabilities.c | 3 ++- src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml | 1

[PATCH 0/3] qemu: Improve support for usb-net devices

omatic USB address assignment 3. New testcase Fixes: https://gitlab.com/libvirt/libvirt/-/issues/14 Rayhan Faizel (3): qemu_capabilities: Re-add QEMU_CAPS_DEVICE_USB_NET capability conf: Improve parsing of usb-net devices tests: Add testcase for usb-net docs/format

[PATCH] NEWS: Announce support for MTP filesystem driver type

Signed-off-by: Rayhan Faizel --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 489201d3fc..16a34e8114 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,12 @@ v10.2.0 (unreleased) * **New features** + * qemu: Support for driver type ``mtp`` in

Re: [PATCH 0/4] qemu: Add support for mtp filesystem driver

Hi, A week has passed so I am bumping this thread. On Fri, Mar 8, 2024 at 11:20 PM Rayhan Faizel wrote: > > This patch series adds support for the mtp backed filesystem device > exposed through a virtual USB MTP device. > > Usage: > > > > >

[PATCH v2] openvz_conf: Use g_autofree

Signed-off-by: Rayhan Faizel --- src/openvz/openvz_conf.c | 60 1 file changed, 17 insertions(+), 43 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index eab3f748d0..4dbaef356c 100644 --- a/src/openvz/openvz_conf.c +++ b

Re: [PATCH] openvz_conf: Use g_autofree

Sorry, forgot to sign the commit Please disregard this patch, i’ll send a v2. ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

[PATCH] openvz_conf: Use g_autofree

--- src/openvz/openvz_conf.c | 60 1 file changed, 17 insertions(+), 43 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index eab3f748d0..4dbaef356c 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -163,

[PATCH 4/4] docs: Add documentation for mtp filesystem driver

Signed-off-by: Rayhan Faizel --- docs/formatdomain.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 967283aaa9..f829f08bde 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -3590,6 +3590,11 @@ A directory on the

[PATCH 3/4] tests: Add testcases for mtp filesystem driver

Simple test case that adds two filesystem devices, one of which is read only. Signed-off-by: Rayhan Faizel --- .../mtp-usb-device.x86_64-latest.args | 35 .../mtp-usb-device.x86_64-latest.xml | 42 +++ tests/qemuxmlconfdata/mtp-usb-device.xml

[PATCH 2/4] qemu: Support for parsing usb-mtp devices

The source tag sets the rootdir property of the device, which is the directory exposed to the guest via the MTP device. The target tag sets the desc property. This device supports read-only mode as well. Like virtiofs, it does not support additional access modes. Signed-off-by: Rayhan Faizel

[PATCH 1/4] qemu_capabilities: Add QEMU_CAPS_DEVICE_MTP capability

Signed-off-by: Rayhan Faizel --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_4.2.0_ppc64.xml | 1 + tests

[PATCH 0/4] qemu: Add support for mtp filesystem driver

This patch series adds support for the mtp backed filesystem device exposed through a virtual USB MTP device. Usage: Rayhan Faizel (4): qemu_capabilities: Add QEMU_CAPS_DEVICE_MTP capability qemu: Support for parsing usb-mtp devices tests: Add testcases for mtp filesystem