From: Peter Krempa
The canonicalization of the paths is not mocked properly and thus the
tests depend on the host system. While the tests do pass on our CI they
break on real deployments at least on Fedora 42.
Since we're in code freeze for the upcoming release, revert the patch
inste
From: Peter Krempa
Turns out the test difference was not caused by forgotten hunks but
rather that the test output depends on the system.
For now both this wrong fix and the commit causing the failure will both
be reverted as we're in code freeze for the upcoming release.
This reverts c
Revert the patches as we're in code freeze.
Peter Krempa (2):
Revert "qemuxmlconfdata: Regenerate outputs after last commit"
Revert "qemu: Match firmware with fully resolved and canonicalized
paths"
src/qemu/qemu_firmware.c | 11
On Tue, Jul 29, 2025 at 10:42:09 +0200, Michal Prívozník via Devel wrote:
> On 7/24/25 15:49, James Le Cuirot wrote:
> > From: James Le Cuirot
> >
> > Distros may provide compatibility symlinks after moving firmware files
> > around, but they won't work for existing VMs when doing a straight
> >
From: Peter Krempa
Commit 4efea21ae8709c6741a1800bd26ae6b49c8a77f5 modified how the EFI
paths are detected but didn't update the outputs.
Fixes: 4efea21ae8709c6741a1800bd26ae6b49c8a77f5
Signed-off-by: Peter Krempa
---
Pushed as build fix.
...manual-efi-aarch64-legacy-paths.aa
On Wed, Jul 23, 2025 at 04:57:57 +, P, Rajasekar via Users wrote:
> Hello libvirt community,
>
> I am seeking clarification on the behavior of `virsh snapshot-delete` when
> used with external snapshots (created with the `--disk-only` option).
>
> **Environment:**
> - libvirt version: 10.5.0
On Thu, Jul 24, 2025 at 12:48:06 -, Aaron Brown wrote:
> > On Tue, Jul 22, 2025 at 13:50:19 -0400, Aaron M. Brown wrote:
> >
> > One definition per line.
> >
> Okay I will remember that going forward!
>
> >
> > This is suspicious because this function until now just returned the
> > next e
On Tue, Jul 22, 2025 at 13:50:19 -0400, Aaron M. Brown wrote:
> This change fixes an issue with virtio console port assignment on
> virtio-serial buses.
> Currently, when trying to autoassign a virtio console device, the device
> cannot be
> assigned to a port greater than 0 on virtio-serial buse
/usr/bin/qemu-system-x86_64
> +
> +
> +
> +
> +
... which are not strictly needed to test consoles.
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
Reviewed-by: Peter Krempa
I'll address the few things I've pointed out myself.
From: Peter Krempa
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 7c203e32fe..a0f770b053 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu
From: Peter Krempa
Fix linebreaks and remove the use of ternary operator.
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c
index
From: Peter Krempa
Automatically free temporary variables in order to remove 'cleanup'
section.
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/src/security/security_selin
From: Peter Krempa
Skip the use of temporary variable.
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c
index b390e0c95f..b16ab14dfe
From: Peter Krempa
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c
index 3004320380..54f12d044f 100644
--- a/src/security/security_selinux.c
From: Peter Krempa
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c
index 54f12d044f..b390e0c95f 100644
--- a/src/security/security_selinux.c
From: Peter Krempa
Automatically free temporary variables in order to remove 'cleanup'
section.
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 20 ++--
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/src/security/security_selin
From: Peter Krempa
Use automatic freeing of temporary variables and remove cleanup section.
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/src/security/security_selinux.c b
From: Peter Krempa
Use the new autoptr helper to free the temporary variables and refactor
cleanup.
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/src/security/security_selinux.c b/src
From: Peter Krempa
The selinux headers have a 'typedef context_s_t *context_t;' definition
in the header so we declare autoptr cleanup function for 'context_s_t'
and use it instead of 'context_t' definitions.
Signed-off-by: Peter Krempa
---
src/security/secu
From: Peter Krempa
Automatically free temporary variables and remove the need for 'cleanup'
section.
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 35 ++---
1 file changed, 15 insertions(+), 20 deletions(-)
diff --git a/sr
From: Peter Krempa
Automatically free temporary variables and change 'cleanup' label to
'error'.
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 37 +++--
1 file changed, 17 insertions(+), 20 deletions(-)
diff
From: Peter Krempa
Declare 'in'/'out' only in the bocks which use them and automatically
free them. Since cleanup section was removed we don't need a 'ret'
variable any more.
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 87 ++
From: Peter Krempa
Declare 'path' only in blocks where it's used and autofree it.
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/security/security_selinux.c b/src/security/sec
From: Peter Krempa
Declare 'filename' inside the loop that is using it and use automatic
freeing.
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/security/security_selinux.c b/sr
From: Peter Krempa
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c
index 75ad5803a9..f042da4a13 100644
--- a/src/security
From: Peter Krempa
Automatically free 'paths' and remove temporary variable.
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/security/security_selinux.c b/src/security/security_selin
From: Peter Krempa
Automatically free 'fcon' and 'newpath' and remove the 'cleanup' label
and 'ret' variable.
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 30 +++---
1 file changed, 11 insertions(+), 19
From: Peter Krempa
Use automatic freeing for 'mcs' and adjust the code.
Signed-off-by: Peter Krempa
---
src/security/security_selinux.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/security/security_selinux.c b/src/security/security_selin
From: Peter Krempa
Fix the misaligned arguments by switching over to modern style.
Signed-off-by: Peter Krempa
---
src/security/security_driver.c | 5 +++--
src/security/security_driver.h | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/security/security_driver.c
Some cleanups resutling from analyzing some selinux code.
Peter Krempa (19):
security/security_driver.c/h: Fix function header formatting
virSecuritySELinuxTransactionRun: Refactor cleanup
virSecuritySELinuxMCSFind: Refactor variable clearing
virSecuritySELinuxRestoreFileLabel: Refactor
On Wed, Jun 25, 2025 at 17:56:33 +0200, Peter Krempa wrote:
> After recent inquiry on libvirt-users I've necromanced this already very
> old series that I still had laying around.
>
> This series:
> - turns virStorageSource's 'protocol' to real enum
>
-tcp-tlsx509-chardev-notls");
> driver.config->chardevTLSx509secretUUID =
> g_strdup("6fd3f62d-9fe7-4a4e-a869-7acd6376d8ea");
> +driver.config->chardevTLSpriority = g_strdup("@SYSTEM:-VERS-TLS1.3");
> DO_TEST_CAPS_LATEST("serial-tcp-tlsx509-secret-chardev");
> +VIR_FREE(driver.config->chardevTLSpriority);
> VIR_FREE(driver.config->chardevTLSx509secretUUID);
> driver.config->chardevTLS = 0;
> DO_TEST_CAPS_LATEST("serial-many-chardev");
With the above nit fixed:
Reviewed-by: Peter Krempa
t; +++ b/src/qemu/qemu.conf.in
> @@ -48,6 +48,7 @@
> #
> #default_tls_x509_verify = 1
>
> +
> #
This is the only ocurence of a commented out but otherwise empty line at
the beginning of a block. Consider deleting it since you are touching
neighboring lines.
Reviewed-by: Peter Krempa
> Signed-off-by: Daniel P. Berrangé
> ---
> src/qemu/libvirtd_qemu.aug | 2 +-
> src/qemu/qemu.conf.in | 12 ++--
> src/qemu/test_libvirtd_qemu.aug.in | 2 +-
> 3 files changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Peter Krempa
On Fri, Jul 18, 2025 at 09:24:05 +0100, Daniel P. Berrangé wrote:
> On Fri, Jul 18, 2025 at 09:39:22AM +0200, Peter Krempa wrote:
> > On Thu, Jul 17, 2025 at 17:02:33 +0100, Daniel P. Berrangé wrote:
> > > On Thu, Jul 17, 2025 at 05:28:09PM +0200, Peter Krempa via Devel wrote:
&
sed to be called on one of the hosts represented in the input CPU
> + definitions. Otherwise the API will give unexpected results.
> +
Reviewed-by: Peter Krempa
On Thu, Jul 17, 2025 at 17:02:33 +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 17, 2025 at 05:28:09PM +0200, Peter Krempa via Devel wrote:
> > From: Peter Krempa
> >
> > Similarly to how we iterate the list of CAs in the concatenated bundle
> > there's a
From: Peter Krempa
We now always load a list of certificates rather than only the first one
so this function is not used any more.
Signed-off-by: Peter Krempa
---
src/rpc/virnettlscert.c | 41 -
src/rpc/virnettlscert.h | 3 ---
2 files changed, 44
From: Peter Krempa
Similarly to how we iterate the list of CAs in the concatenated bundle
there's a possibility of the server/client certificates to be
concatenated as well.
If for some case the first certificate is okay but the further one have
e.g. invalid signatures the validation code
From: Peter Krempa
Signed-off-by: Peter Krempa
---
src/rpc/virnettlscert.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/rpc/virnettlscert.c b/src/rpc/virnettlscert.c
index 6a723c1ed4..774dd5989a 100644
--- a/src/rpc/virnettlscert.c
+++ b/src/rpc
From: Peter Krempa
The function can load a generic list of certs, it doesn't necessarily
have to be the list of CAs. Rename the function, and change error to be
generic.
Signed-off-by: Peter Krempa
---
src/rpc/virnettlscert.c | 14 +++---
src/rpc/virnettlscert.h | 5 +
2
From: Peter Krempa
Since gnutls and thus by extension libvirt allows passing multiple
certificates in one file by concatenating them, virt-pki-validate ought
to validate the hostname of all of them, instead of only the first one
to prevent issues when wrong certs are concatenated.
Signed-off-by
From: Peter Krempa
Use autofree for all temporary variables and return the result directly.
Signed-off-by: Peter Krempa
---
src/rpc/virnettlscontext.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c
From: Peter Krempa
Signed-off-by: Peter Krempa
---
src/rpc/virnettlscontext.c | 74 +++---
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c
index e8023133b4..bf83857a05 100644
--- a/src/rpc
Our code handled properly only multiple CA certs in one file. This patch
extends the validation also to multiple client/server certs in one file.
Peter Krempa (7):
rpc: virnettlscontext: Fix formatting of function definitions
virNetTLSContextNewPath: Refactor temporary variable usage
| 1 +
> src/conf/domain_validate.c | 2 +-
> src/qemu/qemu_command.c| 7 ++-
> tests/qemuxmlconftest.c| 1 +
> 5 files changed, 17 insertions(+), 6 deletions(-)
Reviewed-by: Peter Krempa
tore since they are not needed here */
> virshDiskDropBackingStore(ret);
> return ret;
> --
> 2.43.0
>
Reviewed-by: Peter Krempa
-
> 3 files changed, 47 insertions(+), 34 deletions(-)
Reviewed-by: Peter Krempa
On Thu, Jul 03, 2025 at 13:19:07 +0300, Nikolai Barybin via Devel wrote:
Please also fix your git configuration:
https://libvirt.org/submitting-patches.html#git-configuration
Otherwise the author will be wrong (Nikolai Barybin via Devel) unless
fixed manually due to the DMARC countermeasures th
ONValue *cur,
> } else {
> obj = virQEMUQAPISchemaObjectGet("members", query, "name", cur);
>
> -if (modifier == '*' &&
> +if (modifier == '*' && obj &&
> !virJSONValueObjectHasKey(obj, "default"))
> return 0;
> }
> --
> 2.43.5
Reviewed-by: Peter Krempa
and I'll push it shortly.
On Fri, Jul 11, 2025 at 06:23:46 +, Duan, Zhenzhong wrote:
>
>
> >-Original Message-
> >From: Daniel P. Berrangé
> >Subject: Re: [PATCH v4 00/23] LIBVIRT: X86: TDX support
> >
> >FYI, QEMU soft freeze is next week, and rc0 release
> >is Jul 22nd. I proposed we merge this series once
org/docs/master/devel/code-provenance.html#use-of-ai-content-generators>
>
> Signed-off-by: Pavel Hrdina
> ---
I suggest you wait for others to chime in but from my side:
Reviewed-by: Peter Krempa
On Thu, Jul 10, 2025 at 10:26:57 +0100, Daniel P. Berrangé via Devel wrote:
>
>
> Daniel P. Berrangé (2):
> src: add missing libvirt-admin.pc.in for local usage
> src: fix package name in local pkg-config files
Reviewed-by: Peter Krempa
On Fri, May 30, 2025 at 14:21:23 +0200, Enrique Llorente via Devel wrote:
> This commit introduces a feature enhancement for configuring hostnames in
> virtual machines (VMs) using DHCP. It adds new options to the "passt" tool
> to set the hostname and fully qualified domain name (FQDN) for VMs. Th
On Wed, Jul 09, 2025 at 13:38:12 +0200, Enrique Llorente via Devel wrote:
> This adds support for custom command line arguments for the passt
> backend, similar to qemu:commandline. The feature allows passing
> additional arguments to the passt process for development and testing
> purposes.
>
> T
On Thu, Jul 10, 2025 at 08:39:18 +0200, Enrique Llorente Pastora wrote:
> On Thu, Jul 10, 2025 at 7:55 AM Peter Krempa wrote:
> >
> > On Wed, Jul 09, 2025 at 15:44:15 +0200, Enrique Llorente Pastora wrote:
> > > I have pushed a v3 with all the fixes for v2, clearly v2 was
On Wed, Jul 09, 2025 at 15:44:15 +0200, Enrique Llorente Pastora wrote:
> I have pushed a v3 with all the fixes for v2, clearly v2 was kind of
> half baked, sorry about that.
Before I reply to v3 I still want you to reply at least to my question
about how the test result (.args) file ended up refe
From: Peter Krempa
Introduce schema for the host '' output XMLs and validate our
test data against the schema.
This requires introduction of schema for '' and
'' elements which are not supported when sysinfo is set
explicitly for a domian definition.
Signed-off-b
From: Peter Krempa
Extract the common bits of the domain definition schema which
will be also later reused to construct schema for the host top
level element.
Signed-off-by: Peter Krempa
---
src/conf/schemas/domaincommon.rng | 126 ++---
src/conf/schemas
From: Peter Krempa
Signed-off-by: Peter Krempa
---
...rch64-gigabytesysinfo.expect => aarch64-gigabytesysinfo.xml} | 0
...4-hpe-apollosysinfo.expect => aarch64-hpe-apollosysinfo.xml} | 0
...rch64-moonshotsysinfo.expect => aarch64-moonshotsysinfo.xml} | 0
tests/sy
in virschematest
Peter Krempa (3):
sysinfotest: Use '.xml' suffix for output files
conf: schemas: Split out common parts of 'sysinfo' schema
schema: Schema validate host '' XML test documents
src/conf/schemas/domaincommon.rng | 126 +--
On Mon, Jul 07, 2025 at 15:51:51 +0200, Peter Krempa via Devel wrote:
> On Mon, Jul 07, 2025 at 14:52:09 +0200, Enrique Llorente via Devel wrote:
One additional thing ...
> > @@ -24926,6 +24992,7 @@ virDomainNetBackendFormat(virBuffer *buf,
> >virD
On Thu, Jul 03, 2025 at 14:50:33 +0200, Peter Krempa via Devel wrote:
> From: Peter Krempa
>
> Decide separately and record what shutdown modes are to be applied on
> given VM object rather than spreading out the logic through the code.
>
> This centralization simplifies the
On Mon, Jul 07, 2025 at 14:52:09 +0200, Enrique Llorente via Devel wrote:
> This adds support for custom command line arguments for the passt
> backend, similar to qemu:commandline. The feature allows passing
> additional arguments to the passt process for development and testing
> purposes.
>
> T
From: Peter Krempa
The example allows packets sent by qemu after migration with broken
protocol ID. The proper self announce is handled via
'qemu-announce-self-rarp'.
The qemu bug was addressed by f8778a7785d530515b0db39 (released as
v0.13.0). As we no longer support such old
On Mon, Jul 07, 2025 at 09:19:56 +0100, Daniel P. Berrangé wrote:
> On Mon, Jul 07, 2025 at 09:03:06AM +0200, Peter Krempa via Devel wrote:
> > From: Peter Krempa
> >
> > The example allows packets sent by qemu after migration with broken
> > protocol ID. The proper s
From: Peter Krempa
The example allows packets sent by qemu after migration with broken
protocol ID. The proper self announce is handled via
'qemu-announce-self-rarp'.
The qemu bug was addressed by f8778a7785d530515b0db39 (released as
v0.13.0). As we no longer support such old
On Fri, Jul 04, 2025 at 15:05:10 +0200, Pavel Hrdina wrote:
> On Thu, Jul 03, 2025 at 02:50:33PM +0200, Peter Krempa via Devel wrote:
> > From: Peter Krempa
> >
> > Decide separately and record what shutdown modes are to be applied on
> > given VM object rather t
ered by the default variant.
Reviewed-by: Peter Krempa
From: Peter Krempa
New qemu is deprecating 'pc-q35-4.0-machine', update to the latest
released machine type.
Apart from the previous cases where we could use the aliased machine
type, the firmware auto-selection doesn't work properly for the
unexpanded 'q35' alias and t
From: Peter Krempa
New qemu is deprecating 'pc-i440fx-4.0-machine', update to the latest
released machine type.
Apart from the previous cases where we could use the aliased machine
type, the firmware auto-selection doesn't work properly for the
unexpanded 'pc' alias
From: Peter Krempa
New qemu will be deprecating them. Drop the use from test files not
depending on the actual machine type.
Signed-off-by: Peter Krempa
---
tests/qemuxmlconfdata/vhost-vsock-auto.x86_64-latest.args | 2 +-
tests/qemuxmlconfdata/vhost-vsock-auto.x86_64-latest.xml | 2
From: Peter Krempa
New qemu will be deprecating them. Drop the use from test files not
depending on the actual machine type.
Signed-off-by: Peter Krempa
---
.../pc-i440fx-acpi-root-hotplug-disable.x86_64-latest.args | 2 +-
tests/qemuxmlconfdata/pc-i440fx-acpi-root-hotplug-disable.xml
From: Peter Krempa
New qemu will be deprecating them. Drop the use from test files not
depending on the actual machine type.
Signed-off-by: Peter Krempa
---
.../qemuxmlconfdata/tpm-emulator-crb-profile.x86_64-latest.args | 2 +-
tests/qemuxmlconfdata/tpm-emulator-crb-profile.xml
Peter Krempa (7):
qemuxmlconftest: x86_64: Drop explicit use of '2.10' machine type
qemuxmlconftest: x86_64: Drop explicit use of '2.12' machine type
qemuxmlconftest: x86_64: Drop explicit use of '2.5' machine type
qemuxmlconftest: x86_64: Drop expl
From: Peter Krempa
New qemu will be deprecating them. Drop the use from test files not
depending on the actual machine type.
Signed-off-by: Peter Krempa
---
tests/qemuxmlconfdata/tseg-explicit-size.x86_64-latest.args | 2 +-
tests/qemuxmlconfdata/tseg-explicit-size.x86_64-latest.xml | 2
gt; Reviewed-by: Daniel P. Berrangé
> ---
> src/qemu/qemu_capabilities.c | 2 ++
> src/qemu/qemu_capabilities.h | 1 +
> tests/qemucapabilitiesdata/caps_10.1.0_x86_64+inteltdx.xml | 1 +
> 3 files changed, 4 insertions(+)
Reviewed-by: Peter Krempa
tions(+)
Reviewed-by: Peter Krempa
On Thu, Jul 03, 2025 at 17:24:54 +0200, Hector CAO wrote:
> From: Hector Cao
>
> Add documentation on the way libvirt displays the Host CPU
> model and capabilities (features). There is an implicit
> expection from users to get the CPU model name matching the
> CPU model they are running on, howe
From: Peter Krempa
Decide separately and record what shutdown modes are to be applied on
given VM object rather than spreading out the logic through the code.
This centralization simplifies the conditions in the worker functions
and also:
- provides easy way to check if the auto-shutdown code
From: Peter Krempa
Commit 84bb136c31e added code that intended to skip the save of
transient domains but did so only in the setup part where we pause the
VMS. The second loop that actually attempts to save the VM was not
modified so we'd still try saving them:
Jul 03 14:15:13 and
From: Peter Krempa
'virDomainDriverAutoShutdown' grew into an unwieldy function. Extract
the code for each of the save/shutdown/poweroff steps into helpers and
call them.
Signed-off-by: Peter Krempa
---
src/hypervisor/domain_driver.c | 285 +++--
1 fi
From: Peter Krempa
When auto-shutdown via the qemu driver is requested (rather than via
libvirt guests) we need to start the VMs in a way that they will be kept
around for libvirt to terminate them. This involves inverting the
dependancy relationship for the machined unit file.
Since the setup
From: Peter Krempa
Plumb the new argument across the cgroup helpers up to the domain driver
code.
Signed-off-by: Peter Krempa
---
src/ch/ch_process.c| 2 ++
src/hypervisor/domain_cgroup.c | 4
src/hypervisor/domain_cgroup.h | 1 +
src/lxc/lxc_cgroup.c | 1 +
src
From: Peter Krempa
The existing dependency order of the 'machined' unit file for the domain
we're starting ("After libvirtd/virtqemud"->thus shuts down *before* the
daemon) is intended to work with 'libvirt-guests.service' which requires
the daemon to be ar
From: Peter Krempa
Extract the checker that determines whether the daemon auto shutdown
functionality is active to a separate helper
'virDomainDriverAutoShutdownActive'.
Signed-off-by: Peter Krempa
---
src/hypervisor/domain_driver.c | 13 ++---
src/hypervisor/domain_dri
From: Peter Krempa
Rather than having a bunch of extra variables save the configuration of
the daemon auto shutdown in virDomainDriverAutoShutdownConfig which is
also used when initiating the shutdown.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_conf.c | 30
From: Peter Krempa
The function is called just from one place within the module where it's
defined.
Signed-off-by: Peter Krempa
---
src/hypervisor/domain_cgroup.c | 2 +-
src/hypervisor/domain_cgroup.h | 10 --
src/libvirt_private.syms | 1 -
3 files changed, 1 inse
From: Peter Krempa
The parameter overrides the maximum number of threads for the machine.
Fixes: d5572f62e32
Signed-off-by: Peter Krempa
---
src/util/virsystemd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c
index 92d2890360..4f8424ae32
Following bugs are addressed:
- ordering of systemd units, which cause the VMs to be killed prior to
auto-shutdown finishing
- transient VMs are attempted to be managesaved
- restore of state is applied to VMs which the auto shutdown code
didn't act on otherwise
Peter Kremp
v2:
- [1/3] removed also GNUTLS_KEY_KEY_ENCIPHERMENT use in fallback code
- [2/3 new] removed 'encryption_key' usage from kbase examples
- [3/3 new] removed GNUTLS_KEY_KEY_ENCIPHERMENT use in testsuite
Peter Krempa (3):
tls: Don't require 'keyEncipherment' to be e
From: Peter Krempa
It's not needed with TLS 1.3 any more.
Signed-off-by: Peter Krempa
---
tests/virnettlscontexttest.c | 36 ++--
tests/virnettlssessiontest.c | 14 +++---
2 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/
From: Peter Krempa
Key encipherment is required only for RSA key exchange algorithm. With
TLS 1.3 this is not even used as RSA is used only for authentication.
Since we can't really check when it's required ahead of time drop the
check completely. GnuTLS will moan if it will not be a
From: Peter Krempa
As TLS 1.3 performs key exchange separately from the algorithm used to
verify authenticity, the certificates for libvirt's use of TLS don't
need to require the 'encryption_key' feature any more.
Signed-off-by: Peter Krempa
---
docs/kbase/tlscerts.rst |
On Tue, Jul 01, 2025 at 11:38:37 +0100, Daniel P. Berrangé wrote:
> On Tue, Jul 01, 2025 at 10:59:06AM +0200, Peter Krempa wrote:
> > On Tue, Jul 01, 2025 at 09:49:57 +0100, Daniel P. Berrangé wrote:
> > > On Mon, Jun 30, 2025 at 07:25:05PM +0200, Peter Krempa via Devel wrote:
&
On Tue, Jul 01, 2025 at 10:38:44 +0200, Jiri Denemark via Devel wrote:
> On Mon, Jun 30, 2025 at 16:59:07 -0300, Fabiano Rosas wrote:
> > The concept of capabilities is being merged into the concept of
> > parameters. From now on, the commands that handle capabilities are
> > deprecated in favor of
On Tue, Jul 01, 2025 at 09:49:57 +0100, Daniel P. Berrangé wrote:
> On Mon, Jun 30, 2025 at 07:25:05PM +0200, Peter Krempa via Devel wrote:
> > From: Peter Krempa
> >
> > Key encipherment is required only for RSA key exchange algorithm. With
> > TLS 1.3 this is not ev
On Mon, Jun 30, 2025 at 19:25:05 +0200, Peter Krempa wrote:
> From: Peter Krempa
>
> Key encipherment is required only for RSA key exchange algorithm. With
> TLS 1.3 this is not even used as RSA is used only for authentication.
>
> Since we can't really check when it&#
From: Peter Krempa
Key encipherment is required only for RSA key exchange algorithm. With
TLS 1.3 this is not even used as RSA is used only for authentication.
Since we can't really check when it's required ahead of time drop the
check completely. GnuTLS will moan if it will not be a
he ``amd`` model for the device is now supported.
> +New attributes ``passtrhough`` and ``xtsup`` are also supported for this
> +model.
> +
> * **Improvements**
>
>* Include supported console types in domain capabilities
> --
> 2.49.0
>
Reviewed-by: Peter Krempa
1 - 100 of 1846 matches
Mail list logo
