Re: [PATCH 15/20] hyperv: Support hv-time enlightenment

On Mon, Oct 06, 2025 at 03:14:46PM +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > QEMU supports this enlightenment since version 2.0. It's required > by some other enlightenments (e.g. hv-stimer, hv-stimer-direct). > >From QEMU docs: > > ``hv-time`` > Enables two Hyper-V

Re: [libvirt-python PATCH] build: Adapt to PEP 625 distribution file naming

On Wed, Sep 10, 2025 at 02:04:39PM +0200, Jiri Denemark via Devel wrote: > The version of setuptools shipped by Fedora 42 is PEP 625 compliant, > which requires distribution files to contain a normalized package name. > Thus the generated tarball is called libvirt_python-$VER.tar.gz rather > than l

Re: [PATCH] ci: regenerate with 'lcitool manifest'

On Mon, Aug 04, 2025 at 11:48:41AM +0100, Daniel P. Berrangé via Devel wrote: > From: Daniel P. Berrangé > > This pulls in the fix for libxen which has been removed from armv7 > in Debian sid. > > Signed-off-by: Daniel P. Berrangé > --- > > Pending: https://gitlab.com/libvirt/libvirt-ci/-/merg

Re: [PATCH 0/2] Revert recent patches causing test dependance on host state

On Tue, Jul 29, 2025 at 01:07:27PM +0200, Peter Krempa via Devel wrote: > Revert the patches as we're in code freeze. > > Peter Krempa (2): > Revert "qemuxmlconfdata: Regenerate outputs after last commit" > Revert "qemu: Match firmware with fully resolved and canonicalized > paths" Review

Re: [PATCH] NEWS: Mention zero discard_granularity option

On Mon, Jul 28, 2025 at 01:47:29PM +0200, Martin Kletzander via Devel wrote: > From: Martin Kletzander > > Signed-off-by: Martin Kletzander > --- > NEWS.rst | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature

Re: [PATCH 0/2] meson: Report library versions in the summary

On Fri, Jul 18, 2025 at 03:34:19PM +0200, Michal Privoznik via Devel wrote: > Green pipeline: > > https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1934463449 > > and if you shod individual builds you can see these in action. Nice! > Michal Prívozník (2): > meson: Convert attr_dep to de

Re: [PATCH] qemu_tpm: Do not use persistent definition during pre-start checks

On Fri, Jul 18, 2025 at 03:08:38PM +0200, Martin Kletzander wrote: > From: Martin Kletzander > > Commit 3451987fca7c used the persistent TPM Definition in both calls to > qemuTPMVirCommandSwtpmAddTPMState() but in one of the two cases it > might've been NULL and what's more, it is not the right d

Re: [PATCH 3/3] qemu_tpm: Only warn about missing locking feature on shared filesystems

On Thu, Jul 17, 2025 at 12:34:43PM +0200, Martin Kletzander via Devel wrote: > From: Martin Kletzander > > The warning pollutes the logs and might give a bad impression on someone > reading them even though the locking is not always needed. This way we > at least limit the logging in unnecessary

Re: [libvirt PATCH] conf: schemas: add sysinfocommon.rng into list of installed schemas

On Tue, Jul 15, 2025 at 12:21:11PM +0200, Michal Prívozník wrote: > On 7/15/25 12:15, Pavel Hrdina via Devel wrote: > > From: Pavel Hrdina > > > > Fixes: 918594b419ea3944220fcbab6cf4f1ce7d81e609 > > Signed-off-by: Pavel Hrdina > > --- > > src/conf/schema

[libvirt PATCH] conf: schemas: add sysinfocommon.rng into list of installed schemas

From: Pavel Hrdina Fixes: 918594b419ea3944220fcbab6cf4f1ce7d81e609 Signed-off-by: Pavel Hrdina --- src/conf/schemas/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/schemas/meson.build b/src/conf/schemas/meson.build index b293373085..7ec625b8db 100644 --- a/src/conf/sche

Re: [libvirt PATCH] docs: hacking: Define policy forbidding use of AI code generators

On Thu, Jul 10, 2025 at 02:33:45PM +0200, Peter Krempa wrote: > On Thu, Jul 10, 2025 at 11:43:32 +0200, Pavel Hrdina via Devel wrote: > > This policy is a copy of what QEMU project is using [1] as there is no > > reason to use different policy, only modification is changing the &

[libvirt PATCH] docs: hacking: Define policy forbidding use of AI code generators

This policy is a copy of what QEMU project is using [1] as there is no reason to use different policy, only modification is changing the project name and link to DCO. [1] Signed-off-by: Pavel Hrdina ---

Re: [PATCH 0/7] qemu-10.1 test data and dropped machine type cleanups

On Fri, Jul 04, 2025 at 10:51:34AM +0200, Peter Krempa via Devel wrote: > Peter Krempa (7): > qemuxmlconftest: x86_64: Drop explicit use of '2.10' machine type > qemuxmlconftest: x86_64: Drop explicit use of '2.12' machine type > qemuxmlconftest: x86_64: Drop explicit use of '2.5' machine typ

Re: [PATCH] nwfilter: Remove 'qemu-announce-self' example

On Mon, Jul 07, 2025 at 09:03:06AM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > The example allows packets sent by qemu after migration with broken > protocol ID. The proper self announce is handled via > 'qemu-announce-self-rarp'. > > The qemu bug was addressed by f8778a7785d53

Re: [PATCH 09/10] virDomainDriverAutoShutdownDoSave: Don't attempt to save transient VMs

On Thu, Jul 03, 2025 at 02:50:32PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > Commit 84bb136c31e added code that intended to skip the save of > transient domains but did so only in the setup part where we pause the > VMS. The second loop that actually attempts to save the VM wa

Re: [PATCH 10/10] virDomainDriverAutoShutdown: Refactor selection logic for VMs

On Thu, Jul 03, 2025 at 02:50:33PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > Decide separately and record what shutdown modes are to be applied on > given VM object rather than spreading out the logic through the code. > > This centralization simplifies the conditions in the

Re: [PATCH 08/10] hypervisor: Split out individual steps out of virDomainDriverAutoShutdown

On Thu, Jul 03, 2025 at 02:50:31PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > 'virDomainDriverAutoShutdown' grew into an unwieldy function. Extract > the code for each of the save/shutdown/poweroff steps into helpers and > call them. > > Signed-off-by: Peter Krempa > --- > s

Re: [PATCH 07/10] qemu: Fix auto-shutdown of qemu VMs by the qemu driver

On Thu, Jul 03, 2025 at 02:50:30PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > When auto-shutdown via the qemu driver is requested (rather than via > libvirt guests) we need to start the VMs in a way that they will be kept > around for libvirt to terminate them. This involves in

Re: [PATCH 06/10] cgroup: Plumb the 'daemonDomainShutdown' parameter of 'virSystemdCreateMachine' to drivers

On Thu, Jul 03, 2025 at 02:50:29PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > Plumb the new argument across the cgroup helpers up to the domain driver > code. > > Signed-off-by: Peter Krempa > --- > src/ch/ch_process.c| 2 ++ > src/hypervisor/domain_cgroup.c | 4

Re: [PATCH 05/10] virSystemdCreateMachine: Add flag to invert machined unit dependencies

On Thu, Jul 03, 2025 at 02:50:28PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > The existing dependency order of the 'machined' unit file for the domain > we're starting ("After libvirtd/virtqemud"->thus shuts down *before* the > daemon) is intended to work with 'libvirt-guests.s

Re: [PATCH 04/10] hypervisor: domain: Extract logic for auto shutdown to virDomainDriverAutoShutdownActive

On Thu, Jul 03, 2025 at 02:50:27PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > Extract the checker that determines whether the daemon auto shutdown > functionality is active to a separate helper > 'virDomainDriverAutoShutdownActive'. > > Signed-off-by: Peter Krempa > --- > sr

Re: [PATCH 03/10] qemu: conf: Store 'autoShutdown' config in virDomainDriverAutoShutdownConfig

On Thu, Jul 03, 2025 at 02:50:26PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > Rather than having a bunch of extra variables save the configuration of > the daemon auto shutdown in virDomainDriverAutoShutdownConfig which is > also used when initiating the shutdown. > > Signed-o

Re: [PATCH 01/10] virSystemdCreateMachine: Document @maxthreds

On Thu, Jul 03, 2025 at 02:50:24PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > The parameter overrides the maximum number of threads for the machine. > > Fixes: d5572f62e32 > Signed-off-by: Peter Krempa > --- > src/util/virsystemd.c | 1 + > 1 file changed, 1 insertion(+) Re

Re: [PATCH 02/10] cgroup: Unexport 'virDomainCgroupInitCgroup'

On Thu, Jul 03, 2025 at 02:50:25PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > The function is called just from one place within the module where it's > defined. > > Signed-off-by: Peter Krempa > --- > src/hypervisor/domain_cgroup.c | 2 +- > src/hypervisor/domain_cgroup.h |

Re: [PATCH RFE] conf: Add extraArgs option to passt backend

On Wed, Jun 25, 2025 at 09:40:16AM +0200, Enrique Llorente via Devel wrote: > Add support for passing extra arguments to the passt binary through > the domain XML configuration. This allows users to specify additional > command-line arguments for passt that are not covered by existing > structured

Re: [PATCH] virSocketAddrPrefixToNetmask: Prevent undefined behaviour on bitshifts on signed integer

On Wed, Jun 18, 2025 at 08:31:36AM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > Shifting bits into the sign bit is undefined behaviour in C although > both gcc and clang handle it as expected. > > Since the value is used as unsigned convert it to unsigned int. For code > readabi

Re: [PATCH] qemu: Be more forgiving when acquiring QUERY job when formatting domain XML

On Mon, Jun 16, 2025 at 10:45:15AM +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > In my previous commit of v11.0.0-rc1~115 I've made QEMU driver > implementation for virDomainGetXMLDesc() (qemuDomainGetXMLDesc()) > acquire QERY job. See its commit message for more info. But

Re: [PATCH] docs: fix list term highlighting in URI docs

On Mon, Jun 09, 2025 at 04:18:06PM +0100, Daniel P. Berrangé via Devel wrote: > From: Daniel P. Berrangé > > Having a blank line between the term and its definition prevents the RST > to HTML convertor highlighting 'pkipath' correctly. > > Signed-off-by: Daniel P. Berrangé > --- > docs/uri.rst

Re: [PATCH] docs: Change units to 'kiB' from 'kB'/'kilobytes'/'kb'

On Mon, Jun 02, 2025 at 10:59:02AM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > Use the short unit for kibibytes instead of the confusing or plainly > wrong units. > > Closes: https://gitlab.com/libvirt/libvirt/-/issues/594 > Signed-off-by: Peter Krempa > --- > docs/formatdoma

Re: [PATCH] esx: Avoid corner case where esxUtil_ParseDatastorePath could be called with NULL 'datastorePath'

On Mon, Jun 02, 2025 at 11:03:26AM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > The generated code which parses the data from XML in > esxVI_LookupDatastoreContentByDatastoreName can fill the 'folderPath' > property with NULL if it were missing from the input XML. While this is >

Re: [PATCH 0/9] qemu: Move config validation out of qemu_process.c

On Tue, May 27, 2025 at 09:48:56AM +0200, Peter Krempa via Devel wrote: > Some more cleanups for misplaced validation of config that I've noticed > when I was looking for the code validating floppies in my previous > series. > > Peter Krempa (9): > qemuDomainValidateStorageSource: Rework protoco

Re: [PATCH] qemucapabilitiesdata: Enable GTK graphics for 'caps_10.0.0_x86_64'

On Mon, Apr 28, 2025 at 02:24:20PM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > The common x86_64 test output was usually built without GTK as I've had > that in my build script for a long time. Enable it now as GTK UI is > enabled by many distros and upcoming patches plan to add

[libvirt PATCH 4/6] tools: use virDomainRestoreParams only when necessary

From: Pavel Hrdina We should use the newest API only when user sets parallel-channels. Signed-off-by: Pavel Hrdina --- tools/virsh-domain.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 56ddf4d701..

Re: [PATCH] NEWS: Mention support for mapped-ram

On Thu, Mar 20, 2025 at 05:25:43PM -0600, Jim Fehlig via Devel wrote: > Add a 'New features' entry for mapped-ram itself, and another > for the parallel save/restore feature built on top. > > Signed-off-by: Jim Fehlig > --- > NEWS.rst | 15 +++ > 1 file changed, 15 insertions(+) Rev

Re: [PATCH 2/2] qemu: Fix build on 32-bit platforms

On Thu, Mar 20, 2025 at 04:17:00PM -0600, Jim Fehlig via Devel wrote: > Commits c2518f7bc7 and 28a0621528 introduced build failures on 32-bit > platforms by using incorrect format specifiers with g_strdup_printf. > > In one case, an 'unsigned long' format specifier is used with a > 'long long int'

Re: [PATCH 1/2] qemu: Fix CLang build

On Thu, Mar 20, 2025 at 04:16:59PM -0600, Jim Fehlig via Devel wrote: > Commit f0169f4d caused a build failure with CLang due to potentially > uninitialized variable > > ../src/qemu/qemu_migration_params.c:825:17: error: variable 'nchannels' > is used uninitialized whenever '&&' condition is false

Re: [PATCH] meson: Add back prefix path for runstatedir

On Wed, Apr 02, 2025 at 08:33:23AM +, Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Peter Krempa > >Subject: Re: [PATCH] meson: Add back prefix path for runstatedir > > > >On Wed, Apr 02, 2025 at 15:58:28 +0800, Zhenzhong Duan wrote: > >> Currently libvirt favors /run ins

Re: [PATCH 0/6] qemu: Remove last HMP commands

On Wed, Apr 02, 2025 at 10:08:23AM +0200, Peter Krempa via Devel wrote: > RIP HMP use in libvirt: > > 2007-02-14 [1] - 2025-04-02 > > [1] 23ad665cb05ef9ce7d298cc34bff5efb95ef6948 > > Peter Krempa (6): > qemu: domain: Don't check return value of 'virCPUDefCopy' > qemuSnapshotCreateActiveInte

Re: [PATCH 0/3] apparmor: assume at least version 3

On Mon, Mar 31, 2025 at 11:48:20AM +0100, Daniel P. Berrangé via Devel wrote: > > > Daniel P. Berrangé (3): > apparmor: assume at least apparmor >= 3 > Revert "apparmor: Allow version-specific bits in profiles" > meson: drop remaining checks for apparmor version With the comment for patch

Re: [PATCH v2 0/5] apparmor: assume at least version 3

On Mon, Mar 31, 2025 at 01:37:26PM +0100, Daniel P. Berrangé via Devel wrote: > In v2: > > - Do upfront check for apparmor >= 3.0.0 > - Add further revert commit > > Daniel P. Berrangé (5): > meson: mandate apparmor >= 3.0.0 > apparmor: assume at least apparmor >= 3 > Revert "apparmor: Al

Re: [PATCH 3/3] meson: drop remaining checks for apparmor version

On Mon, Mar 31, 2025 at 11:48:23AM +0100, Daniel P. Berrangé via Devel wrote: > From: Daniel P. Berrangé > > We can now assume at least version three: > > * Debian 12: 3.0.8 > * openSUSE Leap 15.5: 3.0.4 > * openSUSE Leap 15.6: 3.1.7 > * Ubuntu 22.04: 3.0.4 > * Ubuntu 24.04: 4.0.0 > > Sign

[libvirt PATCH 0/6] cleanup and fixes of the mapped-ram feature

Pavel Hrdina (6): tools: remove --parallel from virsh restore command tools: remote --parallel from virsh save command qemu: remove VIR_DOMAIN_SAVE_PARALLEL flag tools: use virDomainRestoreParams only when necessary tools: use virDomainSaveParams only when necessary virsh: add --image-f

Re: [PATCH] NEWS: Mention bump to qemu-6.2, vhost-user shmem check and stats params discoverabilty

On Wed, Mar 26, 2025 at 10:16:35AM +0100, Peter Krempa via Devel wrote: > From: Peter Krempa > > Signed-off-by: Peter Krempa > --- > NEWS.rst | 20 > 1 file changed, 20 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 18d45656b8..2855ec77e4 100644 > --- a/NEWS.rs

[libvirt PATCH 6/6] virsh: add --image-format option to the save command

From: Pavel Hrdina Option --parallel-channels would require changing configuration file to be used so introduce this option as well to make it convenient for users. Signed-off-by: Pavel Hrdina --- docs/manpages/virsh.rst | 5 + tools/virsh-domain.c| 12 2 files changed, 1

[libvirt PATCH] qemu_driver: Fix virDomainSaveImageDefineXML

From: Pavel Hrdina Commit 28a06215280b99708ed8dc2d183f62ba7b34ccf8 added support to restore sparse images but changed the boolean that controls if we open the file as read-only or read-write. Editing XML in the save image resulted in following error message: failed to write header to domain

[libvirt PATCH 2/6] tools: remote --parallel from virsh save command

From: Pavel Hrdina There is no need to have --parallel and --parallel-channels especially when --parallel on its own is the same as not used at all. In both cases libvirt will default to single channel. Signed-off-by: Pavel Hrdina --- docs/manpages/virsh.rst | 11 +-- tools/virsh-domai

[libvirt PATCH 1/6] tools: remove --parallel from virsh restore command

From: Pavel Hrdina There is no need to have --parallel and --parallel-channels especially when --parallel on its own is the same as not used at all. In both cases libvirt will default to single channel. Signed-off-by: Pavel Hrdina --- docs/manpages/virsh.rst | 8 tools/virsh-domain.c

[libvirt PATCH 5/6] tools: use virDomainSaveParams only when necessary

From: Pavel Hrdina We should use the newest API only when user sets parallel-channels. Signed-off-by: Pavel Hrdina --- tools/virsh-domain.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index c21cf847c8..

[libvirt PATCH 3/6] qemu: remove VIR_DOMAIN_SAVE_PARALLEL flag

From: Pavel Hrdina There is no need to use extra flag in addition to the new "parallel.channels" param. Using the flag without param would result in using uninitialized variable. Fixing it would result in error that parallel channels cannot be less then 1 or setting 1 as default. Using the para

Re: [PATCH 0/5] qemu: Two block job fixes

On Mon, Mar 17, 2025 at 06:27:27PM +0100, Peter Krempa via Devel wrote: > Peter Krempa (5): > qemu: monitor: Wire up 'replaces' attribute for 'blockdev-mirror' > qemu: Do not replace filter nodes with virDomainBlockCopy > qemu: Remove return value from 'qemuHotplugRemoveManagedPR' > qemuDom

Re: [PATCH] docs: remove references to removed APIs

On Mon, Mar 17, 2025 at 10:04:17AM +, Daniel P. Berrangé via Devel wrote: > The glib adoption docs was suggesting avoidance of certain APIs that > were obsoleted by glib, during the transition period. Now that the > referenced APIs no longer exist in libvirt code, they can also be > removed fro

Re: [PATCH] scripts: add execute permission to several files

On Mon, Mar 17, 2025 at 10:24:54AM +, Daniel P. Berrangé via Devel wrote: > From: Daniel P. Berrangé > > Most, but not all, files in scripts have execute permission. While we > don't need this in order to launch them via meson/ninja build rules, > it is nice to direct execution if they have e