tlab.com/libvirt/libvirt-ci/-/merge_requests/537
>
> ci/buildenv/debian-sid-cross-armv7l.sh | 1 -
> ci/containers/debian-sid-cross-armv7l.Dockerfile | 1 -
> 2 files changed, 2 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
olved and canonicalized
> paths"
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Mon, Jul 28, 2025 at 01:47:29PM +0200, Martin Kletzander via Devel wrote:
> From: Martin Kletzander
>
> Signed-off-by: Martin Kletzander
> ---
> NEWS.rst | 5 +
> 1 file changed, 5 insertions(+)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
: Convert attr_dep to dependency()
> meson: Report library versions in the summary
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
keep the other one as is because there is
> no issue with calling it that way and adding logic that just skips the
> extra check on NULL could mistake someone in the future.
>
> Signed-off-by: Martin Kletzander
> ---
> src/qemu/qemu_tpm.c | 2 +-
> 1 file changed, 1 insertio
On Thu, Jul 17, 2025 at 12:34:43PM +0200, Martin Kletzander via Devel wrote:
> From: Martin Kletzander
>
> The warning pollutes the logs and might give a bad impression on someone
> reading them even though the locking is not always needed. This way we
> at least limit the logging in unnecessary
On Tue, Jul 15, 2025 at 12:21:11PM +0200, Michal Prívozník wrote:
> On 7/15/25 12:15, Pavel Hrdina via Devel wrote:
> > From: Pavel Hrdina
> >
> > Fixes: 918594b419ea3944220fcbab6cf4f1ce7d81e609
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/conf/schema
From: Pavel Hrdina
Fixes: 918594b419ea3944220fcbab6cf4f1ce7d81e609
Signed-off-by: Pavel Hrdina
---
src/conf/schemas/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/schemas/meson.build b/src/conf/schemas/meson.build
index b293373085..7ec625b8db 100644
--- a/src/conf
On Thu, Jul 10, 2025 at 02:33:45PM +0200, Peter Krempa wrote:
> On Thu, Jul 10, 2025 at 11:43:32 +0200, Pavel Hrdina via Devel wrote:
> > This policy is a copy of what QEMU project is using [1] as there is no
> > reason to use different policy, only modification is changing the
&
This policy is a copy of what QEMU project is using [1] as there is no
reason to use different policy, only modification is changing the
project name and link to DCO.
[1]
<https://www.qemu.org/docs/master/devel/code-provenance.html#use-of-ai-content-generators>
Signed-off-by: Pavel
cases to 'pc-q35-10.0'
> qemucapabilitiestest: Add dump for the qemu-10.1 development cycle on
> x86_64
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
nwfilter/xml/meson.build | 1 -
> src/nwfilter/xml/qemu-announce-self-rarp.xml | 2 ++
> src/nwfilter/xml/qemu-announce-self.xml | 13 -
> 7 files changed, 5 insertions(+), 18 deletions(-)
> delete mode 100644 src/nwfilter/xml/qemu-announce-self.xml
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
t; Fixes: 84bb136c31e
> Signed-off-by: Peter Krempa
> ---
> src/hypervisor/domain_driver.c | 4
> 1 file changed, 4 insertions(+)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
}
> +if (modes[i] == 0) {
> +/* VM wasn't selected for any of the shutdown modes. There's not
> + * much we can do about that as the host is powering off, logging
> + * at least lets admins know */
> +VIR_WARN("auto-shutdown: domain '%s' not successfully shut off
> by any action",
> + domains[i]->name);
> +}
> +
> +if (modes[i] & VIR_DOMAIN_DRIVER_AUTO_SHUTDOWN_MODE_RESTORE) {
> +VIR_DEBUG("Mark %s for autostart on next boot",
Suggestion: I know it's preexisting but would be nice to s/%s/'%s'/.
With the issues fixed:
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
gt; Signed-off-by: Peter Krempa
> ---
> src/hypervisor/domain_driver.c | 285 +++--
> 1 file changed, 161 insertions(+), 124 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
> ---
> src/qemu/qemu.conf.in | 15 ++-
> src/qemu/qemu_cgroup.c | 8 +++-
> 2 files changed, 21 insertions(+), 2 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
ervisor/domain_cgroup.c | 4
> src/hypervisor/domain_cgroup.h | 1 +
> src/lxc/lxc_cgroup.c | 1 +
> src/qemu/qemu_cgroup.c | 1 +
> src/util/vircgroup.c | 6 +-
> src/util/vircgroup.h | 1 +
> 7 files changed, 15 insertions
use the proper
> relationship.
>
> Signed-off-by: Peter Krempa
> ---
> src/util/vircgroup.c | 3 ++-
> src/util/virsystemd.c | 27 +--
> src/util/virsystemd.h | 3 ++-
> tests/virsystemdtest.c | 15 +--
> 4 files changed, 34 insertions(+), 14 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
gt; Signed-off-by: Peter Krempa
> ---
> src/hypervisor/domain_driver.c | 13 ++---
> src/hypervisor/domain_driver.h | 1 +
> src/libvirt_private.syms | 1 +
> 3 files changed, 12 insertions(+), 3 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
wn.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_conf.c | 30 +++---
> src/qemu/qemu_conf.h | 7 +--
> src/qemu/qemu_driver.c | 12 +++-
> 3 files changed, 19 insertions(+), 30 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
1 file changed, 1 insertion(+)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
src/hypervisor/domain_cgroup.h | 10 --
> src/libvirt_private.syms | 1 -
> 3 files changed, 1 insertion(+), 12 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Wed, Jun 25, 2025 at 09:40:16AM +0200, Enrique Llorente via Devel wrote:
> Add support for passing extra arguments to the passt binary through
> the domain XML configuration. This allows users to specify additional
> command-line arguments for passt that are not covered by existing
> structured
gned int. For code
> readability use 'if' statement instead of a ternary.
>
> Closes: https://gitlab.com/libvirt/libvirt/-/issues/785
> Signed-off-by: Peter Krempa
> ---
> src/util/virsocketaddr.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-b
lves: https://bugzilla.redhat.com/show_bug.cgi?id=2369243
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_driver.c | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
l P. Berrangé
> ---
> docs/uri.rst | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
nsertions(+), 19 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
gt; Signed-off-by: Peter Krempa
> ---
> src/esx/esx_storage_backend_vmfs.c | 6 ++
> 1 file changed, 6 insertions(+)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
of graphics to
> validation code
> qemuProcessStartValidateGraphics: Remove redundant checks for RDP
> protocol features
> qemuProcessStartValidateGraphics: Move RDP validation logic to
> qemu_validate.c
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
ming patches plan to add support to
> libvirt as well.
>
> Signed-off-by: Peter Krempa
> ---
> tests/qemucapabilitiesdata/caps_10.0.0_x86_64.replies | 8
> 1 file changed, 8 insertions(+)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
From: Pavel Hrdina
We should use the newest API only when user sets parallel-channels.
Signed-off-by: Pavel Hrdina
---
tools/virsh-domain.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 56ddf4d701
1 file changed, 15 insertions(+)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
cat, but I think this would be the
> preferred approach. And while adding the 2 'Fixes:' lines to the
> commit message, I questioned whether this should be 2 patches.
>
> src/qemu/qemu_monitor.c | 4 ++--
> src/qemu/qemu_process.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Thu, Mar 20, 2025 at 04:16:59PM -0600, Jim Fehlig via Devel wrote:
> Commit f0169f4d caused a build failure with CLang due to potentially
> uninitialized variable
>
> ../src/qemu/qemu_migration_params.c:825:17: error: variable 'nchannels'
> is used uninitialized whenever '&&' condition is false
On Wed, Apr 02, 2025 at 08:33:23AM +, Duan, Zhenzhong wrote:
>
>
> >-Original Message-
> >From: Peter Krempa
> >Subject: Re: [PATCH] meson: Add back prefix path for runstatedir
> >
> >On Wed, Apr 02, 2025 at 15:58:28 +0800, Zhenzhong Duan wrote:
> >> Currently libvirt favors /run ins
: capabilities: Retire QEMU_CAPS_SNAPSHOT_INTERNAL_QMP
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
ion
With the comment for patch 03 addressed.
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
rmor >= 3
> Revert "apparmor: Allow version-specific bits in abstractions too"
> Revert "apparmor: Allow version-specific bits in profiles"
> meson: drop remaining checks for apparmor version
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Mon, Mar 31, 2025 at 11:48:23AM +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> We can now assume at least version three:
>
> * Debian 12: 3.0.8
> * openSUSE Leap 15.5: 3.0.4
> * openSUSE Leap 15.6: 3.1.7
> * Ubuntu 22.04: 3.0.4
> * Ubuntu 24.04: 4.0.0
>
> Sign
Pavel Hrdina (6):
tools: remove --parallel from virsh restore command
tools: remote --parallel from virsh save command
qemu: remove VIR_DOMAIN_SAVE_PARALLEL flag
tools: use virDomainRestoreParams only when necessary
tools: use virDomainSaveParams only when necessary
virsh: add --image
ML which
> allows
> +discoverability of new entries in typed parameter names returned by
> +``virConnectGetAllDomainStats``, ``virDomainListGetStats``, and
> +``virDomainGetGuestInfo``.
> +
> * **Bug fixes**
>
>* qemu: attach virtio-mem with CCW address
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
From: Pavel Hrdina
Option --parallel-channels would require changing configuration file to
be used so introduce this option as well to make it convenient for
users.
Signed-off-by: Pavel Hrdina
---
docs/manpages/virsh.rst | 5 +
tools/virsh-domain.c| 12
2 files changed
From: Pavel Hrdina
Commit 28a06215280b99708ed8dc2d183f62ba7b34ccf8 added support to restore
sparse images but changed the boolean that controls if we open the file
as read-only or read-write. Editing XML in the save image resulted in
following error message:
failed to write header to domain
From: Pavel Hrdina
There is no need to have --parallel and --parallel-channels especially
when --parallel on its own is the same as not used at all. In both cases
libvirt will default to single channel.
Signed-off-by: Pavel Hrdina
---
docs/manpages/virsh.rst | 11 +--
tools/virsh
From: Pavel Hrdina
There is no need to have --parallel and --parallel-channels especially
when --parallel on its own is the same as not used at all. In both cases
libvirt will default to single channel.
Signed-off-by: Pavel Hrdina
---
docs/manpages/virsh.rst | 8
tools/virsh
From: Pavel Hrdina
We should use the newest API only when user sets parallel-channels.
Signed-off-by: Pavel Hrdina
---
tools/virsh-domain.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index c21cf847c8
From: Pavel Hrdina
There is no need to use extra flag in addition to the new
"parallel.channels" param.
Using the flag without param would result in using uninitialized
variable. Fixing it would result in error that parallel channels cannot
be less then 1 or setting 1 as default.
from 'qemuHotplugRemoveManagedPR'
> qemuDomainChangeEjectableMedia: Separate rollback and success code
> paths
> qemuHotplugRemoveManagedPR: Integrate check whether removal is needed
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
> removed from the docs.
>
> NB, the virStringListRemoveDuplicates method remains since there is
> no glib equivalent.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/glib-adoption.rst | 22 --
> 1 file changed, 22 deletions(-)
Reviewed-by: Pavel
00644 => 100755 scripts/mock-noinline.py
> mode change 100644 => 100755 scripts/prohibit-duplicate-header.py
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
dated 'caps_7.0.0_aarch64' data
> qemucapabilitiesdata: Drop un-updated 'qemu_8.0.0_riscv64' data
> qemu: capabilities: Bump minimum qemu to qemu-6.2
> qemu: block: Drop 'sheepdog' protocol support
> qemucapabilitiestest: Update 'caps_10.0.0_x86_64' to
> 'v9.2.0-2369-g98c7362b1e'
> qemucapabilitiestest: Add data for the qemu-10.0 dev cycle on x86_64
> for the '+amdsev' variant
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
virDomainGraphicsDefFormat function was way too long so split it into
separate functions for each graphics type.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf
Use the new virXMLFormatDirect in order to remove usage of
virXMLFormatInternal.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 94f456a362
t in libvirt mentions 9.3
but that version is incorrect.
With that added.
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Mon, Mar 03, 2025 at 11:34:25AM -0700, Jim Fehlig via Devel wrote:
> Signed-off-by: Jim Fehlig
> ---
> NEWS.rst | 8
> 1 file changed, 8 insertions(+)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Wed, Mar 12, 2025 at 05:17:45PM +, Daniel P. Berrangé wrote:
> Currently automatic VM managed save is only performed in session
> daemons, on desktop session close, or host OS shutdown request.
>
> With this change it is possible to control shutdown behaviour for
> all daemons. A recommende
Only VNC, RDP and Spice graphics types are using listen elements so call
the function only where it is needed.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf
virDomainGraphicsDefFormat function was way too long so split it into
separate functions for each graphics type.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 115 ++---
1 file changed, 62 insertions(+), 53 deletions(-)
diff --git a/src/conf
This will be used in specific graphics types that are using listen
elements.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 67 --
1 file changed, 39 insertions(+), 28 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
Now we are able to move the rest into virDomainGraphicsDefFormatVNC
without breaking order of elements in the resulting XML.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf
Now we are able to move the rest into virDomainGraphicsDefFormatSpice
without breaking order of elements in the resulting XML.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 81 --
1 file changed, 39 insertions(+), 42 deletions(-)
diff --git a
Pavel Hrdina (16):
domain_conf: graphics: use a function to format gl element
domain_conf: graphics: use a function to format audio element
domain_conf: modernize graphics formatting
domain_conf: graphics: extract VNC formatting to separate function
domain_conf: graphics: extract SDL
virDomainGraphicsDefFormat function was way too long so split it into
separate functions for each graphics type.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/src/conf/domain_conf.c b
This can be used to format XML where the element has direct value
instead of any subelement. For example:
1524288
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms | 1 +
src/util/virxml.c| 14 ++
src/util/virxml.h| 6 ++
3 files changed, 21
- Remove EOL Debian 11
Signed-off-by: Pavel Hrdina
---
This depends on this MR [1] to update libvirt-ci as well.
[1] <https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/527>
ci/buildenv/debian-11-cross-aarch64.sh| 117
ci/buildenv/debian-11-cross-arm
On Fri, Mar 07, 2025 at 01:37:49PM +0100, Ján Tomko wrote:
> On a Thursday in 2025, Pavel Hrdina wrote:
> > Use the new virXMLFormatDirect in order to remove usage of
> > virXMLFormatInternal.
> >
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/conf/doma
virDomainGraphicsDefFormat function was way too long so split it into
separate functions for each graphics type.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 25 -
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/src/conf/domain_conf.c b/src
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 4 ++--
src/conf/node_device_conf.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index f42b7075ad..94f456a362 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf
It is no longer used anywhere else.
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms | 1 -
src/util/virxml.c| 2 +-
src/util/virxml.h| 7 ---
3 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index
Pavel Hrdina (4):
util: virxml: introduce virXMLFormatElementDirect
conf: use virXMLFormatElementDirect
domain_conf: refactor virDomainLoaderDefFormatNvram
util: virxml: unexport virXMLFormatElementInternal
src/conf/domain_conf.c | 22 ++
src/conf
Removes code duplication.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 39 +--
1 file changed, 17 insertions(+), 22 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index f42b7075ad..850fe7e90b 100644
--- a/src/conf
This was reported on virt-manager issue tracker as it was possible to
provide `listen` attribute with properly escaped characters but libvirt
would format XML without escaping it.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
user with offline VM even if it was running.
Make the check before we start the revert process to not destroy VMs.
Resolves: https://issues.redhat.com/browse/RHEL-30971
Resolves: https://issues.redhat.com/browse/RHEL-79928
Signed-off-by: Pavel Hrdina
---
Changes in v2:
- add comments
-
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 27323ea768..6bb30c6f22 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -26433,7 +26433,7
virDomainGraphicsDefFormat function was way too long so split it into
separate functions for each graphics type.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf
virDomainGraphicsDefFormat function was way too long so split it into
separate functions for each graphics type.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 42 +-
1 file changed, 25 insertions(+), 17 deletions(-)
diff --git a/src/conf
Removes code duplication.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 850fe7e90b..a0e68d6046 100644
--- a/src/conf/domain_conf.c
+++ b/src
virDomainGraphicsDefFormat function was way too long so split it into
separate functions for each graphics type.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 131 ++---
1 file changed, 71 insertions(+), 60 deletions(-)
diff --git a/src/conf
Use separate buffers for attributes and children elements to make the
code cleaner and to use the virXMLFormatElement() function.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 235 -
1 file changed, 92 insertions(+), 143 deletions(-)
diff
nd: Generate cmd line for UEFI shim
> security: Set seclabels on UEFI shim
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
ginally using 6.0.0
> qemuxmlconftest: Add '+amdsev' versions of the rest of
> 'launch-security-sev*' cases
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Wed, Feb 26, 2025 at 12:29:14PM +0100, Peter Krempa wrote:
> On Wed, Feb 26, 2025 at 11:33:52 +0100, Pavel Hrdina wrote:
> > Before this patch the code would start the revert process by destroying
> > the VM and preparing to revert where it would fail with following error:
>
user with offline VM even if it was running.
Make the check before we start the revert process to not destroy VMs.
Resolves: https://issues.redhat.com/browse/RHEL-30971
Resolves: https://issues.redhat.com/browse/RHEL-79928
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 13 +++
Replace Alpine Linux v3.19 with v3.21.
Signed-off-by: Pavel Hrdina
---
ci/buildenv/{alpine-319.sh => alpine-321.sh} | 0
.../{alpine-319.Dockerfile => alpine-321.Dockerfile} | 2 +-
ci/gitlab/builds.yml | 8
ci/
p(30) to wait for VM to boot
but on our hosts it sometimes took a bit longer resulting in
random failures, posted patches to libvirt-tck to fix this issue
- lcitool is not able to prepare Fedora 41 vm as there is no
python3-libdnf5 by default installed and ansible fails with er
On current Fedora libvirt uses nftables by default but the libvirt-tck
tests are not ready for it and most of the nwfilter tests fail. We need
to keep using iptables for now.
Signed-off-by: Pavel Hrdina
---
ci/jobs.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ci/jobs.sh b/ci
Signed-off-by: Pavel Hrdina
---
ci/integration.yml | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/ci/integration.yml b/ci/integration.yml
index ced3fbc3c2..2c5e5a65bc 100644
--- a/ci/integration.yml
+++ b/ci/integration.yml
@@ -29,23 +29,23 @@ centos
r-start' added
>
> Signed-off-by: Peter Krempa
> ---
> .../caps_10.0.0_x86_64.replies| 3631 +
> .../caps_10.0.0_x86_64.xml|2 +-
> 2 files changed, 1836 insertions(+), 1797 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
tor
Fixes: 517248e2394476a3105ff5866b0b718fc6583073
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 78bfaa5b3a..a35abf2747 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qem
ing inactive
> internal snapshot
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Mon, Feb 03, 2025 at 01:26:26PM -0600, Andrea Bolognani wrote:
> On Mon, Feb 03, 2025 at 07:07:36PM +0100, Pavel Hrdina wrote:
> > Fedora and Alpine updated to latest versions.
>
> Technically the latest version of Alpine is 3.21, we just haven't
> updated lcitool to sup
Fedora and Alpine updated to latest versions.
Signed-off-by: Pavel Hrdina
---
ci/buildenv/{alpine-319.sh => alpine-320.sh} | 0
ci/buildenv/debian-11-cross-aarch64.sh| 2 +-
ci/buildenv/debian-11-cross-armv6l.sh | 2 +-
ci/buildenv/debian-11-cross-armv7l.sh |
Fixes: cf32953f5b6ec30386f71b40cf458467752a6dca
Signed-off-by: Pavel Hrdina
---
Pushed
libvirt.spec.in | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index be91fa6bb4..cb41ea1de1 100644
--- a/libvirt.spec.in
+++ b
tlab.com/MichalPrivoznik/libvirt/-/pipelines/1642845347
>
> src/ch/ch_events.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
rc/util/glibcompat.c| 94
> src/util/glibcompat.h| 18
> src/util/vireventglib.c | 12 ++---
> 8 files changed, 10 insertions(+), 126 deletions(-)
s/minimul/minimum/ in subject
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
spec: do not build ch driver on mingw
>
> libvirt.spec.in | 1 +
> meson.build | 11 +--
> 2 files changed, 10 insertions(+), 2 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
lly sized array as used in all the other places
> we have a hextable array.
>
> See also: https://gcc.gnu.org/PR115185
> Reported-by: Yaakov Selkowitz
> Signed-off-by: Daniel P. Berrangé
> ---
> src/util/virsystemd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion
Signed-off-by: Pavel Hrdina
---
NEWS.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 08d1d24d48..98f489dfb0 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -21,6 +21,13 @@ v11.0.0 (unreleased)
* **Bug fixes**
+ * qemu: Fix snapshot to not delete disk image
On Fri, Jan 10, 2025 at 04:10:53PM +0100, Peter Krempa wrote:
> On Fri, Jan 10, 2025 at 15:21:21 +0100, Pavel Hrdina wrote:
> > When we are deleting external snapshot that is not active we only need
> > to delete overlay disk image of the parent snapshot. This works
> > cor
://gitlab.com/libvirt/libvirt/-/issues/734
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index 18b2e478f6..80cd54bf33 100644
--- a/src/qemu/qemu_snapshot.c
1 - 100 of 152 matches
Mail list logo
