From: Kirill Shchetiniuk
Refactored the qemuDomainObjPrivateXMLParseVcpu function to use the
appropriate virXMLPropUInt function to parse unsigned integers,
avoiding unccessery string parsing operations.
Signed-off-by: Kirill Shchetiniuk
---
src/qemu/qemu_domain.c | 16 +++-
1 file
From: Kirill Shchetiniuk
Refactored the default case port option parsing logic to use the
appropriate virXMLPropInt function.
Signed-off-by: Kirill Shchetiniuk
---
src/conf/domain_conf.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/src/conf/domain_conf.
From: Kirill Shchetiniuk
Refactored the virSecretLookupParseSecret fucntion to use the
virXMLPropUUID fucntion, avoid getting the string and parsing it
later. Previously two separate error states merged into one by using
boolean NXOR operation.
Signed-off-by: Kirill Shchetiniuk
---
src/util/vi
From: Kirill Shchetiniuk
Refactored the virNetDevVPortProfileParse function to use the appropriate
virXMLProp* functions to parse input configuration XML.
Signed-off-by: Kirill Shchetiniuk
---
src/conf/netdev_vport_profile_conf.c | 112 +++
1 file changed, 44 insertions
This patch series is supposed to refactor the existing logic of
some parsing functions, changing the previous approach of getting
the string fisrt and then parsing the string itself. Now the
parsing logic is implemented by using the appropriate virXMLProp*
functions.
Changelog fromm v1:
1. 'ret'
> 14. 7. 2025 v 19:22, Ján Tomko :
>
> On a Monday in 2025, Kirill Shchetiniuk via Devel wrote:
>> From: Kirill Shchetiniuk
>>
>> Refactored the virNetDevVPortProfileParse function to use the appropriate
>> virXMLProp* functions to parse input configuration
> 14. 7. 2025 v 19:09, Ján Tomko :
>
> On a Monday in 2025, Kirill Shchetiniuk via Devel wrote:
>> From: Kirill Shchetiniuk
>>
>> Refactored the qemuDomainObjPrivateXMLParseVcpu function to use the
>> appropriate virXMLPropUInt function to parse unsigned
From: Kirill Shchetiniuk
Refactored the default case port option parsing logic to use the
appropriate virXMLPropInt function.
Signed-off-by: Kirill Shchetiniuk
---
src/conf/domain_conf.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/src/conf/domain_conf.c
From: Kirill Shchetiniuk
Refactored the qemuDomainObjPrivateXMLParseVcpu function to use the
appropriate virXMLPropUInt function to parse unsigned integers,
avoiding unccessery string parsing operations.
Signed-off-by: Kirill Shchetiniuk
---
src/qemu/qemu_domain.c | 16 +++-
1 file
From: Kirill Shchetiniuk
Refactored the virSecretLookupParseSecret fucntion to use the
virXMLPropUUID fucntion, avoid getting the string and parsing it
later. Previously two separate error states merged into one by using
boolean NXOR operation.
Signed-off-by: Kirill Shchetiniuk
---
src/util/vi
From: Kirill Shchetiniuk
Refactored the virDomainHostdevSubsysMediatedDevDefParseXML function
to use virXMLPropUUID fuction instead of getting a string and parsing
it later.
Due to parsing function change the missing uuid error reporter and
message were changed and changed error message was also
From: Kirill Shchetiniuk
Refactored the virNetDevVPortProfileParse function to use the appropriate
virXMLProp* functions to parse input configuration XML.
Signed-off-by: Kirill Shchetiniuk
---
src/conf/netdev_vport_profile_conf.c | 120 +++
1 file changed, 48 insertions
This patch series is supposed to refactor the existing logic of
some parsing functions, changing the previous approach of getting
the string fisrt and then parsing the string itself. Now the
parsing logic is implemented by using the appropriate virXMLProp*
functions.
In some places the error repor
On Tue, Jun 03, 2025 at 03:53:53PM +0200, Ján Tomko wrote:
> On a Monday in 2025, Kirill Shchetiniuk via Devel wrote:
> > This series is supposed to refactor the existing parse logic by
> > using the proper utility function and some parameters type change.
> >
> >
From: Kirill Shchetiniuk
Previously, the VNC graphics definition parsing were implemented by
string parsing, the virDomainGraphicsDefParseXMLVNC was refactored
to use the appropriate virXMLProp* utility functions. Overall
parsing logic was not changed and results the same output as before.
Signe
From: Kirill Shchetiniuk
Previously, the 'desktop' graphics configuration contained the
'fullscreen' option which was never used, removed the unused option.
Signed-off-by: Kirill Shchetiniuk
---
docs/formatdomain.rst | 5 ++---
src/conf/domain_conf.c| 17 ++
From: Kirill Shchetiniuk
Previously, the RDP graphics definition parsing were implemented by
string parsing, the virDomainGraphicsDefParseXMLRDP function is
refactored to use the appropriate virXMLProp* utility functions.
Overall parsing logic was not changed and results the same output as
before
From: Kirill Shchetiniuk
Previously, the fullscreen option were parsed as a tristate but stored
as a bool type, changed the fullscreen option type to tristate bool to
avoid unnecessary type convertions.
Signed-off-by: Kirill Shchetiniuk
---
src/conf/domain_conf.c | 9 -
src/conf/domai
This series refactors the existing parse logic by using the proper utility
functions, it also contains some parameters type changes to void
unnecessary type convertions.
1. 'VNC' graphics pasing were refactored to use the vitXMLProp* utility
functions.
'autoport' and 'websocketGenerated' remain t
From: Kirill Shchetiniuk
Previously, the fullscreen option were parsed as a tristate but stored
as a bool type, changed the fullscreen option type to tristate bool to
avoid unnecessary type convertions.
Signed-off-by: Kirill Shchetiniuk
---
src/conf/domain_conf.c | 9 -
src/conf/domai
From: Kirill Shchetiniuk
Previously, the RDP graphics definition parsing were implemented by
string parsing, the virDomainGraphicsDefParseXMLRDP function was
refactored to use the appropriate virXMLProp* utility functions.
Overall parsing logic was not changed and results the same output as befor
From: Kirill Shchetiniuk
Previously, the 'desktop' graphics configuration contained the
'fullscreen' option which was never used, removed the unused option.
Signed-off-by: Kirill Shchetiniuk
---
docs/formatdomain.rst | 5 ++---
src/conf/domain_conf.c| 17 ++
From: Kirill Shchetiniuk
Previously, the VNC graphics definition parsing were implemented by
string parsing, the virDomainGraphicsDefParseXMLVNC function was refactored
to use the appropriate virXMLProp* utility functions. Overall parsing logic
was not changed and results the same output as befor
This series is supposed to refactor the existing parse logic by
using the proper utility function and some parameters type change.
1. VNC graphics pasing were refactored to use the vitXMLProp* utility functions.
'autoport' and 'websocketGenerated' remain their bool type, as this structure
members
From: Kirill Shchetiniuk
Previously, path types were defined separately for files and
directories. The `absDirPath` type, in particular, did not accept
Windows-style paths. Now, absolute paths for files and directories are
united under the 'absolutePath' type.
Relative paths were in fact the sam
From: Kirill Shchetiniuk
Previously, in some places where path attributes were defined, the
'' type was used instead of one of the provided types for
paths. Now, the '' type has been replaced with the
'relativePath' type to maintain consistency and ensure backward
compatibility.
Signed-off-by: K
Hello everyone,
Sometime ago I sent a patch changing the XML schema to add GTK support for
libvirt. As the type for one path argument, I used the type, simply
copying the similar approach from another place in the XML schema definition. I
was told that it's not the best way to use the type fo
On Mon, Apr 28, 2025 at 02:40:49PM +0200, Peter Krempa wrote:
> On Mon, Apr 28, 2025 at 12:22:22 +0200, Kirill Shchetiniuk via Devel wrote:
> > From: Kirill Shchetiniuk
> >
> > Introduce GTK display support with OpenGL for the QEMU driver.
> >
> > - Add new
On Mon, Apr 28, 2025 at 12:33:19PM +0200, Peter Krempa wrote:
> On Mon, Apr 28, 2025 at 12:22:22 +0200, Kirill Shchetiniuk via Devel wrote:
> > From: Kirill Shchetiniuk
> >
> > Introduce GTK display support with OpenGL for the QEMU driver.
> >
> > - Add new
From: Kirill Shchetiniuk
Introduce GTK display support with OpenGL for the QEMU driver.
- Add new XML options for GTK display type.
- Include capability flags for the QEMU driver.
Note: The `QEMU_CAPS_GTK_GL` flag cannot yet be checked, so device
definition validation is incomplete. A placeho
n function do not validate anything. What do you think?
On Mon, Apr 7, 2025 at 3:11 PM Peter Krempa wrote:
> On Mon, Apr 07, 2025 at 14:49:14 +0200, Peter Krempa via Devel wrote:
> > On Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel
> wrote:
> > > When th
When new volume was created using 'vol-create' and '--validate' option
an error occured due to invalid flags passed downward.
Resolves:
https://lists.libvirt.org/archives/list/us...@lists.libvirt.org/thread/7WQ2IRSPWKKV5S3N3YJTFOMAJTZJFN7H/
Kirill Shchetiniuk (2):
storage: virStorageVolDefPar
Signed-off-by: Kirill Shchetiniuk
---
NEWS.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index e2dc4e508b..dd345bad7b 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -28,6 +28,11 @@ v11.3.0 (unreleased)
* **Bug fixes**
+ * storage: Fix new volume creation
+
+N
When the new storage was created using virsh with --validate option
following errors occurred:
# virsh vol-create default --file vol-def.xml --validate
error: Failed to create vol from vol-def.xml
error: unsupported flags (0x4) in function virStorageVolDefParseXML
and after virStorageVolDefParse
Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel
> > >> wrote:
>
> [...]
>
> > >> Either way this hunk is incorrect as this flag should not get here and
> > >> the caller needs to be fixed.
> > >
> > > If in fact
When the new storage was created using virsh with --validate option
following errors occurred:
# virsh vol-create default --file vol-def.xml --validate
error: Failed to create vol from vol-def.xml
error: unsupported flags (0x4) in function virStorageVolDefParseXML
and after virStorageVolDefParse
When domain was started its transient definition was not saved on
disk, this led to the situation when CH driver dies and starts again,
all transient definitions of currently running domains had been
lost.
Newly all transient definitions of running domains are saved on disk
and can be loaded durin
This patch series is supposed to fix the following reported issue on GitLab:
virtchd times out even with an active guest running
https://gitlab.com/libvirt/libvirt/-/issues/743
During further investigation, we found that there are in fact two bugs:
1. The CH driver does not store any domains' XM
Thanks Jan,
Didn’t noticed the issue with the white symbols when submitted a patch, next
time will keep it in mind and be careful. Btw, do we have some tools to check
and warn such possible issues?
Kirill
> 2. 4. 2025 v 18:36, Ján Tomko :
>
> On a Tuesday in 2025, Kirill Shchet
Previously, the CH driver would timeout even if one or more domains
were still running, only an active virsh session prevented the
driver's timeout.
To address this, an inhibitor has been added to ensure driver remains
active as long as any domain is still running. Inhibitor is now held
when a dom
Previously, if any domain was still running, the driver was unable to
reconnect to it, preventing further interactions with running domain.
To resolve this, the driver now attempts to reconnect to the domains'
monitors, which transient definitions are stored in state dir,
during the initialization
When the domain was defined, its persistent domain definition wasn't
saved on disk, leading to the loss of all defined domains after a CH
driver restart.
Now all defined persistent domains are saved on disk and loaded
from disk during CH driver initialization. Saved domains now also can
be removed
When the new CH monitor was started, it ran as a non-daemonized
process and was a child of the CH driver process. This led to a
situation where if the CH driver died, the monitor process were
killed too, terminating the running VM under the monitor. This
led to termination of all VM started under t
When the domain shutdown was executed from virsh, only the VM
process (a child of the CH monitor) was terminated. Since we assume
only one VM per monitor, the monitor process should also be
terminated.
Modified the VM shutdown event handler to match the VMM shutdown
behavior, ensuring the VM monit
When the domain was rebooted, some of its properties were changed but
not updated in the transient domain definition. This led to the
inability to connect to the serial console as its path had changed
during the reboot but was not updated in the domain definition.
Added VIR_CH_EVENT_VM_REBOOTED ev
1. Run CH monitor as a daemon
Made the monitor process daemonized to prevent VM termination if
the CH driver crashes. Added pidfile for daemon's pid aquiring and tracking
as well as its init.
2. Update domain info after reboot
Fixed an issue where domain properties (e.g., serial console path)
were
46 matches
Mail list logo
