Re: [PATCH] NEWS: Document features/improvements/bug fixes I've participated in

2025-07-30 Thread Jiri Denemark via Devel
far, there is no special > +meaning to its value. > + > * **Bug fixes** Reviewed-by: Jiri Denemark

libvirt-11.6.0 release candidate 2

2025-07-30 Thread Jiri Denemark via Devel
I have just tagged v11.6.0-rc2 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH] include: fix version for VIR_CONNECT_BASELINE_CPU_IGNORE_HOST

2025-07-28 Thread Jiri Denemark via Devel
2), > } virConnectBaselineCPUFlags; Oops, thanks for fixing this. Reviewed-by: Jiri Denemark

Entering freeze for libvirt-11.6.0

2025-07-28 Thread Jiri Denemark via Devel
I have just tagged v11.6.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH v5 0/5] Disable Deprecated Features by Default on s390 CPU Models

2025-07-25 Thread Jiri Denemark via Devel
On Thu, Jul 24, 2025 at 14:39:02 -0400, Collin Walling wrote: > On 7/24/25 03:35, Thomas Huth via Devel wrote: > > On 30/06/2025 05.19, Collin Walling wrote: > >> Changelog > >> > >> v5 > >> - dropped the "none" test in qemuxmlactivetest (see commit for > >> details) > >> -

Re: [PATCH] NEWS: mention disabling deprecated features by default on s390 CPU models

2025-07-25 Thread Jiri Denemark via Devel
pu_deprecated_features`` option in > +the qemu.conf file. > + > * **Improvements** > >* qemu: Change default SCSI controller model to ``virtio-scsi`` for ARM > and RISC-V > -- > 2.49.0 > Reviewed-by: Jiri Denemark

Plans for 11.6.0 release (freeze on 2025-07-28)

2025-07-18 Thread Jiri Denemark via Devel
We are getting close to 11.6.0 release of libvirt. To aim for the release on Friday 01 Aug I suggest entering the freeze on Monday 28 Jul and tagging RC2 on Wednesday 30 Jul. I hope this works for everyone. Jirka

[PATCH 7/6] NEWS: Mention virConnectHypervisorBaselineCPU improvements

2025-07-04 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- NEWS.rst | 12 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index d8bd2559f4..4fd12d94f4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,8 +17,20 @@ v11.6.0 (unreleased) * **New features** + * Introduce

[PATCH 6/6] virsh: Add support for VIR_CONNECT_BASELINE_CPU_IGNORE_HOST flag

2025-07-04 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- docs/manpages/virsh.rst | 11 --- tools/virsh-host.c | 8 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 7082ca773a..bcb5495ed9 100644 --- a/docs

[PATCH 5/6] qemu: Implement VIR_CONNECT_BASELINE_CPU_IGNORE_HOST

2025-07-04 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- src/qemu/qemu_driver.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2c06e50454..cf7407ce2d 100644 --- a/src/qemu/qemu_driver.c +++ b

[PATCH 4/6] Introduce VIR_CONNECT_BASELINE_CPU_IGNORE_HOST flag

2025-07-04 Thread Jiri Denemark via Devel
From: Jiri Denemark With this new flag virConnectHypervisorBaselineCPU can be used on any host (rather than being limited to hosts described by individual CPUs passed to the API). Using the flag makes the API behave similarly to the old virConnectBaselineCPU. The main difference is the CPU

[PATCH 3/6] Change documentation style of virConnectBaselineCPUFlags

2025-07-04 Thread Jiri Denemark via Devel
From: Jiri Denemark Moving the documentation above each enum item gives us more space for it. Signed-off-by: Jiri Denemark --- include/libvirt/libvirt-host.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt

[PATCH 2/6] Clarify documentation of virConnectBaselineHypervisorCPU

2025-07-04 Thread Jiri Denemark via Devel
From: Jiri Denemark The API was apparently never considered for being used on a host that is not represented in the input set of CPU definitions. The result is limited to the set of features and CPU models known to the host's hypervisor. This would likely not be a big issue, but thanks to a

[PATCH 1/6] cpu: Show input CPU model names in debug log

2025-07-04 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- src/cpu/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index 77afb7e9b3..233686485d 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -581,7 +581,7 @@ virCPUBaseline(virArch arch

[PATCH 0/6] Make virConnectBaselineHypervisorCPU a bit more sane

2025-07-04 Thread Jiri Denemark via Devel
See 2/6 for description of the issue this series is trying to deal with. Jiri Denemark (6): cpu: Show input CPU model names in debug log Clarify documentation of virConnectBaselineHypervisorCPU Change documentation style of virConnectBaselineCPUFlags Introduce

Release of libvirt-11.5.0

2025-07-01 Thread Jiri Denemark via Devel
The 11.5.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is

Re: [PATCH v2 18/24] qapi/migration: Deprecate capabilities commands

2025-07-01 Thread Jiri Denemark via Devel
On Mon, Jun 30, 2025 at 16:59:07 -0300, Fabiano Rosas wrote: > The concept of capabilities is being merged into the concept of > parameters. From now on, the commands that handle capabilities are > deprecated in favor of the commands that handle parameters. > > Affected commands: > > - migrate-se

[PATCH] NEWS: Mention shared filesystem detection fix

2025-06-30 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index ee4e9a022e..089224cbe3 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -66,6 +66,12 @@ v11.5.0 (unreleased) domain XML acquires QUERY job. But this

Re: [PATCH] NEWS: Document features/improvements/bug fixes I've participated in

2025-06-30 Thread Jiri Denemark via Devel
forgiving when acquiring QUERY job when formatting domain > XML > + > +Since ``libvirt-11.0.0`` the ``virDomainGetXMLDesc()`` API used to format > +domain XML acquires QUERY job. But this caused a regression when the API > + might timeout for incoming migration. This is now fixed. > + Reviewed-by: Jiri Denemark

Re: [PATCH v2 10/13] qemuBuildDeviceAddresDriveProps: Prepare for 'drive' address for usb-bot disks

2025-06-25 Thread Jiri Denemark via Devel
"u:lun", info->addr.drive.unit, > + NULL) < 0) > +return -1; > +break; The code is indented one level more than it should be. > + > +case VIR_DOMAIN_DISK_BUS_VIRTIO: > case VIR_DOMAIN_DISK_BUS_XEN: > case VIR_DOMAIN_DISK_BUS_UML: > case VIR_DOMAIN_DISK_BUS_SD: Reviewed-by: Jiri Denemark

Re: [PATCH v2 12/13] qemuxmlconftest: Prepare for proper testing in 'disk-cdrom-usb-empty'

2025-06-24 Thread Jiri Denemark via Devel
d, 74 insertions(+), 1 deletion(-) > create mode 100644 > tests/qemuxmlconfdata/disk-cdrom-usb-empty.x86_64-latest.abi-update.args > create mode 100644 > tests/qemuxmlconfdata/disk-cdrom-usb-empty.x86_64-latest.abi-update.xml Reviewed-by: Jiri Denemark

Entering freeze for libvirt-11.5.0

2025-06-24 Thread Jiri Denemark via Devel
I have just tagged v11.5.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH v2 13/13] qemu: Replace usb-storage with usb-bot

2025-06-24 Thread Jiri Denemark via Devel
+break; > + > +case VIR_DOMAIN_DISK_MODEL_VIRTIO_TRANSITIONAL: > +case VIR_DOMAIN_DISK_MODEL_VIRTIO: > +case VIR_DOMAIN_DISK_MODEL_VIRTIO_NON_TRANSITIONAL: > +case VIR_DOMAIN_DISK_MODEL_LAST: > virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", > - _("'usb' disk must not be empty")); > + _("USB disk supports only models: 'usb-storage', > 'usb-bot''")); s/''/'/ And the error message looks weird to me, how about s/models/the following models/ ? > return -1; > } > ... Reviewed-by: Jiri Denemark

Re: [PATCH v2 11/13] qemu: monitor: Introduce 'qemuMonitorSetUSBDiskAttached'

2025-06-24 Thread Jiri Denemark via Devel
--- > src/qemu/qemu_monitor.c | 12 > src/qemu/qemu_monitor.h | 3 +++ > src/qemu/qemu_monitor_json.c | 20 > src/qemu/qemu_monitor_json.h | 5 + > 4 files changed, 40 insertions(+) Reviewed-by: Jiri Denemark

Re: [PATCH v2 07/13] qemuxmlconftest: Invoke "disk-usb-device" case also without QEMU_CAPS_DEVICE_USB_BOT and with ABI_UPDATE

2025-06-24 Thread Jiri Denemark via Devel
a/disk-usb-device.x86_64-latest.abi-update.QEMU_CAPS_DEVICE_USB_BOT-disabled.args > create mode 100644 > tests/qemuxmlconfdata/disk-usb-device.x86_64-latest.abi-update.QEMU_CAPS_DEVICE_USB_BOT-disabled.xml > create mode 100644 > tests/qemuxmlconfdata/disk-usb-device.x86_64-latest.ab

Re: [PATCH v2 06/13] qemu_capabilities: Introduce QEMU_CAPS_DEVICE_USB_BOT

2025-06-24 Thread Jiri Denemark via Devel
| 1 + > tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml | 1 + > tests/qemucapabilitiesdata/caps_9.2.0_x86_64+amdsev.xml | 1 + > tests/qemucapabilitiesdata/caps_9.2.0_x86_64.xml | 1 + > 32 files changed, 37 insertions(+) Reviewed-by: Jiri Denemark

Re: [PATCH v2 05/13] qemuxmlconftest: Distribute testing of 'removable' disk property

2025-06-24 Thread Jiri Denemark via Devel
changed, 2 insertions(+), 129 deletions(-) > delete mode 100644 > tests/qemuxmlconfdata/disk-device-removable.x86_64-latest.args > delete mode 100644 > tests/qemuxmlconfdata/disk-device-removable.x86_64-latest.xml > delete mode 100644 tests/qemuxmlconfdata/disk-device-removable.xml Reviewed-by: Jiri Denemark

Re: [PATCH v2 04/13] qemuxmlconftest: Drop 'disk-cdrom-bus-other'

2025-06-24 Thread Jiri Denemark via Devel
delete mode 100644 > tests/qemuxmlconfdata/disk-cdrom-bus-other.x86_64-latest.args > delete mode 100644 > tests/qemuxmlconfdata/disk-cdrom-bus-other.x86_64-latest.xml > delete mode 100644 tests/qemuxmlconfdata/disk-cdrom-bus-other.xml Reviewed-by: Jiri Denemark

Re: [PATCH v2 03/13] qemusecuritytest: Use 'disk-usb-device' case instead of 'disk-cdrom-bus-other'

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:08 +0200, Peter Krempa wrote: > From: Peter Krempa > > Signed-off-by: Peter Krempa > --- > tests/qemusecuritytest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Jiri Denemark

Re: [PATCH v2 02/13] qemuxmlconftest: Test various combinations of config

2025-06-24 Thread Jiri Denemark via Devel
--- > tests/qemuxmlconfdata/disk-usb-device.xml | 66 +-- > 3 files changed, 158 insertions(+), 18 deletions(-) Reviewed-by: Jiri Denemark

Re: [PATCH v2 01/13] qemuhotplugtest: Use VIR_DOMAIN_DEF_PARSE_ABI_UPDATE for virDomainDeviceDefParse

2025-06-24 Thread Jiri Denemark via Devel
+-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Jiri Denemark

Re: [PATCH v2 09/13] qemu: Fill in model of 'usb' disks to preserve ABI compatibility

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:14 +0200, Peter Krempa wrote: > From: Peter Krempa > > While 'usb-bot' and 'usb-storage' are ABI and migration compatible for > disks it's not the case for cdroms. When migrating from a new config > using 'usb-bot' to an older daemon which would use 'usb-storage' the

Re: [PATCH v2 08/13] conf: introduce usb disk models 'usb-storage' and 'usb-bot'

2025-06-24 Thread Jiri Denemark via Devel
On Mon, Jun 23, 2025 at 21:59:13 +0200, Peter Krempa wrote: > From: Peter Krempa > > Historically libvirt specified 'usb-storage' as driver for USB disks. > This though combined with '-blockdev' doesn't properly configure the > device to look like CDROM for . > > 'usb-bot' acts like a controler

Re: [PATCH 0/1] cpu_map: fix vmx-* features wrong bitmaps

2025-06-18 Thread Jiri Denemark via Devel
On Mon, Jun 16, 2025 at 01:46:59 +0200, Hector Cao wrote: > Hello, > > A friendly ping, > > To fix this issue, I would like to propose this solution. > Here is the draft patch, I can submit a proper one in a separate mail if we > can reach an agreement > on this solution. > > Thanks ! > > diff

Plans for 11.5.0 release (freeze on 2025-06-24)

2025-06-18 Thread Jiri Denemark via Devel
We are getting close to 11.5.0 release of libvirt. To aim for the release on Tuesday 01 Jul I suggest entering the freeze on Tuesday 24 Jun and tagging RC2 on Friday 27 Jun. I hope this works for everyone. Jirka

[PATCH 2/2] util: Move virFileGetExistingParent out of ifdef __linux__

2025-06-03 Thread Jiri Denemark via Devel
From: Jiri Denemark The function is called by virFileIsSharedFSOverride which is not Linux specific and thus building on anything but Linux failes. Fixes: 94fb348d670f612c0b58901c9829b4eec81faa50 Signed-off-by: Jiri Denemark --- src/util/virfile.c | 55

[PATCH 1/2] util: Avoid statfs in virFileGetExistingParent

2025-06-03 Thread Jiri Denemark via Devel
From: Jiri Denemark The code was separated from virFileIsSharedFSType which is Linux-only, but virFileGetExistingParent is also called from virFileIsSharedFSOverride which is OS independent. Thus we can't use statfs. Let's use virFileExists (access) instead, we were not interested i

[PATCH 0/2] Fix build on non-Linux

2025-06-03 Thread Jiri Denemark via Devel
Jiri Denemark (2): util: Avoid statfs in virFileGetExistingParent util: Move virFileGetExistingParent out of ifdef __linux__ src/util/virfile.c | 56 ++--- tests/virfilemock.c | 28 +++ 2 files changed, 56 insertions(+), 28

Release of libvirt-11.4.0

2025-06-02 Thread Jiri Denemark via Devel
The 11.4.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is

Re: [PATCH] cpu_map: Add more -noTSX x86 CPU models (Sapphire and Granite rapids)

2025-06-02 Thread Jiri Denemark via Devel
On Mon, Jun 02, 2025 at 01:19:29 +0200, Hector Cao wrote: > Several Intel CPU models with TSX technology (HLE & RTM features) are > affected by the vulnerability TAA[1]. One of the mitigation methods > for TAA is to disable TSX support on the host system. For that purpose, > in 2021, Intel publishe

Re: [PATCH v2] NEWS: Mention removal of compile time helper program lookup, virito-net ABI check and FDC capabilities

2025-05-30 Thread Jiri Denemark via Devel
/sbin to > /bin but only on new installs > > NEWS.rst | 31 +++ > 1 file changed, 31 insertions(+) Reviewed-by: Jiri Denemark

Re: [PATCH v4 00/27] hw/i386/pc: Remove deprecated 2.6 and 2.7 PC machines

2025-05-30 Thread Jiri Denemark via Devel
On Fri, May 30, 2025 at 14:08:25 +0200, Peter Krempa wrote: > The rest are CPU properties > > DEFINE_PROP_BOOL("cpuid-0xb", X86CPU, enable_cpuid_0xb, true), > DEFINE_PROP_BOOL("fill-mtrr-mask", X86CPU, fill_mtrr_mask, true), > DEFINE_PROP_BOOL("full-cpuid-auto-level", X86CPU, full_cpuid_auto_le

libvirt-11.4.0 release candidate 2

2025-05-30 Thread Jiri Denemark via Devel
I have just tagged v11.4.0-rc2 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH] virConnectAuthCallbackDefault: Return failure if 'virGetPassword' returns NULL

2025-05-29 Thread Jiri Denemark via Devel
s NULL. > > Fixes: db72866310d1e520efa8ed2d4589bdb5e76a1c95 > Closes: https://gitlab.com/libvirt/libvirt/-/issues/777 > Signed-off-by: Peter Krempa > --- > src/libvirt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Jiri Denemark

[PATCH 3/3] util: Fix virFileIsSharedFSOverride on nonexistent paths

2025-05-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Commit v11.0.0-162-gf2023e8018 added path canonicalization to virFileIsSharedFSOverride to make sure we can properly match shared filesystem override paths which include symlinks. But virFileCanonicalizePath only works on existing paths, while virFileIsSharedFSOverride may be

[PATCH 2/3] util: Introduce virFileGetExistingParent helper

2025-05-29 Thread Jiri Denemark via Devel
From: Jiri Denemark The code from virFileIsSharedFSType which finds the longest existing path for a given input is separated into a new helper so that it can be reused elsewhere. Signed-off-by: Jiri Denemark --- Notes: If you wonder why the code is almost the same as the original one, but

[PATCH 1/3] util: Document limitation of virFileCanonicalizePath

2025-05-29 Thread Jiri Denemark via Devel
From: Jiri Denemark On most platforms virFileCanonicalizePath is implemented using realpath(), which only works on existing paths. Signed-off-by: Jiri Denemark --- src/util/virfile.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c

[PATCH 0/3] util: Fix virFileIsSharedFSOverride on nonexistent paths

2025-05-29 Thread Jiri Denemark via Devel
Jiri Denemark (3): util: Document limitation of virFileCanonicalizePath util: Introduce virFileGetExistingParent helper util: Fix virFileIsSharedFSOverride on nonexistent paths src/util/virfile.c | 76 +++--- 1 file changed, 45 insertions(+), 31

[PATCH] qemu: Fix error when migration with shared TPM storage is unsupported

2025-05-28 Thread Jiri Denemark via Devel
From: Jiri Denemark The VIR_ERR_NO_SUPPORT error is supposed to be used for unsupported driver APIs. It is incorrectly used when swtpm does not support migration with shared storage resulting in a rather strange error message: this function is not supported by the connection driver: the

[PATCH] NEWS: Make sure releases are separated by two blank lines

2025-05-27 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index a880524ca2..0ba2d20191 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -533,6 +533,7 @@ v10.9.0 (2024-11-01) element is added for that CPU model

[PATCH 2/2] NEWS: Fix virtqemud crash when resuming failed post-copy migration

2025-05-27 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 636fcbd573..a880524ca2 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -42,6 +42,13 @@ v11.4.0 (unreleased) The only workaround is to avoid the

[PATCH 1/2] qemu: Fix crash when resuming failed post-copy migration

2025-05-27 Thread Jiri Denemark via Devel
From: Jiri Denemark Since commit 28a06215280 (released in 11.2.0) resuming a failed post-copy migration calls qemuProcessIncomingDefNew with fd == NULL rather than -1. The function does not expect to be called with NULL file descriptor and tries to dereference it causing virtqemud on the

[PATCH 0/2] qemu: Fix crash when resuming failed post-copy migration

2025-05-27 Thread Jiri Denemark via Devel
Jiri Denemark (2): qemu: Fix crash when resuming failed post-copy migration NEWS: Fix virtqemud crash when resuming failed post-copy migration NEWS.rst | 7 +++ src/qemu/qemu_migration.c | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) -- 2.49.0

Entering freeze for libvirt-11.4.0

2025-05-27 Thread Jiri Denemark via Devel
I have just tagged v11.4.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH 0/7] nss: Couple of fixes and small improvements

2025-05-22 Thread Jiri Denemark via Devel
.c| 52 +- > tools/nss/libvirt_nss.h| 33 +++-- > tools/nss/libvirt_nss_leases.c | 3 ++ > tools/nss/libvirt_nss_macs.c | 2 +- > 5 files changed, 55 insertions(+), 37 deletions(-) Reviewed-by: Jiri Denemark

[PATCH] virsh: Do not print warnings with "error:" prefix

2025-05-22 Thread Jiri Denemark via Devel
From: Jiri Denemark Both vshWarn and vshError are just wrappers around vshPrintStderr which properly propagates the message level to the log, but fails to honor it when printing on stderr. https://issues.redhat.com/browse/RHEL-79460 Signed-off-by: Jiri Denemark --- tools/vsh.c | 6 +- 1

Re: [PATCH] cputest: Skip more tests requiring JSON_MODELS if QEMU is disabled

2025-05-20 Thread Jiri Denemark via Devel
ek > --- > tests/cputest.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Jiri Denemark

Plans for 11.4.0 release (freeze on 2025-05-27)

2025-05-19 Thread Jiri Denemark via Devel
We are getting close to 11.4.0 release of libvirt. To aim for the release on Monday 02 Jun I suggest entering the freeze on Tuesday 27 May and tagging RC2 on Friday 30 May. I hope this works for everyone. Jirka

Re: [PATCH v2] qemu: fix qemuMigrationCapability enum

2025-05-07 Thread Jiri Denemark via Devel
On Wed, May 07, 2025 at 10:07:41 +0300, Dmitry Frolov wrote: > Enum variable of type qemuMigrationCapability is checked for zero in > src/qemu/qemu_migration_params.c:729. > > "if (item->optional) { ..." > > Actualy, QEMU_MIGRATION_CAP_XBZRLE enum constant has value 0. > So, at least, the conditi

Re: [PATCH] qemu: fix qemuMigrationCapability enum

2025-05-06 Thread Jiri Denemark via Devel
On Tue, May 06, 2025 at 17:08:18 +0300, Dmitry Frolov wrote: > Enum variable of type qemuMigrationCapability is checked for zero in > src/qemu/qemu_migration_params.c:729. > > "if (item->optional) { ..." > > Actualy, QEMU_MIGRATION_CAP_XBZRLE enum constant has value 0. > Thus, all uninitialized .

Re: [PATCH] virnetdevtap: Fix memory leak in virNetDevTapReattachBridge

2025-05-06 Thread Jiri Denemark via Devel
On Tue, May 06, 2025 at 10:47:34 +0800, liu.son...@zte.com.cn wrote: > From: QiangWei Zhang > > Variable 'master' needs to be free because it will be reassigned in > virNetDevOpenvswitchInterfaceGetMaster(). > > The leaked stack: > Direct leak of 11 byte(s) in 1 object(s) allocated from: > #0 0x

Release of libvirt-11.3.0

2025-05-02 Thread Jiri Denemark via Devel
The 11.3.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is

libvirt-11.3.0 release candidate 2

2025-04-30 Thread Jiri Denemark via Devel
I have just tagged v11.3.0-rc2 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

[PATCH 15/15] cpu_x86: Fix algorithm for computing CPU model weight

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark This patch is effectively a NOP, but it fixes a logic bug and makes the heuristics more visible and easier to change should there be a need to do so in the future. We decide which CPU model is the best match for given CPU data by comparing lists of features that need to be

[PATCH 13/15] cputest: Add data for a newer version of Intel Atom(R) P5362 CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Atom-P5362-2-disabled.xml|9 + .../x86_64-cpuid-Atom-P5362-2-enabled.xml | 19 + .../x86_64-cpuid-Atom-P5362-2-guest.xml | 43 + .../x86_64-cpuid

[PATCH 14/15] cpu_x86: Refactor virCPUx86CompareCandidateFeatureList

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Refactor weight calculation to a separate virCPUx86WeightFeatures function to avoid code duplication. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 83 ++- 1 file changed, 46 insertions(+), 37 deletions(-) diff --git a

[PATCH 12/15] cputest: Add data for Intel(R) Xeon(R) w7-3465X CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Xeon-w7-3465X-disabled.xml | 10 + .../x86_64-cpuid-Xeon-w7-3465X-enabled.xml| 20 + .../x86_64-cpuid-Xeon-w7-3465X-guest.xml | 55 + .../x86_64-cpuid

[PATCH 11/15] cputest: Add data for Intel(R) Xeon(R) Gold 6530 CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Xeon-Gold-6530-disabled.xml | 10 + .../x86_64-cpuid-Xeon-Gold-6530-enabled.xml | 20 + .../x86_64-cpuid-Xeon-Gold-6530-guest.xml | 58 + .../x86_64-cpuid

[PATCH 10/15] cputest: Add data for Intel(R) Xeon(R) Bronze 3408U CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + ...86_64-cpuid-Xeon-Bronze-3408U-disabled.xml |9 + ...x86_64-cpuid-Xeon-Bronze-3408U-enabled.xml | 21 + .../x86_64-cpuid-Xeon-Bronze-3408U-guest.xml | 59 + .../x86_64-cpuid

[PATCH 08/15] cputest: Add data for AMD EPYC 9334 32-Core CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + ...86_64-cpuid-EPYC-9334-32-Core-disabled.xml |9 + ...x86_64-cpuid-EPYC-9334-32-Core-enabled.xml | 15 + .../x86_64-cpuid-EPYC-9334-32-Core-guest.xml | 42 + .../x86_64-cpuid

[PATCH 09/15] cputest: Add data for Intel(R) Xeon(R) 6731E CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Xeon-6731E-disabled.xml | 11 + .../x86_64-cpuid-Xeon-6731E-enabled.xml | 21 + .../x86_64-cpuid-Xeon-6731E-guest.xml | 128 + .../x86_64-cpuid

[PATCH 07/15] cputest: Add data for Intel(R) Xeon(R) Gold 6152 CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Xeon-Gold-6152-disabled.xml |7 + .../x86_64-cpuid-Xeon-Gold-6152-enabled.xml | 19 + .../x86_64-cpuid-Xeon-Gold-6152-guest.xml | 40 + .../x86_64-cpuid

[PATCH 06/15] cputest: Add data for AMD Ryzen 5 5500U CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + ...-5-5500U-with-Radeon-Graphics-disabled.xml |9 + ...n-5-5500U-with-Radeon-Graphics-enabled.xml | 11 + ...zen-5-5500U-with-Radeon-Graphics-guest.xml | 39 + ...yzen-5-5500U

[PATCH 05/15] cputest: Add data for AMD EPYC 7713 64-Core CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + ...86_64-cpuid-EPYC-7713-64-Core-disabled.xml | 11 + ...x86_64-cpuid-EPYC-7713-64-Core-enabled.xml | 11 + .../x86_64-cpuid-EPYC-7713-64-Core-guest.xml | 44 + .../x86_64-cpuid

[PATCH 04/15] cputest: Add data for Intel(R) Xeon(R) Silver 4214R CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + ...86_64-cpuid-Xeon-Silver-4214R-disabled.xml |7 + ...x86_64-cpuid-Xeon-Silver-4214R-enabled.xml | 19 + .../x86_64-cpuid-Xeon-Silver-4214R-guest.xml | 46 + .../x86_64-cpuid

[PATCH 03/15] cputest: Add data for Intel(R) Xeon(R) CPU E3-1270 v5 CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Xeon-E3-1270-v5-disabled.xml |6 + .../x86_64-cpuid-Xeon-E3-1270-v5-enabled.xml | 18 + .../x86_64-cpuid-Xeon-E3-1270-v5-guest.xml| 32 + .../x86_64-cpuid

[PATCH 02/15] cputest: Add data for Intel(R) Core(TM) i7-1365U CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Core-i7-1365U-disabled.xml |6 + .../x86_64-cpuid-Core-i7-1365U-enabled.xml| 21 + .../x86_64-cpuid-Core-i7-1365U-guest.xml | 71 + .../x86_64-cpuid

[PATCH 01/15] cputest: Add data for Intel(R) Core(TM) i7-1270P CPU

2025-04-29 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Core-i7-1270P-disabled.xml |8 + .../x86_64-cpuid-Core-i7-1270P-enabled.xml| 21 + .../x86_64-cpuid-Core-i7-1270P-guest.xml | 71 + .../x86_64-cpuid

[PATCH 00/15] cpu_x86: Fix CPU model comparison heuristics

2025-04-29 Thread Jiri Denemark via Devel
Several CPU tests covering recent-ish CPUs are added to cputest to make sure the fix doesn't break anything. Jiri Denemark (15): cputest: Add data for Intel(R) Core(TM) i7-1270P CPU cputest: Add data for Intel(R) Core(TM) i7-1365U CPU cputest: Add data for Intel(R) Xeon(R) CPU E3-12

Entering freeze for libvirt-11.3.0

2025-04-28 Thread Jiri Denemark via Devel
I have just tagged v11.3.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

Re: [PATCH] po/zh_CN.po: Fix some translation issues

2025-04-28 Thread Jiri Denemark via Devel
On Sun, Apr 27, 2025 at 10:44:20 +0800, liu.son...@zte.com.cn wrote: > From: QiangWei Zhang > > Swap the order of the two objects to ensure that the logic of the > two objects translated into Chinese is correct. Hi, we use Fedora Weblate for translations: https://translate.fedoraproject.org/pro

Plans for 11.3.0 release (freeze on Friday 25 Apr)

2025-04-17 Thread Jiri Denemark via Devel
We are getting close to 11.3.0 release of libvirt. To aim for the release on Friday 02 May I suggest entering the freeze on Friday 25 Apr and tagging RC2 on Tuesday 29 Apr. I hope this works for everyone. Jirka

Re: [PATCH 0/3] Fix CI, build, and a typo

2025-04-16 Thread Jiri Denemark via Devel
mu_rdp: Fix a typo existance -> existence > > scripts/apibuild.py| 6 -- > src/nwfilter/nwfilter_gentech_driver.c | 4 ++-- > src/qemu/qemu_rdp.c| 2 +- > tools/virt-qemu-qmp-proxy | 1 - > 4 files changed, 3 insertions

Re: [PATCH] virbitmap: Change return type of virBitmapToData to void

2025-04-16 Thread Jiri Denemark via Devel
il/virhostcpu.c | 4 ++-- > tests/virbitmaptest.c | 3 +-- > tools/virsh-completer-domain.c | 6 ++ > tools/virsh-domain.c | 3 +-- > 9 files changed, 11 insertions(+), 25 deletions(-) Reviewed-by: Jiri Denemark and pushed.

Re: [PATCH 0/2] vsh: Fix one memleak and const correctness

2025-04-14 Thread Jiri Denemark via Devel
changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Jiri Denemark

Re: Management applications and CPU feature flags

2025-04-11 Thread Jiri Denemark via Devel
On Fri, Apr 11, 2025 at 13:43:39 +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > On Fri, Apr 11, 2025 at 12:40:46PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > Considering the bigger picture QMP design, when libvirt is trying to > >> > understand QEMU's

Re: [PATCH 5/5] qemu: make passt+vhostuser reconnect behave identically to passt+user

2025-04-10 Thread Jiri Denemark via Devel
On Thu, Apr 10, 2025 at 02:58:30 -0400, Laine Stump wrote: > When "original passt" support was added, we decided that we always > wanted to reconnect (i.e. restart the passt process) if it was somehow > terminated. Generic vhost-user only turns on reconnect if specified in > the config, but there i

Re: [PATCH 4/5] qemu: put vhost-user code that's special for passt in a helper function

2025-04-10 Thread Jiri Denemark via Devel
s changed, 25 insertions(+), 13 deletions(-) Reviewed-by: Jiri Denemark

[PATCH 2/2] qemu: Properly propagate migration state to TPM cleanup code

2025-04-10 Thread Jiri Denemark via Devel
From: Jiri Denemark When migrating a domain with TPM state on a shared disk, we need to skip TPM cleanup on both ends. So far the code only handled successful migration and skipped the cleanup on the source host. But if the migration failed for some reason, the cleanup would be incorrectly

[PATCH 1/2] qemu: Rename outgoingMigration parameter in various TPM functions

2025-04-10 Thread Jiri Denemark via Devel
From: Jiri Denemark The parameter is used to skip TPM state cleanup on outgoing migration with shared storage. But we also need to skip the cleanup after a failed incoming migration. Let's call the parameter "migration" to reflect its usage on both sides of migration. Sign

[PATCH 0/2] Fix migration with TPM on shared storage

2025-04-10 Thread Jiri Denemark via Devel
Jiri Denemark (2): qemu: Rename outgoingMigration parameter in various TPM functions qemu: Properly propagate migration state to TPM cleanup code src/qemu/qemu_domain.c| 8 src/qemu/qemu_domain.h| 2 +- src/qemu/qemu_driver.c| 7 +-- src/qemu/qemu_extdevice.c | 8

Re: [PATCH 3/5] qemu: respond to NETDEV_VHOST_USER_DISCONNECTED event

2025-04-10 Thread Jiri Denemark via Devel
| 18 ++ > 7 files changed, 64 insertions(+) Reviewed-by: Jiri Denemark

Re: [PATCH 2/5] qemu: make processNetDevStreamDisconnectedEvent() reusable

2025-04-10 Thread Jiri Denemark via Devel
unction into something more generic that takes the name of the > event as an arg (the event name is only used in log messages). > > Signed-off-by: Laine Stump > --- > src/qemu/qemu_driver.c | 37 +++-- > 1 file changed, 23 insertions(+), 14 deletions(-) Reviewed-by: Jiri Denemark

Re: [PATCH 0/2] Silence more DBus errors

2025-04-10 Thread Jiri Denemark via Devel
++- > src/util/virinhibitor.c | 5 - > 2 files changed, 6 insertions(+), 2 deletions(-) Reviewed-by: Jiri Denemark

Re: [PATCH 1/5] qemu: remove nonsensical sanity check in processNetdevStreamDisconnectedEvent()

2025-04-10 Thread Jiri Denemark via Devel
new passt process to replace the one that has just been > terminated, so we don't need to check the QEMU capabilities for > QEMU_CAPS_NETDEV_STREAM_RECONNECT. > > Signed-off-by: Laine Stump > --- > src/qemu/qemu_driver.c | 7 --- > 1 file changed, 7 deletions(-) Reviewed-by: Jiri Denemark

[PATCH 0/3] cpu_map: Install Ampere-1 ARM CPU models

2025-04-05 Thread Jiri Denemark via Devel
BTW, the added test will not actually detect similar issues in the future (I'm thinking about such test, though), but it will help with other issues with the ARM CPU map as it hasn't been covered at all. Jiri Denemark (3): tests: Add a basic CPU test for aarch64 cpu_map: Install Am

[PATCH 3/3] NEWS: Document ARM CPU map bug fix

2025-04-04 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e2dc4e508b..2608086717 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -28,6 +28,12 @@ v11.3.0 (unreleased) * **Bug fixes** + * cpu_map: Install

[PATCH 2/3] cpu_map: Install Ampere-1 ARM CPU models

2025-04-04 Thread Jiri Denemark via Devel
From: Jiri Denemark Fixes: 282f38ad3d3960b24aa97d75cae95c8c3d08a218 Fixes: https://gitlab.com/libvirt/libvirt/-/issues/762 Signed-off-by: Jiri Denemark --- src/cpu_map/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cpu_map/meson.build b/src/cpu_map/meson.build index

[PATCH 1/3] tests: Add a basic CPU test for aarch64

2025-04-04 Thread Jiri Denemark via Devel
From: Jiri Denemark The purpose of this test is to enforce loading and parsing of ARM CPU map so that possible issues are found earlier. Signed-off-by: Jiri Denemark --- tests/cputest.c | 35 + tests/cputestdata/aarch64-guest.xml | 4 2

Release of libvirt-11.2.0

2025-04-01 Thread Jiri Denemark via Devel
The 11.2.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is

  1   2   3   4   5   6   >