-sev-snp.x86_64-latest+amdsev.args
delete mode 100644
tests/qemuxmlconfdata/firmware-auto-efi-sev-snp.x86_64-latest+amdsev.err
Reviewed-by: Jim Fehlig
Regards,
Jim
On 9/4/25 17:59, Hector Cao wrote:
On Fri, Sep 5, 2025 at 1:48 AM Jim Fehlig <mailto:jfeh...@suse.com>> wrote:
On 9/4/25 17:00, Hector Cao wrote:
>
>
> On Thu, Sep 4, 2025 at 11:40 PM Jim Fehlig mailto:jfeh...@suse.com>
> <mailto:jf
On 9/10/25 07:57, Andrea Bolognani via Devel wrote:
Signed-off-by: Andrea Bolognani
---
NEWS.rst | 5 +
1 file changed, 5 insertions(+)
Reviewed-by: Jim Fehlig
Regards,
Jim
On 9/18/25 02:12, Andrea Bolognani wrote:
On Wed, Sep 17, 2025 at 12:57:36PM -0600, Jim Fehlig wrote:
On 9/12/25 00:58, Andrea Bolognani wrote:
I wasn't planning on pushing this series until we have
reached an agreement on the edk2 side for the contents of the
descriptors.
After reading
On 9/12/25 00:58, Andrea Bolognani wrote:
On Thu, Sep 11, 2025 at 12:54:25PM -0600, Jim Fehlig wrote:
On 9/11/25 01:38, Andrea Bolognani wrote:
If you want, I can add a comment along the lines of
/* This succeeds, but the selected firmware is not the one
* we want */
to
On 9/11/25 01:38, Andrea Bolognani wrote:
On Wed, Sep 10, 2025 at 04:39:20PM -0600, Jim Fehlig wrote:
On 9/10/25 07:57, Andrea Bolognani via Devel wrote:
One of the new test cases demonstrates how firmware
autoselection doesn't currently work correctly for domains
using SEV-SNP: the descr
On 9/10/25 07:57, Andrea Bolognani via Devel wrote:
One of the new test cases demonstrates how firmware
autoselection doesn't currently work correctly for domains
using SEV-SNP: the descriptor for a suitable firmware exists,
and yet it doesn't get picked up.
Another test cases shows that, while
mware selection fixes
DONOTMERGE update firmware data
DONOTMERGE remove SEV features from non-SEV descriptors
DONOTMERGE don't explicitly request stateless firmware for SEV
Jim Fehlig (1):
tests: Improve AMD SEV-related tests
NEWS.rst
On 9/5/25 03:36, Claudio Fontana wrote:
clarify that "guest" time is time spent running VCPUs specifically.
Signed-off-by: Claudio Fontana
---
include/libvirt/libvirt-host.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Jim Fehlig
Regards,
Jim
di
On 9/4/25 17:00, Hector Cao wrote:
On Thu, Sep 4, 2025 at 11:40 PM Jim Fehlig <mailto:jfeh...@suse.com>> wrote:
On 9/3/25 06:49, Hector Cao wrote:
> On recent Intel CPUs, some of the CPU features (mostly
> vmx-* subfeatures) are listed and controlled via the
On 9/3/25 06:49, Hector Cao wrote:
On recent Intel CPUs, some of the CPU features (mostly
vmx-* subfeatures) are listed and controlled via the
MSRs (Model Specific Registers) instead of the traditional
CPUID instruction method.
To be able to read the MSR's values, the kernel module msr
has to be
On 8/25/25 10:19, Andrea Bolognani via Devel wrote:
Based on proposed changes in the Fedora edk2 package.
AFAICT, the edk2 changes have landed
https://src.fedoraproject.org/rpms/edk2/c/5146a0c3e9bf821d045e0cc3600ad715aca14588?branch=rawhide
Making it possible to merge this, correct?
Regards,
read-only builds.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_firmware.c | 7 +++
1 file changed, 7 insertions(+)
Reviewed-by: Jim Fehlig
Regards,
Jim
On 8/26/25 11:12, Andrea Bolognani wrote:
On Tue, Aug 26, 2025 at 10:39:30AM -0600, Jim Fehlig wrote:
On 8/26/25 09:30, Andrea Bolognani wrote:
On Mon, Aug 25, 2025 at 05:12:57PM -0600, Jim Fehlig wrote:
On 8/25/25 10:19, Andrea Bolognani via Devel wrote:
One of the new test cases
On 8/27/25 09:33, Andrea Bolognani wrote:
On Mon, Aug 25, 2025 at 11:05:02AM -0600, Jim Fehlig wrote:
On 8/20/25 09:12, Andrea Bolognani wrote:
On Thu, Aug 14, 2025 at 03:07:10PM -0600, Jim Fehlig wrote:
On 8/13/25 09:01, Andrea Bolognani wrote:
Can you be more specific about the issue
On 8/26/25 09:30, Andrea Bolognani wrote:
On Mon, Aug 25, 2025 at 05:12:57PM -0600, Jim Fehlig wrote:
On 8/25/25 10:19, Andrea Bolognani via Devel wrote:
One of the new test cases demonstrates how firmware
autoselection doesn't currently work correctly for domains
using SEV-SNP: the descr
On 8/25/25 10:19, Andrea Bolognani via Devel wrote:
Based on proposed changes in the Fedora edk2 package.
The SEV(-ES) and SEV-SNP descriptors are now separate, which
allows libvirt to pick the correct firmware loading mechanism
(flash vs ROM) automatically.
---
.../qemu/firmware/60-edk2-ovmf-
On 8/25/25 10:19, Andrea Bolognani via Devel wrote:
The current code assumes that a stateless firmware has to be
explicitly requested by the user, and should never be picked
otherwise. This means that, for example, domains configured to
use SEV-SNP are forced to explicitly request for the firmwar
On 8/25/25 10:19, Andrea Bolognani via Devel wrote:
One of the new test cases demonstrates how firmware
autoselection doesn't currently work correctly for domains
using SEV-SNP: the descriptor for a suitable firmware exists,
and yet it doesn't get picked up.
But the descriptor is incorrect. Aut
+---
16 files changed, 10 insertions(+), 217 deletions(-)
Good idea, and nice cleanup.
Reviewed-by: Jim Fehlig
Regards,
Jim
--
tests/qemufirmwaretest.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
ACK from V1 stands
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/EZX2PDI2E2O2CMMFS6IAY2HUYNTMOP65/
Reviewed-by: Jim Fehlig
Regards,
Jim
On 8/20/25 09:24, Andrea Bolognani wrote:
On Tue, Aug 19, 2025 at 04:09:28PM -0600, Jim Fehlig via Devel wrote:
On 8/13/25 09:01, Andrea Bolognani wrote:
Stressing again the fact that I know very little about SEV and its
variants, my impression is that generally speaking stateless firmware
is
On 8/20/25 09:12, Andrea Bolognani wrote:
On Thu, Aug 14, 2025 at 03:07:10PM -0600, Jim Fehlig wrote:
On 8/13/25 09:01, Andrea Bolognani wrote:
Can you be more specific about the issue you're experiencing for
SEV(-ES) guests?
I'm seeing the same issue we were trying to solve for
On 8/13/25 09:01, Andrea Bolognani wrote:
On Tue, Aug 12, 2025 at 05:26:19PM -0600, Jim Fehlig wrote:
On 7/31/25 09:45, Andrea Bolognani via Devel wrote:
This test case demonstrates how firmware autoselection doesn't
currently work correctly for domains using SEV-SNP: the
descriptor
On 8/13/25 09:01, Andrea Bolognani wrote:
On Tue, Aug 12, 2025 at 05:26:19PM -0600, Jim Fehlig wrote:
On 7/31/25 09:45, Andrea Bolognani via Devel wrote:
This test case demonstrates how firmware autoselection doesn't
currently work correctly for domains using SEV-SNP: the
descriptor
On 7/31/25 09:45, Andrea Bolognani via Devel wrote:
This test case demonstrates how firmware autoselection doesn't
currently work correctly for domains using SEV-SNP: the
descriptor for a suitable firmware exists, and yet it doesn't
get picked up.
On my test system, autoselection for SEV-SNP gu
--
tests/qemufirmwaretest.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
This change seems fine independent of the others.
Reviewed-by: Jim Fehlig
Regards,
Jim
On 8/5/25 07:02, Gerd Hoffmann wrote:
[adding Daniel to CC]
Daniel suggested that elsewhere in the thread and of course it's an
appealing proposition, as it would keep complexity down and unify
handling across CVM use cases.
However I wonder if changing things would break migration for
existi
On 8/4/25 05:31, Andrea Bolognani wrote:
On Fri, Aug 01, 2025 at 11:39:45AM -0600, Jim Fehlig via Devel wrote:
With this addition, the correct firmware is detected, but it's not properly
provided to qemu
internal error: QEMU unexpectedly closed the monitor (vm='sles15sp7-snp')
On 8/1/25 03:14, Andrea Bolognani wrote:
On Fri, Aug 01, 2025 at 02:06:44AM -0700, Andrea Bolognani wrote:
On Thu, Jul 31, 2025 at 11:33:08AM -0600, Jim Fehlig wrote:
Apologies for not having time to look at this in more detail today, but I
quickly tried these patches and now see
operation
On 7/31/25 09:45, Andrea Bolognani via Devel wrote:
See [1] for the discussion motivating these changes.
[1]
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/U33UEJEXZGZEWOLGVAA5UWPLYY4WHEHT/
Andrea Bolognani (5):
tests: Tweak descriptor for combined firmware
tests:
On 5/13/25 14:25, Jim Fehlig wrote:
On 4/24/25 14:18, Jim Fehlig wrote:
On 4/24/25 04:59, Daniel P. Berrangé wrote:
On Mon, Apr 21, 2025 at 01:38:35PM -0600, Jim Fehlig via Devel wrote:
Hi All,
While investigating an internal bug report, we noticed that a minimal
firmware auto-selection
system.
Reviewed-by: Jim Fehlig
Regards,
Jim
On 7/10/25 03:20, Andrea Bolognani wrote:
On Mon, Jul 07, 2025 at 05:05:05PM -0600, Jim Fehlig via Devel wrote:
* **Improvements**
+ * qemu: Change default SCSI controller model to ``virtio-scsi`` for ARM
+
+The previous default of ``lsilogic`` is unsupported by modern operating
From: Jim Fehlig
Signed-off-by: Jim Fehlig
---
NEWS.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index d8bd2559f4..59494cb380 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -19,6 +19,12 @@ v11.6.0 (unreleased)
* **Improvements**
+ * qemu: Change default SCSI
On 7/3/25 04:35, Daniel P. Berrangé wrote:
On Thu, Jul 03, 2025 at 06:02:38AM -0400, Andrea Bolognani via Devel wrote:
On Wed, Jul 02, 2025 at 02:01:07PM -0600, Jim Fehlig wrote:
On 7/2/25 10:11, Andrea Bolognani wrote:
On Thu, Jun 26, 2025 at 03:29:58PM -0600, Jim Fehlig via Devel wrote
On 7/2/25 10:11, Andrea Bolognani wrote:
On Thu, Jun 26, 2025 at 03:29:58PM -0600, Jim Fehlig via Devel wrote:
Similar to x86, the default SCSI controller model for ARM is lsilogic.
But unlike x86, the ARM virt machine type prefers virtio devices. Switch
the default controller model for ARM
From: Jim Fehlig
Similar to x86, the default SCSI controller model for ARM is lsilogic.
But unlike x86, the ARM virt machine type prefers virtio devices. Switch
the default controller model for ARM from lsilogic to virtio-scsi.
Signed-off-by: Jim Fehlig
---
IMO, the lsilogic SCSI controller
ken versions.
Either way
Reviewed-by: Jim Fehlig
Regards,
Jim
Resolves: https://issues.redhat.com/browse/RHEL-88747
Closes: https://gitlab.com/libvirt/libvirt/-/issues/771
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
Reviewed-by: Jim Fehlig
Regards,
Jim
diff --git a/src/qe
On 4/24/25 14:18, Jim Fehlig wrote:
On 4/24/25 04:59, Daniel P. Berrangé wrote:
On Mon, Apr 21, 2025 at 01:38:35PM -0600, Jim Fehlig via Devel wrote:
Hi All,
While investigating an internal bug report, we noticed that a minimal
firmware auto-selection configuration along with SEV* fails to
On 4/24/25 04:59, Daniel P. Berrangé wrote:
On Mon, Apr 21, 2025 at 01:38:35PM -0600, Jim Fehlig via Devel wrote:
Hi All,
While investigating an internal bug report, we noticed that a minimal
firmware auto-selection configuration along with SEV* fails to find a match.
E.g. the following config
Hi All,
While investigating an internal bug report, we noticed that a minimal firmware
auto-selection configuration along with SEV* fails to find a match. E.g. the
following config
hvm
0x07
...
Fails with "Unable to find 'efi' firmware that is compatible with the c
On 3/19/25 05:54, Daniel P. Berrangé wrote:
On Wed, Mar 05, 2025 at 03:48:10PM -0700, Jim Fehlig via Devel wrote:
When invoking virDomainSaveParams with a relative path, the image is
saved to the daemon's CWD. Similarly, when providing virDomainRestoreParams
with a relative path, it attemp
On 3/20/25 11:55, Daniel P. Berrangé wrote:
Hi Jim,
There are a couple of CI failures after this, one on 32-bit and
one with CLang
Yep, received mail from gitlab as well. Will take a look...
Regards,
Jim
On Wed, Mar 05, 2025 at 03:48:09PM -0700, Jim Fehlig via Devel wrote:
V4 series
On 3/21/25 04:21, Martin Kletzander wrote:
On Fri, Mar 21, 2025 at 08:29:30AM +, Daniel P. Berrangé via Devel wrote:
On Thu, Mar 20, 2025 at 09:36:15PM -0600, Jim Fehlig via Devel wrote:
On 3/20/25 17:07, Pavel Hrdina via Devel wrote:
> Pavel Hrdina (6):
> tools: remove --paralle
On 5/24/24 00:21, Zhenzhong Duan wrote:
QEMU will provides 'tdx-guest' object which is used to launch encrypted
VMs on Intel platform using TDX feature.
Command line looks like:
$QEMU ... \
-object
'{"qom-type":"tdx-guest","id":"lsec0","debug":true,"sept-ve-disable":false,"mrconfigid":"xxx",
On 3/25/25 00:24, Will wrote:
Signed-off-by: Will
---
NEWS.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 1fc80e2496..075fbd2d6c 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -67,6 +67,11 @@ v11.2.0 (unreleased)
restore. Using multiple channels can redu
On 3/25/25 00:24, Will wrote:
Adds support for configuring flags for domains
running under Xen.
The following flags, making use of QEMU's existing flags, are now
configurable for Xen: vapic, synic, stimer, frequencies, tlbflush and
ipi
Tests have been added validating translation to libxl's vi
On 5/24/24 00:21, Zhenzhong Duan wrote:
Extend qemu TDX capability to domain capabilities.
Signed-off-by: Chenyi Qiang
Signed-off-by: Zhenzhong Duan
---
docs/formatdomaincaps.rst | 1 +
src/conf/domain_capabilities.c | 1 +
src/conf/domain_capabilities.h | 1 +
src/conf/schemas
Add a 'New features' entry for mapped-ram itself, and another
for the parallel save/restore feature built on top.
Signed-off-by: Jim Fehlig
---
NEWS.rst | 15 +++
1 file changed, 15 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 484333e55a..76f7ea65b1 100644
---
On 3/25/25 06:49, Martin Kletzander wrote:
On Tue, Mar 25, 2025 at 10:15:12AM +, Daniel P. Berrangé wrote:
On Tue, Mar 25, 2025 at 10:49:49AM +0100, Martin Kletzander wrote:
On Wed, Mar 19, 2025 at 05:43:20PM -0600, Jim Fehlig via Devel wrote:
> On 3/19/25 05:54, Daniel P. Berrangé wr
here first. Thanks for
cleaning up after me, and for improving the mapped-ram support!
Reviewed-by: Jim Fehlig
Regards,
Jim
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 3cf21380ed..056a9e579d 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5945
On 3/21/25 04:21, Martin Kletzander wrote:
On Fri, Mar 21, 2025 at 08:29:30AM +, Daniel P. Berrangé via Devel wrote:
On Thu, Mar 20, 2025 at 09:36:15PM -0600, Jim Fehlig via Devel wrote:
On 3/20/25 17:07, Pavel Hrdina via Devel wrote:
> Pavel Hrdina (6):
> tools: remove --paralle
sertions(+), 78 deletions(-)
For series:
Reviewed-by: Jim Fehlig
Regards,
Jim
1, the default value when the
number of channels is not specified.
Fixes: f0169f4d6ce3915cf70bc3e21fa874369e22c840
Signed-off-by: Jim Fehlig
---
Is it valid to specify '--parallel' without '--parallel-channels'? If so,
should the number of channels default to 1?
src/qemu/qemu_m
#x27; modifier.
Fixes: c2518f7bc7dd4f8ab8655a12ec3a000e1eb5b232
Fixes: 28a06215280b99708ed8dc2d183f62ba7b34ccf8
Signed-off-by: Jim Fehlig
---
A lot of ways to skin this cat, but I think this would be the
preferred approach. And while adding the 2 'Fixes:' lines to the
commit message, I questioned whether this shou
beforehand IMO. See the individual
patches for more commentary. Also, feel free to push if the patches
are fine and it's outside of MDT timezone working hours :-).
Jim Fehlig (2):
qemu: Fix CLang build
qemu: Fix build on 32-bit platforms
src/qemu/qemu_migration_params.c | 2 +-
src
On 3/19/25 09:45, Daniel P. Berrangé wrote:
On Wed, Mar 05, 2025 at 03:48:20PM -0700, Jim Fehlig via Devel wrote:
Similar to qemuMigrationSrcRun, apply migration parameters in
qemuMigrationDstRun. This allows callers to create customized
migration parameters, but delegates their application to
On 3/19/25 06:49, Daniel P. Berrangé wrote:
On Wed, Mar 05, 2025 at 03:48:17PM -0700, Jim Fehlig via Devel wrote:
Move the code in qemuSaveImageCreate that opens, labels, and wraps the
save image fd to a helper function, providing more flexibility for
upcoming mapped-ram support.
Signed-off-by
Hi All,
Does anyone have time to review this series? QEMU has supported mapped-ram for a
few releases now. Adding support in libvirt allows us to build parallel
save/restore on top. Would be a nice feature for the next release :-).
Regards,
Jim
On 3/5/25 15:48, Jim Fehlig wrote:
V4 series
Hi All,
Any comments on this addition to NEWS?
Regards,
Jim
On 3/3/25 11:34, Jim Fehlig wrote:
Signed-off-by: Jim Fehlig
---
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 9c940b1a81..d08a18dc02 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -17,6
Hi Will,
Thanks for the patch! Looks good. I only have some minor comments.
On 3/4/25 02:11, Will wrote:
Adds support for configuring flags for domains
running under Xen.
The following flags, making use of QEMU's existing flags, are now
configurable for Xen: vapic, synic, stimer, frequencies,
From: Claudio Fontana
Signed-off-by: Claudio Fontana
Signed-off-by: Jim Fehlig
---
docs/manpages/virsh.rst | 9 +++--
tools/virsh-domain.c| 39 +++
2 files changed, 42 insertions(+), 6 deletions(-)
diff --git a/docs/manpages/virsh.rst b/docs
Add support for parallel save and restore by mapping libvirt's
"parallel-channels" parameter to QEMU's "multifd-channels"
migration parameter.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c | 32 +---
src/qem
From: Claudio Fontana
Signed-off-by: Claudio Fontana
Signed-off-by: Jim Fehlig
---
docs/manpages/virsh.rst | 12 +++-
tools/virsh-domain.c| 42 +
2 files changed, 49 insertions(+), 5 deletions(-)
diff --git a/docs/manpages/virsh.rst b/docs
parameter.
Signed-off-by: Claudio Fontana
Signed-off-by: Jim Fehlig
---
include/libvirt/libvirt-domain.h | 11 +++
src/libvirt-domain.c | 3 +++
2 files changed, 14 insertions(+)
diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index 0121620e9c
When using the mapped-ram migration capability, direct IO is
enabled by setting the "direct-io" migration parameter to
"true" and passing QEMU an additional fd with O_DIRECT set.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_migration.c | 11 ++-
src/qemu/q
Add support for the mapped-ram migration capability on restore.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c| 27 +++---
src/qemu/qemu_migration.c | 12 ++--
src/qemu/qemu_process.c | 41 ---
src/qemu/qemu_process.h
When using the mapped-ram migration capability, direct IO is
enabled by setting the "direct-io" migration parameter to
"true" and passing QEMU an additional fd with O_DIRECT set.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c | 10 ++
src/q
Similar to qemuMigrationSrcRun, apply migration parameters in
qemuMigrationDstRun. This allows callers to create customized
migration parameters, but delegates their application to the
function performing the migration.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_migration.c | 16
memory size.
Note however that mapped-ram typically uses fewer blocks on disk, hence
the name 'sparse' for 'save_image_format'.
Also note the mapped-ram stream is incompatible with the existing stream
format, hence mapped-ram cannot be used to restore an image saved with
the
qemuProcessStartWithMemoryState() is the only caller of qemuProcessStart()
that uses the qemuProcessIncomingDef struct. Move creation of the struct
to qemuProcessStartWithMemoryState().
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_process.c | 42 -
src
Move the code in qemuSaveImageCreate that opens, labels, and wraps the
save image fd to a helper function, providing more flexibility for
upcoming mapped-ram support.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_saveimage.c | 65 +++
1 file changed, 45
Extend the list of formats to include "sparse", which uses QEMU's mapped-ram
stream format [1] to write guest memory blocks at fixed offsets in the save
image file.
[1]
https://gitlab.com/qemu-project/qemu/-/blob/master/docs/devel/migration/mapped-ram.rst?ref_type=heads
Sig
work
to support parallel save/restore can set the number of channels to
a user-specified value.
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
---
src/qemu/qemu_migration.c| 2 +-
src/qemu/qemu_migration_params.c | 21 +
src/qemu/qemu_migration_params.h
Add the mapped-ram migration capability introduced in QEMU 9.0.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_migration_params.c | 1 +
src/qemu/qemu_migration_params.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/qemu/qemu_migration_params.c b/src
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
---
src/qemu/qemu_migration_params.c | 18 ++
src/qemu/qemu_migration_params.h | 5 +
2 files changed, 23 insertions(+)
diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c
index
Add new function qemuMigrationParamsCapEnabled() to check if a
capability is set in the caller-provided migration parameters.
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
---
src/qemu/qemu_migration_params.c | 16
src/qemu/qemu_migration_params.h | 4
2
Add new function qemuFDPassNewFromMonitor to get an fdset previously
passed to qemu, based on the 'prefix' provided when the qemuFDPass
object was initially created.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_fd.c | 46 ++
src/qemu/qemu
Ensure a relative path is
converted to absolute before invoking the driver domain{Save,Restore}Params
functions.
Signed-off-by: Jim Fehlig
---
src/libvirt-domain.c | 89
1 file changed, 73 insertions(+), 16 deletions(-)
diff --git a/src/libvirt-domain
l/migration/mapped-ram.rst?ref_type=heads
Claudio Fontana (3):
include: Define constants for parallel save/restore
tools: add parallel parameter to virsh save command
tools: add parallel parameter to virsh restore command
Jim Fehlig (15):
lib: virDomain{Save,Restore}Params: Ensure absolute path
Signed-off-by: Jim Fehlig
---
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 9c940b1a81..d08a18dc02 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -17,6 +17,14 @@ v11.2.0 (unreleased)
* **New features**
+ * qemu: Add new 'image_format' pa
On 2/25/25 07:43, Daniel P. Berrangé wrote:
On Thu, Feb 20, 2025 at 05:23:54PM -0700, Jim Fehlig via Devel wrote:
Add support for the 'image_format' typed parameter in virDomainSaveParams.
The parameter overrides the 'save_image_format' setting in qemu.conf.
Signe
On 2/20/25 17:11, Jim Fehlig wrote:
Checking for valid 'foo_image_format' settings in qemu.conf is not done
until the settings are used. Move the checks to
virQEMUDriverConfigLoadSaveEntry, allowing to report incorrect format
settings at driver startup.
This change was made easi
Add support for the 'image_format' typed parameter in virDomainSaveParams.
The parameter overrides the 'save_image_format' setting in qemu.conf.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c | 20
1 file changed, 16 insertions(+), 4 deletions(
Add a new VIR_DOMAIN_SAVE_PARAM_IMAGE_FORMAT typed parameter for
specifying the save image format. A format specified via the
virDomainSaveParams API overrides the save_image_format setting
in qemu.conf. The 'raw' format remains the default.
Signed-off-by: Jim Fehlig
Reviewed-by
@lists.libvirt.org/thread/NZFXRLTJVLPABSXI7C2JIJUZIINZGSIL/
Jim Fehlig (2):
include: Define constant for save image format
qemu: Add support for 'image_format' typed parameter
include/libvirt/libvirt-domain.h | 13 +
src/libvirt-domain.c | 3 +++
src/qemu/qem
lds
in the virQEMUDriverConfig to 'int', which is more in line with the
other fields that represent enumerated types.
Signed-off-by: Jim Fehlig
---
Splitting the change to virQEMUDriverConfig struct into a separate patch
felt a bit awkward compared to one patch, but I'm fine to do th
failure. Checking the validity of
the image format can be left to the calling functions.
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
---
src/qemu/qemu_driver.c| 36 +---
src/qemu/qemu_saveimage.c | 30 +-
src/qemu
reported if
it cannot be honored.
Remove the special handling of configuration errors in
qemuSaveImageGetCompressionProgram and change the dump logic to
fail when dump image format cannot be supported.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c| 19
src/qemu/qemu_saveimage.c
Allow use of the enum outside of qemu_saveimage.
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
---
src/qemu/qemu_saveimage.c | 19 ---
src/qemu/qemu_saveimage.h | 19 +++
2 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/src/qemu
operations.
* New patch4 that moves checking for a valid save image format from
time of use to config file parsing at driver startup
Jim Fehlig (4):
qemu: Move declaration of virQEMUSaveFormat to header file
qemu: Don't ignore dump image format errors
qemu: Change return val
On 2/14/25 15:48, Jim Fehlig wrote:
Even though my work on supporting mapped-ram is the main motivation for
this small cleanup series, IMO is useful in its own right.
Here's an example of that usefulness
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/t
Add support for the 'image_format' typed parameter in virDomainSaveParams.
The parameter overrides the 'save_image_format' setting in qemu.conf.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
d
Add a new VIR_DOMAIN_SAVE_PARAM_IMAGE_FORMAT typed parameter for
specifying the save image format. A format specified via the
virDomainSaveParams API overrides the save_image_format setting
in qemu.conf. The 'raw' format remains the default.
Signed-off-by: Jim Fehlig
---
include/libvi
still be set driver-wide in qemu.conf. Patch2 provides the
implementation in the qemu driver.
[1]
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/SKVPVQ36ND7GHZN27RTYLUXHP5GCUI4B/
Jim Fehlig (2):
include: Define constant for save image format
qemu: Add support for
failure. Checking the validity of
the image format can be left to the calling functions.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c| 33 +--
src/qemu/qemu_saveimage.c | 55 ---
src/qemu/qemu_saveimage.h | 2 +-
src/qemu
Allow use of the enum outside of qemu_saveimage.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_saveimage.c | 19 ---
src/qemu/qemu_saveimage.h | 19 +++
2 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/src/qemu/qemu_saveimage.c b/src/qemu
The 'use_raw_on_fail' logic in qemuSaveImageGetCompressionProgram is only
used by doCoreDump in qemu_driver.c. Move the logic to the single call site
and remove the parameter from qemuSaveImageGetCompressionProgram.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver
1 - 100 of 275 matches
Mail list logo
