Re: [PATCH] ci: regenerate with 'lcitool manifest'

2025-09-22 Thread Ján Tomko via Devel
On a Monday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik This pulls in the fix for generating ENV vars in Dockerfile according to latest standard. Signed-off-by: Michal Privoznik --- --- 8< --- 32 files changed, 198 insertions(+), 198 deletions(-) Reviewed-by:

Re: [libvirt PATCH 7/8] tests: qemuxmlconftests: test virtiofsd command line too

2025-09-22 Thread Ján Tomko via Devel
On a Friday in 2025, Laine Stump wrote: On 9/9/25 8:05 AM, Ján Tomko via Devel wrote: From: Ján Tomko Signed-off-by: Ján Tomko --- ...t-user-fs-ccw.s390x-latest.virtiofsd0.args | 3 ++ ...fs-fd-memory.x86_64-latest.virtiofsd0.args | 9 ++ ...fd-openfiles.x86_64-latest.virtiofsd0.args

[libvirt PATCH 1/8] qemu: passt: split out qemuPasstBuildCommand

2025-09-20 Thread Ján Tomko via Devel
From: Ján Tomko Separate the command line building to make it testable. Signed-off-by: Ján Tomko --- src/qemu/qemu_passt.c | 38 +- src/qemu/qemu_passt.h | 5 + 2 files changed, 34 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_passt.c b/src

Re: [PATCH] esx: Satisfy curl type checks

2025-09-17 Thread Ján Tomko via Devel
On a Monday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik Since its commit [1] curl now performs type checks on curl_easy_setopt(). Some options expect long but we're passing an int. The fix consists mostly of specifying type of numbers passed to the function. Except for two

Re: [PATCH 00/14] qemu: Optimize guest CPU probing

2025-09-17 Thread Ján Tomko via Devel
torjsondata/qemumonitorjson-getcpu-host.json Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 0/6] qemu: refactor disk migration safety check and add corner case exemption for Kubevirt's usage

2025-09-14 Thread Ján Tomko via Devel
| 3 + src/qemu/qemu_monitor_json.c | 3 + tests/qemublocktest.c | 2 + tests/qemublocktestdata/bitmap/synthetic.json | 1 + tests/qemublocktestdata/bitmap/synthetic.out | 1 + 6 files changed, 133 insertions(+), 65 deletions(-) Reviewed-by: Ján Tomko

[libvirt PATCH 7/8] tests: qemuxmlconftests: test virtiofsd command line too

2025-09-12 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- ...t-user-fs-ccw.s390x-latest.virtiofsd0.args | 3 ++ ...fs-fd-memory.x86_64-latest.virtiofsd0.args | 9 ++ ...fd-openfiles.x86_64-latest.virtiofsd0.args | 10 ++ ...fs-hugepages.x86_64-latest.virtiofsd0.args | 3 ++ ...fs

Re: [PATCH 0/5] ch: Emit more events

2025-09-12 Thread Ján Tomko via Devel
/ch/ch_driver.c | 41 + src/ch/ch_events.c | 55 + src/ch/ch_hotplug.c | 33 ++- 3 files changed, 123 insertions(+), 6 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP

[libvirt PATCH 0/8] qemu: test command line of external helpers

2025-09-11 Thread Ján Tomko via Devel
Ján Tomko (8): qemu: passt: split out qemuPasstBuildCommand tests: qemuxmlconftests: store suffix in testQemuInfo tests: qemuxmlconftest: Introduce testQemuConfMarkUsed export qemuVirtioFSBuildCommandLine tests: qemuxmlconftest: test passt command line too tests: qemuxmlconf: virtiofs

Re: [PATCH 0/2] ch: Two simple fixes

2025-09-11 Thread Ján Tomko via Devel
nlock domain in virCHEventStopProcess() on all exit paths src/ch/ch_events.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 0/4] ch: Disk attach/detach fixes

2025-09-11 Thread Ján Tomko via Devel
detach in chDomainRemoveDevice() src/ch/ch_hotplug.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 4/6] qemuMigrationSrcIsSafeDisk: Check also data file propertiues for migrability

2025-09-10 Thread Ján Tomko via Devel
In the commit summary: *properties On a Wednesday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa If the qcow2 data file feature (which separates the data into a separate file from the metadata) is in use the migration safety check ought co ought to Jano consider both the metad

[libvirt PATCH 2/2] util: remove glibcompat.c

2025-09-10 Thread Ján Tomko via Devel
From: Ján Tomko There are no functions reimplemented here anymore. Signed-off-by: Ján Tomko --- src/util/glibcompat.c | 64 --- src/util/meson.build | 1 - 2 files changed, 65 deletions(-) delete mode 100644 src/util/glibcompat.c diff --git a/src

[libvirt PATCH 1/2] build: bump minimum glib version to 2.68

2025-09-10 Thread Ján Tomko via Devel
From: Ján Tomko We removed support for Debian 11 which only had 2.66.8. Next stop: 2.72 after we drop Ubuntu 22.04 For libvirt, the update to the 2.68 GLib release: * introduces g_string_replace * deprecates g_memdup in favor of g_memdup2 * removes the need for some warning workarounds

[libvirt PATCH 0/2] bump minimum glib version to 2.68

2025-09-10 Thread Ján Tomko via Devel
Ján Tomko (2): build: bump minimum glib version to 2.68 util: remove glibcompat.c meson.build | 2 +- src/conf/virdomainjob.c | 6 +- src/esx/esx_vi_types.c | 9 +- src/internal.h | 24 src/libvirt_private.syms | 4 - src/qemu

Re: [PATCH 0/4] ch: Improve domain destroy

2025-09-09 Thread Ján Tomko via Devel
VIR_DOMAIN_DESTROY_GRACEFUL flag support src/ch/ch_driver.c| 13 ++--- src/ch/ch_events.c| 2 +- src/ch/ch_process.c | 22 -- src/ch/ch_process.h | 8 +++- src/util/virprocess.c | 3 ++- 5 files changed, 36 insertions(+), 12 deletions(-) Reviewed-by: Ján Tomko

Re: [PATCH 0/2] datatypes: Add missing check to virGetStream and refactor cleanup paths of helpers

2025-09-09 Thread Ján Tomko via Devel
5 insertions(+), 130 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

[libvirt PATCH 5/8] tests: qemuxmlconftest: test passt command line too

2025-09-09 Thread Ján Tomko via Devel
From: Ján Tomko Introduce testing of the generated command line arguments of helper binaries too, not just QEMU. Start with passt. Signed-off-by: Ján Tomko --- .../net-user-passt.x86_64-7.2.0.passt0.args | 13 .../net-user-passt.x86_64-latest.passt0.args | 13 ...-vhostuser

[libvirt PATCH 6/8] tests: qemuxmlconf: virtiofs: remove locking from the readonly test case

2025-09-09 Thread Ján Tomko via Devel
From: Ján Tomko The combination of locking + readonly is bogus, because there has never been a virtiofsd release that supported both. Locking was a feature of the C-based virtiofsd that was living in the QEMU tree until v8.0.0 and the readonly feature was only introduced in the Rust version of

[libvirt PATCH 8/8] tests: qemuxmlconftest: test locking with older virtiofsd

2025-09-09 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- .../vhost-user-fs-locking.x86_64-7.2.0.args | 35 ++ ...er-fs-locking.x86_64-7.2.0.virtiofsd0.args | 4 ++ .../vhost-user-fs-locking.x86_64-7.2.0.xml| 46 +++ .../qemuxmlconfdata/vhost-user-fs-locking.xml | 46

[libvirt PATCH 4/8] export qemuVirtioFSBuildCommandLine

2025-09-09 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- src/qemu/qemu_virtiofs.c | 2 +- src/qemu/qemu_virtiofs.h | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c index aa282024a4..d192f5ec3c 100644 --- a/src/qemu/qemu_virtiofs.c

[libvirt PATCH 3/8] tests: qemuxmlconftest: Introduce testQemuConfMarkUsed

2025-09-09 Thread Ján Tomko via Devel
From: Ján Tomko Make the code readable enough to not need a comment. Signed-off-by: Ján Tomko --- tests/qemuxmlconftest.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c index a7e32a5a99..dea75d805f

[libvirt PATCH 2/8] tests: qemuxmlconftests: store suffix in testQemuInfo

2025-09-09 Thread Ján Tomko via Devel
From: Ján Tomko Next patch will need this to construct the path to the output file in a deeper level of nesting. Signed-off-by: Ján Tomko --- tests/qemuxmlconftest.c | 1 + tests/testutilsqemu.h | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/qemuxmlconftest.c b/tests

Re: [PATCH 0/3] A couple improvements when auto-adding PCI controllers

2025-09-08 Thread Ján Tomko via Devel
-root-port when needed while plugging in pcie-to-pci-bridge src/conf/domain_addr.c| 43 +++ .../pcie-root-port-too-many.x86_64-latest.err | 2 +- 2 files changed, 35 insertions(+), 10 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 04/14] qemu: Generalize filtering in qemuMonitorJSONParsePropsList

2025-09-08 Thread Ján Tomko via Devel
On a Thursday in 2025, Jiri Denemark via Devel wrote: From: Jiri Denemark qemuMonitorJSONParsePropsList supported filtering based on type. Let's replace it with a callback supplied by the caller to allow for more advanced filtering. Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.

Re: [PATCH] tests: Drop unused vm variable in testQemuMonitorCPUInfo

2025-09-05 Thread Ján Tomko via Devel
On a Thursday in 2025, Jiri Denemark via Devel wrote: From: Jiri Denemark Signed-off-by: Jiri Denemark --- tests/qemumonitorjsontest.c | 5 - 1 file changed, 5 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

[libvirt PATCH] esx: pass 'long' to curl_easy_setopt when needed

2025-09-02 Thread Ján Tomko via Devel
From: Ján Tomko The include header got its type checks fixed in curl 8.14: https://github.com/curl/curl/commit/79b4e56b3f30dc1ac28a81128a07d27338e5219e https://github.com/curl/curl/pull/17143 This causes a warning on rawhide with clang: ../src/esx/esx_vi.c:318:5: error: call to

Re: [PATCH 0/8] qemu-replies-tool: Improvements for .replies comparison

2025-09-01 Thread Ján Tomko via Devel
emu-replies-tool.py | 271 ++- 1 file changed, 207 insertions(+), 64 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 0/2] hw/mips: Remove mipssim machine and mipsnet device

2025-08-28 Thread Ján Tomko via Devel
(+), 595 deletions(-) delete mode 100644 hw/mips/mipssim.c delete mode 100644 hw/net/mipsnet.c Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 00/10] qemu capability simplification and addition of qemu-10.2 test data

2025-08-28 Thread Ján Tomko via Devel
muxmlconftest: Rename and strip specific machine type from 'x86_64-default-cpu-*' cases qemucapabilitiestest: Add data for the qemu-10.2 dev cycle qemuxmlconftest: Add pinned versions of the 'cpu-host-*' cases for qemu-10.1 Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH] qemu: capabilities: Update '10.1.0' capabilities on x86_64 after release

2025-08-28 Thread Ján Tomko via Devel
psdata/qemu_10.1.0-q35.x86_64.xml | 38 +- tests/domaincapsdata/qemu_10.1.0.x86_64.xml | 38 +- .../caps_10.1.0_x86_64.replies| 6197 ++--- .../caps_10.1.0_x86_64.xml| 355 +- ...host-model-fallback-kvm.x86_64-latest.args |2 +- ...cpu-host-model-features.x86_64-latest.args |2 +- .../cpu-host-model-kvm.x86_64-latest.args |2 +- ...st-model-nofallback-kvm.x86_64-latest.args |2 +- 8 files changed, 3925 insertions(+), 2711 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 0/4] docs: Fix live backup kbase page and add support for RST notes/warnings to the CSS

2025-08-27 Thread Ján Tomko via Devel
insertions(+), 11 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 0/3] Fixes for 11.7

2025-08-27 Thread Ján Tomko via Devel
sertions(+), 56 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH] qemuxmlconftest: Paper over test failure at MacOS

2025-08-13 Thread Ján Tomko via Devel
uxmlconftest failure. 1: https://github.com/apple-oss-distributions/dyld/commit/9a9e3e4cfa7de205d61f4114c9b564e4bab7ef7f +63898 -114767 *facepalm* Signed-off-by: Michal Privoznik --- tests/qemuxmlconftest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH] docs: storage: fix the "since" tag

2025-08-13 Thread Ján Tomko via Devel
On a Tuesday in 2025, Roman Bogorodskiy wrote: Trivial :since: tag fix in the ZFS section. Signed-off-by: Roman Bogorodskiy --- docs/storage.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH] qemu: don't warn about missing SMM for CVM firmware

2025-08-12 Thread Ján Tomko via Devel
switch (fw->features[i]) { Regardless: Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 0/5] Cleanup of callers of virDomainDefGetVcpu

2025-08-12 Thread Ján Tomko via Devel
ess.h | 3 --- src/conf/domain_postparse.c | 4 src/qemu/qemu_domain.c | 15 --- src/qemu/qemu_domain.h | 1 - 7 files changed, 12 insertions(+), 32 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 0/2] qemu: Match firmware with fully resolved and canonicalized paths

2025-08-12 Thread Ján Tomko via Devel
(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 3/5] qemu: domain: Remove unused qemuDomainGetVcpuHalted

2025-08-12 Thread Ján Tomko via Devel
On a Thursday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 15 --- src/qemu/qemu_domain.h | 1 - 2 files changed, 16 deletions(-) Unused since: commit 548b1e55257dc8806abdbefa71a87b22dea1 diff --git a/src

Re: [PATCH] news: document fixed nwfilter driver base chain creation

2025-07-30 Thread Ján Tomko via Devel
a VM was started. +This allowed a small window where traffic might not be fully +filtered. It now handles iptables/ip6tables the same way as +ebtables, creating the base chains only if they did not already +exist. v11.5.0 (2025-07-01) Reviewed-by: Ján Tomko

Re: [PATCH 0/2] virnetdevvportprofile: Misc cleanups

2025-07-23 Thread Ján Tomko via Devel
eviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 0/5] secdriver: Misc cleanups

2025-07-23 Thread Ján Tomko via Devel
curity_dac.c | 14 ++-- src/security/security_selinux.c | 59 +++- 3 files changed, 8 insertions(+), 83 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH] news: document new crypto TLS priority string settings

2025-07-22 Thread Ján Tomko via Devel
. + * **Improvements** Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 00/19] security_selinux: Refactor temporary variable cleanup

2025-07-22 Thread Ján Tomko via Devel
-- 3 files changed, 149 insertions(+), 208 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH] qemu: driver: Reformat function headers for block job APIs

2025-07-22 Thread Ján Tomko via Devel
On a Monday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH] src: fix typo in fixup_name()

2025-07-17 Thread Ján Tomko via Devel
(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH] Allow specifying zero discard granularity for block devices

2025-07-17 Thread Ján Tomko via Devel
On a Thursday in 2025, Martin Kletzander via Devel wrote: On Thu, Jul 17, 2025 at 03:14:36PM +0200, Martin Kletzander wrote: From: Martin Kletzander That allows for disabling discard in a way that some guest OSes (e.g. Windows) understand and do not try to trim the disk. Resolves: https://iss

Re: [PATCH 0/2] qemu: Random fixes

2025-07-17 Thread Ján Tomko via Devel
: Report system error on failed open() qemu_tpm: Don't report uninitialized variable in error message src/qemu/qemu_domain.c | 8 src/qemu/qemu_process.c | 4 ++-- src/qemu/qemu_tpm.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Ján Tomko Jano signa

Re: [PATCH 3/3] qemu_tpm: Only warn about missing locking feature on shared filesystems

2025-07-17 Thread Ján Tomko via Devel
On a Thursday in 2025, Martin Kletzander via Devel wrote: From: Martin Kletzander The warning pollutes the logs and might give a bad impression on someone reading them even though the locking is not always needed. This way we at least limit the logging in unnecessary cases. Resolves: https://

Re: [PATCH 0/3] qemu_tpm: Do not pollute logs with unnecessary warning

2025-07-17 Thread Ján Tomko via Devel
tpm: Only warn about missing locking feature on shared filesystems src/qemu/qemu_migration.c | 2 +- src/qemu/qemu_tpm.c | 75 +++ src/qemu/qemu_tpm.h | 4 +-- 3 files changed, 47 insertions(+), 34 deletions(-) Reviewed-by: Ján Tomko J

[libvirt PATCH 2/2] tests: nssdata: add empty status file

2025-07-16 Thread Ján Tomko via Devel
From: Ján Tomko Add a test to makee sure we will keep ignoring empty status files properly in the future. https://bugzilla.redhat.com/show_bug.cgi?id=2364285 Fixes: 63a3d70697dc44ef2f8b40f7c8e9aa869227a7da Signed-off-by: Ján Tomko --- tests/nssdata/virbr2.status | 0 1 file changed, 0

[libvirt PATCH 1/2] DO NOT PUSH Revert "nss: Skip empty files and avoid use of uninitialized value"

2025-07-16 Thread Ján Tomko via Devel
From: Ján Tomko This reverts commit 63a3d70697dc44ef2f8b40f7c8e9aa869227a7da. --- tools/nss/libvirt_nss_leases.c | 9 ++--- tools/nss/libvirt_nss_macs.c | 9 ++--- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/tools/nss/libvirt_nss_leases.c b/tools/nss

[libvirt PATCH 0/2] tests: nssdata: add empty status file

2025-07-16 Thread Ján Tomko via Devel
both covers by most publishers. Now they are also found on web portals and news websites. A blurb may introduce a newspaper or a book. -- https://en.wikipedia.org/wiki/Blurb Ján Tomko (2): DO NOT PUSH Revert "nss: Skip empty files and avoid use of uninitialized value" tests: ns

Re: [PATCH 0/6] nss: Rework debugging

2025-07-16 Thread Ján Tomko via Devel
s/nss/libvirt_nss_log.h Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 2/6] nss: Move logging into a separate file and turn it temporarily on

2025-07-16 Thread Ján Tomko via Devel
On a Friday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik Currently, when somebody wants to debug the NSS plugin, they have to change a line in libvirt_nss.h (to enable debug printings) and recompile the module. This may work for us, developers, but we can not expect this fr

Re: [PATCH 3/6] nss: Make logging conditional on an envvar

2025-07-16 Thread Ján Tomko via Devel
On a Friday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik As promised in previous commit, make NSS modules silent by default and enable debug printings if LIBVIRT_NSS_DEBUG envvar is set. Signed-off-by: Michal Privoznik --- docs/nss.rst| 13 + to

Re: [PATCH 1/5] conf: virNetDevVPortProfileParse refactor

2025-07-14 Thread Ján Tomko via Devel
On a Monday in 2025, Kirill Shchetiniuk via Devel wrote: From: Kirill Shchetiniuk Refactored the virNetDevVPortProfileParse function to use the appropriate virXMLProp* functions to parse input configuration XML. Signed-off-by: Kirill Shchetiniuk --- src/conf/netdev_vport_profile_conf.c | 120

Re: [PATCH 5/5] qemu: qemuDomainObjPrivateXMLParseVcpu refactor

2025-07-14 Thread Ján Tomko via Devel
On a Monday in 2025, Kirill Shchetiniuk via Devel wrote: From: Kirill Shchetiniuk Refactored the qemuDomainObjPrivateXMLParseVcpu function to use the appropriate virXMLPropUInt function to parse unsigned integers, avoiding unccessery string parsing operations. Signed-off-by: Kirill Shchetiniuk

Re: [PATCH 2/5] conf: virDomainHostdevSubsysMediatedDevDefParseXML refactor

2025-07-14 Thread Ján Tomko via Devel
), 13 deletions(-) Reviewed-by: Ján Tomko and pushed Jano signature.asc Description: PGP signature

Re: [PATCH 0/3] sysinfotest: rename output XMLs with .xml suffix and introduce schema testing

2025-07-14 Thread Ján Tomko via Devel
xpect => armsysinfo.xml} (100%) rename tests/sysinfodata/{ppcsysinfo.expect => ppcsysinfo.xml} (100%) rename tests/sysinfodata/{s390-freqsysinfo.expect => s390-freqsysinfo.xml} (100%) rename tests/sysinfodata/{s390sysinfo.expect => s390sysinfo.xml} (100%) rename tests/sysinfodata/{x86sysinfo.expect

Re: [PATCH] build: prohibit realpath() by syntax-check

2025-07-11 Thread Ján Tomko via Devel
--- build-aux/syntax-check.mk | 9 + 1 file changed, 9 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

[libvirt PATCH] qemu: prefer memfd if we have to format system memory

2025-07-04 Thread Ján Tomko via Devel
From: Ján Tomko For any vhost-user device to work, the memory needs to be marked as shared. What we recommend to users (e.g. in the virtiofs quide [0]) is: Technically, only the access mode is needed: But this results in libvirt assuming the file backend. Switch

Re: [PATCH 05/15] tests: Fix mocking of open()

2025-07-02 Thread Ján Tomko via Devel
On a Thursday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik In some cases (well, majority), open() is either rewritten to open64(), either by plain '#define open open64') or at assembly level (using __REDIRECT macro). See for more info. This didn't really matter to us, bec

Re: [PATCH 01/15] log_cleaner: Use virFileCanonicalizePath()

2025-07-02 Thread Ján Tomko via Devel
On a Thursday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik While use of realpath() is not forbidden, our some of our mocks already have a test friendly reimplementation of virFileCanonicalizePath(). Use the latter. That's a good enough reason to forbid it in syntax-check

Re: [PATCH 00/15] virt-aa-helper: Misc improvements

2025-07-02 Thread Ján Tomko via Devel
changed, 353 insertions(+), 265 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 00/10] Unify argument name of migration APIs

2025-07-01 Thread Ján Tomko via Devel
| 24 +- src/remote/remote_protocol.x| 16 +++ src/remote_protocol-structs | 16 +++ src/rpc/gendispatch.pl | 36 +++ 10 files changed, 113 insertions(+), 113 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 01/10] src: Unify argument name of virDomainMigratePrepare()

2025-07-01 Thread Ján Tomko via Devel
ternal.h | 2 +- src/remote/remote_daemon_dispatch.c | 2 +- src/remote/remote_driver.c | 4 ++-- src/remote/remote_protocol.x| 2 +- src/remote_protocol-structs | 2 +- src/rpc/gendispatch.pl | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-)

Re: [PATCH v2 0/3] tls: Remove all traces of key encipherment usage

2025-07-01 Thread Ján Tomko via Devel
- tests/virnettlscontexttest.c | 36 ++-- tests/virnettlssessiontest.c | 14 +++--- 4 files changed, 29 insertions(+), 57 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH] NEWS: Mention 'virsh await' and proper emulation of USB cdroms

2025-06-30 Thread Ján Tomko via Devel
On a Monday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Signed-off-by: Peter Krempa --- NEWS.rst | 12 1 file changed, 12 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

[libvirt PATCH] NEWS: document new AMD IOMMU device

2025-06-30 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- Applies on top of Peter's NEWS patch NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 3ffdceda81..fd2d68a600 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -45,6 +45,12 @@ v11.5.0 (unreleased) wi

[libvirt PATCH] docs: clarify how to build without -Werror

2025-06-24 Thread Ján Tomko via Devel
From: Ján Tomko --werror does not accept any arguments for me and setting git_werror was also needed to disable it with git. Signed-off-by: Ján Tomko --- docs/compiling.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/compiling.rst b/docs/compiling.rst index

Re: [PATCH] NEWS: mention console type in domain capabilities

2025-06-20 Thread Ján Tomko via Devel
) * **Improvements** + * Include supported console types in domain capabilities + +Domain capabilities now include information about supported console types, such as:: + + + + pty + tcp + + + * **Bug fixes** Reviewed-by: Ján Tomko Jano signature.asc

[libvirt PATCH v2 7/7] qemu: format pt and xstup on the command line

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c| 2 ++ tests/qemuxmlconfdata/amd-iommu.x86_64-latest.args | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6fae9b1f5a

[libvirt PATCH v2 5/7] conf: add passthrough and xtsup attributes for IOMMU

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko For the newly supported AMD device. Signed-off-by: Ján Tomko --- docs/formatdomain.rst | 8 src/conf/domain_conf.c | 30 + src/conf/domain_conf.h | 2 ++ src/conf/schemas/domaincommon.rng | 10

[libvirt PATCH v2 6/7] conf: reject some attributes not applicable to intel IOMMU

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- src/conf/domain_validate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index b9a6740437..b28af7fa56 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c

[libvirt PATCH v2 4/7] docs: formatdomain: document intel-only IOMMU attributes

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- docs/formatdomain.rst | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 53d4349d2b..7ebb4c3e9e 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -9077,14

[libvirt PATCH v2 2/7] qemu: introduce QEMU_CAPS_PCI_ID

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Introduced by QEMU commit f864a3235ea1d1d714b3cde2d9a810ea6344a7b5 the presence of this attribute allows libvirt to specify the alias of the AMDVI-PCI device explicitly. (It was implicit before the introduction of this attribute) Signed-off-by: Ján Tomko --- src/qemu

[libvirt PATCH v2 3/7] qemu: add IOMMU model amd

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Introduce a new IOMMU device model 'amd', both the parser and the formatter for QEMU because of our enum warnings. https://issues.redhat.com/browse/RHEL-50560 Signed-off-by: Ján Tomko --- docs/formatdomain.rst | 5 ++- src/conf/dom

[libvirt PATCH v2 REBASED 0/7] qemu: introduce amd-iommu support

2025-06-18 Thread Ján Tomko via Devel
Ján Tomko (7): qemu: introduce QEMU_CAPS_AMD_IOMMU qemu: introduce QEMU_CAPS_PCI_ID qemu: add IOMMU model amd docs: formatdomain: document intel-only IOMMU attributes conf: add passthrough and xtsup attributes for IOMMU conf: reject some attributes not applicable to intel IOMMU qemu

[libvirt PATCH v2 1/7] qemu: introduce QEMU_CAPS_AMD_IOMMU

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Check for the presence of the amd-iommu device, so we can conditionalize probing for its properties. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 3 +++ tests

Re: [PATCH] security_manager: Don't leak seclabel in virSecurityManagerGenLabel()

2025-06-17 Thread Ján Tomko via Devel
1, vm->nseclabels) < 0) { vm->nseclabels--; +} + The braces are not necessary in this case: https://libvirt.org/coding-style.html#curly-braces +virSecurityLabelDefFree(tmp); goto cleanup; } Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 0/6] Various fixes and cleanups

2025-06-17 Thread Ján Tomko via Devel
tools/virsh-domain.c | 13 +- 6 files changed, 165 insertions(+), 80 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 2/2] NEWS: Mention cainfo_path parameter in esx driver

2025-06-11 Thread Ján Tomko via Devel
``cainfo_path`` parameter in the URI to override the +default location used to search for CA certificates. + The wording here makes me think it's a directory. Consider: default path to the CA certificate Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 1/2] esx: Allow specifying different CA bundle for remote connections

2025-06-11 Thread Ján Tomko via Devel
ver. - Use the ``no_verify=1`` `Extra parameters`_ to disable server certificate verification. - Generate new SSL certificates signed by a CA known to your client computer Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH] nvme: Fix more missing enum switches for VIR_DOMAIN_DISK_BUS_NVME

2025-06-09 Thread Ján Tomko via Devel
On a Monday in 2025, Martin Kletzander via Devel wrote: From: Martin Kletzander Signed-off-by: Martin Kletzander --- So it turned out there were more places, but some even in code that was compiling on my machine and in the CI, but was not found. Not sure why, but I went through all the place

Re: [PATCH 0/7] virsh: Fix cleanup in 'event' command and introduce 'await' command

2025-06-05 Thread Ján Tomko via Devel
| 321 - tools/virsh.c | 4 +- tools/virt-admin.c | 4 +- tools/vsh.c| 46 -- tools/vsh.h| 3 +- 7 files changed, 398 insertions(+), 17 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH] libxl_capabilities: Make some functions return void

2025-06-05 Thread Ján Tomko via Devel
those functions into void and drop checks for their retvals. Signed-off-by: Michal Privoznik --- src/libxl/libxl_capabilities.c | 43 +- 1 file changed, 16 insertions(+), 27 deletions(-) > Reviewed-by: Ján Tomko Jano signature.asc Description:

Re: [PATCH v2 0/4] conf: graphics def and parse refactor

2025-06-04 Thread Ján Tomko via Devel
| 125 ++ src/conf/domain_conf.h| 7 +- src/conf/schemas/domaincommon.rng | 5 -- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_process.c | 4 +- src/qemu/qemu_validate.c | 4 +- src/vbox/vbox_common.c | 8 +-

Re: [PATCH v2 3/4] conf: RDP graphics parse refactor

2025-06-04 Thread Ján Tomko via Devel
On a Wednesday in 2025, Kirill Shchetiniuk via Devel wrote: From: Kirill Shchetiniuk Previously, the RDP graphics definition parsing were implemented by string parsing, the virDomainGraphicsDefParseXMLRDP function is refactored to use the appropriate virXMLProp* utility functions. Overall parsi

Re: [PATCH 0/4] conf: graphics def and parse refactor

2025-06-03 Thread Ján Tomko via Devel
On a Monday in 2025, Kirill Shchetiniuk via Devel wrote: This series is supposed to refactor the existing parse logic by using the proper utility function and some parameters type change. 1. VNC graphics pasing were refactored to use the vitXMLProp* utility functions. 'autoport' and 'websocketGe

Re: [PATCH] qemu: command: Don't attempt to set backend MTU for networks which don't use host backend directly

2025-06-03 Thread Ján Tomko via Devel
llowing XML: The OS in the guest reports MTU . Closes: https://gitlab.com/libvirt/libvirt/-/issues/717 Closes: https://gitlab.com/libvirt/libvirt/-/issues/192 Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH 00/11] Support for emulated NVMe disks in VMX and QEMU

2025-06-02 Thread Ján Tomko via Devel
disks NEWS: vmx support for NVMe disks NEWS: qemu support for emulated NVMe disks Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 07/11] qemu_capabilities: Add emulated NVMe disk support to domain capabilities

2025-06-02 Thread Ján Tomko via Devel
On a Monday in 2025, Martin Kletzander via Devel wrote: From: Martin Kletzander This is a separate commit for review ease, but who's really going to use a libvirt with this patch in and the actual functionality missing, that ain't gonna happen, right? You can trade it for a problem of the ac

Re: [PATCH] docs: fix indent of hostdev examples

2025-06-02 Thread Ján Tomko via Devel
On a Friday in 2025, Daniel P. Berrangé via Devel wrote: From: Daniel P. Berrangé Signed-off-by: Daniel P. Berrangé --- docs/formatdomain.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) Trivial. Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH] NEWS: Mention removal of compile time helper program lookup, virito-net ABI check and FDC capabilities

2025-05-29 Thread Ján Tomko via Devel
f FDC/floppy device support statement in capabilities XML + +The data is now based on the presence of the controller in qemu rather than +just a denylist of machine types where floppies not work. + * **Bug fixes** * qemu: Fix failure when reverting to internal snapshots Reviewed-by

Re: [PATCH 0/3] util: Fix virFileIsSharedFSOverride on nonexistent paths

2025-05-29 Thread Ján Tomko via Devel
+++--- 1 file changed, 45 insertions(+), 31 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 00/15] storage_file_probe: Fix ancient bug in qcow2 header extensions parser and refactor the image probing callbacks

2025-05-29 Thread Ján Tomko via Devel
| 1 + tests/virstoragetestdata/out/qed-qed_raw | 2 + tests/virstoragetestdata/out/raw-auto | 1 + tests/virstoragetestdata/out/raw-raw | 1 + 25 files changed, 263 insertions(+), 267 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 13/15] storage_file_probe: Parse all qcow2 extensions at once

2025-05-29 Thread Ján Tomko via Devel
a --- src/storage_file/storage_file_probe.c | 68 +-- 1 file changed, 13 insertions(+), 55 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 03/15] storage_file_probe: qcow2GetExtensions: Fix qcow2 header extension parsing

2025-05-29 Thread Ján Tomko via Devel
gth Interestingly we also had a test case for this specific scenario but the expected test output was wrong. Fixes: a93402d48b2996e5300754d299ef0d3f646aa098 Resolves: https://issues.redhat.com/browse/RHEL-93775 Signed-off-by: Peter Krempa --- src/storage_file/storage_file_probe.c | 62 +-- .../out

Re: [PATCH 02/15] virstoragetest: Reformat output to hilight dataFile relationship

2025-05-29 Thread Ján Tomko via Devel
tests/virstoragetestdata/out/raw-raw | 1 + 21 files changed, 58 insertions(+), 25 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

  1   2   3   4   5   6   >