Re: [PATCH] fix virLogCleanerParseFilename logic

2024-05-31 Thread David Negreira
Appreciated Michal, thank you for your valuable input and help. On Wed, May 29, 2024 at 9:52 AM Michal Prívozník wrote: > > On 5/29/24 09:21, Michal Prívozník wrote: > > On 5/29/24 09:04, David Negreira wrote: > >> Gentle reminder > >> > > >

Re: [PATCH] fix virLogCleanerParseFilename logic

2024-05-31 Thread David Negreira
Gentle reminder On Thu, May 23, 2024 at 9:05 AM David Negreira wrote: > > Hi Michal, > > Thank you for your comments and improvements on the patch. > > > diff --git i/src/logging/log_cleaner.c w/src/logging/log_cleaner.c > > index 4ee91843aa..9f987b02b5 100644 > >

Re: [PATCH] fix virLogCleanerParseFilename logic

2024-05-27 Thread David Negreira
7;%1$s'"), > rotated_index_str); ^ I tested the above patch and it worked. > Can you please send v2? Do you want to submit the patch and keep the author since you basically wrote the patch, or you want me to send a patch with you as co-author? Happy to do it eit

Re: [PATCH] fix virLogCleanerParseFilename logic

2024-05-21 Thread David Negreira
erParseFilename:89 : internal error: Failed to parse rotated index from '' Kind regards, David Negreira On Tue, May 21, 2024 at 10:42 AM Michal Prívozník wrote: > > On 5/19/24 17:40, David Negreira wrote: > > We should return the full filename path when we don't have a ma

[PATCH] fix virLogCleanerParseFilename logic

2024-05-20 Thread David Negreira
We should return the full filename path when we don't have a match on the third group of the regex. Signed-off-by: David Negreira --- src/logging/log_cleaner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/logging/log_cleaner.c b/src/logging/log_cleaner.c