Re: [PATCH v2 1/3] qemu: add IOMMU model smmuv3Dev

2025-10-06 Thread Daniel P . Berrangé via Devel
On Wed, Oct 01, 2025 at 05:23:46PM -0700, Nathan Chen via Devel wrote: > Introduce support for "smmuv3Dev" IOMMU model and > its "parentIdx" driver attribute. The "parentIdx" > attribute indicates the index of the controller that a > smmuv3Dev IOMMU device is attached to. > > Signed-off-by: Nathan

Re: [PATCH] src: report error from failing to add timer/FD watches

2025-10-03 Thread Daniel P . Berrangé via Devel
On Fri, Oct 03, 2025 at 03:27:15PM +0200, Peter Krempa wrote: > On Fri, Oct 03, 2025 at 14:05:39 +0100, Daniel P. Berrangé wrote: > > On Fri, Oct 03, 2025 at 02:58:59PM +0200, Peter Krempa wrote: > > > On Fri, Oct 03, 2025 at 13:43:31 +0100, Daniel P. Berrangé via Devel > &g

Re: [PATCH] src: report error from failing to add timer/FD watches

2025-10-03 Thread Daniel P . Berrangé via Devel
On Fri, Oct 03, 2025 at 02:58:59PM +0200, Peter Krempa wrote: > On Fri, Oct 03, 2025 at 13:43:31 +0100, Daniel P. Berrangé via Devel wrote: > > From: Daniel P. Berrangé > > > > The virEventAddHandle/Timeout APIs are unusual in that they do not > > report errors on

[PATCH] src: report error from failing to add timer/FD watches

2025-10-03 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé The virEventAddHandle/Timeout APIs are unusual in that they do not report errors on failure, because they call through to function callbacks which might be provided externally to libvirt and thus won't be using libvirt's error reporting APIs. This i

Re: [PATCH] spec: fix build with `%define with_qemu 0`

2025-10-03 Thread Daniel P . Berrangé via Devel
On Wed, Oct 01, 2025 at 02:26:53PM -0400, Cole Robinson via Devel wrote: > test_libvirt_sanlock.aug is dependent on WITH_QEMU in meson config > > Signed-off-by: Cole Robinson > --- > libvirt.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This looks like a duplicate of the bug I

Re: [PATCH] rpc: fix race against dtrace probe generator

2025-10-02 Thread Daniel P . Berrangé via Devel
On Thu, Oct 02, 2025 at 02:19:28PM +0100, Daniel P. Berrangé wrote: > From: Daniel P. Berrangé > > The virt_socket_lib library has a dep on dtrace_gen_headers, but > the virprobe.h file (which includes the libvirt_probes.h) is also > used from virnetserverclient.c and virkeepaliv

[PATCH] rpm: disable sanlock when QEMU is disabled

2025-10-02 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé The meson.build rules skip sanlock when QEMU is disabled, so the RPM must not try to create the -sanlock sub-RPM. Signed-off-by: Daniel P. Berrangé --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b

[PATCH] rpc: fix race against dtrace probe generator

2025-10-02 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé The virt_socket_lib library has a dep on dtrace_gen_headers, but the virprobe.h file (which includes the libvirt_probes.h) is also used from virnetserverclient.c and virkeepalive.c files which do not directly depend on virt_socket_lib. Thus it is possible for the latter

Re: [PATCH v3 7/8] tests: Add domaincaps and qemucaps case for mshv

2025-10-01 Thread Daniel P . Berrangé via Devel
1.0-q35.x86_64+mshv.xml > create mode 100644 tests/domaincapsdata/qemu_10.1.0-tcg.x86_64+mshv.xml > create mode 100644 tests/domaincapsdata/qemu_10.1.0.x86_64+mshv.xml > create mode 100644 tests/qemucaps2xmloutdata/caps.x86_64+mshv.xml Reviewed-by: Daniel P. Berrangé With regards,

Re: [PATCH v3 6/8] tests: Add mshv variant for qemucapabilitiestest

2025-10-01 Thread Daniel P . Berrangé via Devel
| 46912 > .../caps_10.1.0_x86_64+mshv.xml | 4996 ++ > 3 files changed, 51913 insertions(+) > create mode 100644 tests/qemucapabilitiesdata/caps_10.1.0_x86_64+mshv.replies > create mode 100644 tests/qemucapabilitiesdata/caps_10.1.0_x86_64+mshv.xml Reviewed

Re: [PATCH v3 8/8] tests: add mshv test to qemuxmlconftest

2025-10-01 Thread Daniel P . Berrangé via Devel
hv-x86_64-q35-headless.x86_64-latest+mshv.args > create mode 100644 > tests/qemuxmlconfdata/mshv-x86_64-q35-headless.x86_64-latest+mshv.xml > create mode 100644 > tests/qemuxmlconfdata/mshv-x86_64-q35-headless.x86_64-latest.err > create mode 100644 tests/qemuxmlconfdata/mshv-x86_6

Re: [PATCH v3 2/8] qemu: use mshv accel for hyperv domains

2025-10-01 Thread Daniel P . Berrangé via Devel
On Fri, Aug 29, 2025 at 03:28:32PM -0500, Praveen K Paladugu wrote: > Add mshv acceleration (-accel mshv) flag to hyperv domains > > Signed-off-by: Praveen K Paladugu > --- > src/qemu/qemu_command.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by:

Re: [PATCH v3 5/8] conf: update capability schema

2025-10-01 Thread Daniel P . Berrangé via Devel
On Fri, Aug 29, 2025 at 03:28:35PM -0500, Praveen K Paladugu wrote: > Update capability schema to include support for hyperv hypervisor with > qemu domains. > > Signed-off-by: Praveen K Paladugu > --- > src/conf/schemas/capability.rng | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src

[PATCH v4 07/23] util: add API to fetch the current thread name

2025-09-27 Thread Daniel P . Berrangé via Devel
when using qemu_thread_create. Signed-off-by: Daniel P. Berrangé --- include/qemu/thread.h| 1 + meson.build | 21 + util/qemu-thread-posix.c | 33 ++- util/qemu-thread-win32.c | 49 4 files changed

[PATCH v4 03/23] system: unconditionally enable thread naming

2025-09-25 Thread Daniel P . Berrangé via Devel
default, which will improve ability to triage QEMU bugs. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Richard Henderson Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrangé --- docs/about/deprecated.rst | 7 +++ include/qemu/thread.h | 1 - system/vl.

[PATCH v4 04/23] util: expose qemu_thread_set_name

2025-09-25 Thread Daniel P . Berrangé via Devel
The ability to set the thread name needs to be used in a number of places, so expose the current impls as public methods. Reviewed-by: Richard Henderson Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- include/qemu/thread.h| 1 + util/qemu-thread-posix.c | 26

[PATCH v4 12/23] monitor: refactor error_vprintf()

2025-09-25 Thread Daniel P . Berrangé via Devel
The monitor_vprintf() code will return -1 if either the monitor is NULL, or the monitor is QMP. The error_vprintf() code can take advantage of this to avoid having to duplicate the same checks, and instead simply look at the return value. Signed-off-by: Daniel P. Berrangé --- monitor/monitor.c

[PATCH v4 05/23] audio: make jackaudio use qemu_thread_set_name

2025-09-25 Thread Daniel P . Berrangé via Devel
: Daniel P. Berrangé --- audio/jackaudio.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/audio/jackaudio.c b/audio/jackaudio.c index 974a3caad3..69dce3f302 100644 --- a/audio/jackaudio.c +++ b/audio/jackaudio.c @@ -629,18 +629,36 @@ static void

Re: [PATCH v4 00/23] util: sync error_report & qemu_log output more closely

2025-09-25 Thread Daniel P . Berrangé via Devel
On Thu, Sep 25, 2025 at 12:22:39PM +0200, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 25/9/25 11:44, Daniel P. Berrangé wrote: > > This series is a tangent that came out of discussion in > > > > https://lists.nongnu.org/archive/html/qemu-devel/2025-08/msg0090

[PATCH v4 23/23] util: add brackets around guest name in message context

2025-09-25 Thread Daniel P . Berrangé via Devel
lename=ca-cert.pem path= [fish food] qemu-system-x86_64: (1144713:main): Unable to access credentials fish/ca-cert.pem: No such file or directory Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- util/message.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v4 22/23] util: add support for formatting thread info in messages

2025-09-25 Thread Daniel P . Berrangé via Devel
ctory Signed-off-by: Daniel P. Berrangé --- include/qemu/message.h | 1 + storage-daemon/qemu-storage-daemon.c | 6 ++ system/vl.c | 8 ++-- tests/qemu-iotests/041 | 2 +- tests/qemu-iotests/common.filter | 2 +- util/message.c

[PATCH v4 20/23] util: add support for formatting a workload name in messages

2025-09-25 Thread Daniel P . Berrangé via Devel
x509 load creds=0x55b3af3fd870 dir=fish blah qcrypto_tls_creds_get_path TLS creds path creds=0x55b3af3fd870 filename=ca-cert.pem path= blah qemu-system-x86_64: Unable to access credentials fish/ca-cert.pem: No such file or directory Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Be

[PATCH v4 19/23] util: convert error-report & log to message API for timestamp

2025-09-25 Thread Daniel P . Berrangé via Devel
no change in output format for either logs or errors with this conversion. There is a slight impact on logging code in that recording the timestamp is now potentially delayed by the need to acquire the logging mutex. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- include/

[PATCH v4 15/23] util: don't skip error prefixes when QMP is active

2025-09-25 Thread Daniel P . Berrangé via Devel
The vreport() function will print to HMP if available, otherwise to stderr. In the event that vreport() is called during execution of a QMP command, it will print to stderr, but mistakenly omit the message prefixes (timestamp, guest name, program name). Signed-off-by: Daniel P. Berrangé

[PATCH v4 13/23] monitor: move error_vprintf back to error-report.c

2025-09-25 Thread Daniel P . Berrangé via Devel
. Signed-off-by: Daniel P. Berrangé --- monitor/monitor.c| 15 --- stubs/error-printf.c | 18 -- stubs/meson.build| 1 - stubs/monitor-core.c | 14 +- util/error-report.c | 15 +++ 5 files changed, 28 insertions(+), 35 deletions(-) delete

[PATCH v4 11/23] monitor: remove redundant error_[v]printf_unless_qmp

2025-09-25 Thread Daniel P . Berrangé via Devel
These functions only had one caller which was easily converted to the normal error_printf() function. Remove them as they don't add sufficient value. Reviewed-by: Richard Henderson Reviewed-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Ber

[PATCH v4 16/23] util: fix interleaving of error & trace output

2025-09-25 Thread Daniel P . Berrangé via Devel
-cert.pem: No such file or directory Signed-off-by: Daniel P. Berrangé --- util/error-report.c | 67 +++-- 1 file changed, 46 insertions(+), 21 deletions(-) diff --git a/util/error-report.c b/util/error-report.c index 872158ad90..222c40d0d1 100644 --- a/util

[PATCH v4 09/23] util: introduce some API docs for logging APIs

2025-09-25 Thread Daniel P . Berrangé via Devel
qemu_log_trylock() must be discouraged because it prevents the inclusion of configured log message prefixes. Reported-by: Markus Armbruster Signed-off-by: Daniel P. Berrangé --- include/qemu/log-for-trace.h | 35 ++- include/qemu/log.h | 26

[PATCH v4 06/23] util: set the name for the 'main' thread

2025-09-25 Thread Daniel P . Berrangé via Devel
Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- util/qemu-thread-posix.c | 6 ++ util/qemu-thread-win32.c | 6 ++ 2 files changed, 12 insertions(+) diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c index b1c127dbe3..afeac9ecad 100644 --- a

[PATCH v4 02/23] monitor: initialize global data from a constructor

2025-09-25 Thread Daniel P . Berrangé via Devel
guaranteed that the process is fully initialized and so not all normal QEMU API rules apply. Reviewed-by: Richard Henderson Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Markus Armbruster Fixes: e69ee454b5f9 (monitor: Make current monitor a per-coroutine property) Signed-off-by: Daniel P

Re: [PATCH v2 19/27] configure: set the meson executable suffix/ext

2025-09-24 Thread Daniel P . Berrangé via Devel
+++- > 1 file changed, 13 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https

Re: [PATCH v2 11/27] build-sys: cfi_debug and safe_stack are not compatible

2025-09-24 Thread Daniel P . Berrangé via Devel
r_internal_memset+0x0): > first defined here > > cfi_debug seems to pull ubsan which has conflicting symbols with safe_stack. > > See also: https://bugzilla.redhat.com/show_bug.cgi?id=2397265 > > Signed-off-by: Marc-André Lureau > --- > meson.build | 3

Re: [PATCH 3/8] conf: Add nodeset attribute to the element

2025-09-20 Thread Daniel P . Berrangé via Devel
-off-by: Andrea Righi > --- > src/conf/device_conf.h| 3 +++ > src/conf/domain_conf.c| 30 -- > src/conf/schemas/domaincommon.rng | 5 + > 3 files changed, 36 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Be

[PATCH] conf: clear the acpiNodeset field after freeing

2025-09-20 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé The virDomainDeviceInfoClear method does not free the struct, only its contents, so all pointer fields must be explicitly set to NULL after releasing to avoid disk of double-free. Reported by coverity: *** CID 895678: Memory - corruptions (USE_AFTER_FREE

Re: [libvirt-python PATCH] build: Adapt to PEP 625 distribution file naming

2025-09-20 Thread Daniel P . Berrangé via Devel
On Wed, Sep 10, 2025 at 02:04:39PM +0200, Jiri Denemark via Devel wrote: > The version of setuptools shipped by Fedora 42 is PEP 625 compliant, > which requires distribution files to contain a normalized package name. > Thus the generated tarball is called libvirt_python-$VER.tar.gz rather > than l

Re: [PATCH v6 0/8] qemu: acpi-generic-initiator support

2025-09-20 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:08:55PM +0200, Andrea Righi wrote: > = Overview = > > This patch set introduces support for acpi-generic-initiator devices, > supported by QEMU [1]. > > The acpi-generic-initiator object is required to support Multi-Instance GPU > (MIG) configurations on NVIDIA GPUs [2]

Re: [PATCH 7/8] docs: Document acpi nodeset in hostdev

2025-09-17 Thread Daniel P . Berrangé via Devel
+++ > 1 file changed, 49 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: htt

Re: [PATCH 5/8] qemu: Generate acpi-generic-initiator command from acpi nodeset

2025-09-17 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:09:00PM +0200, Andrea Righi wrote: > Signed-off-by: Andrea Righi > --- > src/qemu/qemu_command.c | 45 + > 1 file changed, 45 insertions(+) Reviewed-by: Daniel P. Berrangé > > diff --git a/src/qemu/qemu_co

Re: [PATCH 4/8] qemu: Validate acpi nodeset

2025-09-11 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:08:59PM +0200, Andrea Righi wrote: > Signed-off-by: Andrea Righi > --- > src/qemu/qemu_validate.c | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://ww

Re: [PATCH 1/8] qemu: capabilies: Introduce QEMU_CAPS_ACPI_GENERIC_INITIATOR

2025-09-11 Thread Daniel P . Berrangé via Devel
| 1 + > tests/qemucapabilitiesdata/caps_9.2.0_x86_64+amdsev.xml| 1 + > tests/qemucapabilitiesdata/caps_9.2.0_x86_64.xml | 1 + > 14 files changed, 15 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH] conf: clear the acpiNodeset field after freeing

2025-09-09 Thread Daniel P . Berrangé via Devel
On Tue, Sep 09, 2025 at 11:36:42AM +0200, Peter Krempa wrote: > On Tue, Sep 09, 2025 at 10:28:33 +0100, Daniel P. Berrangé via Devel wrote: > > From: Daniel P. Berrangé > > > > The virDomainDeviceInfoClear method does not free the struct, only > > its contents, so

Re: [PATCH 3/8] conf: Add nodeset attribute to the element

2025-09-08 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:08:58PM +0200, Andrea Righi wrote: > This enables partitioning of PCI devices into multiple isolated > instances, each requiring a dedicated virtual NUMA node definition. > > Link: https://mail.gnu.org/archive/html/qemu-arm/2024-03/msg00358.html > Signed-off-by: Andrea R

Re: [PATCH 7/8] docs: Document acpi nodeset in hostdev

2025-09-08 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:09:02PM +0200, Andrea Righi wrote: > Add documentation for the new element in hostdev, > which allows associating devices with ACPI Generic Initiator objects in > QEMU. > > A typical use case is NVIDIA Multi-Instance GPU (MIG), where a physical > GPU is partitioned into

Re: [PATCH 5/8] qemu: Generate acpi-generic-initiator command from acpi nodeset

2025-09-08 Thread Daniel P . Berrangé via Devel
On Mon, Sep 08, 2025 at 07:15:18PM +0200, Andrea Righi wrote: > Hi Daniel, > > On Mon, Sep 08, 2025 at 06:02:20PM +0100, Daniel P. Berrangé wrote: > > On Sat, Sep 06, 2025 at 03:09:00PM +0200, Andrea Righi wrote: > > > Signed-off-by: Andrea Righi > > > --- &g

Re: [PATCH 8/8] NEWS: Mention new acpi-generic-initiator support

2025-09-08 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:09:03PM +0200, Andrea Righi wrote: > Signed-off-by: Andrea Righi > --- > NEWS.rst | 10 ++ > 1 file changed, 10 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flick

Re: [PATCH 6/8] qemu: Add acpi-generic-initiator unit test

2025-09-08 Thread Daniel P . Berrangé via Devel
iator.x86_64-latest.xml > create mode 100644 tests/qemuxmlconfdata/acpi-generic-initiator.xml Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138

Re: [PATCH 2/8] qemu: Allow to define NUMA nodes without memory or CPUs assigned

2025-09-08 Thread Daniel P . Berrangé via Devel
independent and not be shared with > other resources, such as CPU or memory. > > Signed-off-by: Andrea Righi > --- > src/conf/numa_conf.c| 3 +++ > src/qemu/qemu_command.c | 19 --- > 2 files changed, 15 insertions(+), 7 deletions(-) Reviewed-by: Daniel

Re: [PATCH] util: virHostCPUGetStatsLinux: support VIR_NODE_CPU_STATS_GUEST

2025-09-01 Thread Daniel P . Berrangé via Devel
On Thu, Aug 28, 2025 at 10:29:41AM +0200, Claudio Fontana wrote: > it is very useful for platforms to know how much time a node is > spending running guests. > > Signed-off-by: Claudio Fontana > --- > include/libvirt/libvirt-host.h | 10 > src/test/test_driver.c

Re: [PATCH 1/2] api: remote: introduce virDomainBlockRebase2 API

2025-08-29 Thread Daniel P . Berrangé via Devel
On Fri, Aug 29, 2025 at 10:55:29AM +0300, Nikolai Barybin via Devel wrote: > This new API is a combination of virDomainBlockPull and > virDomainBlockRebase (without copy mode) which supports extendable > list of virTypedParameterPtr params. > > It is designed to allow more configurable use of unde

Re: [RFC PATCH 2/5] conf: Support multiple smmuv3Dev IOMMU devices

2025-08-27 Thread Daniel P . Berrangé via Devel
On Thu, Aug 14, 2025 at 07:54:11PM -0700, Nathan Chen via Devel wrote: > Add support for parsing multiple IOMMU devices from > the VM definition when "smmuv3Dev" is the IOMMU model. > > Signed-off-by: Nathan Chen > --- > src/conf/domain_conf.c| 153 ++ > s

Re: [RFC PATCH 3/5] qemu: Implement support for associating iommufd to hostdev

2025-08-27 Thread Daniel P . Berrangé via Devel
On Thu, Aug 14, 2025 at 07:54:12PM -0700, Nathan Chen via Devel wrote: > Implement iommufdId attribute for hostdev devices that > can be used to specify associated iommufd object when > launching a qemu VM. > > Signed-off-by: Nathan Chen > --- > docs/formatdomain.rst | 9 + >

Re: [RFC PATCH 0/5] cover letter: qemu: Implement support for iommufd and multiple vSMMUs

2025-08-27 Thread Daniel P . Berrangé via Devel
On Thu, Aug 14, 2025 at 07:54:09PM -0700, Nathan Chen via Devel wrote: > Hi, > > This is a follow up to the second RFC patchset [0] for supporting multiple > vSMMU instances and using iommufd to propagate DMA mappings to kernel for > VM-assigned host devices in a qemu VM. > > This patchset implem

Re: [PATCH v5 0/6] qemu: acpi-generic-initiator support

2025-08-27 Thread Daniel P . Berrangé via Devel
On Wed, Aug 06, 2025 at 02:42:10PM +0200, Andrea Righi via Devel wrote: > = Overview = > > This patch set introduces support for acpi-generic-initiator devices, > supported by QEMU [1]. > > The acpi-generic-initiator object is required to support Multi-Instance GPU > (MIG) configurations on NVIDI

FYI: Planned list outage Mon 25th Aug from 10:00 JST

2025-08-20 Thread Daniel P . Berrangé via Devel
We have a planned outage of the libvirt.org mailing lists on Monday 25th August. The outage is anticipated to begin at approx 10:00 JST (Japan), and all going well, should last no more than a couple hours. There will be various cosmetic changes to the lists.libvirt.org web interface after the upg

Re: [PATCH 4/4] qemu_cgroup: add /dev/mshv to default devices

2025-08-20 Thread Daniel P . Berrangé via Devel
On Thu, Aug 07, 2025 at 03:48:43PM -0500, Praveen K Paladugu wrote: > From: Praveen K Paladugu > > Add /dev/mshv to default set of devices to pass to domain cgroup. > > Signed-off-by: Praveen K Paladugu > Signed-off-by: Praveen K Paladugu > --- > src/qemu/qemu_cgroup.c | 2 +- > 1 file change

Re: [PATCH 4/4] qemu_cgroup: add /dev/mshv to default devices

2025-08-20 Thread Daniel P . Berrangé via Devel
group.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangl

Re: [PATCH 3/4] qemu: use mshv accel for hyperv domains

2025-08-20 Thread Daniel P . Berrangé via Devel
4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé nb, this patch & the next ought to be /before/ patch 2, as the patch 2 changes will unlock the ability for users to specify type=hyperv in XML which will then be broken until this patch & next pa

Re: [PATCH 2/4] qemu: probe mshv capabilities

2025-08-20 Thread Daniel P . Berrangé via Devel
On Thu, Aug 07, 2025 at 03:48:41PM -0500, Praveen K Paladugu wrote: > From: Praveen K Paladugu > > Probe mshv capabilities from qemu with QMP commands. > > Signed-off-by: Praveen K Paladugu > Signed-off-by: Praveen K Paladugu > --- > src/qemu/qemu_capabilities.c | 31 -

Re: [PATCH 1/4] qemu: introduce mshv capabilities

2025-08-20 Thread Daniel P . Berrangé via Devel
+++--- > src/qemu/qemu_capabilities.h | 1 + > 2 files changed, 38 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [PATCH v1 0/2] docs/tlscerts: minor improvements for TLS setup

2025-08-20 Thread Daniel P . Berrangé via Devel
ey' > > docs/kbase/tlscerts.rst | 42 + > 1 file changed, 38 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé and pushed to git. With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|

Re: [PATCH 05/12] util: add API to fetch the current thread id

2025-08-20 Thread Daniel P . Berrangé via Devel
On Tue, Aug 19, 2025 at 11:35:26PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > For logging it is useful to include the current thread id. On > > POSIX there is no standard API for this, so try the Linux gettid() > > syscall pref

Re: [PATCH 04/12] util: set the name for the 'main' thread

2025-08-20 Thread Daniel P . Berrangé via Devel
On Tue, Aug 19, 2025 at 11:18:00PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > The default main thread name is undefined, so use a constructor to > > explicitly set it to 'main'. This constructor is marked to run early

[PATCH 01/12] include: define constant for early constructor priority

2025-08-19 Thread Daniel P . Berrangé via Devel
default constructors. This is to be used for QEMU constructors that are themselves self-contained, but may be relied upon by other constructors. Signed-off-by: Daniel P. Berrangé --- include/qemu/compiler.h | 8 1 file changed, 8 insertions(+) diff --git a/include/qemu/compiler.h b

[PATCH 12/12] util: add brackets around guest name in message context

2025-08-19 Thread Daniel P . Berrangé via Devel
ca-cert.pem path= [fish food] qemu-system-x86_64(1144713:main): Unable to access credentials fish/ca-cert.pem: No such file or directory Signed-off-by: Daniel P. Berrangé --- util/message.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/util/message.c b/util/messag

[PATCH 11/12] util: add support for formatting thread info in messages

2025-08-19 Thread Daniel P . Berrangé via Devel
_x509_load TLS creds x509 load creds=0x560db818e080 dir=fish qemu-system-x86_64(772366:main): qcrypto_tls_creds_get_path TLS creds path creds=0x560db818e080 filename=ca-cert.pem path= qemu-system-x86_64(772366:main): Unable to access credentials fish/ca-cert.pem: No such file or directory Sig

[PATCH 10/12] util: add support for formatting a program name in messages

2025-08-19 Thread Daniel P . Berrangé via Devel
s path creds=0x5584e13937f0 filename=ca-cert.pem path= qemu-system-x86_64: Unable to access credentials fish/ca-cert.pem: No such file or directory Signed-off-by: Daniel P. Berrangé --- include/qemu/message.h | 1 + system/vl.c| 2 +- tests/unit/test-error-

[PATCH 09/12] util: add support for formatting a workload name in messages

2025-08-19 Thread Daniel P . Berrangé via Devel
x509 load creds=0x55b3af3fd870 dir=fish blah qcrypto_tls_creds_get_path TLS creds path creds=0x55b3af3fd870 filename=ca-cert.pem path= blah qemu-system-x86_64: Unable to access credentials fish/ca-cert.pem: No such file or directory Signed-off-by: Daniel P. Berrangé --- include/qemu/error-r

[PATCH 08/12] util: convert error-report & log to message API for timestamp

2025-08-19 Thread Daniel P . Berrangé via Devel
no change in output format for either logs or errors with this conversion. Signed-off-by: Daniel P. Berrangé --- include/qemu/error-report.h| 1 - system/vl.c| 7 ++- tests/unit/test-error-report.c | 3 ++- util/error-report.c| 18 +++---

[PATCH 07/12] util: introduce common helper for error-report & log code

2025-08-19 Thread Daniel P . Berrangé via Devel
timestamp, but future patches will expand this. This takes the liberty of assigning the new file to the same maintainer as the existing error-report.c file, given it will be extracting some functionality from the latter. Signed-off-by: Daniel P. Berrangé --- MAINTAINERS| 2

[PATCH 06/12] util: add API to fetch the current thread name

2025-08-19 Thread Daniel P . Berrangé via Devel
This will be used to include the thread name in error reports in a later patch. It returns a const string stored in a thread local to avoid memory allocation on POSIX platforms, at the cost of having to store an allocated string pointer on Windows. Signed-off-by: Daniel P. Berrangé --- include

[PATCH 05/12] util: add API to fetch the current thread id

2025-08-19 Thread Daniel P . Berrangé via Devel
For logging it is useful to include the current thread id. On POSIX there is no standard API for this, so try the Linux gettid() syscall preferentially, otherwise fallback to casting the result of thread_self() to an integer. Signed-off-by: Daniel P. Berrangé --- include/qemu/thread.h| 1

[PATCH 04/12] util: set the name for the 'main' thread

2025-08-19 Thread Daniel P . Berrangé via Devel
The default main thread name is undefined, so use a constructor to explicitly set it to 'main'. This constructor is marked to run early as the thread name is intended to be used in error reporting / logs which may be triggered very early in QEMU execution. Signed-off-by: Daniel P

[PATCH 03/12] system: unconditionally enable thread naming

2025-08-19 Thread Daniel P . Berrangé via Devel
default, which will improve ability to triage QEMU bugs. Signed-off-by: Daniel P. Berrangé --- docs/about/deprecated.rst | 7 +++ include/qemu/thread.h | 1 - system/vl.c | 11 ++- util/qemu-thread-posix.c | 18 +- util/qemu-

[PATCH 02/12] monitor: initialize global data from a constructor

2025-08-19 Thread Daniel P . Berrangé via Devel
gger error reporting. Note in particular that the RCU constructor will spawn a background thread so we might even have non-constructor QEMU code running concurrently with other constructors. Signed-off-by: Daniel P. Berrangé --- monitor/monitor.c | 14 +- 1 file changed, 9 insert

[PATCH 00/12] util: sync error_report & qemu_log output more closely

2025-08-19 Thread Daniel P . Berrangé via Devel
those same CLI args. I'm not too happy with the constructor priority logic, but I don't see a better option, as I don't think it is practical to order .o files passed to the linker in a way that nicely guarantees the order of constructor execution. Daniel P. Berrangé (12): include

Re: [PATCH] spec: Package newly introduced CH conf files

2025-08-19 Thread Daniel P . Berrangé via Devel
rpmbuild. Just put > those files into daemon-driver-ch rpm. > > Fixes: 5dca0567f694a7405ca3e796149aed857b1f6090 > Signed-off-by: Michal Privoznik > --- > libvirt.spec.in | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel

Re: [PATCH v2 00/11] Enabling logging for ch guests

2025-08-18 Thread Daniel P . Berrangé via Devel
On Mon, Aug 18, 2025 at 10:53:09AM -0500, Praveen Paladugu wrote: > Daniel, > > The log files are actually created under /var/log/libvirt/ch/ > sub-directory. Seems like > I made a typo in my previous email. > > /var/log/libvirt/ch/ch_.log is the logfile name. Ok, adding the 'ch_' prefix to the

Re: [PATCH v2 00/11] Enabling logging for ch guests

2025-08-18 Thread Daniel P . Berrangé via Devel
On Mon, Aug 18, 2025 at 09:58:32AM -0500, Praveen Paladugu wrote: > Hey Michal, > > Thanks for the follow up. I noticed the new patchset. The new patchset > builds on top of the one I sent. > > My patchset enables support for capturing logs from ch domains to > the standard libvirt path at /var/l

Re: [PATCH] docs: kbase/tlscerts: mention dropped 'encryption_key'

2025-08-12 Thread Daniel P . Berrangé via Devel
On Mon, Aug 04, 2025 at 06:31:14PM +0200, Sebastian Mitterle via Devel wrote: > Older libvirt versions still only work if 'encryption_key' is enabled > in the server and client certificates. Add a note. > > While at it, also add a note that after setting the certificates up, > the TLS ports need t

Re: [PATCH] docs: kbase/tlscerts: mention dropped 'encryption_key'

2025-08-12 Thread Daniel P . Berrangé via Devel
On Wed, Aug 06, 2025 at 12:39:34PM +0200, Sebastian Mitterle wrote: > On Tue, Aug 5, 2025 at 1:54 PM Daniel P. Berrangé wrote: > > > > On Mon, Aug 04, 2025 at 06:31:14PM +0200, Sebastian Mitterle via Devel > > wrote: > > > Older libvirt versions still only work

Re: [PATCH] qemu: don't warn about missing SMM for CVM firmware

2025-08-12 Thread Daniel P . Berrangé via Devel
On Tue, Aug 05, 2025 at 08:54:02AM -0500, Andrea Bolognani wrote: > On Thu, Jul 31, 2025 at 07:33:21PM +0100, Daniel P. Berrangé via Devel wrote: > > +++ b/src/qemu/qemu_firmware.c > > @@ -1540,6 +1540,7 @@ qemuFirmwareSanityCheck(const qemuFirmware *fw, > > boo

Re: [PATCH] Storage: ZFS: implement `resizeVol` method to support native resize

2025-08-12 Thread Daniel P . Berrangé via Devel
e_requests/495 > > Signed-off-by: George Melikov > --- > src/storage/storage_backend_zfs.c | 20 ++++++++ > 1 file changed, 20 insertions(+) Reviewed-by: Daniel P. Berrangé and pushed to git. With regards, Daniel -- |: https://berrange.com -o-https://www.

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Daniel P . Berrangé via Devel
On Mon, Aug 04, 2025 at 02:15:01PM -0600, Jim Fehlig wrote: > On 8/4/25 05:31, Andrea Bolognani wrote: > > On Fri, Aug 01, 2025 at 11:39:45AM -0600, Jim Fehlig via Devel wrote: > > > With this addition, the correct firmware is detected, but it's not > > > properly > > > provided to qemu > > > > >

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Daniel P . Berrangé via Devel
On Tue, Aug 05, 2025 at 01:18:12AM -0700, Andrea Bolognani wrote: > On Tue, Aug 05, 2025 at 08:08:14AM +0100, Daniel P. Berrangé wrote: > > On Mon, Aug 04, 2025 at 02:15:01PM -0600, Jim Fehlig wrote: > > > On 8/4/25 05:31, Andrea Bolognani wrote: > > > > On Fri, Au

[PATCH] ci: regenerate with 'lcitool manifest'

2025-08-04 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé This pulls in the fix for libxen which has been removed from armv7 in Debian sid. Signed-off-by: Daniel P. Berrangé --- Pending: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/537 ci/buildenv/debian-sid-cross-armv7l.sh | 1 - ci/containers/debian

Re: [PATCH v2 0/2] Introduce hardware UUID (hwuuid) element

2025-08-01 Thread Daniel P . Berrangé via Devel
On Fri, Aug 01, 2025 at 10:19:11AM +0100, Mark Cave-Ayland wrote: > On 18/07/2025 09:44, Mark Cave-Ayland wrote: > > > Following on from the discussions at [1] and more recently [2], this series > > introduces a new hardware UUID (hwuuid) element that allows an external > > UUID to be provided to

[PATCH] qemu: don't warn about missing SMM for CVM firmware

2025-07-31 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Neither Intel TDX / AMD SEV(SNP) allow use of SMM, but the EDK2 firmware none the less supports secureboot. Libvirt currently issues bogus warnings about Fedora firmware warning : qemuFirmwareSanityCheck:1575 : Firmware description '/usr/share/qemu/firmware/60

Re: [PATCH] conf: add support for 'edid' attribute to video model

2025-07-31 Thread Daniel P . Berrangé via Devel
On Thu, Jul 31, 2025 at 10:50:40AM +0100, Mark Cave-Ayland wrote: > Add the ability to enable/disable exposing the EDID information to the guest. > This allows migration from legacy machine types that have EDID disabled to a > newer machine type without any change becoming visible to the guest. Co

Re: [PATCH v4 20/23] qemu: Bypass sending VIR_DOMAIN_EVENT_RESUMED event when TD VM reboot

2025-07-31 Thread Daniel P . Berrangé via Devel
edShutdown and bypass the event for TD VM, for > >normal VM, domain is in run state and already bypassing it. > > > >Signed-off-by: Zhenzhong Duan > >Reviewed-by: Daniel P. Berrangé > >--- > > src/qemu/qemu_process.c | 8 +--- > > 1 file changed, 5 insert

Re: [PATCH] NEWS: document bhyve changes for the release

2025-07-30 Thread Daniel P . Berrangé via Devel
On Fri, Jul 25, 2025 at 07:33:40PM +0200, Roman Bogorodskiy wrote: > Signed-off-by: Roman Bogorodskiy > --- > NEWS.rst | 19 +++ > 1 file changed, 19 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com

Re: Question about SEV* guests and automatic firmware selection

2025-07-30 Thread Daniel P . Berrangé via Devel
On Tue, Jul 29, 2025 at 03:28:49PM -0600, Jim Fehlig wrote: > On 5/13/25 14:25, Jim Fehlig wrote: > > On 4/24/25 14:18, Jim Fehlig wrote: > > > On 4/24/25 04:59, Daniel P. Berrangé wrote: > > > > On Mon, Apr 21, 2025 at 01:38:35PM -0600, Jim Fehlig via

Re: [PATCH 0/2] qemu: Match firmware with fully resolved and canonicalized paths

2025-07-29 Thread Daniel P . Berrangé via Devel
On Tue, Jul 29, 2025 at 01:02:18PM +0200, Peter Krempa via Devel wrote: > On Tue, Jul 29, 2025 at 10:42:09 +0200, Michal Prívozník via Devel wrote: > > On 7/24/25 15:49, James Le Cuirot wrote: > > > From: James Le Cuirot > > > > > > Distros may provide compatibility symlinks after moving firmware

[PATCH] include: fix version for VIR_CONNECT_BASELINE_CPU_IGNORE_HOST

2025-07-28 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Signed-off-by: Daniel P. Berrangé --- include/libvirt/libvirt-host.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h index 19043235b2..8922d00e0c 100644 --- a/include/libvirt/libvirt

Re: Entering freeze for libvirt-11.6.0

2025-07-28 Thread Daniel P . Berrangé via Devel
On Mon, Jul 28, 2025 at 11:13:22AM +0200, Jiri Denemark via Announce wrote: > I have just tagged v11.6.0-rc1 in the repository and pushed signed > tarballs to https://download.libvirt.org/ > > Please give the release candidate some testing and in case you find a > serious issue which should have a

[PATCH] include: s/RECREATION/RECREATED/ in domain event names

2025-07-28 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé New event reasons were added in commit 1af740c5012bb45dfe96c77bcd6b20c28b6bb45d Author: Zhenzhong Duan Date: Thu Jul 10 03:21:21 2025 -0400 qemu: Send event VIR_DOMAIN_EVENT_[STOPPED|STARTED] during recreation but the naming did not match existing reason

Re: [RFC] x86 Host CPU features detection by MSRs

2025-07-25 Thread Daniel P . Berrangé via Devel
On Fri, Jul 25, 2025 at 01:45:51PM +0200, Hector Cao wrote: > > > > > > > > > What do you think of this design: > > > > > 1) Create a file msr.conf inside src/util/modules-load.d/ > > > > > 2) Modify src/util/meson.build to install this file to > > /etc/modules-load.d/ > > > > > > > > > > Optional:

Re: [RFC] x86 Host CPU features detection by MSRs

2025-07-25 Thread Daniel P . Berrangé via Devel
On Fri, Jul 25, 2025 at 04:30:40AM -0700, Andrea Bolognani wrote: > On Fri, Jul 25, 2025 at 11:10:15AM +0100, Daniel P. Berrangé wrote: > > On Fri, Jul 25, 2025 at 11:46:54AM +0200, Hector Cao wrote: > > > What do you think of this design: > > > 1) Create a file msr.c

Re: [PATCH v4 00/23] LIBVIRT: X86: TDX support

2025-07-25 Thread Daniel P . Berrangé via Devel
On Thu, Jul 10, 2025 at 05:22:15PM +0100, Daniel P. Berrangé via Devel wrote: > FYI, QEMU soft freeze is next week, and rc0 release > is Jul 22nd. I proposed we merge this series once > the QEMU rc0 release is out, so this is likely ready > for the libvirt August 1st release. I hav

Re: [RFC] x86 Host CPU features detection by MSRs

2025-07-25 Thread Daniel P . Berrangé via Devel
On Fri, Jul 25, 2025 at 11:46:54AM +0200, Hector Cao wrote: > On Fri, Jul 25, 2025 at 11:22 AM Daniel P. Berrangé > wrote: > > > On Wed, Jul 23, 2025 at 08:15:25PM +0200, Hector Cao wrote: > > > On Wed, Jul 9, 2025 at 12:01 PM Daniel P. Berrangé > > > wrote: &

Re: [RFC] x86 Host CPU features detection by MSRs

2025-07-25 Thread Daniel P . Berrangé via Devel
On Wed, Jul 23, 2025 at 08:15:25PM +0200, Hector Cao wrote: > On Wed, Jul 9, 2025 at 12:01 PM Daniel P. Berrangé > wrote: > > > On Wed, Jul 09, 2025 at 05:58:03AM -0400, Andrea Bolognani wrote: > > > On Wed, Jul 09, 2025 at 09:53:40AM +0100, Daniel P. Berrangé via Devel &

  1   2   3   4   5   6   7   8   9   10   >