Re: [PATCH v5 1/5] docs: domain: document deprecated_features attribute

2025-07-14 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 6/30/25 05:19, Collin Walling wrote: Provide documentation for the deprecated_features XML attribute. Available since 11.0.0, and supported for S390. Signed-off-by: Collin Walling --- docs/formatdomain.rst | 8 1 file changed, 8 insertions

Re: [PATCH v5 5/5] qemu: add default_cpu_deprecated_features configuration option

2025-07-02 Thread Boris Fiuczynski
On 7/2/25 12:20, Daniel P. Berrangé via Devel wrote: On Wed, Jul 02, 2025 at 12:05:45PM +0200, Boris Fiuczynski wrote: On 7/1/25 18:35, Daniel P. Berrangé via Devel wrote: On Tue, Jul 01, 2025 at 03:58:02PM +0200, Boris Fiuczynski wrote: On 7/1/25 10:46, Daniel P. Berrangé via Devel wrote

Re: [PATCH v5 5/5] qemu: add default_cpu_deprecated_features configuration option

2025-07-02 Thread Boris Fiuczynski
On 7/1/25 18:35, Daniel P. Berrangé via Devel wrote: On Tue, Jul 01, 2025 at 03:58:02PM +0200, Boris Fiuczynski wrote: On 7/1/25 10:46, Daniel P. Berrangé via Devel wrote: On Sun, Jun 29, 2025 at 11:19:30PM -0400, Collin Walling wrote: From: Boris Fiuczynski Allow to define the default for

Re: [PATCH v5 5/5] qemu: add default_cpu_deprecated_features configuration option

2025-07-01 Thread Boris Fiuczynski
On 7/1/25 10:46, Daniel P. Berrangé via Devel wrote: On Sun, Jun 29, 2025 at 11:19:30PM -0400, Collin Walling wrote: From: Boris Fiuczynski Allow to define the default for deprecated_features when the attribute is not set in the cpu defintion of a domain XML. If these features are still

[PATCH] nodedev: add nodedev name to mdevctl unsupport msg

2025-06-06 Thread Boris Fiuczynski
Let's add the nodedev name to improve the error message for the user. Signed-off-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_d

Re: [PATCH v3 3/3] qemu: process: disable deprecated features for s390 models by default

2025-05-26 Thread Boris Fiuczynski
not include guaranties how a CPU model is expanded and therefore this change does not break the guest ABI. -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Wolfgang Wendt Geschäftsführung: David Faller Si

Re: [PATCH v3 3/3] qemu: process: disable deprecated features for s390 models by default

2025-05-22 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 5/22/25 08:03, Collin Walling wrote: To ease the user with defining a guest with a migratable CPU model, let's disable the deprecated features from the get-go. If these features are still desired, they may be reenabled via the deprecated_feature

Re: [PATCH v3 2/3] qemu: process: refactor deprecated features code

2025-05-22 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 5/22/25 08:03, Collin Walling wrote: Group up the deprecated features code into a single block to keep things clean; only check if the deprecated_features attribute is present once and then do relevent work. Signed-off-by: Collin Walling --- src/qemu

Re: [PATCH v3 1/3] qemu: caps: add virCPUFeaturePolicy param to virQEMUCapsUpdateCPUDeprecatedFeatures

2025-05-22 Thread Boris Fiuczynski
Besides the nit below Reviewed-by: Boris Fiuczynski On 5/22/25 08:03, Collin Walling wrote: Currently, virQEMUCapsUpdateCPUDeprecatedFeatures only allows for disabling deprecated features. This locks the deprecated_features attribute to only do something if set to 'off'. L

Re: [PATCH v1 2/2] qemu: caps: disable deprecated features for s390 models by default

2025-05-19 Thread Boris Fiuczynski
xpd=on,esop=on,msa9_pckmo=on,vxeh2=on,esort=on,appv=on,apqi=on,apft=on,els=on,iep=on,appvi=on,apqci=on,cte=on,ais=on,bpb=on,ctop=on,gs=on,ppa15=on,zpci=on,rdp=on,sea_esop2=on,beareh=on,te=on,cmm=on,vxpdeh2=on \ +-cpu gen16a-base,nnpa=on,aen=on,cmmnt=on,vxpdeh=on,aefsi=on,diag318=on,csske=off,mepoch=on,msa9=on,msa8=on,msa7=on,msa6=on,msa5=on,msa4=on,msa3=on,msa2=on,msa1=on,sthyi=on,edat=on,ri=on,deflate=on,edat2=on,etoken=on,vx=on,ipter=on,pai=on,paie=on,mepochptff=on,ap=on,vxeh=on,vxpd=on,esop=on,msa9_pckmo=on,vxeh2=on,esort=on,appv=on,apqi=on,apft=on,els=on,iep=on,appvi=on,apqci=on,cte=off,ais=on,bpb=off,ctop=on,gs=on,ppa15=on,zpci=on,rdp=on,sea_esop2=on,beareh=on,te=off,cmm=on,vxpdeh2=on \ -m size=262144k \ -object '{"qom-type":"memory-backend-ram","id":"s390.ram","size":268435456}' \ -overcommit mem-lock=off \ -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Wolfgang Wendt Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

Re: [PATCH v1 1/2] qemu: caps: add virCPUFeaturePolicy param to virQEMUCapsUpdateCPUDeprecatedFeatures

2025-05-16 Thread Boris Fiuczynski
def->cpu, policy); } There are no tests with deprecated_features='on'. Could you please add some before doing this change. I would also suggest to separate the code refactoring from code changes introducing an alternative behavior.

Re: [PATCH] NEWS: Mention fix for 'qemu-rdp' error being logged

2025-04-09 Thread Boris Fiuczynski
With the nits fixed Reviewed-by: Boris Fiuczynski On 4/8/25 16:53, Peter Krempa via Devel wrote: From: Peter Krempa Add the news entry stating that it's safe to ignore the error. Signed-off-by: Peter Krempa --- NEWS.rst | 10 ++ 1 file changed, 10 insertions(+) diff --

Re: [PATCH] qemu: rdp: Fix 'qemuRdpAvailable()'

2025-04-08 Thread Boris Fiuczynski
0e3b8a0ba6a3a8c8d Closes:https://gitlab.com/libvirt/libvirt/-/issues/763 Signed-off-by: Peter Krempa Reviewed-by: Boris Fiuczynski -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Wolfgang Wendt Gesch

[PATCH] NEWS: hotplug virtio-mem device

2025-04-05 Thread Boris Fiuczynski
Signed-off-by: Boris Fiuczynski --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 484333e55a..1de0231c57 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -56,6 +56,12 @@ v11.2.0 (unreleased) * **Bug fixes** + * qemu: attach virtio-mem with CCW address

[PATCH] NEWS: Mention virsh hypervisor-cpu-models command

2025-03-25 Thread Boris Fiuczynski
Signed-off-by: Boris Fiuczynski --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 1fc80e2496..18d45656b8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -67,6 +67,14 @@ v11.2.0 (unreleased) restore. Using multiple channels can reduce the time

[PATCH v2] qemu_domain_address: fix CCW virtio-mem hotplug

2025-03-18 Thread Boris Fiuczynski
type CCW. Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_domain_address.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index d38983bf63..5b94c27679 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu

Re: [PATCH] qemu_domain_address: fix CCW virtio-mem hotplug

2025-03-18 Thread Boris Fiuczynski
On 3/18/25 13:00, Martin Kletzander via Devel wrote: On Tue, Mar 18, 2025 at 09:53:22AM +0100, Boris Fiuczynski wrote: Since commit f23f8ff91a virtio-mem supports also CCW. When hotplugging a virtio-mem device with a CCW address results in a PCI device getting attached. The method

[PATCH] qemu_domain_address: fix CCW virtio-mem hotplug

2025-03-18 Thread Boris Fiuczynski
type CCW. Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_domain_address.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index d38983bf63..b0289c2337 100644 --- a/src/qemu/qemu_domain_address.c

Re: [PATCH 2/3] tests: add capabilities for QEMU 9.2.0 on s390x

2025-03-11 Thread Boris Fiuczynski
On 3/7/25 15:57, Peter Krempa wrote: On Thu, Nov 07, 2024 at 17:44:05 +0100, Boris Fiuczynski wrote: On 11/7/24 17:19, Peter Krempa wrote: On Wed, Nov 06, 2024 at 15:31:56 +0100, Boris Fiuczynski wrote: Let us introduce the xml and reply files for QEMU 9.2.0 on s390x. [...] Additionally

[PATCH] NEWS: Document ccwgroup based qeth device support

2025-02-13 Thread Boris Fiuczynski
Signed-off-by: Boris Fiuczynski --- NEWS.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 7dc6a3fa37..4fc8a3bba0 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -31,6 +31,17 @@ v11.1.0 (unreleased) * **New features** + * nodedev: Support ccwgroup based

[PATCH] node_device_udev: add error reporting to udevProcessCCWGroup

2025-02-06 Thread Boris Fiuczynski
Add reporting an internal error when the string to type conversion of devtype fails as this indicates a serious problem since devtype was used to get into this method during the udev event handling. Signed-off-by: Boris Fiuczynski --- src/node_device/node_device_udev.c | 6 +- 1 file

Re: [PATCH 0/8] nodedev: add support for ccwgroup based qeth devices

2025-02-06 Thread Boris Fiuczynski
On 2/5/25 18:01, Michal Prívozník wrote: On 2/4/25 18:11, Boris Fiuczynski wrote: CCW group devices are devices that use multiple subchannels on the mainframe's channel subsystem. A qeth group device maps to subchannels and their corresponding device numbers and device bus-IDs. The qeth d

Re: [PATCH 6/8] nodedev: add ccwgroup node device support

2025-02-06 Thread Boris Fiuczynski
On 2/5/25 19:37, Peter Krempa wrote: On Tue, Feb 04, 2025 at 18:11:41 +0100, Boris Fiuczynski wrote: Add ccwgroup node device type supporting qeth generic driver. Signed-off-by: Boris Fiuczynski --- docs/manpages/virsh.rst | 6 +- include/libvirt/libvirt-nodedev.h

[PATCH 6/8] nodedev: add ccwgroup node device support

2025-02-04 Thread Boris Fiuczynski
Add ccwgroup node device type supporting qeth generic driver. Signed-off-by: Boris Fiuczynski --- docs/manpages/virsh.rst | 6 +- include/libvirt/libvirt-nodedev.h | 1 + src/conf/node_device_conf.c | 212 ++ src/conf

[PATCH 2/8] nodedev: refactor CCW device address

2025-02-04 Thread Boris Fiuczynski
Replace cssid, ssid and devno elements with virCCWDeviceAddress. Reviewed-by: Marc Hartmayer Signed-off-by: Boris Fiuczynski --- src/conf/node_device_conf.c | 16 ++-- src/conf/node_device_conf.h | 4 +--- src/node_device/node_device_driver.c | 11

[PATCH 5/8] nodedev: refactor udevCCWGetState

2025-02-04 Thread Boris Fiuczynski
Refactor method to be only ccw state type depended to allow reuse in a later patch. Reviewed-by: Marc Hartmayer Signed-off-by: Boris Fiuczynski --- src/node_device/node_device_udev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/node_device/node_device_udev.c

[PATCH 1/8] nodedev: refactor CCW device address format

2025-02-04 Thread Boris Fiuczynski
Refactor for reuse in the following patch. Reviewed-by: Marc Hartmayer Signed-off-by: Boris Fiuczynski --- src/conf/node_device_conf.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index

[PATCH 7/8] nodedev: add ccwgroup capability support to ccw devices

2025-02-04 Thread Boris Fiuczynski
Add the group membership information to a CCW device. Allow to filter CCW devices based on a group membership. Signed-off-by: Boris Fiuczynski --- docs/manpages/virsh.rst | 19 ++-- include/libvirt/libvirt-nodedev.h | 1 + src/conf/node_device_conf.c

[PATCH 8/8] nodedev: add qeth layer2 and layer3 device types

2025-02-04 Thread Boris Fiuczynski
Signed-off-by: Boris Fiuczynski --- src/conf/node_device_conf.c| 8 src/conf/node_device_conf.h| 2 ++ src/conf/schemas/nodedev.rng | 6 +- src/node_device/node_device_udev.c | 6 +- 4 files changed, 20 insertions(+), 2 deletions(-) diff --git a/src/conf

[PATCH 3/8] nodedev: remove virNodeDeviceCapCCWDefFormat

2025-02-04 Thread Boris Fiuczynski
Directly use virCCWDeviceAddressFormat. Reviewed-by: Marc Hartmayer Signed-off-by: Boris Fiuczynski --- src/conf/node_device_conf.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 85effb7d78

[PATCH 0/8] nodedev: add support for ccwgroup based qeth devices

2025-02-04 Thread Boris Fiuczynski
mbers. Boris Fiuczynski (8): nodedev: refactor CCW device address format nodedev: refactor CCW device address nodedev: remove virNodeDeviceCapCCWDefFormat nodedev: refactor CCW state format for use in ccwgroup nodedev: refactor udevCCWGetState nodedev: add ccwgroup node device support no

[PATCH 4/8] nodedev: refactor CCW state format for use in ccwgroup

2025-02-04 Thread Boris Fiuczynski
Refactor to allow reuse in ccwgroup. Reviewed-by: Marc Hartmayer Signed-off-by: Boris Fiuczynski --- src/conf/node_device_conf.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 44511f

Re: [PATCH v2 0/8] Enable virtio-mem-ccw

2025-02-04 Thread Boris Fiuczynski
On 2/4/25 11:04, David Hildenbrand wrote: On 04.02.25 10:57, Boris Fiuczynski wrote: On 2/4/25 10:06, David Hildenbrand wrote: On 03.02.25 10:55, Michal Privoznik wrote: v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/ thread/KA2DGRIY7DAMNMYM4MBKLOJCB7YYEUKU/ I

Re: [PATCH v2 0/8] Enable virtio-mem-ccw

2025-02-04 Thread Boris Fiuczynski
t providing the element block an error occurs: error: block size must be a power of two When providing the element block the required minimum value is 1024KiB. -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsr

Re: [PATCH v2 7/8] qemuxmlconftest: Introduce memory-hotplug-virtio-mem-ccw-s390x.xml

2025-02-03 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 2/3/25 10:55, Michal Privoznik wrote: This is similar to emuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.xml except the explicit placement of virtio-mem onto a PCI bus is removed. This results in virtio-mem being placed onto CCW "bus" this dem

Re: [PATCH v2 3/8] qemuxmlconftest: Introduce memory-hotplug-virtio-mem-pci-s390x.xml

2025-02-03 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 2/3/25 10:55, Michal Privoznik wrote: As of v9.2.0-1413-gd77ae821e8 QEMU supports virtio-mem-pci on s390 too. Let's add a test case for that. Signed-off-by: Michal Privoznik --- ...lug-virtio-mem-pci-s390x.s390x-latest.args | 41 +++ ...plug-v

Re: [PATCH 3/8] qemuxmlconftest: Introduce memory-hotplug-virtio-mem-s390x.xml

2025-01-27 Thread Boris Fiuczynski
On 1/27/25 15:34, Michal Prívozník wrote: On 1/27/25 13:42, Boris Fiuczynski wrote: On 1/24/25 13:21, Michal Privoznik wrote: This is an example test for virtio-mem on s390. Currently, both virtio-mem devices are placed onto PCI bus, but this will soon change and the test will be updated

Re: [PATCH 1/8] qemu: Do NOT autoadd NUMA node for s390

2025-01-27 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 1/24/25 13:21, Michal Privoznik wrote: In some cases, we might automatically add a NUMA node. But this doesn't work for s390 really, because in its commit v2.12.0-rc0~41^2~6 QEMU forbade specifying NUMA nodes for s390. Suppress automatic adding of NUMA no

Re: [PATCH 8/8] NEWS: Document virtio-mem-ccw

2025-01-27 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 1/24/25 13:21, Michal Privoznik wrote: Signed-off-by: Michal Privoznik --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 5d742df705..3156c18ed0 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -26,6 +26,11 @@ v11.1.0

Re: [PATCH 6/8] qemu: Allow virtio-mem on CCW

2025-01-27 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 1/24/25 13:21, Michal Privoznik wrote: After previous commits, we can allow virtio-mem to live on CCW channel. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu

Re: [PATCH 5/8] qemu: Validate virtio-mem-ccw

2025-01-27 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 1/24/25 13:21, Michal Privoznik wrote: There are basically two differences between virtio-mem-ccw and virtio-mem-pci. s390 doesn't allow mixing different page sizes and there's no NUMA support in QEMU. Signed-off-by: Michal Privoznik ---

Re: [PATCH 4/8] qemu_caps: Introduce QEMU_CAPS_DEVICE_VIRTIO_MEM_CCW

2025-01-27 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 1/24/25 13:21, Michal Privoznik wrote: This capability tracks whether QEMU supports virtio-mem-ccw device. Introduced in QEMU commit v9.2.0-492-gaa910c20ec only upcoming release of QEMU supports the device. Signed-off-by: Michal Privoznik --- src/qemu

Re: [PATCH 3/8] qemuxmlconftest: Introduce memory-hotplug-virtio-mem-s390x.xml

2025-01-27 Thread Boris Fiuczynski
ly is because of recorded tests/qemucapabilitiesdata/caps_10.0.0_s390x.replies file of qemu v9.2.0-1203-gd6430c17d7. -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Wolfgang Wendt Geschäftsführung: Dav

Re: [PATCH 2/8] qemu_command: Use qemuBuildVirtioDevProps() to build cmd line for virtio-mem and virtio-pmem

2025-01-27 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 1/24/25 13:21, Michal Privoznik wrote: Both, virtio-mem and virtio-pmem devices follow traditional QEMU naming convention: their suffix determines what bus they live on. For instance, virtio-mem-pci, virtio-mem-ccw, virtio-pmem-pci. We already have a function

Re: [PATCH 7/8] qemuxmlconftest: Update memory-hotplug-virtio-mem-s390x.xml

2025-01-27 Thread Boris Fiuczynski
. Should that be fixed? -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Wolfgang Wendt Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

Re: [PATCH v2 2/2] tests: qemucapabilities: Add test data for the qemu-9.2 dev cycle on s390x

2025-01-20 Thread Boris Fiuczynski
ed as "not support" and causes the changes in the eight *.args files. I recommend to perform the probing with a host running in an LPAR to prevent the args files unnecessarily being changed. I can lend you a hand with it if required. -- Mit freundlichen Grüßen/Kind regards B

Re: [PATCH v2 1/2] qemuxmlconftest: Drop s390-default-cpu-...ccw-virtio-2.7 test cases

2025-01-20 Thread Boris Fiuczynski
tests/qemuxmlconfdata/s390-default-cpu-tcg-ccw-virtio-2.7.s390x-latest.xml delete mode 100644 tests/qemuxmlconfdata/s390-default-cpu-tcg-ccw-virtio-2.7.xml Reviewed-by: Boris Fiuczynski -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitz

[PATCH 3/4] qemu_driver: Implement qemuConnectGetHypervisorCPUModelNames

2025-01-15 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_driver.c | 59 ++ 1 file changed, 59 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d2eddbd9ae..1a795cebd0 100644 --- a/src/qemu/qemu_driver.c

[PATCH 1/4] libvirt: Introduce virConnectGetHypervisorCPUModelNames public API

2025-01-15 Thread Boris Fiuczynski
: Collin Walling Reviewed-by: Boris Fiuczynski Signed-off-by: Boris Fiuczynski --- include/libvirt/libvirt-host.h | 7 src/driver-hypervisor.h| 10 ++ src/libvirt-host.c | 65 ++ src/libvirt_public.syms| 5 +++ 4 files changed, 87

[PATCH 4/4] virsh: Introduce new hypervisor-cpu-models command

2025-01-15 Thread Boris Fiuczynski
From: David Judkovics Add new virsh 'host' group command 'hypervisor-cpu-models' to virsh. Signed-off-by: David Judkovics Reviewed-by: Boris Fiuczynski Signed-off-by: Boris Fiuczynski --- docs/manpages/virsh.rst | 20 +++ tools/vi

[PATCH 2/4] remote: Implement virConnectGetHypervisorCPUModelNames

2025-01-15 Thread Boris Fiuczynski
From: David Judkovics Adding access to virConnectGetHypervisorCPUModelNames running on a remote machine. Signed-off-by: David Judkovics Reviewed-by: Boris Fiuczynski Signed-off-by: Boris Fiuczynski --- src/remote/remote_daemon_dispatch.c | 62 + src/remote

[PATCH 0/4] Implement virsh hypervisor-cpu-models

2025-01-15 Thread Boris Fiuczynski
Allows for the query of hypervisor-known CPU models via the simple command: virsh hypervisor-cpu-models. For the QEMU driver, the models are queried via the capabilities file. Each model is printed to the terminal on its own line similar to the cpu-models command, and there is no order to the listi

Re: [PATCH] qemu_capabilities: Avoid memleak in virQEMUCapsProbeFullDeprecatedProperties()

2024-12-18 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 12/18/24 16:31, Michal Privoznik wrote: As one of its arguments, the virQEMUCapsProbeFullDeprecatedProperties() gets a pointer to GStrv (a string list), which it may eventually replace. It's single caller (virQEMUCapsProbeQMPHostCPU()) passes a string

Re: [PATCH v2 2/5] qemu: parse deprecated-props from query-cpu-model-expansion response

2024-11-26 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 11/25/24 20:46, Collin Walling wrote: query-cpu-model-expansion may report an array of deprecated properties. This array is optional, and may not be supported for a particular architecture or reported for a particular CPU model. If the output is present, then

Re: [PATCH v2 5/5] conf: add deprecated_features attribute

2024-11-26 Thread Boris Fiuczynski
a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index bee7a39e4e..c06ca1a833 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6399,6 +6399,10 @@ qemuProcessUpdateGuestCPU(virDomainDef *def, &def->os.arch) < 0) return -1; +if (d

Re: [PATCH v2 4/5] virsh: add --disable-deprecated-features flag to domcapabilities

2024-11-26 Thread Boris Fiuczynski
On 11/26/24 16:14, Boris Fiuczynski wrote: Reviewed-by: Boris Fiuczynski On 11/25/24 20:46, Collin Walling wrote: Add a new flag, --disable-deprecated-features, to the domcapabilities command.  This will modify the output to show the 'host-model' CPU with features flagged as depreca

Re: [PATCH v2 3/5] qemu_capabilities: query deprecated features for host-model

2024-11-26 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 11/25/24 20:46, Collin Walling wrote: Add QEMU_CAPS_QUERY_CPU_MODEL_EXPANSION_DEPRECATED_PROPS for detecting if query-cpu-model-expansion can report deprecated CPU model properties. QEMU introduced this capability in 9.1 release. Add flag and deprecated

Re: [PATCH v2 1/5] qemuMonitorJSONGetCPUModelExpansion: refactor parsing functions

2024-11-26 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 11/25/24 20:46, Collin Walling wrote: Refactor the CPU Model parsing functions within qemuMonitorJSONGetCPUModelExpansion. The new functions, qemuMonitorJSONParseCPUModelExpansionData and qemuMonitorJSONParseCPUModelExpansion invoke the functions they replace

Re: [PATCH v2 0/4] Full boot order support on s390x

2024-11-11 Thread Boris Fiuczynski
On 11/11/24 12:23, Peter Krempa wrote: On Mon, Nov 11, 2024 at 05:57:13 -0500, Andrea Bolognani wrote: On Mon, Nov 11, 2024 at 10:14:46AM +0100, Peter Krempa wrote: On Fri, Nov 08, 2024 at 13:16:33 +0100, Boris Fiuczynski wrote: Boris Fiuczynski (4): qemu: capabilities: Add

Re: [PATCH v2 2/4] tests: add capabilities for QEMU 9.2.0 on s390x

2024-11-11 Thread Boris Fiuczynski
On 11/11/24 10:13, Peter Krempa wrote: On Fri, Nov 08, 2024 at 13:16:35 +0100, Boris Fiuczynski wrote: Let us introduce the xml and reply files for QEMU 9.2.0 on s390x. A QEMU at commit https://github.com/qemu/qemu/commit/11b8920ed2 was used to generate this data. I'll change this t

Re: [PATCH v2 0/4] Full boot order support on s390x

2024-11-11 Thread Boris Fiuczynski
On 11/11/24 10:14, Peter Krempa wrote: On Fri, Nov 08, 2024 at 13:16:33 +0100, Boris Fiuczynski wrote: This series adds on s390x full boot order support which has been introduced recently in QEMU with the PR https://lore.kernel.org/qemu-devel/20241023131710.906748-1-th...@redhat.com/ Changes

[PATCH v2 1/4] qemu: capabilities: Add QEMU_CAPS_VIRTIO_CCW_DEVICE_LOADPARM

2024-11-08 Thread Boris Fiuczynski
Add capability QEMU_CAPS_VIRTIO_CCW_DEVICE_LOADPARM to detect multi boot device support in QEMU by checking the virtio-blk-ccw device property existence of loadparm. Signed-off-by: Boris Fiuczynski Reviewed-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 8 + src/qemu

[PATCH v2 3/4] qemu: command: add multi boot device support on s390x

2024-11-08 Thread Boris Fiuczynski
If QEMU supports multi boot device make use of it instead of using the single boot device machine parameter. Signed-off-by: Boris Fiuczynski Reviewed-by: Peter Krempa --- src/qemu/qemu_command.c | 36 ++--- src/qemu/qemu_command.h | 6

[PATCH v2 0/4] Full boot order support on s390x

2024-11-08 Thread Boris Fiuczynski
s and xml files are removed from patch 2 in this series and are available in https://gitlab.com/fiuczy/libvirt/-/commits/fullbootorder Boris Fiuczynski (4): qemu: capabilities: Add QEMU_CAPS_VIRTIO_CCW_DEVICE_LOADPARM tests: add capabilities for QEMU 9.2.0 on s390x qemu: command: add multi

[PATCH v2 2/4] tests: add capabilities for QEMU 9.2.0 on s390x

2024-11-08 Thread Boris Fiuczynski
Let us introduce the xml and reply files for QEMU 9.2.0 on s390x. A QEMU at commit https://github.com/qemu/qemu/commit/11b8920ed2 was used to generate this data. Signed-off-by: Shalini Chellathurai Saroja Signed-off-by: Boris Fiuczynski --- tests/domaincapsdata/qemu_9.2.0.s390x.xml

[PATCH v2 4/4] NEWS: qemu: add multi boot device support on s390x

2024-11-08 Thread Boris Fiuczynski
Signed-off-by: Boris Fiuczynski --- NEWS.rst | 16 1 file changed, 16 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 34028d59aa..b79f1d0245 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,22 @@ v10.10.0 (unreleased) * **New features** + * qemu: add multi boot

Re: [PATCH 2/3] tests: add capabilities for QEMU 9.2.0 on s390x

2024-11-07 Thread Boris Fiuczynski
On 11/7/24 17:19, Peter Krempa wrote: On Wed, Nov 06, 2024 at 15:31:56 +0100, Boris Fiuczynski wrote: Let us introduce the xml and reply files for QEMU 9.2.0 on s390x. qemu-9.2 is not yet out ... Signed-off-by: Shalini Chellathurai Saroja Signed-off-by: Boris Fiuczynski --- tests

Re: [PATCH 3/3] qemu: command: add multi boot device support on s390x

2024-11-07 Thread Boris Fiuczynski
On 11/7/24 15:53, Peter Krempa wrote: On Wed, Nov 06, 2024 at 15:31:57 +0100, Boris Fiuczynski wrote: If QEMU supports multi boot device make use of it instead of using the single boot device machine parameter. Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_command.c

[PATCH 3/3] qemu: command: add multi boot device support on s390x

2024-11-06 Thread Boris Fiuczynski
If QEMU supports multi boot device make use of it instead of using the single boot device machine parameter. Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_command.c | 40 --- src/qemu/qemu_command.h | 6 ++- src/qemu/qemu_hotplug.c

[PATCH 1/3] qemu: capabilities: Add QEMU_CAPS_VIRTIO_CCW_DEVICE_LOADPARM

2024-11-06 Thread Boris Fiuczynski
Add capability QEMU_CAPS_VIRTIO_CCW_DEVICE_LOADPARM to detect multi boot device support in QEMU by checking the virtio-blk-ccw device property existence of loadparm. Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_capabilities.c | 8 + src/qemu/qemu_capabilities.h

[PATCH 2/3] tests: add capabilities for QEMU 9.2.0 on s390x

2024-11-06 Thread Boris Fiuczynski
Let us introduce the xml and reply files for QEMU 9.2.0 on s390x. Signed-off-by: Shalini Chellathurai Saroja Signed-off-by: Boris Fiuczynski --- tests/domaincapsdata/qemu_9.2.0.s390x.xml | 311 + .../caps_9.2.0_s390x.replies | 36741

[PATCH 0/3] Full boot order support on s390x

2024-11-06 Thread Boris Fiuczynski
/libvirt/-/commits/fullbootorder Boris Fiuczynski (3): qemu: capabilities: Add QEMU_CAPS_VIRTIO_CCW_DEVICE_LOADPARM tests: add capabilities for QEMU 9.2.0 on s390x qemu: command: add multi boot device support on s390x src/qemu/qemu_capabilities.c | 8 + src/qemu

Re: [PATCH v1] tests: add capabilities for QEMU 9.1.0 on s390x

2024-10-25 Thread Boris Fiuczynski
On 10/24/24 19:00, Jiri Denemark wrote: On Wed, Oct 23, 2024 at 11:48:14 +0200, Boris Fiuczynski wrote: On 10/18/24 13:37, Shalini Chellathurai Saroja wrote: Let us introduce the xml and reply files for QEMU 9.1.0 on s390x. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by:Boris

Re: [PATCH v1] tests: add capabilities for QEMU 9.1.0 on s390x

2024-10-23 Thread Boris Fiuczynski
/shalinichellathurai/libvirt/-/ commit/9352fc34fcdb9921eaf1abe51c204a4db79e2672 Ping. Would be nice if this update makes it into the 10.9.0 release. -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Wolfgang W

[PATCH] tests: Fix typo in README.rst of qemucapabilitiesdata

2024-09-16 Thread Boris Fiuczynski
Signed-off-by: Boris Fiuczynski --- tests/qemucapabilitiesdata/README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemucapabilitiesdata/README.rst b/tests/qemucapabilitiesdata/README.rst index 727695c6b0..f65f07cfca 100644 --- a/tests/qemucapabilitiesdata

Re: [PATCH v2 2/2] qemuxmlconftest: Add tests for the ACPI stripping hack on s390

2024-08-02 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski and tested. On 8/1/24 3:52 PM, Peter Krempa wrote: Replace the 'misc-acpi' case by testing a bunch of architectures for how ACPI is handled including a test for the s390 ACPI strip hack added in previous commit. The input files are adapted from the cor

Re: [PATCH v2 1/2] qemu_domain: Strip from s390(x) definitions

2024-08-02 Thread Boris Fiuczynski
muDomainDefACPIPostParse(def, qemuCaps, parseFlags); + if (qemuDomainDefBootPostParse(def, driver, parseFlags) < 0) return -1; Anyway Reviewed-by: Boris Fiuczynski -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender

Re: [PATCH 1/2] qemu_domain: Strip from s390(x) definitions

2024-07-31 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 7/31/24 1:02 PM, Peter Krempa wrote: The s390(x) machines never supported ACPI. That didn't stop users enabling ACPI in their config. As of libvirt-9.2 (98c4e3d073) with new enough qemu we reject configs which require ACPI, but qemu can't satisfy

Re: [PATCH 2/2] qemuxmlconftest: Add tests for the ACPI stripping hack on s390

2024-07-31 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 7/31/24 1:02 PM, Peter Krempa wrote: Replace the 'misc-acpi' case by testing a bunch of architectures for how ACPI is handled including a test for the s390 ACPI strip hack added in previous commit. Signed-off-by: Peter Krempa --- .../aar

[PATCH] qemu_domain: tolerate ACPI feature on S390

2024-07-31 Thread Boris Fiuczynski
was silently tolerated. To allow migration from libvirt versions prior 9.1.0 which allowed the ACPI feature to be used on S390 tolerate ACPI by setting it to absent if specified and QEMU does not support it. Resolves: https://issues.redhat.com/browse/RHEL-49516 Signed-off-by: Boris Fiuczynski

Re: [PATCH] NEWS: Document features/improvements/bug fixes I've participated in

2024-07-30 Thread Boris Fiuczynski
s: Be more forgiving when decoding OEM strings + +On some systems, OEM strings are scattered in multiple sections. This +confused libvirt when generating capabilities XML. Not anymore. + v10.5.0 (2024-07-01) -- Mit freundlichen Grüßen/Kind regards Boris Fi

Re: [PATCH v3] qemu: add a monitor to /proc/$pid when killing times out

2024-07-23 Thread Boris Fiuczynski
On 7/22/24 2:01 PM, Jiri Denemark wrote: On Mon, Jul 22, 2024 at 10:55:05 +0200, Michal Prívozník wrote: On 7/19/24 17:44, Boris Fiuczynski wrote: In cases when a QEMU process takes longer than the time sigterm and sigkill are issued to kill the process do not simply fail and leave the VM in

Re: [PATCH v3] qemu: add a monitor to /proc/$pid when killing times out

2024-07-22 Thread Boris Fiuczynski
On 7/22/24 10:55 AM, Michal Prívozník wrote: On 7/19/24 17:44, Boris Fiuczynski wrote: In cases when a QEMU process takes longer than the time sigterm and sigkill are issued to kill the process do not simply fail and leave the VM in state VIR_DOMAIN_SHUTDOWN until the daemon stops. Instead set

Re: [PATCH v2] qemu: add a monitor to /proc/$pid when killing times out

2024-07-19 Thread Boris Fiuczynski
yscall() fro that matter. Ups, I forgot about that. Sending a v3 out. -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Wolfgang Wendt Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

[PATCH v3] qemu: add a monitor to /proc/$pid when killing times out

2024-07-19 Thread Boris Fiuczynski
cleanup the VM state. Resolves: https://issues.redhat.com/browse/RHEL-28819 Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_domain.c | 8 +++ src/qemu/qemu_domain.h | 2 + src/qemu/qemu_driver.c | 18 ++ src/qemu/qemu_process.c | 124 ++-- src/qemu

[PATCH v2] qemu: add a monitor to /proc/$pid when killing times out

2024-07-19 Thread Boris Fiuczynski
cleanup the VM state. Resolves: https://issues.redhat.com/browse/RHEL-28819 Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_domain.c | 8 +++ src/qemu/qemu_domain.h | 2 + src/qemu/qemu_driver.c | 18 +++ src/qemu/qemu_process.c | 115 ++-- src/qemu

[PATCH] qemu: add a monitor to /proc/$pid when killing times out

2024-07-17 Thread Boris Fiuczynski
cleanup the VM state. Resolves: https://issues.redhat.com/browse/RHEL-28819 Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_domain.c | 8 +++ src/qemu/qemu_domain.h | 2 + src/qemu/qemu_driver.c | 18 ++ src/qemu/qemu_process.c | 127 ++-- src/qemu

Re: [PATCH] NEWS: Document features/improvements/bug fixes I've participated in

2024-06-28 Thread Boris Fiuczynski
with this change. Thanks for adding this to the news update. -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Wolfgang Wendt Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen Registergerich

Re: [PATCH 0/4] nodedev: adjust handling DASDs

2024-06-20 Thread Boris Fiuczynski
On 6/20/24 9:41 AM, Michal Prívozník wrote: On 6/19/24 14:29, Boris Fiuczynski wrote: Adjusting how DASDs are handled as recently ID_* tags are also included in the udev information which causes the problems reported by https://issues.redhat.com/browse/RHEL-39497 Removing the filtering of

Re: [PATCH 0/4] nodedev: adjust handling DASDs

2024-06-19 Thread Boris Fiuczynski
Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Wolfgang Wendt Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

[PATCH 2/4] nodedev: improve DASD detection

2024-06-19 Thread Boris Fiuczynski
object consistency and not end up with multiple node objects for DASDs. Resolves: https://issues.redhat.com/browse/RHEL-39497 Reviewed-by: Marc Hartmayer Signed-off-by: Boris Fiuczynski --- src/node_device/node_device_udev.c | 4 1 file changed, 4 insertions(+) diff --git a/src/node_device

[PATCH 3/4] nodedev: prevent invalid DASD node object creation

2024-06-19 Thread Boris Fiuczynski
Prevent the creation of a new DASD node object when the device does not exist. Resolves: https://issues.redhat.com/browse/RHEL-39497 Reviewed-by: Marc Hartmayer Signed-off-by: Boris Fiuczynski --- src/node_device/node_device_udev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src

[PATCH 0/4] nodedev: adjust handling DASDs

2024-06-19 Thread Boris Fiuczynski
online again. The state information is made available in the ccw capability as an optional state element. Boris Fiuczynski (4): nodedev: refactor storage type fixup nodedev: improve DASD detection nodedev: prevent invalid DASD node object creation nodedev: add ccw device state and remove

[PATCH 4/4] nodedev: add ccw device state and remove fencing

2024-06-19 Thread Boris Fiuczynski
Instead of fencing offline ccw devices add the state to the ccw capability. Resolves: https://issues.redhat.com/browse/RHEL-39497 Signed-off-by: Boris Fiuczynski --- src/conf/node_device_conf.c| 24 src/conf/node_device_conf.h| 11 +++ src/conf

[PATCH 1/4] nodedev: refactor storage type fixup

2024-06-19 Thread Boris Fiuczynski
Refactor the storage type fixup into a reusable method. Reviewed-by: Marc Hartmayer Signed-off-by: Boris Fiuczynski --- src/node_device/node_device_udev.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/src/node_device/node_device_udev.c b/src

Re: [PATCH v2 00/20] node_dev_udev: use workerpool and improve nodedev events

2024-06-18 Thread Boris Fiuczynski
someone to push his series. Seems like patches 2, 3 and 20 are missing your rb or did Marc forget to add them? @Marc, could you send a rebased v3 since it seems the series no longer cleanly applies on master. -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research

Re: [PATCH v2 20/20] node_device_udev: remove incorrect G_GNUC_UNUSED

2024-06-18 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 4/23/24 8:09 PM, Marc Hartmayer wrote: Signed-off-by: Marc Hartmayer --- src/node_device/node_device_udev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index

Re: [PATCH v5 3/3] test: nodedev: fill active_config at driver startup time

2024-04-24 Thread Boris Fiuczynski
Cole, thanks for fixing the problem in test_driver caused by my changes. Reviewed-by: Boris Fiuczynski On 4/23/24 15:44, Cole Robinson wrote: Commit v10.0.0-265-ge67bca23e4 added a `active_config` and `defined_config` to nodedev mdev internal XML handling. `defined_config` can be filled at

Re: [PATCH v5 2/3] test: Sync GetXML INACTIVE behavior with live driver

2024-04-24 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 4/23/24 15:44, Cole Robinson wrote: - Error if INACTIVE requested for transient object - Force dumping INACTIVE XML when object is inactive Signed-off-by: Cole Robinson --- src/test/test_driver.c | 17 - 1 file changed, 16 insertions(+), 1

Re: [PATCH v5 1/3] test: make parsed nodedevs active and persistent

2024-04-24 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 4/23/24 15:44, Cole Robinson wrote: This was the implied default before nodedevs gained a notion of being inactive and transient. It also matches the implied default when parsing other object types Signed-off-by: Cole Robinson --- src/test/test_driver.c | 2

  1   2   3   >