Re: [PATCH 1/7] cpu: : virCPUx86DataAddItem() to void

2024-01-05 Thread Artem Chernyshev
> On 1/4/24 01:16, Artem Chernyshev wrote: > > It doesn't really fix anything. The code is not broken. > > True, just mentioned commit which I addressed in my patch > > No. This changes semantics. Prior to your change, if > qemuMonitorJSONParseCPUx86FeatureWo

Re: [PATCH 00/10] Subject: [PATCH 00/10] Code cleanup

2024-01-05 Thread Artem Chernyshev
ping ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH 0/7] Code cleanup 2

2024-01-04 Thread Artem Chernyshev
Thank you and sorry for those miss-alignments with coding style. Could you check my first submission as well? https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/DCOUUBC2V7WR2HXDBKYQ4E3JOJP7E2MC/ Artem ___ Devel mailing list -- devel

[PATCH 7/7] node_device: udevGetStringSysfsAttr() to void

2024-01-03 Thread Artem Chernyshev
udevGetStringSysfsAttr() return value is invariant, so change it type and remove all dependent checks. Fixes: 7f1f0453fc ("node_device: use g_strdup instead of VIR_STRDUP") Signed-off-by: Artem Chernyshev --- src/node_device/node_device_udev.c | 55 +---

[PATCH 5/7] virprocess: virProcessGetNamespaces() to void

2024-01-03 Thread Artem Chernyshev
virProcessGetNamespaces() return value is invariant, so change it type and remove all dependent checks. Fixes: 7d2fd6ef01 ("Do not check return value of VIR_EXPAND_N") Signed-off-by: Artem Chernyshev --- src/libvirt-lxc.c | 5 + src/lxc/lxc_driver.c| 3 +--

[PATCH 6/7] node_device: udevTranslatePCIIds() to void

2024-01-03 Thread Artem Chernyshev
udevTranslatePCIIds() return value is invariant, so change it type and remove all dependent checks. Fixes: 7f1f0453fc ("node_device: use g_strdup instead of VIR_STRDUP") Signed-off-by: Artem Chernyshev --- src/node_device/node_device_udev.c | 14 +- 1 file changed, 5

[PATCH 4/7] conf: virDomainNetUpdate() to void

2024-01-03 Thread Artem Chernyshev
virDomainNetUpdate() return value is invariant, so change it type and remove all dependent checks. Fixes: 98f6f2081d ("util: alloc: Reimplement VIR_APPEND_ELEMENT using virAppendElement") Signed-off-by: Artem Chernyshev --- src/conf/domain_conf.c | 3 +-- src/conf/domain_conf.h |

[PATCH 1/7] cpu: : virCPUx86DataAddItem() to void

2024-01-03 Thread Artem Chernyshev
it as well. Fixes: 592517636f ("util: alloc: Reimplement VIR_APPEND_ELEMENT_COPY using virAppendElement") Signed-off-by: Artem Chernyshev --- src/cpu/cpu_x86.c | 179 + src/cpu/cpu_x86.h | 4 +- src/libxl/libxl_capabilities.

[PATCH 3/7] lxc: virLXCControllerAddConsole() to void

2024-01-03 Thread Artem Chernyshev
virLXCControllerAddConsole() return value is invariant, so change it type and remove all dependent checks. Fixes: 7d2fd6ef01 ("Do not check return value of VIR_EXPAND_N") Signed-off-by: Artem Chernyshev --- src/lxc/lxc_controller.c | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH 2/7] rpc: virnetserver: virNetServerAddService() to void

2024-01-03 Thread Artem Chernyshev
virNetServerAddService() return value is invariant, so change it type and remove all dependent checks. Fixes: 7d2fd6ef01 ("Do not check return value of VIR_EXPAND_N") Signed-off-by: Artem Chernyshev --- src/lxc/lxc_controller.c | 3 +-- src/rpc/virnetserve

[PATCH 0/7] Code cleanup 2

2024-01-03 Thread Artem Chernyshev
Several functions was modified to become invariant. Change their type to void and remove unnecessary checks of their return values. Found by Linux Verification Center (linuxtesting.org) with SVACE. Artem Chernyshev (7): cpu: : virCPUx86DataAddItem() to void rpc: virnetserver

[PATCH 03/10] virtime: virTimeMillisNowRaw to void

2023-12-24 Thread Artem Chernyshev
virTimeMillisNowRaw() function are invariant now, so, quite a few checks, dependent on it are become irrelevant. Fixes: f5e9bdb87f ("src: replace clock_gettime()/gettimeofday() with g_get_real_time()") Signed-off-by: Artem Chernyshev --- src/conf/virdomainjob.c

[PATCH 01/10] conf: domain_conf: virDomainHostdevInsert/virDomainNetInsert to void

2023-12-24 Thread Artem Chernyshev
ement") Signed-off-by: Artem Chernyshev --- src/conf/domain_conf.c | 25 ++--- src/conf/domain_conf.h | 4 ++-- src/libxl/libxl_domain.c | 3 +-- src/libxl/libxl_driver.c | 6 ++ src/lxc/lxc_driver.c | 6 ++ src/qemu/qemu_driver.c | 6 ++ src/qemu/qemu

[PATCH 08/10] vireventglib: virEventRunDefaultImpl() to void

2023-12-24 Thread Artem Chernyshev
virEventRunDefaultImpl() function returns an invariant result, so turn it to void. Remove all redundant check which depends on it returning value Fixes: 946a25274c ("util: switch to use the GLib event loop impl") Signed-off-by: Artem Chernyshev --- examples/c/misc/event-test

[PATCH 00/10] Subject: [PATCH 00/10] Code cleanup

2023-12-24 Thread Artem Chernyshev
Several functions was modified to become invariant. Change their type to void and remove unnecessary checks of their return values. Found by Linux Verification Center (linuxtesting.org) with SVACE. Artem Chernyshev (10): conf: domain_conf: virDomainHostdevInsert/virDomainNetInsert to void

[PATCH 05/10] conf: virDomainDefMaybeAddInput() to void

2023-12-24 Thread Artem Chernyshev
virDomainDefMaybeAddInput() function returns an invariant result, so turn it to void. Remove all redundant check which depends on it returning value. Fixes: 98f6f2081d ("util: alloc: Reimplement VIR_APPEND_ELEMENT using virAppendElement") Signed-off-by: Artem Chernyshev ---

[PATCH 06/10] virbitmap: virBitmapToData() to void

2023-12-24 Thread Artem Chernyshev
virBitmapToData() function returns an invariant result, so turn it to void. Remove all redundant check which depends on it returning value. Fixes: e59b8f96f7 ("util: a-n: use g_new0") Signed-off-by: Artem Chernyshev --- src/ch/ch_monitor.c| 5 + src/hypervisor/domai

[PATCH 02/10] libxl: libxlMakeDomainCapabilities to void

2023-12-24 Thread Artem Chernyshev
changing to void, because they are invariant. Test fillXenCaps() at moment is useless, so it could be removed or changed in the future. Signed-off-by: Artem Chernyshev --- src/libxl/libxl_capabilities.c | 40 -- src/libxl/libxl_capabilities.h | 2 +- src/libxl

[PATCH 04/10] conf: virDomainGraphicsListenAppendAddress() to void

2023-12-24 Thread Artem Chernyshev
virDomainGraphicsListenAppendAddress() return value is invariant, so change it type and remove all dependent checks. Fixes: 592517636f ("util: alloc: Reimplement VIR_APPEND_ELEMENT_COPY using virAppendElement") Signed-off-by: Artem Chernyshev --- src/conf/domain_conf.c | 4 +---

[PATCH 09/10] vsh: vshCompleterFilter() to void

2023-12-24 Thread Artem Chernyshev
vshCompleterFilter() function returns an invariant result, so turn it to void. Remove redundant check which depends on its returning value Fixes: b668054209 ("tools: Use glib memory functions in vshCompleterFilter") Signed-off-by: Artem Chernyshev --- tools/vsh.c | 9 +++-- 1 fi

[PATCH 07/10] tools: cmdDomblkinfoGet() to void

2023-12-24 Thread Artem Chernyshev
cmdDomblkinfoGet() function returns an invariant result, so turn it to void. Remove all redundant check which depends on it returning value Fixes: 26a137093b ("tools: Use g_strdup_printf() instead of virAsprintf()") Signed-off-by: Artem Chernyshev --- tools/virsh-domain-moni

[PATCH 10/10] vsh: vshInitDebug() to void

2023-12-24 Thread Artem Chernyshev
vshInitDebug() function returns an invariant result, so turn it to void. Remove all redundant checks which depends on its returning value Fixes: 26a137093b ("tools: Use g_strdup_printf() instead of virAsprintf()") Signed-off-by: Artem Chernyshev --- tools/vsh.c | 12 +--- 1 fi