On Fri, Aug 01, 2025 at 02:06:44AM -0700, Andrea Bolognani wrote:
> On Thu, Jul 31, 2025 at 11:33:08AM -0600, Jim Fehlig wrote:
> > Apologies for not having time to look at this in more detail today, but I
> > quickly tried these patches and now see
> >
> > operation failed: unable to find any mast
On Thu, Jul 31, 2025 at 11:33:08AM -0600, Jim Fehlig wrote:
> Apologies for not having time to look at this in more detail today, but I
> quickly tried these patches and now see
>
> operation failed: unable to find any master var store for loader:
> /usr/share/qemu/ovmf-x86_64-sev.bin
This happens
On Wed, Jul 30, 2025 at 12:50:25PM +0100, Daniel P. Berrangé wrote:
> On Tue, Jul 29, 2025 at 03:28:49PM -0600, Jim Fehlig wrote:
> > > Andrea,
> > >
> > > Having spent a fair bit of time in the firmware auto-selection code,
> > > perhaps you have an opinion about this?
> >
> > Sorry to keep naggin
Signed-off-by: Andrea Bolognani
---
NEWS.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 5a320b7f33..b3c7dcb141 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -96,6 +96,12 @@ v11.6.0 (unreleased)
ebtables, creating the base chains only if they did not already
We currently always pick a read-only firmware unless we are
explicitly asked for a read/write one, which is probably what
most people expect anyway but doesn't really make sense
otherwise: if no specific requirement has been provided by the
user, both read-only and read/write firmwares should be
al
The current code assumes that a stateless firmware has to be
explicitly requested by the user, and should never be picked
otherwise. This means that, for example, domains configured to
use SEV-SNP are forced to explicitly request for the firmware
to be stateless.
Additionally, we assume that only
This test case demonstrates how firmware autoselection doesn't
currently work correctly for domains using SEV-SNP: the
descriptor for a suitable firmware exists, and yet it doesn't
get picked up.
Signed-off-by: Andrea Bolognani
---
...-auto-efi-sev-snp.x86_64-latest+amdsev.err | 1 +
...-auto-e
This kind of firmware build is not shipped in Fedora, where
most descriptors in our test suite come from, so we had to
make it up. It was based off the Secure Boot-enabled edk2
build, and the filename it points to is the same.
That has been fine so far since it's not actually being picked
up by an
See [1] for the discussion motivating these changes.
[1]
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/U33UEJEXZGZEWOLGVAA5UWPLYY4WHEHT/
Andrea Bolognani (5):
tests: Tweak descriptor for combined firmware
tests: Add firmware-auto-efi-sev-snp
qemu: Fix matching for
On Fri, Jul 25, 2025 at 01:25:47PM +0100, Daniel P. Berrangé wrote:
> On Fri, Jul 25, 2025 at 01:45:51PM +0200, Hector Cao wrote:
> > One thing I'm worried about with modules-load.d approach is that at libvirt
> > installation, the module
> > is not actually loaded, a reboot is necessary to make it
On Fri, Jul 25, 2025 at 11:10:15AM +0100, Daniel P. Berrangé wrote:
> On Fri, Jul 25, 2025 at 11:46:54AM +0200, Hector Cao wrote:
> > What do you think of this design:
> > 1) Create a file msr.conf inside src/util/modules-load.d/
> > 2) Modify src/util/meson.build to install this file to /etc/modul
On Mon, Jul 07, 2025 at 05:05:05PM -0600, Jim Fehlig via Devel wrote:
> * **Improvements**
>
> + * qemu: Change default SCSI controller model to ``virtio-scsi`` for ARM
> +
> +The previous default of ``lsilogic`` is unsupported by modern operating
> +systems. ``virtio-scsi`` is a more sui
On Wed, Jul 09, 2025 at 09:53:40AM +0100, Daniel P. Berrangé via Devel wrote:
> On Wed, Jul 09, 2025 at 10:29:32AM +0200, Hector Cao wrote:
> > > >3. if that fails too, load the msr module and try again;
> > >
> > > It seems like a modules-load file is simpler than having this manual
> > > kmod
On Mon, Jul 07, 2025 at 04:45:30PM -0600, Jim Fehlig wrote:
> BTW, what do you think about a similar change for x86_64? I vaguely recall
> the choice of lsilogic for broader Windows support. We checked w2k8r2-w2k25
> and win10, none of which contain an LSI Logic driver. virtio-scsi may be a
> bette
Using lsilogic on RISC-V was never an actual decision, but
rather a consequence of that being the default for legacy x86
guests. Using virtio-scsi is a much more sensible choice.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain.c| 1 +
...virt-default-mod
Use a better order for sections, improve comments, tweak
formatting.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index c408fb8c88..a6c0b581
Make the helper stateless. This requires the caller to check
whether it needs to be called in the first place instead of
adding this check inside the function, which makes for more
readable, if a little more verbose, code.
We also update callers to check the return value against
VIR_DOMAIN_CONTROL
I was working on this last year, then sort of lost track. Jim's
recent patch[1] caused me to remember about this work and look into
picking it up again.
This is only half of the original series, which itself was reduced in
scope compared to the first revision. I'll try to get around to
everything,
On Wed, Jul 02, 2025 at 02:01:07PM -0600, Jim Fehlig wrote:
> On 7/2/25 10:11, Andrea Bolognani wrote:
> > On Thu, Jun 26, 2025 at 03:29:58PM -0600, Jim Fehlig via Devel wrote:
> > > However, I do understand this
> > > change could break existing ARM VM configurations containing a SCSI
> > > contro
On Thu, Jun 26, 2025 at 03:29:58PM -0600, Jim Fehlig via Devel wrote:
> Similar to x86, the default SCSI controller model for ARM is lsilogic.
> But unlike x86, the ARM virt machine type prefers virtio devices. Switch
> the default controller model for ARM from lsilogic to virtio-scsi.
>
> Signed-o
On Tue, Jun 24, 2025 at 05:48:52PM +0200, Ján Tomko via Devel wrote:
> +++ b/docs/compiling.rst
> @@ -105,8 +105,8 @@ Notes:
> ~~
>
> By default when the ``meson`` is run from within a GIT checkout, it will turn
> -on -Werror for builds. This can be disabled with --werror=false, but this is
>
On Mon, Jun 09, 2025 at 09:38:51AM +0200, Michal Privoznik via Devel wrote:
> - Replace Alpine 3.21 with 3.22
>
> Signed-off-by: Michal Privoznik
> ---
>
> Green pipeline:
>
> https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1860029940
>
> ci/buildenv/{alpine-321.sh => alpine-322.sh}
We no longer check for the presence of the commands included
in these packages at build time.
Signed-off-by: Andrea Bolognani
---
ci/buildenv/almalinux-9.sh| 9 -
ci/buildenv/alpine-321.sh | 6 --
ci/buildenv/alpine-edge.sh
We've recently stopped checking for the presence of various
commands at build time, which means that we no longer need
to have the corresponding packages installed in the build
environment.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 14 --
1 file changed, 14 deletions(-)
daemon-common should have always depended on kmod, since
there are various situations in which a module (un)load might
be triggered by a driver.
For the util-linux dependency, we're simply adjusting the
comment to match reality.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 4 +++-
1 fi
We've recently stopped checking for the presence of several
commands at build time. That means we don't need them in the
RPM or CI build environment either.
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1855622714
Andrea Bolognani (3):
rpm: Fix/clarify Requires
rpm: Drop unne
On Thu, Jun 05, 2025 at 05:13:23PM +0200, Peter Krempa wrote:
> I'm not a fan. The rendered HTML makes it obvious by putting it in a
> block with different formatting.
>
> With the $ in front you can't tripple click to select the whole line and
> paste it somewhere.
>
> But since the command itself
Looks slightly nicer and makes it absolutely obvious that
these are shell commands.
Signed-off-by: Andrea Bolognani
---
docs/downloads.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/downloads.rst b/docs/downloads.rst
index cdcddabc57..e39d876f36 100644
--- a/doc
These mirrors no longer exist, they're just straight up
redirects to GitLab now.
Signed-off-by: Andrea Bolognani
---
docs/downloads.rst | 6 --
1 file changed, 6 deletions(-)
diff --git a/docs/downloads.rst b/docs/downloads.rst
index 11837c29e1..cdcddabc57 100644
--- a/docs/downloads.rst
++
We use the same format for GitLab and libvirt.org, but not
for GitHub.
Signed-off-by: Andrea Bolognani
---
docs/downloads.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/downloads.rst b/docs/downloads.rst
index 00feb8a761..11837c29e1 100644
--- a/docs/downloads.rst
+
*** CLICK HERE TO BLURB ***
Andrea Bolognani (3):
docs: Unify clone instructions
docs: Drop mention of read-only git mirrors
docs: Add prompt to clone commands
docs/downloads.rst | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
--
2.49.0
On Mon, May 12, 2025 at 03:51:09PM +0200, Peter Krempa wrote:
> On Thu, May 08, 2025 at 11:32:19 +0200, Andrea Bolognani wrote:
> > From: "Matthew R. Ochs"
> >
> > Notable differences:
> >
> > * various machine types, notably vexpress-a9, have stopped
> > accepting user-specified CPU models
On Thu, May 08, 2025 at 06:58:45PM +, Matt Ochs wrote:
> On May 8, 2025, at 4:00 AM, Andrea Bolognani wrote:
> > That was all present in my patch from earlier this year[1], which
> > this one is clearly based on.
> >
> > And "based on" is a very generous term in this case, since what the
> > a
On Thu, May 08, 2025 at 07:51:29AM +0200, Peter Krempa wrote:
> On Wed, May 07, 2025 at 16:38:38 -0700, Matthew R. Ochs via Devel wrote:
> > diff --git
> > a/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args
> >
> > b/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-l
The borzoi machine type was dropped in QEMU 9.2.0, so let's
use a different machine type with no ACPI support and no
implicit USB controller instead.
Signed-off-by: Andrea Bolognani
---
tests/qemuxmlconfdata/aarch64-noacpi-acpi.aarch64-latest.err | 2 +-
tests/qemuxmlconfdata/aarch64-noacpi-ac
On Thu, May 08, 2025 at 02:06:19AM -0700, Andrea Bolognani wrote:
> On Thu, May 08, 2025 at 07:59:38AM +0200, Peter Krempa wrote:
> > This one also should be mentioned, but I don't actually know the reason
> > for this. So if you can dig it out please reply with it and I'll ammend
> > the commit me
This combines my [v1] with Mattew's [v2] in a way that preserves
accurate authorship information, correctly splits changes across
patches and adequately documents the changes themselves.
[v1]
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/Z4NQ3CVQYLNGZRBC35CUHOQ2EXJROPYG/
On Thu, May 08, 2025 at 02:00:07AM -0700, Andrea Bolognani wrote:
> On Thu, May 08, 2025 at 07:51:29AM +0200, Peter Krempa wrote:
> [...] seems to indicate that they have just applied a naive
> s/borzoi/collie/ without considering the semantics. With this patch
> applied:
>
> $ grep collie tests/
On Thu, May 08, 2025 at 07:59:38AM +0200, Peter Krempa wrote:
> On Wed, May 07, 2025 at 16:38:46 -0700, Matthew R. Ochs via Devel wrote:
> > Add xml and reply files for QEMU 10.0.0 on aarch64.
>
> I'd prefer if the commit message commented on some of the .args changes.
> See below. (I can ammend th
On Tue, Apr 29, 2025 at 05:41:43PM +0200, Jiří Denemark wrote:
> On Tue, Apr 29, 2025 at 13:03:12 +0100, Daniel P. Berrangé wrote:
> > On Tue, Apr 29, 2025 at 01:42:22PM +0200, Peter Krempa wrote:
> > > On Tue, Apr 29, 2025 at 12:36:40 +0100, Daniel P. Berrangé wrote:
> > > > On Tue, Apr 15, 2025 a
On Fri, Mar 14, 2025 at 10:13:49AM +, Daniel P. Berrangé wrote:
> On Fri, Mar 14, 2025 at 11:01:21AM +0100, Andrea Bolognani wrote:
> > %define arches_qemu_kvm %{ix86} x86_64 %{power64} %{arm} aarch64
> > s390x riscv64
> > %if 0%{?rhel}
> > -%if 0%{?rhel} > 8
> > +%if 0%{?rhe
On Tue, Apr 01, 2025 at 10:55:28AM +0200, Alessandro wrote:
> We attempted multiple ways to clean up dynamic files; however, we must
> preserve user overrides, which requires keeping the file
> /etc/apparmor.d/libvirt/libvirt-uuid
>
> This commit proposes to move user overrides into
> /etc/apparmor
On Tue, Apr 01, 2025 at 03:24:10PM +0100, Daniel P. Berrangé wrote:
> On Tue, Apr 01, 2025 at 07:15:46AM -0700, Andrea Bolognani via Devel wrote:
> > More importantly, I'm not convinced that you can just start deleting
> > that file unconditionally. Since, as you n
On Tue, Apr 01, 2025 at 04:00:42PM +0200, Alessandro wrote:
> On Tue, 1 Apr 2025 at 14:22, Andrea Bolognani wrote:
> > On Tue, Apr 01, 2025 at 10:55:28AM +0200, Alessandro wrote:
> > > We attempted multiple ways to clean up dynamic files; however, we must
> > > preserve user overrides, which requi
44 matches
Mail list logo
