[PATCH v2] RFC: audio: deprecate HMP audio commands

2025-10-18 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau The command is niche and better served by the host audio system. There is no QMP equivalent, fortunately. You can capture the audio stream via remote desktop protocols too (dbus, vnc, spice). Signed-off-by: Marc-André Lureau --- docs/about/deprecated.rst | 20 ++

[PATCH v2 09/29] qemu_validate: Reflect dependencies of hv-evmcs

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik Per QEMU documentation (docs/system/i386/hyperv.rst): ``hv-evmcs`` The enlightenment is nested specific, it targets Hyper-V on KVM guests. Requires: ``hv-vapic`` Reflect this dependency when validating domain definition. Signed-off-by: Michal Privoznik --- src/q

[PATCH 4/5] ch: implement network device hot detach

2025-10-18 Thread Stefan Kober
On-behalf-of: SAP [email protected] Signed-off-by: Stefan Kober --- src/ch/ch_hotplug.c | 69 ++--- 1 file changed, 65 insertions(+), 4 deletions(-) diff --git a/src/ch/ch_hotplug.c b/src/ch/ch_hotplug.c index 25058e08f3..480acf93a6 100644 --- a/src/ch/

[PULL 10/23] tests/docker/common: print meson log on configure failure

2025-10-18 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-ID: <[email protected]> --- tests/docker/common.rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/common.rc b/tests/docker/comm

[PATCH v2 28/29] qemu_process: Populate hyperv features for host-model

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik Pretty straightforward. The only "weird" thing here is that 'hv-time' enlightenment is exposed as a under element. Since it's required by 'hv-stimer' and 'hv-stimer-direct' it needs to be enabled too. Resolves: https://issues.redhat.com/browse/RHEL-114003 Signed-off-by:

[PULL 23/23] build-sys: pass -fvisibility=default for wasm bindgen

2025-10-18 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Otherwise, no functions are generated: https://github.com/rust-lang/rust-bindgen/issues/2989 Signed-off-by: Marc-André Lureau Reviewed-by: Kohei Tokunaga Message-ID: <[email protected]> --- meson.build| 4 ru

Re: [PATCH RFC V6 22/24] monitor,qdev: Introduce 'device_set' to change admin state of existing devices

2025-10-18 Thread Markus Armbruster via Devel
Peter Maydell writes: > On Thu, 9 Oct 2025 at 15:56, Markus Armbruster wrote: >> qdev introspection (device-list-properties) is like QOM type >> introspection. I'm not sure why it exists. > > It exists because it is the older of the two interfaces: > device-list-properties was added in 2012, wh

Re: [PATCH RFC V6 22/24] monitor,qdev: Introduce 'device_set' to change admin state of existing devices

2025-10-18 Thread Daniel P . Berrangé via Devel
On Thu, Oct 09, 2025 at 02:51:25PM +0200, Igor Mammedov via Devel wrote: > On Thu, 09 Oct 2025 10:55:40 +0200 > Markus Armbruster wrote: > > > [email protected] writes: > > > > > From: Salil Mehta > > > > > > This patch adds a "device_set" interface for modifying properties of > > > devic

Re: [PATCH] NEWS: Document features/improvements/bug fixes I've participated in

2025-10-18 Thread Ján Tomko via Devel
On a Monday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik There are some features/improvements/bug fixes I've either contributed or reviewed/merged. Document them for upcoming release. Signed-off-by: Michal Privoznik --- NEWS.rst | 13 + 1 file changed, 13 inser

[RFC PATCH 16/16] qemu: Add support for enabling timed block device statistics collection

2025-10-18 Thread Peter Krempa via Devel
From: Peter Krempa Add validation that qemu supports the collection of statistics and enable it on the block device commandline. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 15 + src/qemu/qemu_validate.c | 29 ++ ...sk-statis

[PATCH] qemu-replies-tool: Fix logic error when dumping device properties

2025-10-18 Thread Peter Krempa via Devel
From: Peter Krempa In a recent refactor the block of code outputting device properties was mis-indented causing it to only work on device properties which have no 'default-value'. Fixes: 301e1ba244f Signed-off-by: Peter Krempa --- scripts/qemu-replies-tool.py | 20 ++-- 1 file

Re: [PATCH v2 07/27] configure: set the bindgen cross target

2025-10-18 Thread Paolo Bonzini via Devel
On 9/24/25 14:04, [email protected] wrote: From: Marc-André Lureau Implement a bash version of rust-bindgen rust_to_clang_target() to convert from rust target to clang target. Signed-off-by: Marc-André Lureau Reviewed-by: Paolo Bonzini --- configure

[RFC PATCH 6/7] qemu: Update Cgroup, namespace, and seclabel for qemu to access iommufd paths

2025-10-18 Thread Nathan Chen via Devel
Allow access to /dev/iommu and /dev/vfio/devices/vfio* when launching a qemu VM with iommufd feature enabled. Signed-off-by: Nathan Chen --- src/qemu/qemu_cgroup.c | 61 src/qemu/qemu_cgroup.h | 1 + src/qemu/qemu_namespace.c| 44

[PULL 02/23] gitlab-ci: fix 'needs' property type must be array

2025-10-18 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau The gitlab "Pipeline editor" has some warnings, and gitlab-ci-local fails. Read also from the docs https://docs.gitlab.com/ci/yaml/#needs "Supported values: An array of jobs (maximum of 50 jobs). An empty array ([]), to set the job to start as soon as the pi

Re: [PATCH v4 17/23] util: fix interleaving of error prefixes

2025-10-18 Thread Philippe Mathieu-Daudé
On 25/9/25 11:44, Daniel P. Berrangé wrote: The vreport() function will optionally emit an prefix for error messages which is output to stderr incrementally. In the event that two vreport() calls execute concurrently, there is a risk that the prefix output will interleave. To address this it is r

[PULL 03/23] scripts/archive-source: speed up downloading subprojects

2025-10-18 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Running meson on each subproject is quite slow. According to Paolo, meson will run download tasks in parallel. Signed-off-by: Marc-André Lureau Reviewed-by: Alex Bennée Message-ID: <[email protected]> --- scripts/archive-source.sh |

[PATCH] docs: domain: add watchdog notification support

2025-10-18 Thread Massimiliano Minella via B4 Relay via Devel
From: Massimiliano Minella Since v0.8.0 a watchdog notification is available under event ID VIR_DOMAIN_EVENT_ID_WATCHDOG, update the documentation to remove the previous limitation. Signed-off-by: Massimiliano Minella --- Remove limitation on notification support for watchdog. --- docs/formatd

Re: [PATCH v2 07/27] configure: set the bindgen cross target

2025-10-18 Thread Paolo Bonzini via Devel
On 9/24/25 14:04, [email protected] wrote: diff --git a/scripts/rust-to-clang-target.sh b/scripts/rust-to-clang-target.sh new file mode 100644 index 00..5451807888 --- /dev/null +++ b/scripts/rust-to-clang-target.sh @@ -0,0 +1,62 @@ +#!/usr/bin/env sh No shebang is needed, sin

Re: [PATCH 6/8] wireshark: Introduce and use vir_val_to_str()

2025-10-18 Thread Peter Krempa via Devel
On Tue, Oct 14, 2025 at 08:31:45 +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > Wireshark offers val_to_str() function which converts numeric > value to string by looking up value ('val') in an array ('vs') of > pairs. If no corresponding string is found, then > the value

[RFC PATCH 11/16] qemu_monitor: Extract 'timed_stats' of block devices

2025-10-18 Thread Peter Krempa via Devel
From: Peter Krempa The 'timed_stats' block is a set of statistics gathered in configurable time intervals. The stats include latency timings of reads/writes as well as the depth of the request queues. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 1 + src/qemu/qemu_monitor.h

Re: [PATCH v3 4/8] qemu: probe mshv capabilities

2025-10-18 Thread Daniel P . Berrangé via Devel
On Fri, Aug 29, 2025 at 03:28:34PM -0500, Praveen K Paladugu wrote: > Probe mshv capabilities from qemu with QMP commands. Limit probing only > to x86_64 architecture with newer versions of QEMU. > > Signed-off-by: Praveen K Paladugu > --- > src/qemu/qemu_capabilities.c | 21

Re: [PATCH 1/2] remote: allow passing cmd arguments to REMOTE_DRIVER_TRANSPORT_EXT

2025-10-18 Thread Daniel P . Berrangé via Devel
On Fri, Oct 10, 2025 at 08:58:17AM +, Sergey Dyasli wrote: > Allow passing up to 5 arguments to the ext program via the query > parameters. URI example: > > qemu+ext:///system?command=/bin/prog&ext_arg1=192.168.0.10&ext_arg2=8080 AFAIR, URI query parameters can be repeated arbitrarily ma

Re: [PATCH v2 14/29] qemu: Use virXPathTristateBool()

2025-10-18 Thread Michal Prívozník via Devel
On 10/15/25 03:45, Ján Tomko wrote: > On a Wednesday in 2025, Michal Privoznik via Devel wrote: >> From: Michal Privoznik >> >> There are two places in our code base which can use freshly >> introduced virXPathTristateBool(): >> qemuStorageSourcePrivateDataParse() and >> qemuDomainObjPrivateXMLPar

[PATCH 3/3] tests: qemuxmlconfdata: provide smmuv3Dev sample XML and CLI args

2025-10-18 Thread Nathan Chen via Devel
Provide sample XML and CLI args for the smmuv3Dev XML schema for pc, q35, and virt machine types. Signed-off-by: Nathan Chen --- .../iommu-smmuv3Dev.aarch64-latest.args | 39 .../iommu-smmuv3Dev.aarch64-latest.xml| 62 +++ tests/qemuxmlconfdata/iommu-sm

Re: [PATCH v3 4/9] tests: Add tests for SEV firmware selection

2025-10-18 Thread Andrea Bolognani via Devel
On Thu, Sep 18, 2025 at 06:11:09AM -0600, Jim Fehlig wrote: > On 9/18/25 02:12, Andrea Bolognani wrote: > > I'm actively working to get things sorted out in Fedora, but > > unfortunately I'm having trouble getting access to SEV-capable > > hardware and that's slowing things down. > > > > We should

[PULL 14/23] lcitool/alpine: workaround bindgen issue

2025-10-18 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-ID: <[email protected]> --- tests/docker/dockerfiles/alpine.docker | 2 ++ tests/lcitool/refresh | 8 +++- 2 files changed, 9 insertions(+),

[PATCH v2 27/29] conf: Introduce hyperv host-model mode

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik So far we have two modes for hyperv features: 1) custom, where users have to enable features explicitly, and 2) passthrough, where hypervisor enables features automagically. Problem with 'custom' mode is that some features are not plain on/off switches but expect int/stri

[PATCH v2] libvirt-ci: forbid RISC-V cross compile on Debian < 13

2025-10-18 Thread 杨泽伟
From 3c3ebcea07d20977f30baedcec50a859c1ac04a5 Mon Sep 17 00:00:00 2001 From: yzewei Date: Sat, 11 Oct 2025 09:39:29 +0800 Subject: [PATCH] This patch updates [PATCH v1] to add validation: RISC-V cross compilation is forbidden on Debian < 13. Signed-off-by: yzewei --- lcitool/projects.py | 2 +

[PATCH v2 01/27] build-sys: require -lrt when no shm_open() in std libs

2025-10-18 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Fail during configure time if the shm functions are missing, as required by oslib-posix.c. Note, we could further check the presence of the function in librt. This is a minor cleanup/improvement. Signed-off-by: Marc-André Lureau --- meson.build | 16 +--- 1

[PATCH v4 18/23] util: introduce common helper for error-report & log code

2025-10-18 Thread Daniel P . Berrangé via Devel
The error-report and log code both have a need to add prefixes to messages they are printing, with the current example being a timestamp. The format and configuration they use should be consistent, so providing a common helper will ensure this is always the case. Initially the helper only emits a

[PATCH v4 08/23] log: avoid repeated prefix on incremental qemu_log calls

2025-10-18 Thread Daniel P . Berrangé via Devel
Some code makes multiple qemu_log calls to incrementally emit a single message. Currently timestamps get prepended to all qemu_log calls, even those continuing a previous incomplete message. This changes the qemu_log so it skips adding a new line prefix, if the previous qemu_log call did NOT end w

[PATCH v2 06/29] qemu_validate: Reflect dependencies of hv-stimer

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik Per QEMU documentation (docs/system/i386/hyperv.rst): ``hv-stimer`` Enables Hyper-V synthetic timers. Requires: ``hv-vpindex``, ``hv-synic``, ``hv-time`` Reflect these dependencies when validating domain definition. Signed-off-by: Michal Privoznik --- src/qemu/qe

[PATCH v2 4/7] tcg/mips: Remove support for O32 and N32 ABIs

2025-10-18 Thread Philippe Mathieu-Daudé
See previous commit for rationale. Signed-off-by: Philippe Mathieu-Daudé --- tcg/mips/tcg-target-reg-bits.h | 9 ++ tcg/mips/tcg-target.c.inc| 15 ++ common-user/host/mips/safe-syscall.inc.S | 35 3 files changed, 6 insertions(+), 5

[PULL 01/23] build-sys: require -lrt when no shm_open() in std libs

2025-10-18 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Fail during configure time if the shm functions are missing, as required by oslib-posix.c. Note, we could further check the presence of the function in librt. This is a minor cleanup/improvement. Signed-off-by: Marc-André Lureau Reviewed-by: Alex Bennée Message-ID: <20

Re: [PATCH 1/2] remote: allow passing cmd arguments to REMOTE_DRIVER_TRANSPORT_EXT

2025-10-18 Thread Sergey Dyasli
On 10/10/2025 10:18, Daniel P. Berrangé wrote: On Fri, Oct 10, 2025 at 08:58:17AM +, Sergey Dyasli wrote: Allow passing up to 5 arguments to the ext program via the query parameters. URI example: qemu+ext:///system?command=/bin/prog&ext_arg1=192.168.0.10&ext_arg2=8080 AFAIR, URI que

[PATCH 06/20] qemu_caps: Prefer VIR_DOMAIN_CAPS_ENUM_IS_SET()

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik While virDomainCapsEnum is in fact a bitmap, we also have a macro to manipulate/query individual bits. Prefer it to make the code more readable. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [PATCH 8/8] wireshark: Adapt to wireshark-4.6.0

2025-10-18 Thread Peter Krempa via Devel
On Tue, Oct 14, 2025 at 08:31:47 +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > The main difference is that wmem_packet_scope() is gone [1] but > the packet_info struct has 'pool` member which points to the > allocator used for given packet. > > Unfortunately, while we wer

[RFC PATCH 05/16] qemuMigrationCookieAddNBD: Use qemuBlockGetNamedNodeData to fetch the capacities

2025-10-18 Thread Peter Krempa via Devel
From: Peter Krempa 'qemuMonitorBlockStatsUpdateCapacityBlockdev' uses the same command internally. Upcoming patches will want to merge qemuMonitorBlockStatsUpdateCapacityBlockdev into qemuMonitorGetAllBlockStatsInfo and qemuMigrationCookieAddNBD is the only place that doesn't call qemuMonitorGet

[PATCH 2/8] wireshark: Switch header files to #pragma once

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik The genxdrstub.pl script generates some header files. But they use the old pattern to guard against multiple inclusion: #ifndef SOMETHING_H #define SOMETHING_H ... #endif Change the script to generate just '#pragma once' used everywhere else in our code. Signed-o

[PATCH 13/20] qemu_capabilities: Format and parse new hyperv domcaps members

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik After previous commit the virDomainCapsFeatureHyperv struct gained new members. Since virQEMUCaps struct holds a pointer to such struct we must format and parse it to/from capabilities XML. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 42 +++

[PATCH v2 08/27] tests/docker/common: print errors to stderr

2025-10-18 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- tests/docker/common.rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/docker/common.rc b/tests/docker/common.rc index a611e6adf9..2ed2365a61 100755 --- a/tests/docker/com

Re: [PATCH] qemucapabilitiestest: Update 'caps_10.2.0_x86_64' to v10.1.0-1060-geb7abb4a71

2025-10-18 Thread Pavel Hrdina via Devel
On Tue, Oct 07, 2025 at 10:36:20AM +0200, Peter Krempa via Devel wrote: > From: Peter Krempa > > Notable changes: > - 10.2 machine types added > - 'prefetchi' is now migratable on the detected cpu > - 'cpr-exec-command' migration parameter added > - 'inject-ghes-v2-error' command added (unsta

[PATCH v2 0/2] Fix sanlock without qemu (dejavu)

2025-10-18 Thread Daniel P . Berrangé via Devel
My previous RPM fix was wrong, as sanlock can actually be used with libxl too. It is the meson rules that were wrong. Daniel P. Berrangé (2): Revert "rpm: disable sanlock when QEMU is disabled" locking: use & install test_libvirt_sanlock.sug for both QEMU & LibXL libvirt.spec.in

Re: [PATCH v3 1/8] qemu: introduce mshv capabilities

2025-10-18 Thread Daniel P . Berrangé via Devel
On Fri, Aug 29, 2025 at 03:28:31PM -0500, Praveen K Paladugu wrote: > Qemu with mshv capabilities can launch domains of type hyperv. > > Signed-off-by: Praveen K Paladugu > --- > src/qemu/qemu_capabilities.c | 40 +--- > src/qemu/qemu_capabilities.h | 1 + > 2 fi

[PATCH 1/2] Replace all use of 'g_new' with 'g_new0'

2025-10-18 Thread Peter Krempa via Devel
From: Peter Krempa Always use the version which clears the allocated memory. Signed-off-by: Peter Krempa --- src/network/network_pf.c | 2 +- src/qemu/qemu_nbdkit.c | 2 +- src/qemu/qemu_process.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/network/network_pf.

[PATCH v1] lcitool: remove obsolete RISC-V ports setup for Debian 13+

2025-10-18 Thread 杨泽伟
From 1603e78297c32f241d7a55f510bae3b8ac16f154 Mon Sep 17 00:00:00 2001 From: yzewei Date: Fri, 10 Oct 2025 18:01:59 +0800 Subject: [PATCH] lcitool: remove obsolete RISC-V ports setup for Debian 13+ Debian 13 and later officially support riscv64, so the old debian-ports archive keyring and sources

[PATCH 5/8] wireshark: Don't special case retval of get_program_data() in dissect_libvirt_message()

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik The get_program_data() function returns a pointer (in this specific case to an array of procedure strings) which, if non-NULL is then passed val_to_str(). Well, if val_to_str() sees NULL it is treated gracefully, i.e. like if the numeric value 'proc' wasn't found in the arr

[PATCH v2 24/27] WIP: cirrus/macos: enable Rust

2025-10-18 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Currently fails with a linking issue: = note: some arguments are omitted. use `--verbose` to show all linker arguments = note: ld: warning: ignoring duplicate libraries: '-lSystem', '-lc', '-llibgio-2.0.dylib', '-llibglib-2.0.dylib', '-llibgmodule-2.0.dylib', '-llib

Re: [PATCH] network: pf: split flush and rules commands

2025-10-18 Thread Laine Stump via Devel
On 10/5/25 2:58 AM, Roman Bogorodskiy wrote: Current implementation uses a single command to flush the old rules and create new ones. This is not optimal because if flush fails for some non-critical reasons (e.g. because the anchor didn't previously exist), it will block rules creation and networ

[PATCH 16/20] NEWS: Document new hyperv enlightenment

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik Signed-off-by: Michal Privoznik --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 006b2ccf6a..8b6c736f01 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,12 @@ v11.9.0 (unreleased) * **New features** + * Support ``time

[PATCH 12/20] conf: Report default hyperv values in domain capabilities

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik So far the set of available Hyper-V enlightenments are reported in domain capabilities. Well, some enlightenments are more than just simple on/off switch. For instance, the 'spinlocks' enlightenment expects a number, or 'vendor_id' expects a string. All of these have some

Re: [PATCH v2 12/27] lcitool: update, switch to f41

2025-10-18 Thread Daniel P . Berrangé via Devel
On Wed, Sep 24, 2025 at 04:04:09PM +0400, [email protected] wrote: > From: Marc-André Lureau > > Newer lcitool version has various fixes helping QEMU CI and this series. > > Signed-off-by: Marc-André Lureau > --- > scripts/ci/setup/ubuntu/ubuntu-2204-aarch64.yaml | 3 ++- > script

Re: [PATCH v2 1/3] qemu: add IOMMU model smmuv3Dev

2025-10-18 Thread Daniel P . Berrangé via Devel
On Wed, Oct 01, 2025 at 05:23:46PM -0700, Nathan Chen via Devel wrote: > Introduce support for "smmuv3Dev" IOMMU model and > its "parentIdx" driver attribute. The "parentIdx" > attribute indicates the index of the controller that a > smmuv3Dev IOMMU device is attached to. > > Signed-off-by: Nathan

Re: [PATCH v3] qapi: net/tap: deprecate vhostforce option

2025-10-18 Thread Vladimir Sementsov-Ogievskiy
On 14.10.25 08:48, Jason Wang wrote: On Mon, Sep 1, 2025 at 11:39 PM Vladimir Sementsov-Ogievskiy wrote: This option doesn't make sense since long ago (10 years!) commit 1e7398a140f7a6 ("vhost: enable vhost without without MSI-X"). qemu-options.hx still say: """ "use vh

3 grandes beneficios de la bisutería para la estética femenina

2025-10-18 Thread gkm32451
La bisutería proporciona beneficios estéticos multiplicados 😍, en especial en aquellas personas que aspiran de ilustrar su estilo y personalidad de forma versátil y económica. El equipo de Sifrah ha preparado tres beneficios clave orientados al público femenino 🙋‍♀️ Allí vamos! 1. Realza el Est

Re: [PATCH RFC V6 22/24] monitor,qdev: Introduce 'device_set' to change admin state of existing devices

2025-10-18 Thread Igor Mammedov via Devel
On Thu, 09 Oct 2025 10:55:40 +0200 Markus Armbruster wrote: > [email protected] writes: > > > From: Salil Mehta > > > > This patch adds a "device_set" interface for modifying properties of devices > > that already exist in the guest topology. Unlike 'device_add'/'device_del' > > (hot-plug)

Re: [PATCH v4 00/23] util: sync error_report & qemu_log output more closely

2025-10-18 Thread Philippe Mathieu-Daudé
Hi Daniel, On 25/9/25 11:44, Daniel P. Berrangé wrote: This series is a tangent that came out of discussion in https://lists.nongnu.org/archive/html/qemu-devel/2025-08/msg00903.html In thinking about adding thread info to error_report, I came to realize we should likely make qemu_log behav

Re: [PATCH] qemu-replies-tool: Fix logic error when dumping device properties

2025-10-18 Thread Ján Tomko via Devel
On a Tuesday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa In a recent refactor the block of code outputting device properties was mis-indented causing it to only work on device properties which have no 'default-value'. Fixes: 301e1ba244f Signed-off-by: Peter Krempa --- scripts/qe

Release of libvirt-11.8.0

2025-10-18 Thread Jiri Denemark via Devel
The 11.8.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is

Re: [PATCH RFC V6 22/24] monitor,qdev: Introduce 'device_set' to change admin state of existing devices

2025-10-18 Thread Peter Maydell
On Thu, 9 Oct 2025 at 15:56, Markus Armbruster wrote: > qdev introspection (device-list-properties) is like QOM type > introspection. I'm not sure why it exists. It exists because it is the older of the two interfaces: device-list-properties was added in 2012, whereas qom-list-properties was onl

[RFC PATCH 0/7] Implement support for iommufd and multiple vSMMUs

2025-10-18 Thread Nathan Chen via Devel
Hi, This is a follow up to the third RFC patchset [0] for supporting multiple vSMMU instances and using iommufd to propagate DMA mappings to kernel for VM-assigned host devices in a qemu VM. It builds on the recent libvirt patch series [1] without support for iommufd and the 'accel' iommu attribut

Re: [PATCH 7/8] wireshark: Don't leak column strings

2025-10-18 Thread Peter Krempa via Devel
On Tue, Oct 14, 2025 at 08:31:46 +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > One of the problems of using val_to_str() is that it may return a > const string from given table ('vs'), OR return an allocated one. > Since the caller has no idea which case it is, it resides

Re: [PATCH v4] qapi: net: deprecate vhostforce option

2025-10-18 Thread Vladimir Sementsov-Ogievskiy
On 16.10.25 11:48, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: This option for tap and vhost-user netdevs doesn't make sense since long ago (10 years!), starting from commits: 1e7398a140f7a6 ("vhost: enable vhost without without MSI-X") 24f938a682d934 ("vhost user:suppor

[PATCH 5/7] qemu: snapshot: Deactivate block nodes on manually snapshotted disks

2025-10-18 Thread Peter Krempa via Devel
From: Peter Krempa If the user wants to manually preserve state of the disk we need, apart from pausing the machine to quiesce all writes, also deactivate the block nodes of the device. This ensures that qemu writes out metadata (e.g. block dirty bitmaps) which are normally stored only in memory,

[PATCH v2 13/27] lcitool/qemu: include libclang-rt for TSAN

2025-10-18 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- scripts/ci/setup/ubuntu/ubuntu-2204-aarch64.yaml | 1 + scripts/ci/setup/ubuntu/ubuntu-2204-s390x.yaml| 1 + tests/docker/dockerfiles/centos9.docker | 1 + tests/docker/docke

[PATCH 11/20] docs: Drop remark on now unsupported version of QEMU

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik In formatdomaincaps.rst under section documenting hyperv features there's a paragraph describing behaviour with QEMU older than 6.1.0. Well, as of v11.2.0-rc1~216 the minimum required version is 6.2.0 rendering the paragraph needless. Drop it. Signed-off-by: Michal Privozn

Re: [PATCH v3 4/8] qemu: probe mshv capabilities

2025-10-18 Thread Praveen K Paladugu
On 10/1/2025 4:37 AM, Daniel P. Berrangé wrote: On Fri, Aug 29, 2025 at 03:28:34PM -0500, Praveen K Paladugu wrote: Probe mshv capabilities from qemu with QMP commands. Limit probing only to x86_64 architecture with newer versions of QEMU. Signed-off-by: Praveen K Paladugu --- src/qemu/qe

[RFC PATCH v5 5/7] qemu: open iommufd FDs from libvirt backend

2025-10-18 Thread Nathan Chen via Devel
Open iommufd FDs from libvirt backend without exposing these FDs to XML users, i.e. one per domain for /dev/iommu and one per iommufd hostdev for /dev/vfio/devices/vfioX, and pass the FD to qemu command line. Signed-off-by: Nathan Chen --- src/qemu/qemu_command.c | 43 +++- src/qemu/qemu_co

Re: [PATCH] src: report error from failing to add timer/FD watches

2025-10-18 Thread Peter Krempa via Devel
On Fri, Oct 03, 2025 at 13:43:31 +0100, Daniel P. Berrangé via Devel wrote: > From: Daniel P. Berrangé > > The virEventAddHandle/Timeout APIs are unusual in that they do not > report errors on failure, because they call through to function > callbacks which might be provided externally to libvirt

Re: [PATCH 0/2] Forbid 'g_new' (the one without clearing memory)

2025-10-18 Thread Pavel Hrdina via Devel
On Tue, Oct 07, 2025 at 06:30:55PM +0200, Peter Krempa via Devel wrote: > I got burned by it in WIP patches. Let's not allow it anywhere. > > Peter Krempa (2): > Replace all use of 'g_new' with 'g_new0' > syntax-check: Prohibit the non-clearing 'g_new' Reviewed-by: Pavel Hrdina signature.a

AI coding policy question

2025-10-18 Thread Cole Robinson via Devel
Hi all, I used claude code to generate (unsubmitted) patches, before I realized libvirt had a policy rejecting AI generated submissions. The patches add domaincapabilities sound model output. If you've looked at code in this area, you know it's largely boilerplate. I'd describe the changes as:

Re: [PATCH 0/5] CH: Add network interface hotplug support

2025-10-18 Thread Michal Prívozník via Devel
On 10/6/25 17:18, Stefan Kober wrote: > This patch set adds support for attaching and detaching network interfaces to > Cloud Hypervisor domains at runtime. > > Stefan Kober (5): > ch: pass virCHDriver to chDomainAttachDeviceLice > ch: add net device alias assignment > ch: implement network

[PATCH 3/5] ch: implement network device hot attach

2025-10-18 Thread Stefan Kober
On-behalf-of: SAP [email protected] Signed-off-by: Stefan Kober --- src/ch/ch_hotplug.c | 10 +++ src/ch/ch_monitor.c | 5 +- src/ch/ch_monitor.h | 1 - src/ch/ch_process.c | 163 +--- src/ch/ch_process.h | 8 +++ 5 files changed, 111 insertions(+

[RFC PATCH v5 0/7] qemu: Implement support for iommufd and multiple HW-accel vSMMUs

2025-10-18 Thread Nathan Chen via Devel
Hi, This is a follow up to the fourth RFC patchset [0] for supporting multiple vSMMU instances and using iommufd to propagate DMA mappings to kernel for VM-assigned host devices in a qemu VM. This patchset implements support for specifying multiple devices within the VM definition when smmuv3Dev

globos personalizados

2025-10-18 Thread cbankerseniority
En https://www.globostuky.com.ar/, fabricamos desde 1964 los más innovadores productos de látex. Gracias a nuestros 60 años de experiencia, somos el proveedor más completo de globos y accesorios para decoración, publicidad y expresión social. Los globos son sinónimo de buenos momentos, alegría

[PULL 15/23] tests/lcitool: add missing rust-std dep

2025-10-18 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Some distros/targets may pull it by default, but some don't. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-ID: <[email protected]> --- scripts/ci/setup/ubuntu/ubuntu-2204-aarch64.yaml | 1 + scripts/ci

Re: [PATCH] virt-login-shell: check for NULL from virGetLastError()

2025-10-18 Thread Daniel P . Berrangé via Devel
On Mon, Sep 29, 2025 at 07:55:55PM +0300, [email protected] wrote: > From: Denis Rastyogin > > virGetLastError() may return NULL in case of OOM. Without a check this > could lead to a NULL pointer dereference when accessing its fields. > The result of virGetLastError() is usually checked in oth

[PATCH 05/20] domain_conf: Use virXMLFormatElement() to format hyperv features

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik Not only is it more modern that old virBufferAsprintf() of opening and closing tag, it's also aware of child elements buffer and thus formats a singleton properly. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 13 +++--

Re: [PATCH v2 14/29] qemu: Use virXPathTristateBool()

2025-10-18 Thread Ján Tomko via Devel
On a Wednesday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik There are two places in our code base which can use freshly introduced virXPathTristateBool(): qemuStorageSourcePrivateDataParse() and qemuDomainObjPrivateXMLParseBlockjobs(). Signed-off-by: Michal Privoznik ---

[PULL 09/23] tests/docker: use fully qualified image name for emsdk

2025-10-18 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Without it, at least it fails with podman on fc42: [1/6] STEP 1/15: FROM emscripten/emsdk:3.1.50 AS build-base Error: creating build container: short-name resolution enforced but cannot prompt without a TTY Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berran

Re: [PATCH v2 7/7] buildsys: Remove support for 32-bit MIPS hosts

2025-10-18 Thread Daniel P . Berrangé via Devel
On Thu, Oct 09, 2025 at 09:52:10PM +0200, Philippe Mathieu-Daudé wrote: > Stop detecting 32-bit MIPS host as supported, update the > deprecation document. See previous commit for rationale. > > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/about/deprecated.rst | 13 + > do

Re: [PATCH v2 01/29] docs: Fix QEMU version wrt hypervclock

2025-10-18 Thread Pavel Hrdina via Devel
On Wed, Oct 08, 2025 at 03:35:10PM +0200, Ján Tomko via Devel wrote: > On a Wednesday in 2025, Michal Privoznik via Devel wrote: > > From: Michal Privoznik > > > > The hv-time feature was introduced in QEMU commit > > v2.0.0-rc0~119^2~3 which means the first version the feature is > > available i

Re: [PATCH v2 2/3] conf: Support multiple smmuv3Dev IOMMU devices

2025-10-18 Thread Ján Tomko via Devel
On a Wednesday in 2025, Nathan Chen via Devel wrote: Add support for parsing multiple IOMMU devices from the VM definition when "smmuv3Dev" is the IOMMU model. Signed-off-by: Nathan Chen --- src/conf/domain_conf.c| 84 + src/conf/domain_conf.h| 9 +- src

Re: [PATCH 15/20] hyperv: Support hv-time enlightenment

2025-10-18 Thread Michal Prívozník via Devel
On 10/6/25 16:41, Pavel Hrdina wrote: > On Mon, Oct 06, 2025 at 03:14:46PM +0200, Michal Privoznik via Devel wrote: >> From: Michal Privoznik >> >> QEMU supports this enlightenment since version 2.0. It's required >> by some other enlightenments (e.g. hv-stimer, hv-stimer-direct). >> >From QEMU do

Re: [PATCH v2] RFC: audio: deprecate HMP audio commands

2025-10-18 Thread Dr. David Alan Gilbert
* [email protected] ([email protected]) wrote: > From: Marc-André Lureau > > The command is niche and better served by the host audio system. > There is no QMP equivalent, fortunately. You can capture the audio > stream via remote desktop protocols too (dbus, vnc, spice). > >

Re: [PATCH 0/3] Implement support for multiple vSMMUs

2025-10-18 Thread nathanc--- via Devel
This series is on Github: https://github.com/NathanChenNVIDIA/libvirt/tree/smmuv3Dev-no-accel-09-22-25 Thanks, Nathan [0] https://lists.libvirt.org/archives/list/[email protected]/thread/XXEO2O54IEJPTKRWLDZKCO53DM4RYL27/ [1] https://lore.kernel.org/qemu-devel/20250829082543.7680-1-skoloth

[RFC PATCH 01/16] qemu: monitor: Remove qemuMonitorQueryBlockstats

2025-10-18 Thread Peter Krempa via Devel
From: Peter Krempa Unused since v8.6.0-154-g75a0fbe420 Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 15 --- src/qemu/qemu_monitor.h | 2 -- src/qemu/qemu_monitor_json.c | 2 +- src/qemu/qemu_monitor_json.h | 3 --- 4 files changed, 1 insertion(+), 21 delet

[PATCH v2 21/29] conf: More hyperv related members into a single struct

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik So far, we have an array of integers (hyperv_features), an uint (hyperv_spinlocks), a string (hyperv_vendor_id) and some tristate switches scattered across virDomainDef. Soon, new knobs will be introduced and keeping the current state would only worsen readability. Introdu

Re: [PATCH] rpc: fix race against dtrace probe generator

2025-10-18 Thread Martin Kletzander via Devel
On Thu, Oct 02, 2025 at 03:13:25PM +0100, Daniel P. Berrangé via Devel wrote: On Thu, Oct 02, 2025 at 02:19:28PM +0100, Daniel P. Berrangé wrote: From: Daniel P. Berrangé The virt_socket_lib library has a dep on dtrace_gen_headers, but the virprobe.h file (which includes the libvirt_probes.h)

[PATCH v2 2/2] locking: use & install test_libvirt_sanlock.sug for both QEMU & LibXL

2025-10-18 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé The RPM specfile was referencing test_libvirt_sanlock.aug in the common file list, for both QEMU and LibXL. This makes sense since the sanlock.conf file is cloned for both drivers. The libvirt_sanlock.aug file, however, was missing a reference to the LibXL copy of the con

[PATCH v2 0/7] tcg/mips: Remove support for 32-bit hosts

2025-10-18 Thread Philippe Mathieu-Daudé
Since v1: - Removed N32/O32 ABIs (rth) - Do not remove tgen_qemu_ld2/st2 32-bit hosts are deprecated since v10.0. 2 releases later (as of v10.2) we can remove such code. Start with MIPS TCG backend. Remove related buildsys and testing. Philippe Mathieu-Daudé (7): docker: Remove 32-bit MIPS tool

[PATCH 18/20] conf: Introduce hyperv host-model mode

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik So far we have two modes for hyperv features: 1) custom, where users have to enable features explicitly, and 2) passthrough, where hypervisor enables features automagically. Problem with 'custom' mode is that some features are not plain on/off switches but expect int/stri

[PATCH v2 7/7] buildsys: Remove support for 32-bit MIPS hosts

2025-10-18 Thread Philippe Mathieu-Daudé
Stop detecting 32-bit MIPS host as supported, update the deprecation document. See previous commit for rationale. Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 13 + docs/about/removed-features.rst | 6 ++ configure | 7 --

Re: [PATCH] conf.c: use hwuuid for guest ABI stability check if present

2025-10-18 Thread Jiri Denemark via Devel
On Fri, Sep 26, 2025 at 10:37:38 +0100, Mark Cave-Ayland wrote: > With the introduction of the hwuuid element it is possible to pass a separate > hardware UUID from the domain UUID for use by the guest. > > In the case where the hwuuid element is present, it is the hardware UUID that > is visible

Re: [PATCH v2 03/29] conf: Introduce virDomainDefHasTimer()

2025-10-18 Thread Ján Tomko via Devel
On a Wednesday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik This is a simple helper to tell whether domain definition has certain type of timer or not. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 17 + src/conf/domain_conf.h | 4 s

Re: Qemu pause-before-switchover and libvirt live migration

2025-10-18 Thread Peter Krempa via Devel
On Thu, Oct 16, 2025 at 14:43:56 +, Rogério Vinhal Nunes via Devel wrote: > Hello, > > I’m looking into the libvirt hooks that are available to make use of during a > live migration, but there's only hooks on migration begin and migration end. > On qemu directly I’m able to use pause-before-

Entering freeze for libvirt-11.8.0

2025-10-18 Thread Jiri Denemark via Devel
I have just tagged v11.8.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

[PATCH v2 01/29] docs: Fix QEMU version wrt hypervclock

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik The hv-time feature was introduced in QEMU commit v2.0.0-rc0~119^2~3 which means the first version the feature is available in is 2.0.0. But our docs say 1.2.2. Fix it. Signed-off-by: Michal Privoznik --- docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH 3/8] wireshark: Move WIRESHARK_VERSION macro definition

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik Soon, other parts of the wireshark code will need to differentiate wrt wireshark version. Therefore, move the WIRESHARK_VERSION macro definition among with its deps into packet-libvirt.h. Signed-off-by: Michal Privoznik --- tools/wireshark/src/packet-libvirt.h | 14 +

[PATCH v2 11/29] NEWS: Document Hyper-V enlightenment validation

2025-10-18 Thread Michal Privoznik via Devel
From: Michal Privoznik Signed-off-by: Michal Privoznik --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 006b2ccf6a..c44203bcc1 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -25,6 +25,11 @@ v11.9.0 (unreleased) Intel-specific USB controllers are rele

  1   2   >