Re: [PATCH] virt-login-shell: check for NULL from virGetLastError()

2025-10-17 Thread Daniel P . Berrangé via Devel
On Wed, Oct 01, 2025 at 02:25:55PM -, Denis Rastyogin wrote: > Indeed, when virDomainCreate() < 0, virDispatchError() should be invoked, > but since we do not check its return value, there is no absolute guarantee > that the error message will always be set successfully. > > virDispatchError()

Re: [PATCH v2] RFC: audio: deprecate HMP audio commands

2025-10-17 Thread Marc-André Lureau via Devel
Hi Daniel On Wed, Oct 15, 2025 at 1:33 PM Daniel P. Berrangé wrote: > On Wed, Oct 15, 2025 at 01:28:51PM +0400, [email protected] > wrote: > > From: Marc-André Lureau > > > > The command is niche and better served by the host audio system. > > There is no QMP equivalent, fortunately.

[PATCH 2/2] syntax-check: Prohibit the non-clearing 'g_new'

2025-10-17 Thread Peter Krempa via Devel
From: Peter Krempa Signed-off-by: Peter Krempa --- build-aux/syntax-check.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 4ba059b56b..4deaa70368 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check

Re: [PATCH v2 27/27] WIP: enable rust for wasm/emscripten

2025-10-17 Thread Paolo Bonzini via Devel
On 9/29/25 10:52, Kohei Tokunaga wrote: Hi Marc-André, Thank you for working on this patch. > wasm-ld: error: unable to find library -llibqemuutil.a This issue looks similar to the one in "[PATCH v2 24/27] WIP: cirrus/macos: enable Rust" so I tried the upcoming meson change[1] mentioned in th

[RFC PATCH 00/16] qemu: Expose 'limits' and 'timed_stats' block device statistics via bulk stats API

2025-10-17 Thread Peter Krempa via Devel
This series is RFC as there's pending QEMU work enabling either of the groups: For the limits the following qemu patches are needed: https://lists.nongnu.org/archive/html/qemu-block/2025-09/msg00804.html For timed stats, the statistics already exist but can't be enabled without: https://lists

[PATCH v4 10/23] ui/vnc: remove use of error_printf_unless_qmp()

2025-10-17 Thread Daniel P . Berrangé via Devel
The error_printf_unless_qmp() will print to the monitor if the current one is HMP, if it is QMP nothing will be printed, otherwise stderr will be used. This scenario is easily handled by checking !monitor_cur_is_qmp() and then calling the error_printf() function. Reviewed-by: Dr. David Alan Gilbe

[RFC PATCH 12/16] Expose qemu timed block statistics via bulk stats API

2025-10-17 Thread Peter Krempa via Devel
From: Peter Krempa The statistics show various disk access timing parameters collected in configurable interval which can be useful for performance investigations. Note that the statistic collection needs to be enabled explicitly for the statistics to be collected and displayed. Signed-off-by:

[RFC PATCH 3/7] tests: qemuxmlconfdata: provide smmuv3Dev sample XML and CLI args

2025-10-17 Thread Nathan Chen via Devel
Provide sample XML and CLI args for the smmuv3Dev XML schema for pc, q35, and virt machine types. Signed-off-by: Nathan Chen --- .../iommu-smmuv3Dev.aarch64-latest.args | 39 .../iommu-smmuv3Dev.aarch64-latest.xml| 62 +++ tests/qemuxmlconfdata/iommu-sm

[PULL 22/23] build-sys: deprecate mips host

2025-10-17 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-ID: <[email protected]> --- docs/about/build-platforms.rst | 2 -- docs/about/deprecated.rst | 9 +++-- meson.build| 8

[PATCH] apparmor: Allow AMD-SEV device access for AMD-SEV VM

2025-10-17 Thread Hector Cao
AMD-SEV virtual machines interact with the underlying AMD-SEV technology through the character device /dev/sev. Currently, the AppArmor profile does not include the rule required to allow this access. There are two main approaches to address this limitation: 1) Add the required rule to the libvir

[PATCH v4 21/23] util: add support for formatting a program name in messages

2025-10-17 Thread Daniel P . Berrangé via Devel
The error_report function can include the program name in any messages it prints. The qemu_log function has no equivalent behaviour. This introduces support for a "program name" in the new messages API, which will be included by default for all binaries. This change tweaks the output of the error

Re: [RFC PATCH v7 0/3] Fix virtio console port assignment issue

2025-10-17 Thread Boris Fiuczynski
Ping On 9/19/25 21:26, Aaron M. Brown wrote: Changelog: --- v7: - Removed some unnecessary definitions from test xml - Moved edge case reservation logic to virDomainVirtioSerialAddrAssign --- v6: - Fixed issue with console auto port index starting from 1 instead of 0 --- v5: - Added xml

[PATCH v2 03/29] conf: Introduce virDomainDefHasTimer()

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik This is a simple helper to tell whether domain definition has certain type of timer or not. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 17 + src/conf/domain_conf.h | 4 src/libvirt_private.syms | 1 + 3 files changed, 22 inser

[PATCH 0/2] allow migrations with the ext transport

2025-10-17 Thread Sergey Dyasli
Hello, I have a use case for live-migration where the socket of the destination libvirtd is proxied by an mTLS WebSocket proxy. Since there is no WebSocket support in Libvirt, I've decided to use the existing ext transport and point it to a proxy binary on the source host of live-migration. Whil

[PATCH 20/20] NEWS: Document new host-model hyperv mode

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik Signed-off-by: Michal Privoznik --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 8b6c736f01..d0114a7a23 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -22,6 +22,12 @@ v11.9.0 (unreleased) The ``time`` Hyper-V enlightenment ena

Re: [PATCH v2 34/38] qemu: Unify USB controllers across Arm architectures

2025-10-17 Thread Peter Krempa via Devel
On Thu, Sep 25, 2025 at 20:07:20 +0200, Andrea Bolognani via Devel wrote: > Currently we differentiate between 64-bit and 32-bit > architectures, which doesn't seem very reasonable > considering that the same machine types are available > in both cases. Remove this inconsistency. > > Signed-off-by

Re: [PATCH v3 3/8] qemu: add /dev/mshv to default cgroup acl

2025-10-17 Thread Daniel P . Berrangé via Devel
On Fri, Aug 29, 2025 at 03:28:33PM -0500, Praveen K Paladugu wrote: > Add /dev/mshv to default set of devices allowed into domain's cgroup. > > Signed-off-by: Praveen K Paladugu > --- > src/qemu/qemu.conf.in | 2 +- > src/qemu/qemu_cgroup.c | 2 +- > src/qemu/test_libvir

Re: Qemu pause-before-switchover and libvirt live migration

2025-10-17 Thread Rogério Vinhal Nunes via Devel
Sent from my iPhone > On 17 Oct 2025, at 12:59, Peter Krempa wrote: > > > > Please don't top-post on technical lists. > >> On Thu, Oct 16, 2025 at 18:47:36 +, Rogério Vinhal Nunes wrote: >> >> We have some internal tools we need to setup/tear down on the time the >> domain stops on the

[PATCH v2 18/29] qemu_command: Move hyperv cmd line generation into a function

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 155 ++-- 1 file changed, 85 insertions(+), 70 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f7af92fe35..542022b889 100644 --- a/src/qemu

Re: [PATCH v2 25/27] RFC: build-sys: deprecate mips host

2025-10-17 Thread Philippe Mathieu-Daudé
On 24/9/25 14:04, [email protected] wrote: From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- docs/about/build-platforms.rst | 2 -- docs/about/deprecated.rst | 9 +++-- meson.build| 8 3 files changed, 11 insertions(+), 8 deletion

[PATCH 2/2] remote: allow migrations with the ext transport

2025-10-17 Thread Sergey Dyasli
Add virURICheckExtCommand() in a similar fashion to the existing virURICheckUnixSocket() and use it for (1) the same host migration check and (2) in remoteConnectOpen(). This allows to migrate VMs using the ext transport, as the external command can act as a proxy to the remote libvirt. Signed-of

[PULL 13/23] lcitool/qemu: include libclang-rt for TSAN

2025-10-17 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-ID: <[email protected]> --- scripts/ci/setup/ubuntu/ubuntu-2204-aarch64.yaml | 1 + scripts/ci/setup/ubuntu/ubuntu-2204-s390x.yaml| 1 + tests/docke

Re: [PATCH v4] qapi: net: deprecate vhostforce option

2025-10-17 Thread Markus Armbruster via Devel
Vladimir Sementsov-Ogievskiy writes: > This option for tap and vhost-user netdevs doesn't make sense > since long ago (10 years!), starting from commits: > > 1e7398a140f7a6 ("vhost: enable vhost without without MSI-X") > 24f938a682d934 ("vhost user:support vhost user nic for non msi guests") >

Re: [PATCH v3 4/9] tests: Add tests for SEV firmware selection

2025-10-17 Thread Jim Fehlig via Devel
On 9/24/25 06:19, Andrea Bolognani wrote: On Thu, Sep 18, 2025 at 06:11:09AM -0600, Jim Fehlig wrote: On 9/18/25 02:12, Andrea Bolognani wrote: I'm actively working to get things sorted out in Fedora, but unfortunately I'm having trouble getting access to SEV-capable hardware and that's slowing

Re: [PATCH v3 4/9] tests: Add tests for SEV firmware selection

2025-10-17 Thread Andrea Bolognani via Devel
On Wed, Sep 24, 2025 at 04:34:25PM -0600, Jim Fehlig wrote: > On 9/24/25 06:19, Andrea Bolognani wrote: > > On Thu, Sep 18, 2025 at 06:11:09AM -0600, Jim Fehlig wrote: > > > On 9/18/25 02:12, Andrea Bolognani wrote: > > > > I'm actively working to get things sorted out in Fedora, but > > > > unfort

Re: [PATCH v2 00/27] CI/build-sys fixes to enable Rust more widely

2025-10-17 Thread Marc-André Lureau
Hi On Tue, Sep 30, 2025 at 1:09 PM Paolo Bonzini via Devel wrote: > > On 9/27/25 19:17, Alex Bennée wrote: > > [email protected] writes: > > > >> From: Marc-André Lureau > >> > >> Hi, > >> > >> This patch series fixes a number of issues with the build system and CI and > >> enable Rust

[PATCH 0/3] Implement support for multiple vSMMUs

2025-10-17 Thread Nathan Chen via Devel
Hi, This is a follow up to the third RFC patchset [0] for supporting multiple vSMMU instances. This patchset implements support for specifying multiple devices within the VM definition when smmuv3Dev IOMMU model is specified, and is tested with Shameer's recently accepted qemu series for user-cr

Re: [PATCH 1/5] ch: pass virCHDriver to chDomainAttachDeviceLice

2025-10-17 Thread Michal Prívozník via Devel
On 10/6/25 17:18, Stefan Kober wrote: > On-behalf-of: SAP [email protected] > Signed-off-by: Stefan Kober > --- > src/ch/ch_hotplug.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/ch/ch_hotplug.c b/src/ch/ch_hotplug.c > index b953fe4c6c..902eab839b 100644 > -

[PATCH 07/20] qemu_command: Move hyperv cmd line generation into a function

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 155 ++-- 1 file changed, 85 insertions(+), 70 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 08e2a5147d..b235b505a8 100644 --- a/src/qemu

[PATCH v2 17/27] tests/docker: add ENABLE_RUST environment

2025-10-17 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- tests/docker/common.rc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/docker/common.rc b/tests/docker/common.rc index d202c0c666..52f01848a3 100755 --- a/tests/docker/common.rc +++ b/

[PATCH 2/5] ch: add net device alias assignment

2025-10-17 Thread Stefan Kober
On-behalf-of: SAP [email protected] Signed-off-by: Stefan Kober --- src/ch/ch_alias.c | 47 +++ src/ch/ch_alias.h | 3 +++ 2 files changed, 50 insertions(+) diff --git a/src/ch/ch_alias.c b/src/ch/ch_alias.c index bdf8452a3c..dad297b20c 100644 ---

Re: [PATCH v3] qapi: net/tap: deprecate vhostforce option

2025-10-17 Thread Jason Wang via Devel
On Mon, Sep 1, 2025 at 11:39 PM Vladimir Sementsov-Ogievskiy wrote: > > This option doesn't make sense since long ago (10 years!) > commit 1e7398a140f7a6 ("vhost: enable vhost without without MSI-X"). qemu-options.hx still say: """ "use vhostforce=on to force vhost on for non

[PATCH 17/20] qemu_caps: Introduce virQEMUCapsGetHypervCapabilities()

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik We'll need to access hypervCapabilities memeber later on. Introduce a getter function. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 7 +++ src/qemu/qemu_capabilities.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/src/qemu/qemu_capabi

[RFC PATCH 14/16] qemu: capabilities: Introduce QEMU_CAPS_DISK_TIMED_STATS

2025-10-17 Thread Peter Krempa via Devel
From: Peter Krempa The capability tracks support for 'stats-intervals' property of disk frontends which enables statistics collection on the devices. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h |

[PULL 12/23] lcitool: update, switch to f41

2025-10-17 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Newer lcitool version has various fixes helping QEMU CI and this series. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-ID: <[email protected]> --- scripts/ci/setup/ubuntu/ubuntu-2204-aarch64.yaml | 3 ++-

Re: [PATCH v2 2/3] conf: Support multiple smmuv3Dev IOMMU devices

2025-10-17 Thread Daniel P . Berrangé via Devel
On Wed, Oct 01, 2025 at 05:23:47PM -0700, Nathan Chen via Devel wrote: > Add support for parsing multiple IOMMU devices from > the VM definition when "smmuv3Dev" is the IOMMU model. > > Signed-off-by: Nathan Chen > --- > src/conf/domain_conf.c| 84 + > src/conf/domai

[RFC PATCH 4/7] qemu: Implement support for associating iommufd to hostdev

2025-10-17 Thread Nathan Chen via Devel
Implement a new iommufd attribute under hostdevs' PCI subsystem driver that can be used to specify associated iommufd object when launching a qemu VM. Signed-off-by: Nathan Chen --- docs/formatdomain.rst | 8 src/conf/device_conf.c | 9 + src/conf/device_con

[RFC PATCH 08/16] Remove qemuMonitorBlockStatsUpdateCapacityBlockdev

2025-10-17 Thread Peter Krempa via Devel
From: Peter Krempa Remove the function and address the ripple effect the removal has. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 16 +++- src/qemu/qemu_monitor.c | 12 src/qemu/qemu_monitor.h | 5 - src/qemu/qemu_monitor_json.c | 9 -

[PATCH v2 2/2] net/stream: remove deprecated 'reconnect' option

2025-10-17 Thread Vladimir Sementsov-Ogievskiy
It was deprecated in 9.2, time to remove. Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/about/deprecated.rst | 9 - docs/about/removed-features.rst | 10 ++ net/stream.c| 20 +--- qapi/net.json | 13 +

Re: [PATCH v2 00/27] CI/build-sys fixes to enable Rust more widely

2025-10-17 Thread Alex Bennée
Marc-André Lureau writes: > On Sat, Sep 27, 2025 at 9:18 PM Alex Bennée wrote: > > [email protected] writes: > > > From: Marc-André Lureau > > > > Hi, > > > > This patch series fixes a number of issues with the build system and CI and > > enable Rust for many of our jobs, getti

[PATCH v2 6/7] kvm/mips: Remove support for 32-bit hosts

2025-10-17 Thread Philippe Mathieu-Daudé
See previous commit for rationale. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 2 -- 1 file changed, 2 deletions(-) diff --git a/meson.build b/meson.build index afaefa01722..c5710a6a47c 100644 --- a/meson.build +++ b/meson.build @@ -295,8 +295,6 @@ elif cpu == 'ppc' kvm_targets =

[PATCH v4 01/23] include: define constant for early constructor priority

2025-10-17 Thread Daniel P . Berrangé via Devel
Functions marked with __attribute__((__constructor__)) will be invoked in linker order. In theory this is well defined, but in practice, it is hard to determine what this order will be with the layers of indirection through meson, ninja and the static libraries QEMU builds. Notably, the order curr

[PATCH 10/20] conf: More hyperv related members into a single struct

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik So far, we have an array of integers (hyperv_features), an uint (hyperv_spinlocks), a string (hyperv_vendor_id) and some tristate switches scattered across virDomainDef. Soon, new knobs will be introduced and keeping the current state would only worsen readability. Introdu

[RFC PATCH 15/16] conf: Add configuration option for timed disk statistics collection

2025-10-17 Thread Peter Krempa via Devel
From: Peter Krempa QEMU supports collection of disk statistics in configurable time windows. Add support for enabling this feature to the conf parser. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 17 src/conf/domain_conf.c| 34 +++

[PATCH v2 26/27] build-sys: pass -fvisibility=default for wasm bindgen

2025-10-17 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Otherwise, no functions are generated: https://github.com/rust-lang/rust-bindgen/issues/2989 Signed-off-by: Marc-André Lureau --- meson.build| 4 rust/bql/meson.build | 1 + rust/chardev/meson.build | 1 + rust/hw/char/pl011/meso

Re: [PATCH v2 0/2] Fix sanlock without qemu (dejavu)

2025-10-17 Thread Martin Kletzander via Devel
On Mon, Oct 06, 2025 at 12:17:30PM +0100, Daniel P. Berrangé via Devel wrote: My previous RPM fix was wrong, as sanlock can actually be used with libxl too. It is the meson rules that were wrong. I could've foresee this, but both your previous fix and Cole's patch together made sense... if bli

[PATCH 0/2] Forbid 'g_new' (the one without clearing memory)

2025-10-17 Thread Peter Krempa via Devel
I got burned by it in WIP patches. Let's not allow it anywhere. Peter Krempa (2): Replace all use of 'g_new' with 'g_new0' syntax-check: Prohibit the non-clearing 'g_new' build-aux/syntax-check.mk | 2 +- src/network/network_pf.c | 2 +- src/qemu/qemu_nbdkit.c| 2 +- src/qemu/qemu_proce

Re: [PATCH] qemu: Drop reconnectBlockjobs from _qemuDomainObjPrivate struct

2025-10-17 Thread Peter Krempa via Devel
On Wed, Oct 15, 2025 at 10:52:28 +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > The 'reconnectBlockjobs' member of the _qemuDomainObjPrivate > struct is basically unused after v8.7.0-rc1~110. It's not even > formatted into the status XML, just parsed. This makes needless >

Re: Qemu pause-before-switchover and libvirt live migration

2025-10-17 Thread Peter Krempa via Devel
Please don't top-post on technical lists. On Thu, Oct 16, 2025 at 18:47:36 +, Rogério Vinhal Nunes wrote: > > We have some internal tools we need to setup/tear down on the time the > domain stops on the source and starts on the destination, so I don't > believe full native support would fit.

Re: [PATCH 0/2] remove deprecated 'reconnect' options

2025-10-17 Thread Markus Armbruster via Devel
Vladimir Sementsov-Ogievskiy writes: > On 10.10.25 10:52, Michael Tokarev wrote: >> On 10/9/25 17:17, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> They were deprecated in 9.2, now we can remove them. New options to use are reconnect-ms. >> Speaking of the optio

Re: [PATCH v2 04/29] qemuxmlconfdata: Adjust hv-stimer related tests

2025-10-17 Thread Ján Tomko via Devel
On a Wednesday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik In QEMU, hv-stimer and hv-stimer-direct require hv-time. Reflect this fact in our tests. Signed-off-by: Michal Privoznik --- tests/qemuxmlconfdata/hyperv-stimer-direct.x86_64-latest.args | 2 +- tests/qemuxmlconfd

Re: [PATCH v2 27/27] WIP: enable rust for wasm/emscripten

2025-10-17 Thread Kohei Tokunaga
Hi Marc-André, Thank you for working on this patch. > wasm-ld: error: unable to find library -llibqemuutil.a This issue looks similar to the one in "[PATCH v2 24/27] WIP: cirrus/macos: enable Rust" so I tried the upcoming meson change[1] mentioned in that patch for the wasm build. By also applyi

[PATCH v2 1/2] Revert "rpm: disable sanlock when QEMU is disabled"

2025-10-17 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé This reverts commit fefde6175884ff65241ddb3afae2d903df37e20e. The commit was mistaken, as sanlock is enabled for libxl too, however, the install of test_libvirt_sanlock.aug was missing when QEMU was disabled, causing the RPM build failure. Signed-off-by: Daniel P. Berra

Re: [PATCH] qemu: add support for dirty-sync-missed-zero-copy migration statistic

2025-10-17 Thread Tejus GK
> On 3 Oct 2025, at 10:59 PM, Tejus GK wrote: > > QEMU can report how many times a zerocopy send got deferred during a > live migration with VIR_MIGRATE_ZEROCOPY enabled. Support the stat in > libvirt as part of virDomainGetJobStats > > Signed-off-by: Tejus GK > --- > include/libvirt/libvirt-

Re: [PATCH] NEWS: Fix format of XML elements/attributes in v11.8.0 section

2025-10-17 Thread Ján Tomko via Devel
On a Monday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik It's a good practice to use a different style of formatting for literal values like XML element/attribute names, functions, etc. In this specific case, the 'acpi' and 'nodeset' names should be formatted using two sing

[PATCH 3/7] qemu: Re-activate block nodes before storage operations

2025-10-17 Thread Peter Krempa via Devel
From: Peter Krempa Upcoming patches will modify how we treat inactive block nodes so that we can properly deactivate nodes for 'manual' disk snapshot mode. Re-activate the nodes before operations requiring them. This includes also query operations where we e.g. probe bitmaps. Signed-off-by: Pet

Re: [PATCH v2] RFC: audio: deprecate HMP audio commands

2025-10-17 Thread Daniel P . Berrangé via Devel
On Wed, Oct 15, 2025 at 01:28:51PM +0400, [email protected] wrote: > From: Marc-André Lureau > > The command is niche and better served by the host audio system. > There is no QMP equivalent, fortunately. You can capture the audio > stream via remote desktop protocols too (dbus, vnc, sp

[PATCH v2 29/29] NEWS: Document new host-model hyperv mode

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik Signed-off-by: Michal Privoznik --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index c44203bcc1..5dcc4a1c2f 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,12 @@ v11.9.0 (unreleased) * **New features** + * Introduce Hype

[PATCH 1/2] remote: allow passing cmd arguments to REMOTE_DRIVER_TRANSPORT_EXT

2025-10-17 Thread Sergey Dyasli
Allow passing up to 5 arguments to the ext program via the query parameters. URI example: qemu+ext:///system?command=/bin/prog&ext_arg1=192.168.0.10&ext_arg2=8080 Signed-off-by: Sergey Dyasli --- src/remote/remote_driver.c | 23 ++- 1 file changed, 22 insertions(+), 1 de

Re: [PATCH v1] lcitool: remove obsolete RISC-V ports setup for Debian 13+

2025-10-17 Thread yangzewei
Hello all, Apologies for the previous patch. Since it was my first time sending a patch via email, the message included some extra headers/footers from my company email client. If this affected the patch application, I can send a clean [PATCH v2] version. Thanks for your understanding.

Re: [PATCH 0/1] Refine the domain status saving logic

2025-10-17 Thread Yong Huang
On Mon, Sep 22, 2025 at 4:49 PM Yong Huang wrote: > > > On Mon, Sep 22, 2025 at 4:28 PM Peter Krempa wrote: > >> On Mon, Sep 22, 2025 at 16:15:47 +0800, Yong Huang wrote: >> > On Mon, Sep 22, 2025 at 2:59 PM Peter Krempa >> wrote: >> > >> > > On Mon, Sep 22, 2025 at 11:30:46 +0800, Yong Huang w

Re: [PATCH 7/8] wireshark: Don't leak column strings

2025-10-17 Thread Michal Prívozník via Devel
On 10/14/25 14:23, Peter Krempa wrote: > On Tue, Oct 14, 2025 at 08:31:46 +0200, Michal Privoznik via Devel wrote: >> From: Michal Privoznik >> >> One of the problems of using val_to_str() is that it may return a >> const string from given table ('vs'), OR return an allocated one. >> Since the cal

[PATCH v4 14/23] monitor: introduce monitor_cur_is_hmp() helper

2025-10-17 Thread Daniel P . Berrangé via Devel
Note that this is not simply the inverse of monitor_cur_is_qmp(), as both helpers require that monitor_cur() is first non-NULL. Signed-off-by: Daniel P. Berrangé --- include/monitor/monitor.h | 1 + monitor/monitor.c | 10 ++ stubs/monitor-core.c | 6 ++

Re: [PATCH v2 01/29] docs: Fix QEMU version wrt hypervclock

2025-10-17 Thread Ján Tomko via Devel
On a Wednesday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik The hv-time feature was introduced in QEMU commit v2.0.0-rc0~119^2~3 which means the first version the feature is available in is 2.0.0. But our docs say 1.2.2. Fix it. Those are libvirt versions, "qemu" means i

[PATCH v2 07/29] qemu_validate: Reflect dependencies of hv-tlbflush

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik Per QEMU documentation (docs/system/i386/hyperv.rst): ``hv-tlbflush`` Enables paravirtualized TLB shoot-down mechanism. Requires: ``hv-vpindex`` Reflect this dependency when validating domain definition. Signed-off-by: Michal Privoznik --- src/qemu/qemu_validate.

Re: [PATCH v4 22/23] util: add support for formatting thread info in messages

2025-10-17 Thread Philippe Mathieu-Daudé
On 25/9/25 11:44, Daniel P. Berrangé wrote: The message context is now extended to be able to include the thread ID and thread name, after the program name. On Linux the thread ID will match the process TID visible in /proc, while on other platforms it will merely be an integer repr of the system

[PATCH v2 26/29] qemu_caps: Introduce virQEMUCapsGetHypervCapabilities()

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik We'll need to access hypervCapabilities memeber later on. Introduce a getter function. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 7 +++ src/qemu/qemu_capabilities.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/src/qemu/qemu_capabi

[PATCH v2 02/29] src: Drop needless typecast to virDomainTimerNameType

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik This was missed in v8.10.0-rc1~229 which switched the 'name' member of _virDomainTimerDef struct from int to virDomainTimerNameType. Signed-off-by: Michal Privoznik --- src/libxl/libxl_conf.c | 2 +- src/libxl/xen_common.c | 2 +- src/lxc/lxc_cgroup.c | 2 +- src

Re: [PATCH v4] qapi: net: deprecate vhostforce option

2025-10-17 Thread Markus Armbruster via Devel
Vladimir Sementsov-Ogievskiy writes: > On 16.10.25 11:48, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> This option for tap and vhost-user netdevs doesn't make sense >>> since long ago (10 years!), starting from commits: >>> >>> 1e7398a140f7a6 ("vhost: enable vhost w

Re: [PATCH 8/8] wireshark: Adapt to wireshark-4.6.0

2025-10-17 Thread Michal Prívozník via Devel
On 10/14/25 14:33, Peter Krempa wrote: > On Tue, Oct 14, 2025 at 08:31:47 +0200, Michal Privoznik via Devel wrote: >> From: Michal Privoznik >> >> The main difference is that wmem_packet_scope() is gone [1] but >> the packet_info struct has 'pool` member which points to the >> allocator used for g

[PATCH v3 02/23] vhost: drop backend_features field

2025-10-17 Thread Vladimir Sementsov-Ogievskiy
This field is mostly unused and sometimes confusing. We even have a TODO-like comment to drop it, the comment is removed in this commit. The field is used to held VHOST_USER_F_PROTOCOL_FEATURES for vhost-user and/or VHOST_NET_F_VIRTIO_NET_HDR for vhost-net (which may be vhost-user-net). But we can

Re: [PATCH v2 26/27] build-sys: pass -fvisibility=default for wasm bindgen

2025-10-17 Thread Kohei Tokunaga
> From: Marc-André Lureau > > Otherwise, no functions are generated: > https://github.com/rust-lang/rust-bindgen/issues/2989 > > Signed-off-by: Marc-André Lureau > --- > meson.build| 4 > rust/bql/meson.build | 1 + > rust/chardev/meson.build | 1 + > rus

[RFC PATCH 07/16] qemuMonitorJSONGetAllBlockStatsInfo: Directly probe data from 'query-named-block-nodes'

2025-10-17 Thread Peter Krempa via Devel
From: Peter Krempa Currently the data which was probed for statistics from 'query-named-block-nodes' was updated in a separate call in qemuMonitorJSONBlockStatsUpdateCapacityBlockdev. This patch moves and adapts the code so that everything is probed in qemuMonitorJSONGetAllBlockStatsInfo. qemuM

Re: [PATCH v4] qapi: net: deprecate vhostforce option

2025-10-17 Thread Vladimir Sementsov-Ogievskiy
On 16.10.25 13:38, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: On 16.10.25 11:48, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: This option for tap and vhost-user netdevs doesn't make sense since long ago (10 years!), starting from commits: 1e7398a140f

Re: [PATCH 0/2] remove deprecated 'reconnect' options

2025-10-17 Thread Michael Tokarev
On 10/9/25 17:17, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: They were deprecated in 9.2, now we can remove them. New options to use are reconnect-ms. Reviewed-by: Michael Tokarev Who would like to merge this? * Marc-André, since PATCH 1 is chardev * Jason, since PATCH

Re: [PATCH v2 4/7] tcg/mips: Remove support for O32 and N32 ABIs

2025-10-17 Thread Thomas Huth via Devel
On 09/10/2025 21.52, Philippe Mathieu-Daudé wrote: See previous commit for rationale. Signed-off-by: Philippe Mathieu-Daudé --- tcg/mips/tcg-target-reg-bits.h | 9 ++ tcg/mips/tcg-target.c.inc| 15 ++ common-user/host/mips/safe-syscall.inc.S | 35 -

libvirt-11.8.0 release candidate 2

2025-10-17 Thread Jiri Denemark via Devel
I have just tagged v11.8.0-rc2 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

[PATCH v2 23/29] conf: Report default hyperv values in domain capabilities

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik So far the set of available Hyper-V enlightenments are reported in domain capabilities. Well, some enlightenments are more than just simple on/off switch. For instance, the 'spinlocks' enlightenment expects a number, or 'vendor_id' expects a string. All of these have some

Re: [PATCH v2 19/38] qemu: Add sanity checks for auto-added PCI and USB controllers

2025-10-17 Thread Peter Krempa via Devel
The summary is wrong; it mentions USB which was removed. On Fri, Oct 03, 2025 at 08:56:37 +0200, Peter Krempa via Devel wrote: > On Thu, Sep 25, 2025 at 20:07:05 +0200, Andrea Bolognani via Devel wrote: > > These checks enforce some expectations that were, until now, > > documented solely through

Re: [PATCH v3] libvirt-ci: remove obsolete RISC-V ports setup for Debian 13+

2025-10-17 Thread Daniel P . Berrangé via Devel
Hi, Only the main libvirt.git uses the old style mailing list workflow. Everything else is exclusively gitlab merge requests, so could you submit an MR for this against the https://gitlab.com/libvirt/libvirt-ci repository. On Sat, Oct 11, 2025 at 10:26:00AM +0800, [email protected] wrote: > F

Re: [PATCH 1/2] remote: allow passing cmd arguments to REMOTE_DRIVER_TRANSPORT_EXT

2025-10-17 Thread Daniel P . Berrangé via Devel
On Tue, Oct 14, 2025 at 03:13:10PM +0100, Sergey Dyasli wrote: > On 10/10/2025 10:18, Daniel P. Berrangé wrote: > > On Fri, Oct 10, 2025 at 08:58:17AM +, Sergey Dyasli wrote: > > > Allow passing up to 5 arguments to the ext program via the query > > > parameters. URI example: > > > > > >

[PULL 07/23] configure: set the bindgen cross target

2025-10-17 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Implement a bash version of rust-bindgen rust_to_clang_target() to convert from rust target to clang target. Signed-off-by: Marc-André Lureau Reviewed-by: Paolo Bonzini Message-ID: <[email protected]> --- configure

[PATCH 04/20] domain_conf: Move format of hyperv features into a function

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 158 ++--- 1 file changed, 84 insertions(+), 74 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 281846dfbe..6fa07267c0 100644 --- a/src/conf/d

[PATCH v2 22/29] docs: Drop remark on now unsupported version of QEMU

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik In formatdomaincaps.rst under section documenting hyperv features there's a paragraph describing behaviour with QEMU older than 6.1.0. Well, as of v11.2.0-rc1~216 the minimum required version is 6.2.0 rendering the paragraph needless. Drop it. Signed-off-by: Michal Privozn

[PATCH] qemuxmlconftest: Add example for "sgio='filtered'" disk option

2025-10-17 Thread Peter Krempa via Devel
From: Peter Krempa The test suite validates only the error with the "sgio='unfiltered'" setting which isn't supported by the qemu driver. Validate also the 'filtered' used explicitly (the default behaviour if unspecified is the same as 'filtered'). Signed-off-by: Peter Krempa --- .../qemuxmlco

[PATCH v2 19/29] qemu_command: Prefer virBufferAddLit() in qemuBuildCpuHypervCommandLine()

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik Using virBufferAsprintf() just to concatenate two literal strings is excessive. Use virBufferAddLit(). Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_

Re: [PATCH v2 7/7] buildsys: Remove support for 32-bit MIPS hosts

2025-10-17 Thread Philippe Mathieu-Daudé
On 10/10/25 10:46, Daniel P. Berrangé wrote: On Thu, Oct 09, 2025 at 09:52:10PM +0200, Philippe Mathieu-Daudé wrote: Stop detecting 32-bit MIPS host as supported, update the deprecation document. See previous commit for rationale. Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecat

Re: [PATCH 1/8] wireshark: Drop needless declaration of proto_register_libvirt() and proto_reg_handoff_libvirt()

2025-10-17 Thread Peter Krempa via Devel
On Tue, Oct 14, 2025 at 08:31:40 +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > Both proto_register_libvirt() and proto_reg_handoff_libvirt() are > declared in packet-libvirt.h which is included from plugin.c. > There's no need to provide another declaration in plugin.c. >

Re: [PATCH v3 3/8] qemu: add /dev/mshv to default cgroup acl

2025-10-17 Thread Praveen K Paladugu
On 10/1/2025 4:52 AM, Daniel P. Berrangé wrote: On Fri, Aug 29, 2025 at 03:28:33PM -0500, Praveen K Paladugu wrote: Add /dev/mshv to default set of devices allowed into domain's cgroup. Signed-off-by: Praveen K Paladugu --- src/qemu/qemu.conf.in | 2 +- src/qemu/qemu_cgroup.

[PATCH] qemu: Drop /dev/kvm from default device ACL

2025-10-17 Thread Praveen K Paladugu
A domain that runs with TCG emulation does not need kvm device, so drop it from default device ACL. To dynamically add devices to defaultDeviceACL, make it a GSList. This variable will be initialized when qemu driver is initalized. Lastly, dynamically append /dev/kvm to default ACL only if the do

[PULL 05/23] scripts/archive-source: use a bash array

2025-10-17 Thread marcandre.lureau--- via Devel
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Alex Bennée Message-ID: <[email protected]> --- scripts/archive-source.sh | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/scripts/archiv

[RFC PATCH 02/16] qemu_monitor_json.c: Use consistent function hader coding style

2025-10-17 Thread Peter Krempa via Devel
From: Peter Krempa Convert the rest of the code to the new prevailing coding style. Commit 6e6a11bc0ac did the same for the header file. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 373 +++ 1 file changed, 246 insertions(+), 127 deletions(-)

[RFC PATCH 10/16] Expose qemu storage request limits via bulk stats API

2025-10-17 Thread Peter Krempa via Devel
From: Peter Krempa Management applications can use the detected limits to cross reference with configuration within the VM to ensure optimal performance. Signed-off-by: Peter Krempa --- docs/manpages/virsh.rst | 21 + include/libvirt/libvirt-domain.h | 148 +++

Re: [PATCH v4 20/23] util: add support for formatting a workload name in messages

2025-10-17 Thread Philippe Mathieu-Daudé
On 25/9/25 11:44, Daniel P. Berrangé wrote: The error_report function can include the guest name in any messages it prints. The qemu_log function has no equivalent behaviour. This introduces support for a "workload name" in the new messages API, which in the case of system emulators will be the

Re: [PATCH v3 0/7] USB hostdev: allow addressing by port

2025-10-17 Thread Maximilian Martin via Devel
Ping :) Am 18.09.2025 um 08:25 schrieb Maximilian Martin via Devel: Ping :) Let me know if there is anything I can do to make this feature finally come to life. Am 04.09.2025 um 22:11 schrieb Maximilian Martin: Ping Am 18.08.25, 16:40 schrieb Maximilian Martin via Devel http://lists.libv

Re: [PATCH RFC V6 22/24] monitor,qdev: Introduce 'device_set' to change admin state of existing devices

2025-10-17 Thread Igor Mammedov via Devel
On Thu, 09 Oct 2025 16:55:54 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > On Thu, 09 Oct 2025 10:55:40 +0200 > > Markus Armbruster wrote: > > > >> [email protected] writes: > >> > >> > From: Salil Mehta > >> > > >> > This patch adds a "device_set" interface for modif

[PATCH v2 05/29] qemu_validate: Reflect dependencies of hv-synic

2025-10-17 Thread Michal Privoznik via Devel
From: Michal Privoznik Per QEMU documentation (docs/system/i386/hyperv.rst): ``hv-synic`` Enables Hyper-V Synthetic interrupt controller Requires: ``hv-vpindex`` Reflect this dependency when validating domain definition. Signed-off-by: Michal Privoznik --- src/qemu/qemu_validate.c | 42

[PATCH 0/7] qemu: Node reactivation and 'manual' disk snapshot enhancements

2025-10-17 Thread Peter Krempa via Devel
Peter Krempa (7): qemu: monitor: Track inactive state of block nodes in 'qemuBlockNamedNodeData' qemu: block: Introduce helper function to ensure that block nodes are active qemu: Re-activate block nodes before storage operations qemu: migration: Don't reactivate block nodes after m

Re: [PATCH v2 2/3] conf: Support multiple smmuv3Dev IOMMU devices

2025-10-17 Thread nathanc--- via Devel
Hi Jano, Thank you for the detailed feedback on patches 1 and 2. I will address these review comments in the next revision. Thanks, Nathan

Re: Qemu pause-before-switchover and libvirt live migration

2025-10-17 Thread Peter Krempa via Devel
On Fri, Oct 17, 2025 at 11:45:09 +0200, Claudio Fontana wrote: > On 10/16/25 19:44, Peter Krempa via Devel wrote: > > On Thu, Oct 16, 2025 at 14:43:56 +, Rogério Vinhal Nunes via Devel > > wrote: > >> Hello, > >> > >> I’m looking into the libvirt hooks that are available to make use of > >> d

  1   2   >