Re: libvirt-gitlab-executor - maintainer?

2025-07-18 Thread Daniel P . Berrangé via Devel
On Fri, Jul 18, 2025 at 05:28:59PM +0200, Kristina Hanicova via Devel wrote: > Hello Libvirt friends, > > Is anyone interested in maintaining this orphaned repository: > https://gitlab.com/libvirt/libvirt-gitlab-executor ? > > It is used in Cryptsetup CI and we would like to upstream some changes

libvirt-gitlab-executor - maintainer?

2025-07-18 Thread Kristina Hanicova via Devel
Hello Libvirt friends, Is anyone interested in maintaining this orphaned repository: https://gitlab.com/libvirt/libvirt-gitlab-executor ? It is used in Cryptsetup CI and we would like to upstream some changes. If no one is interested, I am willing to take on the role of the maintainer myself:) R

Re: [PATCH 0/2] meson: Report library versions in the summary

2025-07-18 Thread Pavel Hrdina via Devel
On Fri, Jul 18, 2025 at 03:34:19PM +0200, Michal Privoznik via Devel wrote: > Green pipeline: > > https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1934463449 > > and if you shod individual builds you can see these in action. Nice! > Michal Prívozník (2): > meson: Convert attr_dep to de

Re: [PATCH] qemu_tpm: Do not use persistent definition during pre-start checks

2025-07-18 Thread Pavel Hrdina via Devel
On Fri, Jul 18, 2025 at 03:08:38PM +0200, Martin Kletzander wrote: > From: Martin Kletzander > > Commit 3451987fca7c used the persistent TPM Definition in both calls to > qemuTPMVirCommandSwtpmAddTPMState() but in one of the two cases it > might've been NULL and what's more, it is not the right d

[PATCH 2/2] meson: Report library versions in the summary

2025-07-18 Thread Michal Privoznik via Devel
From: Michal Privoznik The summary() directive accepts dependency() too [1] in which case it also prints version of the dependency found. This may come handy when reading build process transcripts. 1: https://mesonbuild.com/Reference-manual_functions.html#summary Signed-off-by: Michal Privoznik

[PATCH 1/2] meson: Convert attr_dep to dependency()

2025-07-18 Thread Michal Privoznik via Devel
From: Michal Privoznik Currently, libattr is detected using cc.find_library() because at historically, the library was lacking pkg-config file. But that changed with libattr-2.4.48 (released 7+ years ago) and even prehistoric distros have it now. Switch to dependency(). Signed-off-by: Michal Pri

[PATCH 0/2] meson: Report library versions in the summary

2025-07-18 Thread Michal Privoznik via Devel
Green pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1934463449 and if you shod individual builds you can see these in action. Michal Prívozník (2): meson: Convert attr_dep to dependency() meson: Report library versions in the summary meson.build | 77

Re: [PATCH 0/4] qemu: add support for RBD namespace

2025-07-18 Thread Peter Krempa via Devel
On Wed, Jun 25, 2025 at 17:56:33 +0200, Peter Krempa wrote: > After recent inquiry on libvirt-users I've necromanced this already very > old series that I still had laying around. > > This series: > - turns virStorageSource's 'protocol' to real enum > - removes virStorageSource's 'volume' > - w

Re: [PATCH 2/6] nss: Move logging into a separate file and turn it temporarily on

2025-07-18 Thread Michal Prívozník via Devel
On 7/16/25 13:27, Ján Tomko wrote: > On a Friday in 2025, Michal Privoznik via Devel wrote: >> From: Michal Privoznik >> >> Currently, when somebody wants to debug the NSS plugin, they have >> to change a line in libvirt_nss.h (to enable debug printings) and >> recompile the module. This may work

[PATCH] qemu_tpm: Do not use persistent definition during pre-start checks

2025-07-18 Thread Martin Kletzander via Devel
From: Martin Kletzander Commit 3451987fca7c used the persistent TPM Definition in both calls to qemuTPMVirCommandSwtpmAddTPMState() but in one of the two cases it might've been NULL and what's more, it is not the right definition which should've been used. Change that to @tpm which is the curren

Re: [PATCH 3/3] qemu_tpm: Only warn about missing locking feature on shared filesystems

2025-07-18 Thread Martin Kletzander via Devel
On Fri, Jul 18, 2025 at 11:03:56AM +0200, Pavel Hrdina wrote: On Thu, Jul 17, 2025 at 12:34:43PM +0200, Martin Kletzander via Devel wrote: From: Martin Kletzander The warning pollutes the logs and might give a bad impression on someone reading them even though the locking is not always needed.

Re: [PATCH 3/3] qemu: add ability to set TLS priority string with QEMU

2025-07-18 Thread Peter Krempa via Devel
On Fri, Jul 18, 2025 at 13:05:33 +0100, Daniel P. Berrangé via Devel wrote: > From: Daniel P. Berrangé > > QEMU will either use the GNUTLS default priority string of "NORMAL", > or on Fedora/RHEL related distros, "@QEMU,SYSTEM", which resolves to > a configuration in /etc/crypto-policies/back-end

Re: [PATCH 2/3] qemu: sanitize blank lines in config file

2025-07-18 Thread Peter Krempa via Devel
On Fri, Jul 18, 2025 at 13:05:32 +0100, Daniel P. Berrangé via Devel wrote: > From: Daniel P. Berrangé > > We mostly use 2 blank lines between config file entries to > improve readability. Fix where we don't do that. > > Signed-off-by: Daniel P. Berrangé > --- > src/qemu/qemu.conf.in | 50

Re: [PATCH 1/3] qemu: fix order of VNC TLS config entries

2025-07-18 Thread Peter Krempa via Devel
On Fri, Jul 18, 2025 at 13:05:31 +0100, Daniel P. Berrangé via Devel wrote: > From: Daniel P. Berrangé > > For TLS config parameters, the 'verify' option always comes before the > 'secret_uuid' option, except in the VNC case which has them reversed. > > Signed-off-by: Daniel P. Berrangé > --- >

Plans for 11.6.0 release (freeze on 2025-07-28)

2025-07-18 Thread Jiri Denemark via Devel
We are getting close to 11.6.0 release of libvirt. To aim for the release on Friday 01 Aug I suggest entering the freeze on Monday 28 Jul and tagging RC2 on Wednesday 30 Jul. I hope this works for everyone. Jirka

[PATCH 3/3] qemu: add ability to set TLS priority string with QEMU

2025-07-18 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé QEMU will either use the GNUTLS default priority string of "NORMAL", or on Fedora/RHEL related distros, "@QEMU,SYSTEM", which resolves to a configuration in /etc/crypto-policies/back-ends/gnutls.config. The latter gives the sysadmin the ability to change the priority str

[PATCH 2/3] qemu: sanitize blank lines in config file

2025-07-18 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé We mostly use 2 blank lines between config file entries to improve readability. Fix where we don't do that. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu.conf.in | 50 +-- 1 file changed, 48 insertions(+), 2 deletions(-) d

[PATCH 1/3] qemu: fix order of VNC TLS config entries

2025-07-18 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé For TLS config parameters, the 'verify' option always comes before the 'secret_uuid' option, except in the VNC case which has them reversed. Signed-off-by: Daniel P. Berrangé --- src/qemu/libvirtd_qemu.aug | 2 +- src/qemu/qemu.conf.in | 12 ++

[PATCH 0/3] qemu: workaround for GNUTLS bug hitting live migration

2025-07-18 Thread Daniel P . Berrangé via Devel
This is a workaround for existing running QEMU processes which are susceptible to a GNUTLS crasher bug with non-multifd live migration: https://gitlab.com/qemu-project/qemu/-/issues/1937 which in turn is caused by a gnutls regression https://gitlab.com/gnutls/gnutls/-/issues/1717 Even if

Re: download.libvirt.org HTTPS certificate expired causing download failures

2025-07-18 Thread Daniel P . Berrangé via Devel
On Fri, Jul 18, 2025 at 10:36:53AM +, Song, Jiaying (CN) wrote: > Hello libvirt team, > > I am a user trying to fetch packages from https://download.libvirt.org/, but > I encountered an issue where the HTTPS certificate issued by Let's Encrypt > (CN=R10) appears to have expired. > > This ca

Re: [PATCH 6/7] virNetTLSCertSanityCheck: Validate all concatenated certs

2025-07-18 Thread Daniel P . Berrangé via Devel
On Fri, Jul 18, 2025 at 12:32:39PM +0200, Peter Krempa wrote: > On Fri, Jul 18, 2025 at 09:24:05 +0100, Daniel P. Berrangé wrote: > > On Fri, Jul 18, 2025 at 09:39:22AM +0200, Peter Krempa wrote: > > > On Thu, Jul 17, 2025 at 17:02:33 +0100, Daniel P. Berrangé wrote: > > > > On Thu, Jul 17, 2025 at

download.libvirt.org HTTPS certificate expired causing download failures

2025-07-18 Thread Song, Jiaying (CN)
Hello libvirt team, I am a user trying to fetch packages from https://download.libvirt.org/, but I encountered an issue where the HTTPS certificate issued by Let's Encrypt (CN=R10) appears to have expired. This causes download failures in automated builds and package fetching processes. For e

Re: [PATCH 6/7] virNetTLSCertSanityCheck: Validate all concatenated certs

2025-07-18 Thread Peter Krempa via Devel
On Fri, Jul 18, 2025 at 09:24:05 +0100, Daniel P. Berrangé wrote: > On Fri, Jul 18, 2025 at 09:39:22AM +0200, Peter Krempa wrote: > > On Thu, Jul 17, 2025 at 17:02:33 +0100, Daniel P. Berrangé wrote: > > > On Thu, Jul 17, 2025 at 05:28:09PM +0200, Peter Krempa via Devel wrote: > > > > From: Peter K

Re: [PATCH 7/6] NEWS: Mention virConnectHypervisorBaselineCPU improvements

2025-07-18 Thread Peter Krempa via Devel
On Fri, Jul 04, 2025 at 16:56:37 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > Signed-off-by: Jiri Denemark > --- > NEWS.rst | 12 > 1 file changed, 12 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index d8bd2559f4..4fd12d94f4 100644 > --- a/NEWS.rst > +++

Re: [PATCH 3/3] qemu_tpm: Only warn about missing locking feature on shared filesystems

2025-07-18 Thread Pavel Hrdina via Devel
On Thu, Jul 17, 2025 at 12:34:43PM +0200, Martin Kletzander via Devel wrote: > From: Martin Kletzander > > The warning pollutes the logs and might give a bad impression on someone > reading them even though the locking is not always needed. This way we > at least limit the logging in unnecessary

[PATCH v2 2/2] qemuxmlconftest: add tests for new hardware UUID (hwuuid) element

2025-07-18 Thread Mark Cave-Ayland
Add new 'hwuuid' and 'hwuuid-smbios-uuid-match' tests to verify that the new hardware UUID (hwuuid) element is working as intended. In particular the 'hwuuid-smbios-uuid-match' test is designed to ensure that the hwuuid and smbios UUIDs are always identical, similar to the existing logic works for

[PATCH v2 1/2] conf: introduce hardware UUID (hwuuid) element

2025-07-18 Thread Mark Cave-Ayland
The hardware UUID (hwuuid) element provides a mechanism to supply an external UUID to the guest, as opposed to the libvirt domain UUID. This is to allow for the scenario whereby a domain can be stopped, cloned and then started as a new domain without altering the guest-visible UUID. Add the elemen

[PATCH v2 0/2] Introduce hardware UUID (hwuuid) element

2025-07-18 Thread Mark Cave-Ayland
Following on from the discussions at [1] and more recently [2], this series introduces a new hardware UUID (hwuuid) element that allows an external UUID to be provided to the guest, as opposed to the libvirt domain UUID. The use case for this feature is to allow a domain to cloned and then restart

Re: [PATCH 6/7] virNetTLSCertSanityCheck: Validate all concatenated certs

2025-07-18 Thread Daniel P . Berrangé via Devel
On Fri, Jul 18, 2025 at 09:39:22AM +0200, Peter Krempa wrote: > On Thu, Jul 17, 2025 at 17:02:33 +0100, Daniel P. Berrangé wrote: > > On Thu, Jul 17, 2025 at 05:28:09PM +0200, Peter Krempa via Devel wrote: > > > From: Peter Krempa > > > > > > Similarly to how we iterate the list of CAs in the con

Re: [PATCH 6/7] virNetTLSCertSanityCheck: Validate all concatenated certs

2025-07-18 Thread Peter Krempa via Devel
On Thu, Jul 17, 2025 at 17:02:33 +0100, Daniel P. Berrangé wrote: > On Thu, Jul 17, 2025 at 05:28:09PM +0200, Peter Krempa via Devel wrote: > > From: Peter Krempa > > > > Similarly to how we iterate the list of CAs in the concatenated bundle > > there's a possibility of the server/client certific