Re: [PATCH v2] qemu: passt: add support for custom command line arguments

2025-07-09 Thread Peter Krempa via Devel
On Thu, Jul 10, 2025 at 08:39:18 +0200, Enrique Llorente Pastora wrote: > On Thu, Jul 10, 2025 at 7:55 AM Peter Krempa wrote: > > > > On Wed, Jul 09, 2025 at 15:44:15 +0200, Enrique Llorente Pastora wrote: > > > I have pushed a v3 with all the fixes for v2, clearly v2 was kind of > > > half baked,

Re: [PATCH v2] qemu: passt: add support for custom command line arguments

2025-07-09 Thread Enrique Llorente Pastora via Devel
On Thu, Jul 10, 2025 at 7:55 AM Peter Krempa wrote: > > On Wed, Jul 09, 2025 at 15:44:15 +0200, Enrique Llorente Pastora wrote: > > I have pushed a v3 with all the fixes for v2, clearly v2 was kind of > > half baked, sorry about that. > > Before I reply to v3 I still want you to reply at least to

Re: [PATCH v2] qemu: passt: add support for custom command line arguments

2025-07-09 Thread Peter Krempa via Devel
On Wed, Jul 09, 2025 at 15:44:15 +0200, Enrique Llorente Pastora wrote: > I have pushed a v3 with all the fixes for v2, clearly v2 was kind of > half baked, sorry about that. Before I reply to v3 I still want you to reply at least to my question about how the test result (.args) file ended up refe

RE: [PATCH v3 07/21] conf: Add tdx as launch security type

2025-07-09 Thread Duan, Zhenzhong
>-Original Message- >From: Daniel P. Berrangé >Subject: Re: [PATCH v3 07/21] conf: Add tdx as launch security type > >On Mon, Jun 30, 2025 at 02:17:18PM +0800, Zhenzhong Duan wrote: >> When 'tdx' is used, the VM will be launched with Intel TDX feature enabled. >> TDX feature supports run

Re: [PATCH v2] qemu: passt: add support for custom command line arguments

2025-07-09 Thread Enrique Llorente Pastora via Devel
I have pushed a v3 with all the fixes for v2, clearly v2 was kind of half baked, sorry about that. On Mon, Jul 7, 2025 at 5:02 PM Peter Krempa wrote: > > On Mon, Jul 07, 2025 at 15:51:51 +0200, Peter Krempa via Devel wrote: > > On Mon, Jul 07, 2025 at 14:52:09 +0200, Enrique Llorente via Devel wr

Re: Support cloning of VMs - part 2

2025-07-09 Thread Daniel P . Berrangé via Devel
On Wed, Jul 09, 2025 at 01:42:20PM +0100, Mark Cave-Ayland wrote: > On 09/07/2025 12:10, Daniel P. Berrangé wrote: > > > On Wed, Jul 09, 2025 at 11:27:45AM +0100, Daniel P. Berrangé via Devel > > wrote: > > > On Mon, Jul 07, 2025 at 02:19:10PM +0100, Mark Cave-Ayland wrote: > > > > Hi all, > > >

Re: Support cloning of VMs - part 2

2025-07-09 Thread Mark Cave-Ayland
On 09/07/2025 12:10, Daniel P. Berrangé wrote: On Wed, Jul 09, 2025 at 11:27:45AM +0100, Daniel P. Berrangé via Devel wrote: On Mon, Jul 07, 2025 at 02:19:10PM +0100, Mark Cave-Ayland wrote: Hi all, I'm currently looking at how libvirt can be used to clone a saved VM, and have been focusing o

[PATCH v3] qemu: passt: add support for custom command line arguments

2025-07-09 Thread Enrique Llorente via Devel
This adds support for custom command line arguments for the passt backend, similar to qemu:commandline. The feature allows passing additional arguments to the passt process for development and testing purposes. The implementation: - Adds a passt XML namespace for custom arguments - Properly taints

Re: Support cloning of VMs - part 2

2025-07-09 Thread Daniel P . Berrangé via Devel
On Wed, Jul 09, 2025 at 11:27:45AM +0100, Daniel P. Berrangé via Devel wrote: > On Mon, Jul 07, 2025 at 02:19:10PM +0100, Mark Cave-Ayland wrote: > > Hi all, > > > > I'm currently looking at how libvirt can be used to clone a saved VM, and > > have been focusing on the previous thread on this topi

RE: [PATCH v3 14/21] qemu: Add FakeReboot support for TDX guest

2025-07-09 Thread Duan, Zhenzhong
>-Original Message- >From: Daniel P. Berrangé >Subject: Re: [PATCH v3 14/21] qemu: Add FakeReboot support for TDX guest > >On Wed, Jul 09, 2025 at 09:44:42AM +, Duan, Zhenzhong wrote: >> >> >> >-Original Message- >> >From: Daniel P. Berrangé >> >Subject: Re: [PATCH v3 14/21]

Re: Support cloning of VMs - part 2

2025-07-09 Thread Daniel P . Berrangé via Devel
On Mon, Jul 07, 2025 at 02:19:10PM +0100, Mark Cave-Ayland wrote: > Hi all, > > I'm currently looking at how libvirt can be used to clone a saved VM, and > have been focusing on the previous thread on this topic at > https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/YXN2L2PYL

RE: [PATCH v3 12/21] conf: Add Intel TDX Quote Generation Service(QGS) support

2025-07-09 Thread Duan, Zhenzhong
>-Original Message- >From: Daniel P. Berrangé >Subject: Re: [PATCH v3 12/21] conf: Add Intel TDX Quote Generation >Service(QGS) support > >On Wed, Jul 09, 2025 at 02:52:05AM +, Duan, Zhenzhong wrote: >> >> >> >-Original Message- >> >From: Daniel P. Berrangé >> >Subject: Re:

RE: [PATCH v3 21/21] docs: domain: Add documentation for Intel TDX guest

2025-07-09 Thread Duan, Zhenzhong
>-Original Message- >From: Daniel P. Berrangé >Subject: Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel >TDX guest > >On Mon, Jun 30, 2025 at 02:17:32PM +0800, Zhenzhong Duan wrote: >> Signed-off-by: Zhenzhong Duan >> --- >> docs/formatdomain.rst | 63 >++

Re: [PATCH v3 07/21] conf: Add tdx as launch security type

2025-07-09 Thread Daniel P . Berrangé via Devel
On Mon, Jun 30, 2025 at 02:17:18PM +0800, Zhenzhong Duan wrote: > When 'tdx' is used, the VM will be launched with Intel TDX feature enabled. > TDX feature supports running encrypted VM (Trust Domain, TD) under the > control of KVM. A TD runs in a CPU model which protects the confidentiality > of i

Re: [RFC] x86 Host CPU features detection by MSRs

2025-07-09 Thread Daniel P . Berrangé via Devel
On Wed, Jul 09, 2025 at 05:58:03AM -0400, Andrea Bolognani wrote: > On Wed, Jul 09, 2025 at 09:53:40AM +0100, Daniel P. Berrangé via Devel wrote: > > On Wed, Jul 09, 2025 at 10:29:32AM +0200, Hector Cao wrote: > > > > >3. if that fails too, load the msr module and try again; > > > > > > > > It

Re: [RFC] x86 Host CPU features detection by MSRs

2025-07-09 Thread Andrea Bolognani via Devel
On Wed, Jul 09, 2025 at 09:53:40AM +0100, Daniel P. Berrangé via Devel wrote: > On Wed, Jul 09, 2025 at 10:29:32AM +0200, Hector Cao wrote: > > > >3. if that fails too, load the msr module and try again; > > > > > > It seems like a modules-load file is simpler than having this manual > > > kmod

Re: [PATCH v3 14/21] qemu: Add FakeReboot support for TDX guest

2025-07-09 Thread Daniel P . Berrangé via Devel
On Wed, Jul 09, 2025 at 09:44:42AM +, Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Daniel P. Berrangé > >Subject: Re: [PATCH v3 14/21] qemu: Add FakeReboot support for TDX guest > > > >On Mon, Jun 30, 2025 at 02:17:25PM +0800, Zhenzhong Duan wrote: > >> Utilize the exist

RE: [PATCH v3 14/21] qemu: Add FakeReboot support for TDX guest

2025-07-09 Thread Duan, Zhenzhong
>-Original Message- >From: Daniel P. Berrangé >Subject: Re: [PATCH v3 14/21] qemu: Add FakeReboot support for TDX guest > >On Mon, Jun 30, 2025 at 02:17:25PM +0800, Zhenzhong Duan wrote: >> Utilize the existing fake reboot mechanism to do reboot for TDX guest. >> >> Different from normal

Re: [PATCH v3 00/21] LIBVIRT: X86: TDX support

2025-07-09 Thread Daniel P . Berrangé via Devel
On Wed, Jul 09, 2025 at 09:35:02AM +, Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Daniel P. Berrangé > >Subject: Re: [PATCH v3 00/21] LIBVIRT: X86: TDX support > > > >On Wed, Jul 09, 2025 at 08:55:48AM +, Duan, Zhenzhong wrote: > >> > >> > >> >-Original Message-

RE: [PATCH v3 00/21] LIBVIRT: X86: TDX support

2025-07-09 Thread Duan, Zhenzhong
>-Original Message- >From: Daniel P. Berrangé >Subject: Re: [PATCH v3 00/21] LIBVIRT: X86: TDX support > >On Wed, Jul 09, 2025 at 08:55:48AM +, Duan, Zhenzhong wrote: >> >> >> >-Original Message- >> >From: Daniel P. Berrangé >> >Subject: Re: [PATCH v3 00/21] LIBVIRT: X86: TD

[PATCH v2 1/1] docs : add doc on cpu model and features

2025-07-09 Thread Hector CAO
From: Hector Cao Add documentation on the way libvirt displays the Host CPU model and capabilities (features). There is an implicit expection from users to get the CPU model name matching the CPU model they are running on, however, this does not happen most of the time. As a consequence, having a

[PATCH v2 0/1] docs : add doc on cpu model and features

2025-07-09 Thread Hector CAO
Hello, This is a follow-up of the submission: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/EZBLO5CIGC3FTI5J72WNVAKWPSNQFLCY/ Based on Jiri's feedback, it is better to tackle this situation by documentation. You can find here a proposal for the documentation. The section

Re: [PATCH v3 00/21] LIBVIRT: X86: TDX support

2025-07-09 Thread Daniel P . Berrangé via Devel
On Wed, Jul 09, 2025 at 08:55:48AM +, Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Daniel P. Berrangé > >Subject: Re: [PATCH v3 00/21] LIBVIRT: X86: TDX support > > > >On Mon, Jun 30, 2025 at 02:17:11PM +0800, Zhenzhong Duan wrote: > >> Hi, > >> > >> This series brings l

RE: [PATCH v3 00/21] LIBVIRT: X86: TDX support

2025-07-09 Thread Duan, Zhenzhong
>-Original Message- >From: Daniel P. Berrangé >Subject: Re: [PATCH v3 00/21] LIBVIRT: X86: TDX support > >On Mon, Jun 30, 2025 at 02:17:11PM +0800, Zhenzhong Duan wrote: >> Hi, >> >> This series brings libvirt the x86 TDX support. >> >> * What's TDX? >> TDX stands for Trust Domain Extens

Re: [RFC] x86 Host CPU features detection by MSRs

2025-07-09 Thread Daniel P . Berrangé via Devel
On Wed, Jul 09, 2025 at 10:29:32AM +0200, Hector Cao wrote: > > >3. if that fails too, load the msr module and try again; > > > > It seems like a modules-load file is simpler than having this manual > > kmod load + repeat. > > > > > Is this modules-load file deployed by libvirt itself or are yo

Re: [RFC] x86 Host CPU features detection by MSRs

2025-07-09 Thread Hector Cao
Thanks Daniel, On Wed, Jul 9, 2025 at 10:17 AM Daniel P. Berrangé wrote: > On Wed, Jul 09, 2025 at 10:03:26AM +0200, Hector Cao wrote: > > Hello, > > > > This mail is a Request for Comment. > > > > On recent Intel CPUs, some of the CPU features (mostly vmx-* subfeatures) > > are listed and contr

Re: [RFC] x86 Host CPU features detection by MSRs

2025-07-09 Thread Daniel P . Berrangé via Devel
On Wed, Jul 09, 2025 at 10:03:26AM +0200, Hector Cao wrote: > Hello, > > This mail is a Request for Comment. > > On recent Intel CPUs, some of the CPU features (mostly vmx-* subfeatures) > are listed and controlled > via the MSRs (Model Specific Registers) instead of the traditional CPUID > instr

[RFC] x86 Host CPU features detection by MSRs

2025-07-09 Thread Hector Cao
Hello, This mail is a Request for Comment. On recent Intel CPUs, some of the CPU features (mostly vmx-* subfeatures) are listed and controlled via the MSRs (Model Specific Registers) instead of the traditional CPUID instruction method. Right now, libvirt reads the MSR's values via /dev/cpu/*/cpu

Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel TDX guest

2025-07-09 Thread Daniel P . Berrangé via Devel
On Wed, Jul 09, 2025 at 03:13:11PM +0800, Xiaoyao Li wrote: > On 7/9/2025 2:58 PM, Daniel P. Berrangé wrote: > > > > Could we rename "policy" to "attributes", or more precisely > > > > "tdAttributes"? It's not intuitive for users to connect "policy" with > > > > "TD attributes". > > > Will use "att

Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel TDX guest

2025-07-09 Thread Xiaoyao Li
On 7/9/2025 2:58 PM, Daniel P. Berrangé wrote: Could we rename "policy" to "attributes", or more precisely "tdAttributes"? It's not intuitive for users to connect "policy" with "TD attributes". Will use "attributes" as QAPI exposes "attributes". IMHO 'policy' is preferrable as it is consistent