[PATCH v5 3/3] domain_addr.c: update console port reservation comment and allowZero var to allowPortZero for clarity

Reviewed-by: Boris Fiuczynski Signed-off-by: Aaron M. Brown --- src/conf/domain_addr.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index 76e11c0dde..1d417ac36d 100644 --- a/src/conf/domain_addr.c +++ b

[PATCH v5 1/3] qemuxmlconftest: Add console-virtio-vioserial tests

Signed-off-by: Aaron M. Brown --- ...onsole-virtio-vioserial.x86_64-latest.args | 44 + ...console-virtio-vioserial.x86_64-latest.xml | 63 +++ .../console-virtio-vioserial.xml | 48 ++ tests/qemuxmlconftest.c | 1 + 4 fi

[PATCH v5 2/3] virDomainVirtioSerialAddrAssign: Fix virtio console port auto assignment on vioserial bus

This change fixes an issue with virtio console port assignment on vioserial buses. Currently, when trying to autoassign a virtio console device, the device cannot be assigned to a port greater than 0 on vioserial buses. You will receive the following error: `virtio-serial-bus: A port already exi

[PATCH v5 0/3] Fix virtio console port assignment issue

Changelog: --- v5: - Added xml tests to tests/qemuxmlconfdata - Fixed virito -> virtio typo in commit message --- v4: - Update commit messages --- v3: - Added Reviewed-By - Included CI Results Link --- v2: - Split patch into two commits - Added fixes tag --- This libvirt patch series does t

Re: [PATCH v4 1/2] virDomainVirtioSerialAddrAssign: Fix virtio console port assignment on vioserial bus

Thank you Ján, I have fixed this in the next version

Re: [PATCH v4 0/2] Fix virtio console port assignment issue

My apologies Peter, this is my first time upstream. The first two versions were internally reviewed

[PATCH 3/3] ci: Drop unnecessary build dependencies

We no longer check for the presence of the commands included in these packages at build time. Signed-off-by: Andrea Bolognani --- ci/buildenv/almalinux-9.sh| 9 - ci/buildenv/alpine-321.sh | 6 -- ci/buildenv/alpine-edge.sh

[PATCH 2/3] rpm: Drop unnecessary BuildRequires

We've recently stopped checking for the presence of various commands at build time, which means that we no longer need to have the corresponding packages installed in the build environment. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 14 -- 1 file changed, 14 deletions(-)

[PATCH 1/3] rpm: Fix/clarify Requires

daemon-common should have always depended on kmod, since there are various situations in which a module (un)load might be triggered by a driver. For the util-linux dependency, we're simply adjusting the comment to match reality. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 4 +++- 1 fi

[PATCH 0/3] Drop unnecessary build dependencies

We've recently stopped checking for the presence of several commands at build time. That means we don't need them in the RPM or CI build environment either. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1855622714 Andrea Bolognani (3): rpm: Fix/clarify Requires rpm: Drop unne

Re: [PATCH 3/3] docs: Add prompt to clone commands

On Thu, Jun 05, 2025 at 05:13:23PM +0200, Peter Krempa wrote: > I'm not a fan. The rendered HTML makes it obvious by putting it in a > block with different formatting. > > With the $ in front you can't tripple click to select the whole line and > paste it somewhere. > > But since the command itself

Re: [PATCH 3/3] docs: Add prompt to clone commands

On Thu, Jun 05, 2025 at 15:39:15 +0200, Andrea Bolognani via Devel wrote: > Looks slightly nicer and makes it absolutely obvious that > these are shell commands. > > Signed-off-by: Andrea Bolognani > --- > docs/downloads.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff -

Re: [PATCH 2/3] docs: Drop mention of read-only git mirrors

On Thu, Jun 05, 2025 at 15:39:14 +0200, Andrea Bolognani via Devel wrote: > These mirrors no longer exist, they're just straight up > redirects to GitLab now. > > Signed-off-by: Andrea Bolognani > --- > docs/downloads.rst | 6 -- > 1 file changed, 6 deletions(-) Reviewed-by: Peter Krempa

Re: [PATCH 1/3] docs: Unify clone instructions

On Thu, Jun 05, 2025 at 15:39:13 +0200, Andrea Bolognani via Devel wrote: > We use the same format for GitLab and libvirt.org, but not > for GitHub. > > Signed-off-by: Andrea Bolognani > --- > docs/downloads.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Peter Krempa

[PATCH 03/10] src: Unify argument name of virDomainMigratePrepare2()

From: Michal Privoznik The virDomainMigratePrepare2() API declares one of its argument as 'bandwidth', though throughout various typedefs, RPC and callback implementations the name is changed to 'resource'. This creates a confusing. Unify the name. Signed-off-by: Michal Privoznik --- src/drive

[PATCH 3/3] docs: Add prompt to clone commands

Looks slightly nicer and makes it absolutely obvious that these are shell commands. Signed-off-by: Andrea Bolognani --- docs/downloads.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/downloads.rst b/docs/downloads.rst index cdcddabc57..e39d876f36 100644 --- a/doc

[PATCH 2/3] docs: Drop mention of read-only git mirrors

These mirrors no longer exist, they're just straight up redirects to GitLab now. Signed-off-by: Andrea Bolognani --- docs/downloads.rst | 6 -- 1 file changed, 6 deletions(-) diff --git a/docs/downloads.rst b/docs/downloads.rst index 11837c29e1..cdcddabc57 100644 --- a/docs/downloads.rst ++

[PATCH 1/3] docs: Unify clone instructions

We use the same format for GitLab and libvirt.org, but not for GitHub. Signed-off-by: Andrea Bolognani --- docs/downloads.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/downloads.rst b/docs/downloads.rst index 00feb8a761..11837c29e1 100644 --- a/docs/downloads.rst +

[PATCH 0/3] docs: Small tweaks to downloads page

*** CLICK HERE TO BLURB *** Andrea Bolognani (3): docs: Unify clone instructions docs: Drop mention of read-only git mirrors docs: Add prompt to clone commands docs/downloads.rst | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) -- 2.49.0

Re: [PATCH 0/2] docs: Fix docs for VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES_ZEROES

On Thu, Jun 05, 2025 at 03:22:03PM +0200, Peter Krempa via Devel wrote: > Remove note about needing a pre-cleared image and document need to > enable discards to obtain a sparse image. > > Peter Krempa (2): > Revert "docs: Add warning about using a cleared image with > VIR_MIGRATE_PARAM_MIGR

[PATCH 0/2] docs: Fix docs for VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES_ZEROES

Remove note about needing a pre-cleared image and document need to enable discards to obtain a sparse image. Peter Krempa (2): Revert "docs: Add warning about using a cleared image with VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES_ZEROES" docs: Note that zero detection on migration sparsi

[PATCH 1/2] Revert "docs: Add warning about using a cleared image with VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES_ZEROES"

From: Peter Krempa QEMU clears the images even when sparse mode is required so asking the users to do so is not needed. Remove the docs. This reverts commit 332ee4931a84ec23e7f6fcb963083318c1307dc7 Signed-off-by: Peter Krempa --- docs/manpages/virsh.rst | 4 +--- include/libvirt/libv

[PATCH 2/2] docs: Note that zero detection on migration sparsifies image only when discard='unmap' is set

From: Peter Krempa The mirroring job clears the destination to ensure that the guest visible disk contents are identical to the state on the source. The image itself is kept sparse only when the disk 'discard' option is set to 'unmap' (Also the disks would eventually desparsify itself anyways wit

[PATCH 10/10] gendispatch: Finish rename of the migration argument

From: Michal Privoznik This patch is useless. Either APIs it don't have 'resource' nor 'bandwidth' argument to begin with, or they serve as a wrapper over different API (changed in previous commits). Nonetheless, in the name of consistency, let's just change those variable names. Signed-off-by:

[PATCH 09/10] qemu: Finish argument rename

From: Michal Privoznik There are still some functions around migration code that use 'resource' instead 'bandwidth'. Rename the variable/argument inside them. Signed-off-by: Michal Privoznik --- src/qemu/qemu_migration.c | 60 +++ 1 file changed, 30 insertio

[PATCH 08/10] src: Unify argument name of virDomainMigratePerform3()

From: Michal Privoznik The virDomainMigratePerform3() API declares its last argument as 'bandwidth', though throughout various typedefs, RPC and callback implementations the name is changed to 'resource'. This creates a confusing. Unify the name. Signed-off-by: Michal Privoznik --- src/driver-

[PATCH 07/10] src: Unify argument name of virDomainMigrateBegin3()

From: Michal Privoznik The virDomainMigrateBegin3() API declares its last argument as 'bandwidth', though throughout various typedefs, RPC and callback implementations the name is changed to 'resource'. This creates a confusing. Unify the name. Signed-off-by: Michal Privoznik --- src/driver-hy

[PATCH 06/10] src: Unify argument name of virDomainMigratePrepareTunnel3()

From: Michal Privoznik The virDomainMigratePrepareTunnel3() API declares one of its argument as 'bandwidth', though throughout various typedefs, RPC and callback implementations the name is changed to 'resource'. This creates a confusing. Unify the name. Signed-off-by: Michal Privoznik --- src

[PATCH 05/10] src: Unify argument name of virDomainMigratePrepare3()

From: Michal Privoznik The virDomainMigratePrepare3() API declares one of its argument as 'bandwidth', though throughout various typedefs, RPC and callback implementations the name is changed to 'resource'. This creates a confusing. Unify the name. Signed-off-by: Michal Privoznik --- src/drive

[PATCH 04/10] src: Unify argument name of virDomainMigratePrepareTunnel()

From: Michal Privoznik The virDomainMigratePrepareTunnel() API declares one of its argument as 'bandwidth', though throughout various typedefs, RPC and callback implementations the name is changed to 'resource'. This creates a confusing. Unify the name. Signed-off-by: Michal Privoznik --- src/

[PATCH 02/10] src: Unify argument name of virDomainMigratePerform()

From: Michal Privoznik The virDomainMigratePerform() API declares its last argument as 'bandwidth', though throughout various typedefs, RPC and callback implementations the name is changed to 'resource'. This creates a confusing. Unify the name. Signed-off-by: Michal Privoznik --- src/driver-h

[PATCH 01/10] src: Unify argument name of virDomainMigratePrepare()

From: Michal Privoznik The virDomainMigratePrepare() API declares its last argument as 'bandwidth', though throughout various typedefs, RPC and callback implementations the name is changed to 'resource'. This creates a confusing. Unify the name. Signed-off-by: Michal Privoznik --- src/driver-h

[PATCH 00/10] Unify argument name of migration APIs

Some of our APIs have 'bandwidth' argument but then, at internal impl level it's renamed to 'resource', inconsistently. Since it's really describing bandwidth that the migration can use, let's rename it. Michal Prívozník (10): src: Unify argument name of virDomainMigratePrepare() src: Unify ar

Re: [PATCH 0/7] virsh: Fix cleanup in 'event' command and introduce 'await' command

On a Thursday in 2025, Peter Krempa via Devel wrote: 'virsh await' is a helper/syntax-sugar command which allows you to wait until a domain reaches a certain state. Currently this series implements conditions named 'domain-inactive' and 'guest-agent-available'. Peter Krempa (7): virthread: Regi

[PATCH 2/7] virthread: Add infrastructure for static virCond definitions

From: Peter Krempa Add the automatic cleanup handler as well as static initializer to allow simple stack allocated conditions. Signed-off-by: Peter Krempa --- src/util/virthread.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/util/virthread.h b/src/util/virthread.h index a7ec6b

Re: [PATCH] libxl_capabilities: Make some functions return void

On a Thursday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik Inside of libxlMakeDomainCapabilities() there are some functions called and basically all of them never return anything but zero (indicating success). Yet, they are called in a fashion that suggests otherwise. Turn

[PATCH] libxl_capabilities: Make some functions return void

From: Michal Privoznik Inside of libxlMakeDomainCapabilities() there are some functions called and basically all of them never return anything but zero (indicating success). Yet, they are called in a fashion that suggests otherwise. Turn those functions into void and drop checks for their retvals

[PATCH 7/7] virsh: await: Introduce 'guest-agent-available' condition

From: Peter Krempa The new condition allows waiting for the guest agent to show up, which usually means that the guest has booted enough to respond to external stimuli. Signed-off-by: Peter Krempa --- docs/manpages/virsh.rst| 5 + tools/virsh-domain-event.c | 42 ++

[PATCH 5/7] vsh: Add support for commands with more return values

From: Peter Krempa Add a new handler callback for command handlers which will want to return more than just EXIT_SUCCESS/EXIT_FAILURE. The new handler allows returning integers. Any negative values are converted to EXIT_FAILURE, other values are returned as reported in cases where we forward the

[PATCH 6/7] virsh: Introduce 'await' command for waiting until target domain state is reached

From: Peter Krempa The new command is meant as syntax sugar for event handling which blocks virsh until the requested state condition is reached. The initial implementation adds a condition 'domain-inactive' returning if the domain is/becomes inactive for whatever reason. This command is useful

[PATCH 4/7] vshCommandRun: Convert to directly return the exit code

From: Peter Krempa Currently the handler functions in the virt shells return only a boolean signalling if the command was successful or not. In preparation for a command which will want to return another value (timeout) convert vshCommand run to actually return the requested exit code instead and

[PATCH 3/7] virsh: cmdEvent: Ensure that event callbacks are unregistered before returning

From: Peter Krempa Successful return from 'virConnectDomainEventDeregisterAny' does not guarantee that there aren't still in-progress events being handled by the callbacks. Since 'cmdEvent' passes in a slice from an array as the private data of the callbacks, we must ensure that the array stays i

[PATCH 0/7] virsh: Fix cleanup in 'event' command and introduce 'await' command

'virsh await' is a helper/syntax-sugar command which allows you to wait until a domain reaches a certain state. Currently this series implements conditions named 'domain-inactive' and 'guest-agent-available'. Peter Krempa (7): virthread: Register auto cleanup function for virMutex virthread: A

[PATCH 1/7] virthread: Register auto cleanup function for virMutex

From: Peter Krempa This makes it very convenient to declare a mutex on stack along with the VIR_MUTEX_INITIALIZE macro without the need to have complex cleanup. Signed-off-by: Peter Krempa --- src/util/virthread.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virthread.h b/src/u