Re: [PATCH v2 0/4] conf: graphics def and parse refactor

On a Wednesday in 2025, Kirill Shchetiniuk via Devel wrote: This series refactors the existing parse logic by using the proper utility functions, it also contains some parameters type changes to void unnecessary type convertions. 1. 'VNC' graphics pasing were refactored to use the vitXMLProp* ut

Re: [PATCH v2 3/4] conf: RDP graphics parse refactor

On a Wednesday in 2025, Kirill Shchetiniuk via Devel wrote: From: Kirill Shchetiniuk Previously, the RDP graphics definition parsing were implemented by string parsing, the virDomainGraphicsDefParseXMLRDP function is refactored to use the appropriate virXMLProp* utility functions. Overall parsi

Re: [PATCH 0/4] conf: graphics def and parse refactor

On Tue, Jun 03, 2025 at 03:53:53PM +0200, Ján Tomko wrote: > On a Monday in 2025, Kirill Shchetiniuk via Devel wrote: > > This series is supposed to refactor the existing parse logic by > > using the proper utility function and some parameters type change. > > > > 1. VNC graphics pasing were refact

[PATCH v2 1/4] conf: VNC graphics parse refactor

From: Kirill Shchetiniuk Previously, the VNC graphics definition parsing were implemented by string parsing, the virDomainGraphicsDefParseXMLVNC was refactored to use the appropriate virXMLProp* utility functions. Overall parsing logic was not changed and results the same output as before. Signe

[PATCH v2 4/4] conf: desktop graphics remove unused option

From: Kirill Shchetiniuk Previously, the 'desktop' graphics configuration contained the 'fullscreen' option which was never used, removed the unused option. Signed-off-by: Kirill Shchetiniuk --- docs/formatdomain.rst | 5 ++--- src/conf/domain_conf.c| 17 ++

[PATCH v2 3/4] conf: RDP graphics parse refactor

From: Kirill Shchetiniuk Previously, the RDP graphics definition parsing were implemented by string parsing, the virDomainGraphicsDefParseXMLRDP function is refactored to use the appropriate virXMLProp* utility functions. Overall parsing logic was not changed and results the same output as before

[PATCH v2 2/4] conf: SDL fullscreen option refactor

From: Kirill Shchetiniuk Previously, the fullscreen option were parsed as a tristate but stored as a bool type, changed the fullscreen option type to tristate bool to avoid unnecessary type convertions. Signed-off-by: Kirill Shchetiniuk --- src/conf/domain_conf.c | 9 - src/conf/domai

[PATCH v2 0/4] conf: graphics def and parse refactor

This series refactors the existing parse logic by using the proper utility functions, it also contains some parameters type changes to void unnecessary type convertions. 1. 'VNC' graphics pasing were refactored to use the vitXMLProp* utility functions. 'autoport' and 'websocketGenerated' remain t