Re: [PATCH v3 3/3] qemu: process: disable deprecated features for s390 models by default

2025-05-26 Thread Peter Krempa via Devel
On Mon, May 26, 2025 at 17:26:47 +0200, Boris Fiuczynski wrote: > On 5/26/25 14:40, Peter Krempa via Devel wrote: > > On Thu, May 22, 2025 at 02:03:16 -0400, Collin Walling wrote: > > > To ease the user with defining a guest with a migratable CPU model, > > > > disclaimer: I'm not an expert on: >

Re: [PATCH v3 3/3] qemu: process: disable deprecated features for s390 models by default

2025-05-26 Thread Boris Fiuczynski
On 5/26/25 14:40, Peter Krempa via Devel wrote: On Thu, May 22, 2025 at 02:03:16 -0400, Collin Walling wrote: To ease the user with defining a guest with a migratable CPU model, disclaimer: I'm not an expert on: - libvirt's cpu driver - s390x cpu etc. let's disable the deprecated f

Re: [PATCH 3/4] qemu: capabilities: Introduce QEMU_CAPS_BUS_FLOPPY

2025-05-26 Thread Michal Prívozník via Devel
On 5/26/25 15:12, Peter Krempa wrote: > On Mon, May 26, 2025 at 15:08:09 +0200, Michal Prívozník wrote: >> On 5/26/25 09:57, Peter Krempa via Devel wrote: >>> From: Peter Krempa >>> >>> Introduce a common capability for support of floppy devices by qemu. >>> >>> Floppy support can be compiled out

Re: [PATCH 0/4] qemu: Reflect support of floppy devices in capabilities XML

2025-05-26 Thread Michal Prívozník via Devel
On 5/26/25 09:57, Peter Krempa via Devel wrote: > Probe if qemu actually supports floppy controllers which can be compiled > out with custom configs and reflect that in the capability XML. > > Peter Krempa (4): > qemu: domain: Introduce qemuDomainMachineSupportsFloppy > qemu: Move floppy devic

Re: [PATCH 3/4] qemu: capabilities: Introduce QEMU_CAPS_BUS_FLOPPY

2025-05-26 Thread Peter Krempa via Devel
On Mon, May 26, 2025 at 15:08:09 +0200, Michal Prívozník wrote: > On 5/26/25 09:57, Peter Krempa via Devel wrote: > > From: Peter Krempa > > > > Introduce a common capability for support of floppy devices by qemu. > > > > Floppy support can be compiled out ('FDC', 'FDC_ISA', 'FDC_SYSBUS' qemu >

Re: [PATCH 3/4] qemu: capabilities: Introduce QEMU_CAPS_BUS_FLOPPY

2025-05-26 Thread Michal Prívozník via Devel
On 5/26/25 09:57, Peter Krempa via Devel wrote: > From: Peter Krempa > > Introduce a common capability for support of floppy devices by qemu. > > Floppy support can be compiled out ('FDC', 'FDC_ISA', 'FDC_SYSBUS' qemu > Kconfig options) and also isn't supported by all architectures. Add a > capa

Re: [PATCH v3 3/3] qemu: process: disable deprecated features for s390 models by default

2025-05-26 Thread Peter Krempa via Devel
On Thu, May 22, 2025 at 02:03:16 -0400, Collin Walling wrote: > To ease the user with defining a guest with a migratable CPU model, disclaimer: I'm not an expert on: - libvirt's cpu driver - s390x cpu etc. > let's disable the deprecated features from the get-go. If these > features are s

Re: [PATCH 0/2] network: support NAT networking for FreeBSD/pf

2025-05-26 Thread Roman Bogorodskiy
Roman Bogorodskiy wrote: > This series implements NAT networks support for FreeBSD using the Packet > Filter (pf) firewall. ping

Re: [PATCH 0/2] CH: Add support for a configuration file and log level configuration

2025-05-26 Thread Michal Prívozník via Devel
On 5/22/25 08:21, Stefan Kober wrote: > Similar to the qemu.conf file that allows QEMU specific configurations we add > the possibility to specify a ch.conf file for Cloud Hypervisor configuration. > > The initial single config option is the log level, which sets the verbosity of > the Cloud Hyper

[PATCH 1/2] schemas: path types unification / refactor

2025-05-26 Thread Kirill Shchetiniuk via Devel
From: Kirill Shchetiniuk Previously, path types were defined separately for files and directories. The `absDirPath` type, in particular, did not accept Windows-style paths. Now, absolute paths for files and directories are united under the 'absolutePath' type. Relative paths were in fact the sam

[PATCH v3 2/2] Updates console port reservation comment and changes the allowZero variable to allowPortZero for clarity

2025-05-26 Thread Aaron M. Brown
Reviewed-by: Boris Fiuczynski Signed-off-by: Aaron M. Brown --- src/conf/domain_addr.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index bc2b0f50e8..86f5cfc337 100644 --- a/src/conf/domain_addr.c +++ b

[PATCH 2/2] schemas: path attributes type refactor

2025-05-26 Thread Kirill Shchetiniuk via Devel
From: Kirill Shchetiniuk Previously, in some places where path attributes were defined, the '' type was used instead of one of the provided types for paths. Now, the '' type has been replaced with the 'relativePath' type to maintain consistency and ensure backward compatibility. Signed-off-by: K

Re: [PATCH 1/2] ch: Add config file support

2025-05-26 Thread Michal Prívozník via Devel
On 5/22/25 08:21, Stefan Kober wrote: > Similar to the QEMU driver, the ch driver receives support for > configuration files that allows doing certain configuration on the > virtchd daemon. > > The initial use case will be setting the verbosity of the cloud > hypervisor instances started by virtch

Re: [PATCH 2/2] ch: add log level configuration option

2025-05-26 Thread Michal Prívozník via Devel
On 5/22/25 08:21, Stefan Kober wrote: > Allow a user to set the verbosity of the cloud hypervisor instances by > specifying it in the ch.conf configuration file. > --- > src/ch/ch_conf.c| 10 ++ > src/ch/ch_conf.h| 15 +++ > src/ch/ch_monitor.c | 6 ++ > 3 files ch

[PATCH 4/4] qemuDomainMachineSupportsFloppy: Check for QEMU_CAPS_BUS_FLOPPY

2025-05-26 Thread Peter Krempa via Devel
From: Peter Krempa Refuse to use floppy devices if qemu doesn't support them. Reflect that also in capabilities. Both of the above is achieved by checking for the QEMU_CAPS_BUS_FLOPPY in qemuDomainMachineSupportsFloppy. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c

[PATCH 3/4] qemu: capabilities: Introduce QEMU_CAPS_BUS_FLOPPY

2025-05-26 Thread Peter Krempa via Devel
From: Peter Krempa Introduce a common capability for support of floppy devices by qemu. Floppy support can be compiled out ('FDC', 'FDC_ISA', 'FDC_SYSBUS' qemu Kconfig options) and also isn't supported by all architectures. Add a capability that will check for 'isa-fdc' and 'sysbus-fdc' devices

[PATCH 2/4] qemu: Move floppy device support validation to validation code

2025-05-26 Thread Peter Krempa via Devel
From: Peter Krempa Move the validation from qemuProcessStartValidateDisks to qemuValidateDomainDeviceDefDiskFrontend and adjust the test case which now fails a bit earlier, thus no output XML is needed. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 7 --- src

[PATCH 1/4] qemu: domain: Introduce qemuDomainMachineSupportsFloppy

2025-05-26 Thread Peter Krempa via Devel
From: Peter Krempa Add a helper that will collect the logic for determinin whether a VM supports floppy disks. Use it in the capabilities code and when validating the VM definition at startup. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 3 +-- src/q

[PATCH 0/4] qemu: Reflect support of floppy devices in capabilities XML

2025-05-26 Thread Peter Krempa via Devel
Probe if qemu actually supports floppy controllers which can be compiled out with custom configs and reflect that in the capability XML. Peter Krempa (4): qemu: domain: Introduce qemuDomainMachineSupportsFloppy qemu: Move floppy device support validation to validation code qemu: capabilities

Re: [PATCH v2 0/4] domain_capabilities: add console capabilities

2025-05-26 Thread Michal Prívozník via Devel
On 5/24/25 18:15, Roman Bogorodskiy wrote: > Main change since v1 is adding console capabilities reporting for the > libxl driver. > > There's also a minor cosmetic change in the qemu part to alphabetically > sort VIR_DOMAIN_CHR_TYPE_* arguments for VIR_DOMAIN_CAPS_ENUM_SET(). > > Apparently, the