[libvirt PATCH 2/2] build: do not use -Winline

2025-05-16 Thread Ján Tomko via Devel
From: Ján Tomko We don't really care if a function cannot be inlined. Signed-off-by: Ján Tomko --- meson.build | 6 -- 1 file changed, 6 deletions(-) diff --git a/meson.build b/meson.build index bb0436e072..a46c2a7037 100644 --- a/meson.build +++ b/meson.build @@ -438,12 +438,6 @@ cc_flag

[libvirt PATCH 1/2] build: prohibit inline functions in C files by syntax-check

2025-05-16 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- build-aux/syntax-check.mk | 10 ++ src/hyperv/hyperv_wmi.c| 2 +- src/locking/lock_daemon.c | 4 ++-- src/qemu/qemu_block.c | 2 +- src/qemu/qemu_command.c| 2 +- src/qemu/qemu_saveimage.c | 2 +- src/rpc/virnetserver.c

[libvirt PATCH 0/2] Remove 'inline' keyword from C files

2025-05-16 Thread Ján Tomko via Devel
Ján Tomko (2): build: prohibit inline functions in C files by syntax-check build: do not use -Winline build-aux/syntax-check.mk | 10 ++ meson.build| 6 -- src/hyperv/hyperv_wmi.c| 2 +- src/locking/lock_daemon.c | 4 ++-- src/qemu/qemu_block.c | 2 +

Re: [PATCH v3 0/3] Add virt machine support for configuring PCI high memory MMIO size

2025-05-16 Thread Matt Ochs via Devel
> On May 16, 2025, at 6:47 AM, Daniel P. Berrangé wrote: > > I have pushed this series > Thanks Daniel!

Re: [PATCH] cpu_x86: Do not inline cpuidCall()

2025-05-16 Thread Fabio Estevam
Hi Ján, On Fri, May 16, 2025 at 8:30 AM Ján Tomko wrote: > > On a Wednesday in 2025, Fabio Estevam wrote: > >The following build error is observed with DEBUG_BUILD = 1: > > > > What exactly is DEBUG_BUILD? I can't find the variable anywhere. DEBUG_BUILD is a configuration variable used in OpenEm

[PATCH v2] cpu_x86: Do not inline cpuidCall()

2025-05-16 Thread Fabio Estevam
The following build error is observed when the DEBUG_BUILD variable is enabled in OpenEmbedded: src/cpu/cpu_x86.c: In function 'cpuidSetLeaf4': src/cpu/cpu_x86.c:2563:1: error: inlining failed in call to 'cpuidCall': function not considered for inlining [-Werror=inline] 2563 | cpuidCall(virCPUx8

RE: [RFC PATCH 0/5] qemu: Implement support for iommufd and multiple vSMMUs

2025-05-16 Thread Shameerali Kolothum Thodi via Devel
> -Original Message- > From: Nathan Chen > Sent: Thursday, May 15, 2025 9:37 PM > To: devel@lists.libvirt.org > Cc: Shameerali Kolothum Thodi ; > nicol...@nvidia.com; Nathan Chen > Subject: [RFC PATCH 0/5] qemu: Implement support for iommufd and multiple > vSMMUs > > Hi, > > This is

Re: [PATCH v3 0/3] Add virt machine support for configuring PCI high memory MMIO size

2025-05-16 Thread Daniel P . Berrangé via Devel
I have pushed this series On Thu, May 15, 2025 at 07:48:07AM -0700, Matthew R. Ochs wrote: > This patch series adds support for configuring the PCI high memory MMIO > window size for aarch64 virt machine types using the highmem-mmio-size > feature introduced in QEMU v10.0.0 [1]. It allows users to

Re: [PATCH 0/2] spec: Bump min_rhel and min_fedora

2025-05-16 Thread Ján Tomko via Devel
On a Friday in 2025, Michal Privoznik via Devel wrote: Per our support policy [1], the minimal version we aim to support is RHEL-9 and Fedora 41. Reflect this in the spec file. 1: https://libvirt.org/platforms.html Michal Prívozník (2): spec: Bump min_rhel spec: Bump min_fedora libvirt.spec.

Re: [PATCH] cpu_x86: Do not inline cpuidCall()

2025-05-16 Thread Daniel P . Berrangé via Devel
On Fri, May 16, 2025 at 01:30:41PM +0200, Ján Tomko via Devel wrote: > On a Wednesday in 2025, Fabio Estevam wrote: > > The following build error is observed with DEBUG_BUILD = 1: > > > > What exactly is DEBUG_BUILD? I can't find the variable anywhere. > > --buildtype debug is the default for me

Re: [PATCH] cpu_x86: Do not inline cpuidCall()

2025-05-16 Thread Ján Tomko via Devel
On a Wednesday in 2025, Fabio Estevam wrote: The following build error is observed with DEBUG_BUILD = 1: What exactly is DEBUG_BUILD? I can't find the variable anywhere. --buildtype debug is the default for meson with -Doptimization=g this should already be disabled since: commit 7253dda5178e

Re: [PATCH] ch: Support RNG device

2025-05-16 Thread stefan . kober
Awesome! Looking forward for more. Stefan

Re: [PATCH 3/3] qemu: capabilities: report supported console types

2025-05-16 Thread Michal Prívozník via Devel
On 5/15/25 18:29, Roman Bogorodskiy wrote: > Extend domain capabilities with information about the supported console > device types. > > Signed-off-by: Roman Bogorodskiy > --- > src/qemu/qemu_capabilities.c | 32 +++ > src/qemu/qemu_capabilities.h

Re: [PATCH 00/17] qemu: Fix regresion when loading internal snapshots and few cleanups

2025-05-16 Thread Michal Prívozník via Devel
On 5/15/25 17:28, Peter Krempa via Devel wrote: > This series: > > 1) Fixes the regression in loading internal snapshots: >https://gitlab.com/libvirt/libvirt/-/issues/771 > > 2) Fixes bugs in cleanup paths of snapshot reversion where we'd keep an >inactive transient VM definition in the d

Re: [PATCH v1 1/2] qemu: caps: add virCPUFeaturePolicy param to virQEMUCapsUpdateCPUDeprecatedFeatures

2025-05-16 Thread Boris Fiuczynski
On 5/1/25 22:17, Collin Walling wrote: Currently, virQEMUCapsUpdateCPUDeprecatedFeatures only allows for disabling deprecated features. This locks the deprecated_features attribute to only do something if set to 'off'. Let's add a virCPUFeaturePolicy to the function's parameters which will allo

Re: [PATCH] ch: Support RNG device

2025-05-16 Thread Michal Prívozník via Devel
On 5/16/25 09:57, Stefan Kober wrote: > Cloud Hypervisor supports virtio-rng devices and the configuration of > the randomness source (e.g. /dev/random or /dev/urandom). > > This commit adds support for configuring the RNG device via libvirt for > the ch driver. > > Signed-off-by: Stefan Kober >

Re: [PATCH 0/3] domain_capabilities: add console capabilities

2025-05-16 Thread Michal Prívozník via Devel
On 5/15/25 18:29, Roman Bogorodskiy wrote: > Motivation behind this series is to give management software possibility > to check whether the 'pty' console could be used, > or it should use something else, e.g. 'nmdm' for bhyve. > > Because of the complex relationships between 'serial' and 'console

[PATCH] ch: Support RNG device

2025-05-16 Thread Stefan Kober
Cloud Hypervisor supports virtio-rng devices and the configuration of the randomness source (e.g. /dev/random or /dev/urandom). This commit adds support for configuring the RNG device via libvirt for the ch driver. Signed-off-by: Stefan Kober --- src/ch/ch_domain.c | 8 +++- src/ch/ch_mon

[PATCH] cpu_x86: Do not inline cpuidCall()

2025-05-16 Thread Fabio Estevam
The following build error is observed with DEBUG_BUILD = 1: src/cpu/cpu_x86.c: In function 'cpuidSetLeaf4': src/cpu/cpu_x86.c:2563:1: error: inlining failed in call to 'cpuidCall': function not considered for inlining [-Werror=inline] 2563 | cpuidCall(virCPUx86CPUID *cpuid) | ^ Re

Re: [PATCH] ci: refresh with 'lcitool manifest'

2025-05-16 Thread Peter Krempa via Devel
On Fri, May 16, 2025 at 10:04:30 +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > - Add Fedora 42 > - Remove EOL Fedora 40 > - Switch mingw from Fedora 41 to Fedora 42 > > Signed-off-by: Michal Privoznik > --- Reviewed-by: Peter Krempa

[PATCH 2/2] spec: Bump min_fedora

2025-05-16 Thread Michal Privoznik via Devel
From: Michal Privoznik Fedora 40 is now officially at end of life [1]. The minimal version we aim to support upstream is thus Fedora 41. Reflect this in the spec file. 1: https://lists.fedoraproject.org/archives/list/devel-annou...@lists.fedoraproject.org/thread/XCUBN7NR7LXFFSA3IJDRTGHC7K4CXARV

[PATCH 1/2] spec: Bump min_rhel

2025-05-16 Thread Michal Privoznik via Devel
From: Michal Privoznik RHEL-8 is out of our support scope. The minimal version we aim to support upstream is RHEL-9. Reflect this in the spec file. Signed-off-by: Michal Privoznik --- libvirt.spec.in | 32 +--- 1 file changed, 9 insertions(+), 23 deletions(-) diff

[PATCH 0/2] spec: Bump min_rhel and min_fedora

2025-05-16 Thread Michal Privoznik via Devel
Per our support policy [1], the minimal version we aim to support is RHEL-9 and Fedora 41. Reflect this in the spec file. 1: https://libvirt.org/platforms.html Michal Prívozník (2): spec: Bump min_rhel spec: Bump min_fedora libvirt.spec.in | 38 -- 1 file

[PATCH] ci: refresh with 'lcitool manifest'

2025-05-16 Thread Michal Privoznik via Devel
From: Michal Privoznik - Add Fedora 42 - Remove EOL Fedora 40 - Switch mingw from Fedora 41 to Fedora 42 Signed-off-by: Michal Privoznik --- Green pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1819375318 It also contains spec file changes that I'll be sending shortly. I ha

Re: [PATCH v3 0/6] qemu: acpi-generic-initiator support

2025-05-16 Thread Michal Prívozník via Devel
On 5/15/25 16:35, Andrea Righi wrote: > Hi Michal, >> >> Sorry for late review. Normally, to make it up to you I'd fix all the >> small nits and merge, but this is introducing new feature and yet not >> updating documentation and that's a show stopper. Also, don't forget to >> add a NEWS.rst entr