[PATCH 2/5] qemu: make processNetDevStreamDisconnectedEvent() reusable

2025-04-09 Thread Laine Stump via Devel
We will be adding a new event whose response will be *exactly* the same as the response to NETDEV_STREAM_DISCONNECTED. Rather than doing a copy-paste of the complete function that does the processing, turn that function into something more generic that takes the name of the event as an arg (the eve

[PATCH 0/5] qemu: respond to NETDEV_VHOST_USER_DISCONNECTED event by starting a new passt process

2025-04-09 Thread Laine Stump via Devel
This brings behavior of passt+vhostuser in line with trad-passt - if the passt process is somehow terminated, libvirt will start a new passt process that qemu will connect to. You'll notice no change in behavior if your QEMU binary doesn't have the patches that add NETDEV_VHOST_USER_DISCONNECTED t

[PATCH 1/5] qemu: remove nonsensical sanity check in processNetdevStreamDisconnectedEvent()

2025-04-09 Thread Laine Stump via Devel
By definition QEMU will never send a NETDEV_STREAM_DISCONNECTED event if it doesn't support the reconnect option for a stream netdev (and even if, by some comedy of errors, it did send NETDEV_STREAM_DISCONNECTED in that case, our response to the event doesn't request anything at all of QEMU (much l

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Markus Armbruster via Devel
Steven Sistare writes: > On 4/9/2025 10:44 AM, Markus Armbruster wrote: >> Steven Sistare writes: >> >>> On 4/9/2025 9:34 AM, Markus Armbruster wrote: Steven Sistare writes: > On 4/9/2025 3:39 AM, Markus Armbruster wrote: [...] Anyway, asking you to fix design mistakes all over

Re: [PATCH] esx: Accept empty "path" URI component same way as "/"

2025-04-09 Thread Michal Prívozník via Devel
On 4/8/25 16:31, Peter Krempa via Devel wrote: > From: Peter Krempa > > When connecting to "esx://" URI there's code which prints a warning that > the path is not "empty". The check validates that "uri->path" is "/". > > In case when the user uses URI such as: > > esx://hostname > > the warni

[PATCH v3 2/2] qapi/block-core: deprecate some block-job- APIs

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
For change, pause, resume, complete, dismiss and finalize actions corresponding job- and block-job commands are almost equal. The difference is in find_block_job_locked() vs find_job_locked() functions. What's different? 1. find_block_job_locked() checks whether the found job is a block-job. Th

[PATCH v2 0/2] storage: vol-create bug fix

2025-04-09 Thread Kirill Shchetiniuk via Devel
When new volume was created using 'vol-create' and '--validate' option an error occured due to invalid flags passed downward. Resolves: https://lists.libvirt.org/archives/list/us...@lists.libvirt.org/thread/7WQ2IRSPWKKV5S3N3YJTFOMAJTZJFN7H/ Kirill Shchetiniuk (2): storage: virStorageVolDefPar

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Steven Sistare via Devel
On 4/9/2025 3:39 AM, Markus Armbruster wrote: Hi Steve, I apologize for the slow response. Steve Sistare writes: Using qom-list and qom-get to get all the nodes and property values in a QOM tree can take multiple seconds because it requires 1000's of individual QOM requests. Some managers fe

Re: [PATCH] bhyve: support interface type 'network'

2025-04-09 Thread Michal Prívozník via Devel
On 4/2/25 19:27, Roman Bogorodskiy wrote: > Add support for interface type 'network'. While bridge remains the only > supported options for networks in bhyve, supporting interface type > 'network' allows easier configuration and makes domain XMLs more > compatible with the other drivers. > > While

Re: [PATCH 1/5] virHostCPUGetInfoPopulateLinux: Use automatic memory freeing

2025-04-09 Thread Michal Prívozník via Devel
On 4/7/25 15:24, Peter Krempa via Devel wrote: > From: Peter Krempa > > Use 'g_autfree' for the two temporary strings. > > 'sysfs_cpudir' was used in two places, one of which is in a loop. Add > another helper variable for it and declare the other one in the loop. > > Signed-off-by: Peter Kremp

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Markus Armbruster via Devel
Steven Sistare writes: > On 4/9/2025 9:34 AM, Markus Armbruster wrote: >> Steven Sistare writes: >>> On 4/9/2025 3:39 AM, Markus Armbruster wrote: Hi Steve, I apologize for the slow response. Steve Sistare writes: > Using qom-list and qom-get to get all the nodes and pro

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Steven Sistare via Devel
On 4/9/2025 9:34 AM, Markus Armbruster wrote: Steven Sistare writes: On 4/9/2025 3:39 AM, Markus Armbruster wrote: Hi Steve, I apologize for the slow response. Steve Sistare writes: Using qom-list and qom-get to get all the nodes and property values in a QOM tree can take multiple seconds

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Markus Armbruster via Devel
Steven Sistare writes: > On 4/9/2025 3:39 AM, Markus Armbruster wrote: >> Hi Steve, I apologize for the slow response. >> >> Steve Sistare writes: >> >>> Using qom-list and qom-get to get all the nodes and property values in a >>> QOM tree can take multiple seconds because it requires 1000's o

[PATCH v3 1/2] qapi: synchronize jobs and block-jobs documentation

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
Actualize documentation and synchronize it for commands which actually call the same functions internally. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 61 ++-- qapi/job.json| 30 -- 2 files changed, 64

Re: [PATCH 0/3] bhyve: support random number generator device

2025-04-09 Thread Michal Prívozník via Devel
On 4/8/25 18:27, Roman Bogorodskiy wrote: > > Roman Bogorodskiy (3): > bhyve: support random number generator device > bhyve: argv2xml: support virtio-rnd devices > bhyve: extend RNG device validation > > src/bhyve/bhyve_capabilities.c| 15 > src/bhyve/bhyve_capabi

Re: [PATCH v8 55/55] docs: Add TDX documentation

2025-04-09 Thread Xiaoyao Li
On 4/2/2025 6:50 PM, Daniel P. Berrangé wrote: CC libvirt / Jiri, for confirmation about whether the CPUID restrictions listed below will have any possible impact on libvirt CPUID handling... On Tue, Apr 01, 2025 at 09:02:05AM -0400, Xiaoyao Li wrote: Add docs/system/i386/tdx.rst for TDX suppor

Re: [PATCH v2 1/2] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-09 Thread Michal Prívozník via Devel
On 4/9/25 10:43, Kirill Shchetiniuk via Devel wrote: > When the new storage was created using virsh with --validate option > following errors occurred: > > # virsh vol-create default --file vol-def.xml --validate > error: Failed to create vol from vol-def.xml > error: unsupported flags (0x4) in f

Re: [PATCH v2 0/2] storage: vol-create bug fix

2025-04-09 Thread Michal Prívozník via Devel
On 4/9/25 10:43, Kirill Shchetiniuk via Devel wrote: > When new volume was created using 'vol-create' and '--validate' option > an error occured due to invalid flags passed downward. > > Resolves: > https://lists.libvirt.org/archives/list/us...@lists.libvirt.org/thread/7WQ2IRSPWKKV5S3N3YJTFOMAJTZ

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Markus Armbruster via Devel
Hi Steve, I apologize for the slow response. Steve Sistare writes: > Using qom-list and qom-get to get all the nodes and property values in a > QOM tree can take multiple seconds because it requires 1000's of individual > QOM requests. Some managers fetch the entire tree or a large subset > of

[PATCH v2 2/2] NEWS: mention vol-create bug fix

2025-04-09 Thread Kirill Shchetiniuk via Devel
Signed-off-by: Kirill Shchetiniuk --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e2dc4e508b..dd345bad7b 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -28,6 +28,11 @@ v11.3.0 (unreleased) * **Bug fixes** + * storage: Fix new volume creation + +N

Re: [PATCH v3 1/2] qapi: synchronize jobs and block-jobs documentation

2025-04-09 Thread Markus Armbruster via Devel
Vladimir Sementsov-Ogievskiy writes: > Actualize documentation and synchronize it for commands which actually > call the same functions internally. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Markus Armbruster

[PATCH v2 1/2] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-09 Thread Kirill Shchetiniuk via Devel
When the new storage was created using virsh with --validate option following errors occurred: # virsh vol-create default --file vol-def.xml --validate error: Failed to create vol from vol-def.xml error: unsupported flags (0x4) in function virStorageVolDefParseXML and after virStorageVolDefParse

[PATCH v3 0/2] deprecate some block-job- APIs

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
This is for 10.1, of course. v3: fix wording, typos v2: Update documentation: add patch 01 v1 was: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs Supersedes: <20250401155730.103718-1-vsement...@yandex-team.ru> Vladimir Sementsov-Ogievskiy (2): qapi: synchronize jobs and blo

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Peter Krempa via Devel
On Wed, Apr 09, 2025 at 09:39:02 +0200, Markus Armbruster via Devel wrote: > Hi Steve, I apologize for the slow response. > > Steve Sistare writes: > > > Using qom-list and qom-get to get all the nodes and property values in a > > QOM tree can take multiple seconds because it requires 1000's of

Re: [PATCH] NEWS: Mention fix for 'qemu-rdp' error being logged

2025-04-09 Thread Boris Fiuczynski
With the nits fixed Reviewed-by: Boris Fiuczynski On 4/8/25 16:53, Peter Krempa via Devel wrote: From: Peter Krempa Add the news entry stating that it's safe to ignore the error. Signed-off-by: Peter Krempa --- NEWS.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/NEWS