Re: [PATCH V4 17/18] tools: add parallel parameter to virsh save command

2025-04-05 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:26PM -0700, Jim Fehlig via Devel wrote: > From: Claudio Fontana > > Signed-off-by: Claudio Fontana > Signed-off-by: Jim Fehlig > --- > docs/manpages/virsh.rst | 12 +++- > tools/virsh-domain.c| 42 + > 2 files ch

[PATCH] NEWS: hotplug virtio-mem device

2025-04-05 Thread Boris Fiuczynski
Signed-off-by: Boris Fiuczynski --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 484333e55a..1de0231c57 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -56,6 +56,12 @@ v11.2.0 (unreleased) * **Bug fixes** + * qemu: attach virtio-mem with CCW address +

Re: [PATCH] build: clang stack frame size handling improvement

2025-04-05 Thread Michal Prívozník via Devel
On 4/4/25 08:46, Michal Prívozník wrote: > On 4/3/25 18:28, Roman Bogorodskiy wrote: >> Michal Prívozník wrote: >> >>> On 4/2/25 19:24, Roman Bogorodskiy wrote: The 'plain' optimization type also triggers the clang stack frame size issues, so increase limit for it as well. Sig

[PATCH 0/3] cpu_map: Install Ampere-1 ARM CPU models

2025-04-05 Thread Jiri Denemark via Devel
BTW, the added test will not actually detect similar issues in the future (I'm thinking about such test, though), but it will help with other issues with the ARM CPU map as it hasn't been covered at all. Jiri Denemark (3): tests: Add a basic CPU test for aarch64 cpu_map: Install Ampere-1 ARM C

Re: [PATCH] build: clang stack frame size handling improvement

2025-04-05 Thread Roman Bogorodskiy
Michal Prívozník wrote: > On 4/2/25 19:24, Roman Bogorodskiy wrote: > > The 'plain' optimization type also triggers the clang stack frame size > > issues, so increase limit for it as well. > > > > Signed-off-by: Roman Bogorodskiy > > --- > > meson.build | 2 +- > > 1 file changed, 1 insertion

Fwd: system cache dropped

2025-04-05 Thread matus valentin
Hi, I have a setup with multiple virtual machines (VMs) running on one host, each with a saved state. All VMs share the same parent, which is located on a shared drive. Whenever I restore any VM using virsh restore, the parent is dropped from the system cache, causing all data to be downloaded fro

Re: [PATCH 8/8] NEWS: Mention guest agent error code improvements

2025-04-05 Thread Peter Krempa via Devel
On Fri, Mar 21, 2025 at 11:53:50 +, Daniel P. Berrangé wrote: > On Fri, Mar 21, 2025 at 12:40:39PM +0100, Peter Krempa wrote: > > On Fri, Mar 21, 2025 at 11:35:36 +, Daniel P. Berrangé wrote: > > > On Fri, Mar 21, 2025 at 12:15:19PM +0100, Peter Krempa via Devel wrote: > > > > On Thu, Mar 2

[libvirt PATCH 4/6] tools: use virDomainRestoreParams only when necessary

2025-04-05 Thread Pavel Hrdina via Devel
From: Pavel Hrdina We should use the newest API only when user sets parallel-channels. Signed-off-by: Pavel Hrdina --- tools/virsh-domain.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 56ddf4d701..

RE: [PATCH rfcv4 04/13] conf: expose TDX feature in domain capabilities

2025-04-05 Thread Duan, Zhenzhong
>-Original Message- >From: Jim Fehlig >Subject: Re: [PATCH rfcv4 04/13] conf: expose TDX feature in domain >capabilities > >On 5/24/24 00:21, Zhenzhong Duan wrote: >> Extend qemu TDX capability to domain capabilities. >> >> Signed-off-by: Chenyi Qiang >> Signed-off-by: Zhenzhong Duan

Re: [PATCH V4 01/18] lib: virDomain{Save,Restore}Params: Ensure absolute path

2025-04-05 Thread Jim Fehlig via Devel
On 3/19/25 05:54, Daniel P. Berrangé wrote: On Wed, Mar 05, 2025 at 03:48:10PM -0700, Jim Fehlig via Devel wrote: When invoking virDomainSaveParams with a relative path, the image is saved to the daemon's CWD. Similarly, when providing virDomainRestoreParams with a relative path, it attempts to

Re: [PATCH] NEWS: Mention support for mapped-ram

2025-04-05 Thread Pavel Hrdina via Devel
On Thu, Mar 20, 2025 at 05:25:43PM -0600, Jim Fehlig via Devel wrote: > Add a 'New features' entry for mapped-ram itself, and another > for the parallel save/restore feature built on top. > > Signed-off-by: Jim Fehlig > --- > NEWS.rst | 15 +++ > 1 file changed, 15 insertions(+) Rev

Re: [PATCH v2 1/3] qemu: Reflect MAC address change in live domain XML

2025-04-05 Thread Michal Prívozník via Devel
On 3/18/25 15:10, Daniel P. Berrangé wrote: > On Tue, Mar 18, 2025 at 02:58:18PM +0100, Michal Privoznik via Devel wrote: >> From: Michal Privoznik >> >> If a guest changes MAC address on its vNIC, then QEMU emits >> NIC_RX_FILTER_CHANGED event (the event is emitted in other cases >> too, but that

Re: [PATCH 2/2] qemu: Fix build on 32-bit platforms

2025-04-05 Thread Pavel Hrdina via Devel
On Thu, Mar 20, 2025 at 04:17:00PM -0600, Jim Fehlig via Devel wrote: > Commits c2518f7bc7 and 28a0621528 introduced build failures on 32-bit > platforms by using incorrect format specifiers with g_strdup_printf. > > In one case, an 'unsigned long' format specifier is used with a > 'long long int'

Re: [PATCH v2 20/22] admin: add 'daemon-shutdown' command

2025-04-05 Thread Daniel P . Berrangé via Devel
On Thu, Mar 13, 2025 at 02:18:18PM +0100, Peter Krempa wrote: > On Wed, Mar 12, 2025 at 17:18:00 +, Daniel P. Berrangé wrote: > > The daemons are wired up to shutdown in responsible to UNIX process > > signals, as well as in response to login1 dbus signals, or loss of > > desktop session. The l

[PATCH v9 05/17] qemu: monitor: Add support for ThrottleGroup operations

2025-04-05 Thread Peter Krempa via Devel
From: Chun Feng Wu This change contains QMP requests for ThrottleGroup * ThrottleGroup is updated through "qemuMonitorJSONUpdateThrottleGroup" * ThrottleGroup is retrieved through "qemuMonitorJSONGetThrottleGroup" * ThrottleGroup is deleted by reusing "qemuMonitorDelObject" * ThrottleGroup is ad

Re: Questions regarding potential resize implementation in libvirt

2025-04-05 Thread Peter Krempa via Devel
On Thu, Mar 20, 2025 at 08:56:04 +0100, Maximilian Immanuel Brandtner wrote: > I've been working on an RFC patch-set to implement resizing for > consoles in QEMU. Now that the patch-set is in review I've turned my > attention to bringing this feature to libvirt. > > With the QEMU patch-set there a

Re: [PATCH 3/8] conf: Introduce VIR_STORAGE_NET_HOST_TRANS_FD

2025-04-05 Thread Ján Tomko via Devel
On a Friday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Prepare the parser code and anything using 'virStorageNetHostTransport' to support passing a FD instead of opening the connection by qemu itself. For now this just preparse the parser and data structures, but the code *pre

[PATCH] virt-aa-helper: delete dynamic files

2025-04-05 Thread Alessandro
We attempted multiple ways to clean up dynamic files; however, we must preserve user overrides, which requires keeping the file /etc/apparmor.d/libvirt/libvirt-uuid This commit proposes to move user overrides into /etc/apparmor.d/libvirt/libvirt-uuid.local and include it, if present, unconditional

Re: [PATCH v2 1/1] NEWS: qemu: support block disk along with throttle filters

2025-04-05 Thread Harikumar Rajkumar
> On 3/25/25 11:57, Harikumar Rajkumar wrote: > > Reviewed-by: Michal Privoznik > and merged. > > Michal Thank you for merging this.

[PATCH 6/8] qemuAgentCheckError: Use 'VIR_ERR_AGENT_COMMAND_FAILED'

2025-04-05 Thread Peter Krempa via Devel
From: Peter Krempa In the two cases when we know that the command returned failure switch to the new error code so that management applications can programatically detect failure of the guest agent command. Signed-off-by: Peter Krempa --- src/qemu/qemu_agent.c | 4 ++-- 1 file changed, 2 inser

Re: [PATCH v3 00/20] Add qemu RDP server support

2025-04-05 Thread Martin Kletzander via Devel
On Sun, Mar 16, 2025 at 12:18:21PM +0400, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Hi, This patch series offers an out-of-process Remote Desktop Protocol (RDP) server solution utilizing QEMU's -display dbus interface, offering improved modularity and potential security benefi

Re: [PATCH 0/4] Allow xml-configured coredump format on VM crash

2025-04-05 Thread Daniel P . Berrangé via Devel
On Fri, Mar 28, 2025 at 05:45:12PM +0100, Denis V. Lunev via Devel wrote: > On 3/27/25 11:14, Nikolai Barybin wrote: > > When libvirt processes VM crash event it always dumps core in raw > > format. > > > > This series makes it possible to configure dump format via domain xml. > > This would be es

[PATCH 0/8] qemu: Improve guest agent corner case errors

2025-04-05 Thread Peter Krempa via Devel
This series introduces two new error codes aimed to help management applications to better in deciding when corner cases of guest agent interaction are encountered. Peter Krempa (8): lib: error: Introduce 'VIR_ERR_AGENT_COMMAND_TIMEOUT' qemu: agent: Differentiate timeouts when syncing from com

[PATCH v2 4/5] Revert "apparmor: Allow version-specific bits in profiles"

2025-04-05 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé This reverts commit 19eb8abc9a4d15190852d644b773a2348f11c9da. There is no longer any need to dynamically generate version specific rules. This revert can be reverted, if the need ever arises again in the future. Signed-off-by: Daniel P. Berrangé --- src/security/appar

Re: [PATCH V4 16/18] qemu: Add support for parallel save and restore

2025-04-05 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:25PM -0700, Jim Fehlig via Devel wrote: > Add support for parallel save and restore by mapping libvirt's > "parallel-channels" parameter to QEMU's "multifd-channels" > migration parameter. > > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_driver.c | 32 +

[PATCH 2/6] qemuSnapshotCreateActiveInternal: Fix error logic

2025-04-05 Thread Peter Krempa via Devel
From: Peter Krempa The 'ret' variable is set to 0 before a call which can theoretically fail. Not in practice really as the failure scenarion includes only object initialization. Since the code already has another variable for checking monitor returns use that one properly so that the code makes

[PATCH v3 0/6] qemu: acpi-generic-initiator support

2025-04-05 Thread Andrea Righi via Devel
= Overview = This patch set introduces support for acpi-generic-initiator devices, supported by QEMU [1]. The acpi-generic-initiator object is required to support Multi-Instance GPU (MIG) configurations on NVIDIA GPUs [2]. MIG enables partitioning of GPU resources into multiple isolated instances

Re: [PATCH V4 15/18] include: Define constants for parallel save/restore

2025-04-05 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:24PM -0700, Jim Fehlig via Devel wrote: > From: Claudio Fontana > > Add a new VIR_DOMAIN_SAVE_PARALLEL flag to the save and restore APIs, > which can be used to specify the use of multiple, parallel channels > for saving and restoring a domain. The number of parallel

[PATCH 0/3] apparmor: assume at least version 3

2025-04-05 Thread Daniel P . Berrangé via Devel
Daniel P. Berrangé (3): apparmor: assume at least apparmor >= 3 Revert "apparmor: Allow version-specific bits in profiles" meson: drop remaining checks for apparmor version meson.build | 3 -- src/security/apparmor/libvirt-lxc.in | 2 - src/se

[PATCH 2/6] conf: Introduce acpi-generic-initiator device

2025-04-05 Thread Andrea Righi via Devel
Introduce apci-generic-initiator device to the domain XML. Example definition: dev0 1 This enables partitioning of PCI resources into multiple isolated instances, each requiring a dedicated NUMA node definition, that can be represented by the acpi-generic-initiator object. Si

Re: [PATCH v3 00/20] Add qemu RDP server support

2025-04-05 Thread Marc-André Lureau via Devel
Hi On Tue, Mar 18, 2025 at 5:48 PM Martin Kletzander wrote: > > On Sun, Mar 16, 2025 at 12:18:21PM +0400, marcandre.lur...@redhat.com wrote: > >From: Marc-André Lureau > > > >Hi, > > > >This patch series offers an out-of-process Remote Desktop Protocol (RDP) > >server solution utilizing QEMU's -

Re: [PATCH V4 00/18] qemu: support mapped-ram+directio+mulitfd

2025-04-05 Thread Daniel P . Berrangé via Devel
Hi Jim, There are a couple of CI failures after this, one on 32-bit and one with CLang On Wed, Mar 05, 2025 at 03:48:09PM -0700, Jim Fehlig via Devel wrote: > V4 series adding support for QEMU's mapped-ram stream format [1] and > migration capability. The use of mapped-ram is controlled by extend

Re: [PATCH v8 55/55] docs: Add TDX documentation

2025-04-05 Thread Daniel P . Berrangé via Devel
CC libvirt / Jiri, for confirmation about whether the CPUID restrictions listed below will have any possible impact on libvirt CPUID handling... On Tue, Apr 01, 2025 at 09:02:05AM -0400, Xiaoyao Li wrote: > Add docs/system/i386/tdx.rst for TDX support, and add tdx in > confidential-guest-support.r

Re: [PATCH v2 0/1] NEWS: qemu: Support for Block Disk Along with Throttle Filters

2025-04-05 Thread Harikumar Rajkumar
Hi Team, Could someone kindly review and include the details in the NEWS section. Your assistance would be greatly appreciated. release news for the patch: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/5YHQI4R7UUU7FVPE6VCZ4BDXPRZIOFGZ/ Best regards, Harikumar R

Re: Questions regarding potential resize implementation in libvirt

2025-04-05 Thread Maximilian Immanuel Brandtner
On Thu, 2025-03-20 at 09:58 +, Daniel P. Berrangé wrote: > On Thu, Mar 20, 2025 at 08:56:04AM +0100, Maximilian Immanuel > Brandtner wrote: > > I've been working on an RFC patch-set to implement resizing for > > consoles in QEMU. Now that the patch-set is in review I've turned > > my > > attent

[PATCH v1 10/18] conf: Add Intel TDX Quote Generation Service(QGS) support

2025-04-05 Thread Zhenzhong Duan
Add element "quoteGenerationSocket" to tdx launch security type. It contains only an optional unix socket address attribute, when omitted, libvirt will use default QGS server address "/var/run/tdx-qgs/qgs.socket". UNIX sockets offer the required functionality with greater security than vsock, so l

Re: [PATCH V4 00/18] qemu: support mapped-ram+directio+mulitfd

2025-04-05 Thread Jim Fehlig via Devel
On 3/20/25 11:55, Daniel P. Berrangé wrote: Hi Jim, There are a couple of CI failures after this, one on 32-bit and one with CLang Yep, received mail from gitlab as well. Will take a look... Regards, Jim On Wed, Mar 05, 2025 at 03:48:09PM -0700, Jim Fehlig via Devel wrote: V4 series addin

[PATCH v1 13/18] qemu: Support reboot command in guest

2025-04-05 Thread Zhenzhong Duan
We can reboot a TDX guest with 'virsh reboot' or 'virsh shutdown' if action for onPoweroff is 'restart'. But running reboot command in guest shell will always lead to shutdown. This behavior is not consistent with normal guest, fix it by checking shutdown reason and action configuration to trigger

Re: [PATCH V4 14/18] qemu: Support O_DIRECT with mapped-ram on restore

2025-04-05 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:23PM -0700, Jim Fehlig via Devel wrote: > When using the mapped-ram migration capability, direct IO is > enabled by setting the "direct-io" migration parameter to > "true" and passing QEMU an additional fd with O_DIRECT set. > > Signed-off-by: Jim Fehlig > --- > src

Re: [PATCH 3/5] bhyve: Advertise hostdev support.

2025-04-05 Thread Roman Bogorodskiy
Alexander Shursha wrote: > bhyve itself had this feature long ago, but enabling it was blocked by > Linux-specific code in virpci > > Signed-off-by: Alexander Shursha > --- > src/bhyve/bhyve_capabilities.c | 2 +- > tests/domaincapsdata/bhyve_basic.x86_64.xml | 3 ++- > tests/dom

RE: [PATCH] meson: Add back prefix path for runstatedir

2025-04-05 Thread Duan, Zhenzhong
>-Original Message- >From: Pavel Hrdina >Subject: Re: [PATCH] meson: Add back prefix path for runstatedir > >On Wed, Apr 02, 2025 at 08:33:23AM +, Duan, Zhenzhong wrote: >> >> >> >-Original Message- >> >From: Peter Krempa >> >Subject: Re: [PATCH] meson: Add back prefix path

Re: [PATCH V4 02/18] qemu: Add function to get FDPass object from monitor

2025-04-05 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:11PM -0700, Jim Fehlig via Devel wrote: > Add new function qemuFDPassNewFromMonitor to get an fdset previously > passed to qemu, based on the 'prefix' provided when the qemuFDPass > object was initially created. > > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_fd

Re: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs

2025-04-05 Thread Markus Armbruster via Devel
Vladimir Sementsov-Ogievskiy writes: > On 04.04.25 17:13, Markus Armbruster wrote: [...] >> So, auto-finalize=true is silently ignored when another job in the same >> transaction has auto-finalize=false? > > Yes, at least, it looks like so: > > static void job_completed_txn_success_locked(Job *