On 3/21/25 04:21, Martin Kletzander wrote:
On Fri, Mar 21, 2025 at 08:29:30AM +, Daniel P. Berrangé via Devel wrote:
On Thu, Mar 20, 2025 at 09:36:15PM -0600, Jim Fehlig via Devel wrote:
On 3/20/25 17:07, Pavel Hrdina via Devel wrote:
> Pavel Hrdina (6):
> tools: remove --parallel from v
From: Michal Privoznik
There's too much happening inside of vboxSnapshotRedefine(). Not
only it makes the function hard to read, but it also increases
stack size of the function. Move one part into a separate
function: vboxSnapshotAddRWDisks()
Signed-off-by: Michal Privoznik
---
src/vbox/vbox_
On a Wednesday in 2025, Kirill Shchetiniuk wrote:
Thanks Jan,
Didn’t noticed the issue with the white symbols when submitted a patch, next
time will keep it in mind and be careful. Btw, do we have some tools to check
and warn such possible issues?
For the extra/removed lines, git diff/git s
On a Thursday in 2025, Peter Krempa via Devel wrote:
This series introduces two new error codes aimed to help management
applications to better in deciding when corner cases of guest agent
interaction are encountered.
Peter Krempa (8):
lib: error: Introduce 'VIR_ERR_AGENT_COMMAND_TIMEOUT'
qemu
On 5/24/24 00:21, Zhenzhong Duan wrote:
QEMU will provides 'tdx-guest' object which is used to launch encrypted
VMs on Intel platform using TDX feature.
Command line looks like:
$QEMU ... \
-object
'{"qom-type":"tdx-guest","id":"lsec0","debug":true,"sept-ve-disable":false,"mrconfigid":"xxx",
From: Ján Tomko
Signed-off-by: Ján Tomko
---
[Heavily shortened]
src/qemu/libvirt-qemu.sysusers.conf | 4 -
src/qemu/libvirt_qemu_probes.d |22 -
src/qemu/libvirtd_qemu.aug | 205 -
src/qemu/meson.build | 244 -
src/qemu/postcopy-migration.sysctl
From: Peter Krempa
As all supported qemu versions now support the QMP internal snapshot
commands (QEMU_CAPS_SNAPSHOT_INTERNAL_QMP is always present) we can
remove the code for loading snapshots during startup via '-loadvm'.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 6 --
sr
Introduce the definition of a new acpi-generic-initiator object that can
be used to link a PCI device with multiple NUMA nodes.
Link: https://mail.gnu.org/archive/html/qemu-arm/2024-03/msg00358.html
Signed-off-by: Andrea Righi
---
src/conf/domain_conf.c| 26 +
On Tue, Mar 18, 2025 at 05:57:18PM +0400, Marc-André Lureau wrote:
Hi
On Tue, Mar 18, 2025 at 5:48 PM Martin Kletzander wrote:
On Sun, Mar 16, 2025 at 12:18:21PM +0400, marcandre.lur...@redhat.com wrote:
>From: Marc-André Lureau
>
>Hi,
>
>This patch series offers an out-of-process Remote Des
We attempted multiple ways to clean up dynamic files; however, we must
preserve user overrides, which requires keeping the file
/etc/apparmor.d/libvirt/libvirt-uuid
This commit proposes to move user overrides into
/etc/apparmor.d/libvirt/libvirt-uuid.local and include it, if present,
unconditional
For change, pause, resume, complete, dismiss and finalize actions
corresponding job- and block-job commands are almost equal. The
difference is in find_block_job_locked() vs find_job_locked()
functions. What's different?
1. find_block_job_locked() do check, is found job a block-job. This OK
whe
Actualize documentation and synchronize it for commands which actually
call the same functions internally.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/block-core.json | 59 +---
qapi/job.json| 29 --
2 files changed, 61
v2:
Update documentation: add patch 01
v1 was:
[PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs
Supersedes: <20250401155730.103718-1-vsement...@yandex-team.ru>
Vladimir Sementsov-Ogievskiy (2):
qapi: synchronize jobs and block-jobs documentation
qapi/block-core: derpecate so
On Thu, Mar 20, 2025 at 04:16:59PM -0600, Jim Fehlig via Devel wrote:
> Commit f0169f4d caused a build failure with CLang due to potentially
> uninitialized variable
>
> ../src/qemu/qemu_migration_params.c:825:17: error: variable 'nchannels'
> is used uninitialized whenever '&&' condition is false
When domain was started its transient definition was not saved on
disk, this led to the situation when CH driver dies and starts again,
all transient definitions of currently running domains had been
lost.
Newly all transient definitions of running domains are saved on disk
and can be loaded durin
On Thu, Mar 20, 2025 at 12:51:35PM +0100, Maximilian Immanuel Brandtner wrote:
> On Thu, 2025-03-20 at 10:28 +, Daniel P. Berrangé wrote:
> > On Thu, Mar 20, 2025 at 11:09:41AM +0100, Maximilian Immanuel
> > Brandtner wrote:
> > > On Thu, 2025-03-20 at 09:58 +, Daniel P. Berrangé wrote:
> >
On 3/17/25 14:57, Martin Kletzander wrote:
> On Mon, Mar 17, 2025 at 12:28:50PM +0100, Michal Privoznik via Devel wrote:
>> So far, we only process NIC_RX_FILTER_CHANGED event when the
>> corresponding device has 'trustGuestRxFilters' enabled. And the
>> event is emitted only for virtio model. IOW,
From: Ján Tomko
For mutliple reasons, the use of the QEMU driver is no longer
recommended:
1. It is still incomplete
Git statistics from '3 years ago' speak for themselves:
src/qemu: 42505 insertions(+), 31154 deletions(-)
Compared to other drivers that are mostly completed and do not
re
On a Friday in 2025, Peter Krempa via Devel wrote:
From: Peter Krempa
In deployments where libvirt is containerized together with the VM it
may be hard for the management application to access listening sockets
inside the container from the outside.
This patch implements "transport='fd'" for t
On 3/25/25 11:57, Harikumar Rajkumar wrote:
> Signed-off-by: Harikumar Rajkumar
> ---
> NEWS.rst | 8
> 1 file changed, 8 insertions(+)
Reviewed-by: Michal Privoznik
and merged.
Michal
>
> diff --git a/NEWS.rst b/NEWS.rst
> index 18d45656b8..e33308693a 100644
> --- a/NEWS.rst
>
On Wed, Apr 02, 2025 at 11:50:26 +0100, Daniel P. Berrangé wrote:
> CC libvirt / Jiri, for confirmation about whether the CPUID restrictions
> listed below will have any possible impact on libvirt CPUID handling...
..
> > +Feature check
> > +~
> > +
> > +QEMU checks if the final (CPU) f
On Wed, Mar 05, 2025 at 03:48:19PM -0700, Jim Fehlig via Devel wrote:
> qemuProcessStartWithMemoryState() is the only caller of qemuProcessStart()
> that uses the qemuProcessIncomingDef struct. Move creation of the struct
> to qemuProcessStartWithMemoryState().
>
> Signed-off-by: Jim Fehlig
> ---
On Fri, Apr 04, 2025 at 14:41:13 +0200, Ján Tomko wrote:
> On a Wednesday in 2025, Peter Krempa via Devel wrote:
> > Browse the result at:
> >
> > https://pipo.sk.gitlab.io/-/libvirt/-/jobs/9603174377/artifacts/website/docs.html
> >
> > (The security warning happens as my username on gitlab conta
Signed-off-by: Zhenzhong Duan
---
docs/formatdomain.rst | 63 +++
1 file changed, 63 insertions(+)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 41fccfeb84..ff8b1ba4cb 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -94
This patch series is supposed to fix the following reported issue on GitLab:
virtchd times out even with an active guest running
https://gitlab.com/libvirt/libvirt/-/issues/743
During further investigation, we found that there are in fact two bugs:
1. The CH driver does not store any domains' XM
From: Michal Privoznik
There are two instances where vm->privateData is typecasted only
so that it can be dereferenced further. Well, that's exactly what
CH_DOMAIN_PRIVATE() macro is for. Use that instead.
Signed-off-by: Michal Privoznik
---
src/ch/ch_events.c | 2 +-
src/ch/ch_process.c | 4
On 04.04.25 17:13, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
On 04.04.25 09:20, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
[...]
+
+``block-job-finalize`` (since 10.1)
+''
+
+Use ``job-finalize`` instead.
+
block-jo
Browse the result at:
https://pipo.sk.gitlab.io/-/libvirt/-/jobs/9603174377/artifacts/website/docs.html
(The security warning happens as my username on gitlab contains a dot.)
Peter Krempa (2):
docs: Re-order XML schema after API documentation on 'docs' page
docs: Render API and XML sections
From: Michal Privoznik
There's a problem with glib: what we might consider functions are
in fact macros and to make things worse - they do declare local
variables. For instance here's the declaration of
g_clear_pointer() macro:
#define g_clear_pointer(pp, destroy) \
G_STMT_
Michal Privoznik via Devel wrote:
> From: Michal Privoznik
>
> After previous cleanups, all functions have their stack smaller
> than 2048 bytes and thus the workaround is no longer needed.
Thanks, now that works for me too.
Reviewed-by: Roman Bogorodskiy
> Signed-off-by: Michal Privoznik
Vladimir Sementsov-Ogievskiy writes:
> On 04.04.25 09:20, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
[...]
>>> +
>>> +``block-job-finalize`` (since 10.1)
>>> +''
>>> +
>>> +Use ``job-finalize`` instead.
>>> +
>>
>> block-job-finalize's doc
From: Michal Privoznik
The @transport variable is already pass into the function with
proper type. There's no need to typecast it to its very same type
inside the function.
Signed-off-by: Michal Privoznik
---
src/remote/remote_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
On a Friday in 2025, Michal Privoznik via Devel wrote:
Inspired by Roman's patch:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/FNAFORLGXFBL7KPI7RTBWV2ERHX57RIR/
There are two functions where clang produces stack greater than 2048
bytes (our current limit - see @stack_f
From: Michal Privoznik
There's too much happening inside of vboxSnapshotRedefine(). Not
only it makes the function hard to read, but it also increases
stack size of the function. Move one part into a separate
function: vboxSnapshotCreateFakeDiffStorage()
Signed-off-by: Michal Privoznik
---
src
On Fri, Apr 04, 2025 at 02:49:57PM +0200, Jiri Denemark via Devel wrote:
> BTW, the added test will not actually detect similar issues in the
> future (I'm thinking about such test, though), but it will help with
> other issues with the ARM CPU map as it hasn't been covered at all.
A test that par
Hi,
Right now, looking at the QEMU driver, libvirt supports listing all of
the present CPUs on the hypervisor via /sys/devices/system/cpu/present.
For systems where cgroups with exclusive CPU bits are configured,
however, there might be CPUs that are not availabe to libvirt. This
leads to situatio
On 4/4/25 11:02, Roman Bogorodskiy wrote:
> Michal Prívozník wrote:
>
>>
>
> IIRC, the first time I've encountered this issue was actually a test
> file. So I guess it would still make sense to keep the workaround for
> clang for now, dropping the optimization condition?
Maybe, but I haven't
From: Michal Privoznik
After previous cleanups, all functions have their stack smaller
than 2048 bytes and thus the workaround is no longer needed.
Signed-off-by: Michal Privoznik
---
meson.build | 5 -
1 file changed, 5 deletions(-)
diff --git a/meson.build b/meson.build
index bf4a245dd3
From: Michal Privoznik
There's too much happening inside of vboxSnapshotRedefine(). Not
only it makes the function hard to read, but it also increases
stack size of the function. Move one part into a separate
function: vboxSnapshotAddDisksToMediaRegistry()
Signed-off-by: Michal Privoznik
---
s
From: Michal Privoznik
There's too much happening inside of vboxSnapshotRedefine(). Not
only it makes the function hard to read, but it also increases
stack size of the function. Move one part into a separate
function: vboxSnapshotReplaceRWDisks()
Signed-off-by: Michal Privoznik
---
src/vbox/v
From: Michal Privoznik
When opening a connection, the client does some RPC talk
(most notably REMOTE_PROC_CONNECT_OPEN, and in some cases
REMOTE_PROC_CONNECT_GET_URI even).
Now, calling RPC means that local variables must be created.
Having them in doRemoteOpen() increases its stack size which g
Inspired by Roman's patch:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/FNAFORLGXFBL7KPI7RTBWV2ERHX57RIR/
There are two functions where clang produces stack greater than 2048
bytes (our current limit - see @stack_frame_size in meson.build):
1) doRemoteOpen()
2) vbox
On Fri, Apr 04, 2025 at 14:07:39 +0100, Daniel P. Berrangé wrote:
> On Fri, Apr 04, 2025 at 02:49:57PM +0200, Jiri Denemark via Devel wrote:
> > BTW, the added test will not actually detect similar issues in the
> > future (I'm thinking about such test, though), but it will help with
> > other issu
On a Thursday in 2025, Michal Privoznik via Devel wrote:
*** BLURB HERE ***
Michal Prívozník (3):
ch: Use CH_DOMAIN_PRIVATE() more
ch: Drop pid from monitor
ch: Fix printf format strings wrt size_t argument
src/ch/ch_events.c | 4 ++--
src/ch/ch_monitor.c | 14 --
src/ch/ch_monit
From: Jiri Denemark
Signed-off-by: Jiri Denemark
---
NEWS.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index e2dc4e508b..2608086717 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -28,6 +28,12 @@ v11.3.0 (unreleased)
* **Bug fixes**
+ * cpu_map: Install Ampere
From: Jiri Denemark
Fixes: 282f38ad3d3960b24aa97d75cae95c8c3d08a218
Fixes: https://gitlab.com/libvirt/libvirt/-/issues/762
Signed-off-by: Jiri Denemark
---
src/cpu_map/meson.build | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/cpu_map/meson.build b/src/cpu_map/meson.build
index 9a1c0
From: Jiri Denemark
The purpose of this test is to enforce loading and parsing of ARM CPU
map so that possible issues are found earlier.
Signed-off-by: Jiri Denemark
---
tests/cputest.c | 35 +
tests/cputestdata/aarch64-guest.xml | 4
2 fil
On a Wednesday in 2025, Peter Krempa via Devel wrote:
Browse the result at:
https://pipo.sk.gitlab.io/-/libvirt/-/jobs/9603174377/artifacts/website/docs.html
(The security warning happens as my username on gitlab contains a dot.)
Have you considered changing it?
Peter Krempa (2):
docs: Re
On 04.04.25 09:20, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
For change, pause, resume, complete, dismiss and finalize actions
corresponding job- and block-job commands are almost equal. The
difference is in find_block_job_locked() vs find_job_locked()
functions. What's dif
Michal Prívozník wrote:
> On 4/4/25 08:46, Michal Prívozník wrote:
> > On 4/3/25 18:28, Roman Bogorodskiy wrote:
> >> Michal Prívozník wrote:
> >>
> >>> On 4/2/25 19:24, Roman Bogorodskiy wrote:
> The 'plain' optimization type also triggers the clang stack frame size
> issues, so inc
On 4/3/25 18:28, Roman Bogorodskiy wrote:
> Michal Prívozník wrote:
>
>> On 4/2/25 19:24, Roman Bogorodskiy wrote:
>>> The 'plain' optimization type also triggers the clang stack frame size
>>> issues, so increase limit for it as well.
>>>
>>> Signed-off-by: Roman Bogorodskiy
>>> ---
>>> meson
51 matches
Mail list logo
