[libvirt PATCH 6/6] virsh: add --image-format option to the save command

2025-03-25 Thread Pavel Hrdina via Devel
From: Pavel Hrdina Option --parallel-channels would require changing configuration file to be used so introduce this option as well to make it convenient for users. Signed-off-by: Pavel Hrdina --- docs/manpages/virsh.rst | 5 + tools/virsh-domain.c| 12 2 files changed, 1

RE: [PATCH rfcv4 08/13] Add Intel TDX Quote Generation Service(QGS) support

2025-03-25 Thread Duan, Zhenzhong
>-Original Message- >From: Daniel P. Berrangé >Subject: Re: [PATCH rfcv4 08/13] Add Intel TDX Quote Generation Service(QGS) >support > >On Fri, May 24, 2024 at 02:21:23PM +0800, Zhenzhong Duan wrote: >> Add element "quoteGenerationService" to tdx launch security type. >> Currently it con

RE: [PATCH rfcv4 05/13] conf: add tdx as launch security type

2025-03-25 Thread Duan, Zhenzhong
>-Original Message- >From: Daniel P. Berrangé >Subject: Re: [PATCH rfcv4 05/13] conf: add tdx as launch security type > >On Fri, May 24, 2024 at 02:21:20PM +0800, Zhenzhong Duan wrote: >> When 'tdx' is used, the VM will launched with Intel TDX feature enabled. >> TDX feature supports run

[PATCH 1/3] ch: virCHMonitorNew() run new CH monitor daemonized

2025-03-25 Thread Kirill Shchetiniuk via Devel
When the new CH monitor was started, it ran as a non-daemonized process and was a child of the CH driver process. This led to a situation where if the CH driver died, the monitor process were killed too, terminating the running VM under the monitor. This led to termination of all VM started under t

[PATCH 3/3] ch: virCHProcessEvent() vm shutdown event handler fix

2025-03-25 Thread Kirill Shchetiniuk via Devel
When the domain shutdown was executed from virsh, only the VM process (a child of the CH monitor) was terminated. Since we assume only one VM per monitor, the monitor process should also be terminated. Modified the VM shutdown event handler to match the VMM shutdown behavior, ensuring the VM monit

Re: [PATCH rfcv4 05/13] conf: add tdx as launch security type

2025-03-25 Thread Daniel P . Berrangé via Devel
On Fri, May 24, 2024 at 02:21:20PM +0800, Zhenzhong Duan wrote: > When 'tdx' is used, the VM will launched with Intel TDX feature enabled. > TDX feature supports running encrypted VM (Trust Domain, TD) under the > control of KVM. A TD runs in a CPU model which protects the > confidentiality of its

Re: [PATCH V4 01/18] lib: virDomain{Save,Restore}Params: Ensure absolute path

2025-03-25 Thread Daniel P . Berrangé via Devel
On Tue, Mar 25, 2025 at 04:33:03PM +0100, Martin Kletzander wrote: > On Tue, Mar 25, 2025 at 08:41:41AM -0600, Jim Fehlig wrote: > > On 3/25/25 06:49, Martin Kletzander wrote: > > > On Tue, Mar 25, 2025 at 10:15:12AM +, Daniel P. Berrangé wrote: > > > > On Tue, Mar 25, 2025 at 10:49:49AM +0100,

Re: [PATCH V4 01/18] lib: virDomain{Save,Restore}Params: Ensure absolute path

2025-03-25 Thread Martin Kletzander via Devel
On Tue, Mar 25, 2025 at 08:41:41AM -0600, Jim Fehlig wrote: On 3/25/25 06:49, Martin Kletzander wrote: On Tue, Mar 25, 2025 at 10:15:12AM +, Daniel P. Berrangé wrote: On Tue, Mar 25, 2025 at 10:49:49AM +0100, Martin Kletzander wrote: On Wed, Mar 19, 2025 at 05:43:20PM -0600, Jim Fehlig via

[PATCH 2/3] ch: virCHProcessEvent() update domain info after reboot

2025-03-25 Thread Kirill Shchetiniuk via Devel
When the domain was rebooted, some of its properties were changed but not updated in the transient domain definition. This led to the inability to connect to the serial console as its path had changed during the reboot but was not updated in the domain definition. Added VIR_CH_EVENT_VM_REBOOTED ev

Re: [PATCH V4 01/18] lib: virDomain{Save,Restore}Params: Ensure absolute path

2025-03-25 Thread Jim Fehlig via Devel
On 3/25/25 06:49, Martin Kletzander wrote: On Tue, Mar 25, 2025 at 10:15:12AM +, Daniel P. Berrangé wrote: On Tue, Mar 25, 2025 at 10:49:49AM +0100, Martin Kletzander wrote: On Wed, Mar 19, 2025 at 05:43:20PM -0600, Jim Fehlig via Devel wrote: > On 3/19/25 05:54, Daniel P. Berrangé wrote: >

[PATCH 0/3] ch: monitor daemonization, sync after reboot, and shutdown fixes

2025-03-25 Thread Kirill Shchetiniuk via Devel
1. Run CH monitor as a daemon Made the monitor process daemonized to prevent VM termination if the CH driver crashes. Added pidfile for daemon's pid aquiring and tracking as well as its init. 2. Update domain info after reboot Fixed an issue where domain properties (e.g., serial console path) were

Re: [PATCH rfcv4 08/13] Add Intel TDX Quote Generation Service(QGS) support

2025-03-25 Thread Daniel P . Berrangé via Devel
On Fri, May 24, 2024 at 02:21:23PM +0800, Zhenzhong Duan wrote: > Add element "quoteGenerationService" to tdx launch security type. > Currently it contains only one sub-element "SocketAddress". > > "SocketAddress" is modelized according to QEMU QAPI, supporting > inet, unix, vsock and fd type and

Re: [PATCH V4 01/18] lib: virDomain{Save,Restore}Params: Ensure absolute path

2025-03-25 Thread Martin Kletzander via Devel
On Tue, Mar 25, 2025 at 10:15:12AM +, Daniel P. Berrangé wrote: On Tue, Mar 25, 2025 at 10:49:49AM +0100, Martin Kletzander wrote: On Wed, Mar 19, 2025 at 05:43:20PM -0600, Jim Fehlig via Devel wrote: > On 3/19/25 05:54, Daniel P. Berrangé wrote: > > On Wed, Mar 05, 2025 at 03:48:10PM -0700,

[PATCH v2 0/1] NEWS: qemu: Support for Block Disk Along with Throttle Filters

2025-03-25 Thread Harikumar Rajkumar
NEWS: qemu: Support for Block Disk Along with Throttle Filters Harikumar Rajkumar (1): NEWS: qemu: support block disk along with throttle filters NEWS.rst | 8 1 file changed, 8 insertions(+) -- 2.48.1

Entering freeze for libvirt-11.2.0

2025-03-25 Thread Jiri Denemark via Devel
I have just tagged v11.2.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

[PATCH v2 1/1] NEWS: qemu: support block disk along with throttle filters

2025-03-25 Thread Harikumar Rajkumar
Signed-off-by: Harikumar Rajkumar --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 18d45656b8..e33308693a 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -75,6 +75,14 @@ v11.2.0 (unreleased) system are printed. A user may specify ``--all`` to also pr

Re: [PATCH V4 01/18] lib: virDomain{Save,Restore}Params: Ensure absolute path

2025-03-25 Thread Daniel P . Berrangé via Devel
On Tue, Mar 25, 2025 at 10:49:49AM +0100, Martin Kletzander wrote: > On Wed, Mar 19, 2025 at 05:43:20PM -0600, Jim Fehlig via Devel wrote: > > On 3/19/25 05:54, Daniel P. Berrangé wrote: > > > On Wed, Mar 05, 2025 at 03:48:10PM -0700, Jim Fehlig via Devel wrote: > > > > When invoking virDomainSaveP

Re: [PATCH] NEWS: Mention virsh hypervisor-cpu-models command

2025-03-25 Thread Jiri Denemark via Devel
On Tue, Mar 25, 2025 at 11:29:57 +0100, Boris Fiuczynski wrote: > Signed-off-by: Boris Fiuczynski > --- > NEWS.rst | 8 > 1 file changed, 8 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 1fc80e2496..18d45656b8 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -67,6 +67,14 @@ v11

[PATCH] NEWS: Mention virsh hypervisor-cpu-models command

2025-03-25 Thread Boris Fiuczynski
Signed-off-by: Boris Fiuczynski --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 1fc80e2496..18d45656b8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -67,6 +67,14 @@ v11.2.0 (unreleased) restore. Using multiple channels can reduce the time required

Re: [PATCH] docs: add table showing guest IP/DNS/gateway settings when using SLIRP

2025-03-25 Thread Michal Prívozník via Devel
On 3/25/25 00:40, Laine Stump via Devel wrote: > When using the default SLIRP backend for , the > setting doesn't behave as might be > expected (i.e. it doesn't set the guest interface IP/prefix to exactly > the provided values). This *should* have created questions when users > originally encount

Re: [PATCH v3 0/3] Reflect MAC change in live domain XML

2025-03-25 Thread Martin Kletzander via Devel
On Tue, Mar 25, 2025 at 10:18:10AM +0100, Michal Privoznik via Devel wrote: v3 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/MW4SHZSS2UM2VNBKIONMODZVCRPSGEI3/ or: https://marc.info/?l=libvir-list&m=174230601829060&w=2 since our list archive is giving me some HTTP

Re: [PATCH 1/1] NEWS: Support block disk along with throttle filters

2025-03-25 Thread Peter Krempa via Devel
On Tue, Mar 25, 2025 at 11:10:08 +0530, Harikumar Rajkumar wrote: Missing developer certificate of origin certification: https://libvirt.org/hacking.html#developer-certificate-of-origin > --- > NEWS.rst | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index

Re: [PATCH V4 01/18] lib: virDomain{Save,Restore}Params: Ensure absolute path

2025-03-25 Thread Martin Kletzander via Devel
On Wed, Mar 19, 2025 at 05:43:20PM -0600, Jim Fehlig via Devel wrote: On 3/19/25 05:54, Daniel P. Berrangé wrote: On Wed, Mar 05, 2025 at 03:48:10PM -0700, Jim Fehlig via Devel wrote: When invoking virDomainSaveParams with a relative path, the image is saved to the daemon's CWD. Similarly, when

[PATCH v3 1/3] qemu: Reflect MAC address change in live domain XML

2025-03-25 Thread Michal Privoznik via Devel
From: Michal Privoznik If a guest changes MAC address on its vNIC, then QEMU emits NIC_RX_FILTER_CHANGED event (the event is emitted in other cases too, but that's not important right now). Now, domain XML allows users to chose whether to trust these events or not: For the 'no' case no actio

[PATCH v3 3/3] qemu: Emit NIC_MAC_CHANGE event

2025-03-25 Thread Michal Privoznik via Devel
From: Michal Privoznik So far, we only process NIC_RX_FILTER_CHANGED event when the corresponding device has 'trustGuestRxFilters' enabled. And the event is emitted only for virtio model. IOW, this is fairly limited situation and other scenarios don't emit any event (e.g. change of MAC address on

[PATCH v3 2/3] Introduce NIC_MAC_CHANGE event

2025-03-25 Thread Michal Privoznik via Devel
From: Michal Privoznik The aim off this event is to notify management application that guest changed MAC address on one of its vNICs so the app can update its internal records, e.g. for finding match between guest/host view of vNICs. Signed-off-by: Michal Privoznik Reviewed-by: Martin Kletzande

[PATCH v3 0/3] Reflect MAC change in live domain XML

2025-03-25 Thread Michal Privoznik via Devel
v3 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/MW4SHZSS2UM2VNBKIONMODZVCRPSGEI3/ or: https://marc.info/?l=libvir-list&m=174230601829060&w=2 since our list archive is giving me some HTTP error currently. diff to v2: - Rebased (there were some public APIs merged m

Re: [PATCH] USB hostdev: allow addressing by port

2025-03-25 Thread Maximilian Martin via Devel
Ping :) It's a much requested feature and certainly a low-hanging fruit. I'm happy to integrate feedback! Am 17.03.2025 um 21:59 schrieb Maximilian Martin via Devel: From: Maximilian Martin Currently, only vendor/product and bus/device matching are supported for USB host devices. Neither of

Re: [libvirt PATCH] qemu_driver: Fix virDomainSaveImageDefineXML

2025-03-25 Thread Jim Fehlig via Devel
On 3/24/25 13:20, Pavel Hrdina via Devel wrote: From: Pavel Hrdina Commit 28a06215280b99708ed8dc2d183f62ba7b34ccf8 added support to restore sparse images but changed the boolean that controls if we open the file as read-only or read-write. Editing XML in the save image resulted in following err