Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c| 2 ++
tests/qemuxmlconfdata/amd-iommu.x86_64-latest.args | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 269455ff3b..b778c76f5a 100644
--
On a Tuesday in 2025, Peter Krempa via Devel wrote:
v9 of the throttle filtering series with my reviews and R-b tags
applied.
Requires
[PATCH 0/5] qemu: Two block job fixes
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/TX2YAFHOFO46GR7WVQSPURWHL6O2KCDZ/
to be applied t
On a Wednesday in 2025, Ján Tomko via Devel wrote:
Introduce a new IOMMU device model 'amd', both the parser
and the formatter for QEMU because of our enum warnings.
https://issues.redhat.com/browse/RHEL-50560
Signed-off-by: Ján Tomko
---
docs/formatdomain.rst | 5 ++-
On a Tuesday in 2025, Peter Krempa via Devel wrote:
From: Chun Feng Wu
Introduce throttlegroup into domain and provide corresponding methods
* Define new struct 'virDomainThrottleGroupDef' and corresponding destructor
* Add operations(Add, Update, Del, ByName, Copy, Free) for
'virDomainThrott
For the newly supported AMD device.
Signed-off-by: Ján Tomko
---
docs/formatdomain.rst | 8
src/conf/domain_conf.c | 30 +
src/conf/domain_conf.h | 2 ++
src/conf/schemas/domaincommon.rng | 10 ++
tests/qemu
On a Friday in 2025, Peter Krempa wrote:
The qemu part was now merged.
Diff to rfc-v2:
- The 'ctrl' and 'event' queues are not exposed to be mapped:
- dropped patch for named queue support
- adapted validation logic
- adapted docs
Peter Krempa (6):
qemucapabilitiestest: Update 'caps_1
Signed-off-by: Ján Tomko
---
src/conf/domain_validate.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c
index be91caee65..1f3643d441 100644
--- a/src/conf/domain_validate.c
+++ b/src/conf/domain_validate.c
@@ -3029,6 +3029,15 @@
Signed-off-by: Ján Tomko
---
docs/formatdomain.rst | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index c5708000b8..8c122f5dae 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -8921,14 +8921,15 @@ Example
Introduce a new IOMMU device model 'amd', both the parser
and the formatter for QEMU because of our enum warnings.
https://issues.redhat.com/browse/RHEL-50560
Signed-off-by: Ján Tomko
---
docs/formatdomain.rst | 5 ++-
src/conf/domain_conf.c| 1
Introduced by QEMU commit TBD, the presence of this attribute
allows libvirt to specify the alias of the AMDVI-PCI device
explicitly. (It was implicit before the introduction
of this attribute)
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 8 ++
src/qemu/qemu_cap
To the cc'd QEMU developers - I'd appreciate guidance on how/whether
to document and expose the 'xtsup' and 'pt' parameters to libvirt users.
Based on QEMU series:
Subject: [PATCH v4 0/2] hw/i386/amd_iommu: Add migration support
From: Suravee Suthikulpanit
Message-ID: <20250304141716.638880-1-sur
Check for the presence of the amd-iommu device, so we can conditionalize
probing for its properties.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 3 +++
tests/qemucapabilitiesdata/caps_1
On Tue, Mar 18, 2025 at 03:31:30PM +0100, Michal Prívozník wrote:
> On 3/18/25 15:10, Daniel P. Berrangé wrote:
> > On Tue, Mar 18, 2025 at 02:58:18PM +0100, Michal Privoznik via Devel wrote:
> >> From: Michal Privoznik
> >>
> >> If a guest changes MAC address on its vNIC, then QEMU emits
> >> NIC
From: Chun Feng Wu
ThrottleGroup lifecycle implementation, note, in QOM, throttlegroup name is
prefixed with
"throttle-" to clearly separate throttle group objects into their own namespace.
* "qemuDomainSetThrottleGroup", this method is to add("object-add") or
update("qom-set")
throttlegroup
On Tue, Mar 18, 2025 at 02:58:18PM +0100, Michal Privoznik via Devel wrote:
> From: Michal Privoznik
>
> If a guest changes MAC address on its vNIC, then QEMU emits
> NIC_RX_FILTER_CHANGED event (the event is emitted in other cases
> too, but that's not important right now). Now, domain XML allow
On a Tuesday in 2025, Peter Krempa via Devel wrote:
On Sun, Mar 16, 2025 at 12:18:21 +0400, marcandre.lureau--- via Devel wrote:
From: Marc-André Lureau
Marc-André Lureau (20):
build-sys: drop -Winline when optimization=g
build: fix -Werror=maybe-uninitialized
qemu-slirp: drop unneeded ch
Signed-off-by: Ján Tomko
Fixes: bfa7d5aaa8834c6801cacbfc6c6ea83a8ecaca9c
---
Pushed as a trivial CI fix
src/conf/domain_conf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 5748a89bd1..d05e68dd41 100644
--- a/src/conf/domain_conf.c
+++
From: Chun Feng Wu
For hot attaching/detaching
* Leverage qemuBlockThrottleFiltersData to prepare attaching/detaching
throttle filter data for qemuMonitorBlockdevAdd and qemuMonitorBlockdevDel
* For hot attaching, within qemuDomainAttachDiskGeneric,prepare throttle
filters json data, and crea
From: Chun Feng Wu
Introduce throttle filter along with corresponding operations.
* Define new struct 'virDomainThrottleFilterDef' and corresponding destructor
* Update _virDomainDiskDef to include virDomainThrottleFilterDef
* Support throttle filter "Parse" and "Format" for operations between D
From: Chun Feng Wu
Update "attach_disk" to support new option: throttle-groups to
form filter chain in QEMU for specific disk
Signed-off-by: Chun Feng Wu
* apply suggested coding style changes.
Signed-off-by: Harikumar Rajkumar
* Fixed alignment of child elements in the XML
* Fixed placemen
From: Chun Feng Wu
Define macro for iotune options, this macro is used by opts_blkdeviotune and
later throttle group opts
Signed-off-by: Chun Feng Wu
Reviewed-by: Peter Krempa
Signed-off-by: Peter Krempa
---
tools/virsh-domain.c | 308 ++-
1 file chang
From: Harikumar Rajkumar
* Add tests for throttlefilter nodename parse and format for statusxml
(disk/privateData/nodenames/nodename with type='throttle-filter')
* Add iotune limited disk tests to make sure iotune refactory works
Signed-off-by: Chun Feng Wu
* Isolate status xml test
Signed-of
v9 of the throttle filtering series with my reviews and R-b tags
applied.
Requires
[PATCH 0/5] qemu: Two block job fixes
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/TX2YAFHOFO46GR7WVQSPURWHL6O2KCDZ/
to be applied to work properly.
Posting for tracking and possibly fi
From: Chun Feng Wu
* Add tests for throttlegroup domain xml processing, including
groups referenced and not referenced by filters
* Add tests for throttlefilter domain xml processing, including
throttle group referenced by different disks
* Add negative test case to report error when iotune is co
From: Chun Feng Wu
Refactor iotune verification, and verify some rules
* Disk iotune validation can be reused for throttle group validation,
refactor it into common method "virDomainDiskIoTuneValidate"
* Add "virDomainDefValidateThrottleGroups" to validate throttle groups,
which in turn call
From: Chun Feng Wu
It contains throttle filter nodename processing(new nodename,
topnodename, parse and format nodename), throttle filter
attaching/detaching preparation and implementation.
* Updated "qemuDomainDiskGetTopNodename", so if throttlefilter is used
together with copyOnRead, top nod
From: Chun Feng Wu
Defined new public APIs:
* virDomainSetThrottleGroup to add or update throttlegroup within specific
domain,
it will be referenced by throttlefilter later in disk to do limits
* virDomainGetThrottleGroup to get throttlegroup info, old-style is discarded
(APIs to query first
From: Chun Feng Wu
extract common methods from "qemuDomainSetBlockIoTune" to be reused
by throttle handling later, common methods include:
* "qemuDomainValidateBlockIoTune", which is to validate that PARAMS
contains only recognized parameter names with correct types
* "qemuDomainSetBlockIoTuneF
From: Chun Feng Wu
Within "testQemuMonitorJSONqemuMonitorJSONUpdateThrottleGroup"
* Test qemuMonitorJSONGetThrottleGroup
* Test qemuMonitorJSONUpdateThrottleGroup, which updates limits through
"qom-set"
Signed-off-by: Chun Feng Wu
* fix test
Signed-off-by: Harikumar Rajkumar
* Deleted gett
From: Chun Feng Wu
Introduce throttlegroup into domain and provide corresponding methods
* Define new struct 'virDomainThrottleGroupDef' and corresponding destructor
* Add operations(Add, Update, Del, ByName, Copy, Free) for
'virDomainThrottleGroupDef'
* Update _virDomainDef to include virDomai
From: Chun Feng Wu
Introduce schema for defining '' element which
configures throttling groups which can be configured for multiple
disks.
* Refactor "diskIoTune" to extract common schema "iotune"
* Add new elements ''
* contains defintion, which references
"iotune"
Signed-off-by: Chun Feng
From: Chun Feng Wu
Introduce schema for defining '' element which
references throttling groups to form filter chain in qemu for specific
disk
* Add new elements ''
* can include multiple throttlegroup references to
form filter chain in qemu
* Chained throttle filters feature in qemu is descri
On Sun, Mar 16, 2025 at 12:18:21 +0400, marcandre.lureau--- via Devel wrote:
> From: Marc-André Lureau
> Marc-André Lureau (20):
> build-sys: drop -Winline when optimization=g
> build: fix -Werror=maybe-uninitialized
> qemu-slirp: drop unneeded check for OOM
> util: annotate non-null argum
Signed-off-by: Ján Tomko
---
Pushed as trivial
src/qemu/qemu_domain_address.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
index 5b94c27679..e89cdee487 100644
--- a/src/qemu/qemu_domain_address.c
+++ b/src/qemu/qemu_domain_a
On a Tuesday in 2025, Boris Fiuczynski wrote:
Since commit f23f8ff91a virtio-mem supports also CCW. When hotplugging a
virtio-mem device with a CCW address results in a PCI device getting
attached. The method qemuDomainAssignMemoryDeviceSlot is only
considering PCI as address type and overwriting
On Tue, Mar 18, 2025 at 02:58:18PM +0100, Michal Privoznik via Devel wrote:
> From: Michal Privoznik
>
> If a guest changes MAC address on its vNIC, then QEMU emits
> NIC_RX_FILTER_CHANGED event (the event is emitted in other cases
> too, but that's not important right now). Now, domain XML allow
From: Michal Privoznik
The aim off this event is to notify management application that
guest changed MAC address on one of its vNICs so the app can
update its internal records, e.g. for finding match between
guest/host view of vNICs.
Signed-off-by: Michal Privoznik
Reviewed-by: Martin Kletzande
From: Michal Privoznik
So far, we only process NIC_RX_FILTER_CHANGED event when the
corresponding device has 'trustGuestRxFilters' enabled. And the
event is emitted only for virtio model. IOW, this is fairly
limited situation and other scenarios don't emit any event (e.g.
change of MAC address on
v2 of
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/AVMO4LJK4HHFISPGCW4YXSLZ4HH36XLT/
diff to v1:
- If the MAC address is changed to its original the proper event is
emitted.
- In 3/3 some variables were renamed to avoid ambiguity.
Michal Prívozník (3):
qemu: Reflect
From: Michal Privoznik
If a guest changes MAC address on its vNIC, then QEMU emits
NIC_RX_FILTER_CHANGED event (the event is emitted in other cases
too, but that's not important right now). Now, domain XML allows
users to chose whether to trust these events or not:
For the 'no' case no actio
Since commit f23f8ff91a virtio-mem supports also CCW. When hotplugging a
virtio-mem device with a CCW address results in a PCI device getting
attached. The method qemuDomainAssignMemoryDeviceSlot is only
considering PCI as address type and overwriting the CCW address. Adding
support for address typ
On 3/18/25 13:00, Martin Kletzander via Devel wrote:
On Tue, Mar 18, 2025 at 09:53:22AM +0100, Boris Fiuczynski wrote:
Since commit f23f8ff91a virtio-mem supports also CCW. When hotplugging a
virtio-mem device with a CCW address results in a PCI device getting
attached. The method qemuDomainAssi
On Tue, Mar 18, 2025 at 09:53:22AM +0100, Boris Fiuczynski wrote:
Since commit f23f8ff91a virtio-mem supports also CCW. When hotplugging a
virtio-mem device with a CCW address results in a PCI device getting
attached. The method qemuDomainAssignMemoryDeviceSlot is only
considering PCI as address
We are getting close to 11.2.0 release of libvirt. To aim for the
release on Tuesday 01 Apr I suggest entering the freeze on Tuesday
25 Mar and tagging RC2 on Friday 28 Mar.
I hope this works for everyone.
Jirka
Since commit f23f8ff91a virtio-mem supports also CCW. When hotplugging a
virtio-mem device with a CCW address results in a PCI device getting
attached. The method qemuDomainAssignMemoryDeviceSlot is only
considering PCI as address type and overwriting the CCW address. Adding
support for address typ
From: Maximilian Martin
Currently, only vendor/product and bus/device matching are supported for USB
host
devices. Neither of these provide a stable and persistent way of assigning a
guest
a specific host device. Vendor/product can be ambiguous. Device numbers change
on
every enumeration.
Thi
46 matches
Mail list logo
