Re: [PATCH v8 17/18] virsh: Add support for throttle group operations

2025-03-14 Thread Peter Krempa
On Wed, Feb 19, 2025 at 22:27:21 +0530, Harikumar Rajkumar wrote: > From: Chun Feng Wu > > Implement new throttle cmds > > * Add new virsh cmds: domthrottlegroupset, domthrottlegrouplist, > domthrottlegroupinfo, domthrottlegroupdel > * Add doc for new cmds at docs/manpages/virsh.rst > * Add cm

[PATCH 2/2] ch: ref count fix in virCHEventHandlerLoop and virCHStartEventHandler

2025-03-14 Thread Kirill Shchetiniuk
Monitor Reference Counting Fix: The monitor was being unreferenced inside virCHEventHandlerLoop, that has led to a segmentation fault. The monitor was unreferenced after successful child thread creation while it was still being used in the child thread. To maintain correct reference counting, the m

Re: [PATCH v2 00/21] Add qemu RDP server support

2025-03-14 Thread Ján Tomko
On a Friday in 2025, Martin Kletzander wrote: I've bisected it to 28d4703a1f12711ab180e72db08a83bae59941df which is what I thought was the patch that changed the behaviour. What is that commit? Both my libvirt checkouts give me: fatal: bad object 28d4703a1f12711ab180e72db08a83bae59941df And

Re: [PATCH v8 18/18] virsh: Add option "throttle-groups" to "attach_disk"

2025-03-14 Thread Peter Krempa
On Wed, Feb 19, 2025 at 22:27:22 +0530, Harikumar Rajkumar wrote: > From: Chun Feng Wu > > Update "attach_disk" to support new option: throttle-groups to > form filter chain in QEMU for specific disk > > Signed-off-by: Chun Feng Wu > > * apply suggested coding style changes. > > Signed-off-by

Re: [PATCH v8 04/18] config: Introduce ThrottleFilter and corresponding XML parsing

2025-03-14 Thread Peter Krempa
On Wed, Feb 19, 2025 at 22:27:08 +0530, Harikumar Rajkumar wrote: > From: Chun Feng Wu > > Introduce throttle filter along with corresponding operations. > > * Define new struct 'virDomainThrottleFilterDef' and corresponding destructor > * Update _virDomainDiskDef to include virDomainThrottleFil

[PATCH 0/6] qemu: Add support for iothread to virtqueue mapping for 'virtio-scsi'

2025-03-14 Thread Peter Krempa
The qemu part was now merged. Diff to rfc-v2: - The 'ctrl' and 'event' queues are not exposed to be mapped: - dropped patch for named queue support - adapted validation logic - adapted docs Peter Krempa (6): qemucapabilitiestest: Update 'caps_10.0.0_x86_64' to v9.2.0-2799-g0462

[PATCH 1/2] ch: virCHProcessStop preserve last meaningful error

2025-03-14 Thread Kirill Shchetiniuk
The last meaningful error was being reset during the execution of virCHProcessStop, which led to inconsistent error output in case any error occurred before the stop. To maintain consistent error output and avoid unknown error messages, last meaningful error preservation has been added. Signed-off

[PATCHv2 0/2] ch: minor fixes - segfault and last meaningful error preservation

2025-03-14 Thread Kirill Shchetiniuk
During fixing some other issue found out a few minor bugs related to CH driver. First bug is related to monitor object ref count in virCHStartEventHandler and virCHEventHandlerLoop, as object was unrefed by parent while is still used by child thread. Moved object unref to the correct place to the

[PATCH 5/6] qemuxmlconftest: Add 'iothreads-virtio-scsi-mapping' case

2025-03-14 Thread Peter Krempa
Test the XML and commandline for iothread<->virtqueue mapping for 'virtio-scsi' controllers. Signed-off-by: Peter Krempa --- ...ads-virtio-scsi-mapping.x86_64-latest.args | 40 ...eads-virtio-scsi-mapping.x86_64-latest.xml | 61 +++ .../iothreads-virtio-scsi-mapping.

[PATCH 6/6] NEWS: Mention multiple iothread support for 'virtio-scsi' controller

2025-03-14 Thread Peter Krempa
Signed-off-by: Peter Krempa --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 9c940b1a81..37233121b6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,12 @@ v11.2.0 (unreleased) * **New features** + * qemu: Add support for multiple iothreads for

[PATCH 4/6] qemu: Implement support for iothread <-> virtqueue mapping for 'virtio-scsi' controllers

2025-03-14 Thread Peter Krempa
Similarly to 'virtio-blk' users can map multiple iothreads and pin them appropriately for 'virtio-scsi' controllers to ensure the best performance. Implement the validation and command line generation based on the helpers we have for 'virtio-blk'. Signed-off-by: Peter Krempa --- src/qemu/qemu_c

[PATCH 3/6] conf: Add support for iothread to queue mapping config for 'virtio-scsi'

2025-03-14 Thread Peter Krempa
Upcoming qemu release will support configuring mapping iothreads to virtio queues for 'virtio-scsi' controllers in order to improve performance. Reuse the infrastructure we have from the same configuration for 'virti-blk' to implement the conf support for this feature. Signed-off-by: Peter Krempa

[PATCH 2/6] qemu: capabilities: Introduce QEMU_CAPS_VIRTIO_SCSI_IOTHREAD_MAPPING

2025-03-14 Thread Peter Krempa
The 'virtio-scsi' controller now supports iothread<->virtqueue mapping configuration. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 3 +++ tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml | 1 + 3

[PATCH 1/6] qemucapabilitiestest: Update 'caps_10.0.0_x86_64' to v9.2.0-2799-g0462a32b4f

2025-03-14 Thread Peter Krempa
Notable changes: - 'virtio-scsi' supports 'iothread-vq-mapping' - 'vfio-pci' device gained two unstable options 'x-igd-legacy-mode' and 'x-igd-lpc' Signed-off-by: Peter Krempa --- .../caps_10.0.0_x86_64.replies| 193 ++ .../caps_10.0.0_x86_64.xml

Re: [PATCH] rpm: Enable KVM for riscv64 on RHEL 10+

2025-03-14 Thread Daniel P . Berrangé
On Fri, Mar 14, 2025 at 11:01:21AM +0100, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index cb41ea1de1..9217820137 100644 > --- a/libvirt.spec.in

[PATCH] rpm: Enable KVM for riscv64 on RHEL 10+

2025-03-14 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index cb41ea1de1..9217820137 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -8,7 +8,9 @@ %define arches_qemu_kvm %{ix86} x

Re: [PATCH v8 15/18] test_driver: Test throttle group lifecycle APIs

2025-03-14 Thread Peter Krempa
On Fri, Mar 14, 2025 at 09:03:09 -, Harikumar Rajkumar wrote: > > On Wed, Feb 19, 2025 at 22:27:19 +0530, Harikumar Rajkumar wrote: > > > > For the sake of not prolonging the review any more I'm dropping this > > patch for now. Please submit it once we're done with the qemu driver > > impl. >

Re: [PATCH v8 15/18] test_driver: Test throttle group lifecycle APIs

2025-03-14 Thread Harikumar Rajkumar
> On Wed, Feb 19, 2025 at 22:27:19 +0530, Harikumar Rajkumar wrote: > > For the sake of not prolonging the review any more I'm dropping this > patch for now. Please submit it once we're done with the qemu driver > impl. Could you kindly confirm if the patch review has been completed? If so, we w

Re: [PATCH v2 00/21] Add qemu RDP server support

2025-03-14 Thread Marc-André Lureau
Hi On Thu, Mar 13, 2025 at 4:58 PM Martin Kletzander wrote: > >> $ virsh start fedora39 > >> error: Failed to start domain 'fedora39' > >> error: operation failed: Failed to connect to dbus-daemon: The connection > >> is closed > > > >Hmm, I don't get this issue. libvirt fails to connect to the

Re: [PATCH] news: Add item for guest load averages

2025-03-14 Thread Pavel Hrdina
On Mon, Mar 03, 2025 at 02:32:01PM +0100, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > NEWS.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 9c940b1a8176..d7d40cf5546d 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -17,6 +17,8 @@ v1

Re: [PATCH] NEWS: Mention new 'image_format' parameter for virDomainSaveParams

2025-03-14 Thread Pavel Hrdina
On Mon, Mar 03, 2025 at 11:34:25AM -0700, Jim Fehlig via Devel wrote: > Signed-off-by: Jim Fehlig > --- > NEWS.rst | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature