Dear Michal
Thank you for your reply.
I will create a test based on your comment and post v2.
-Original Message-
From: Michal Prívozník
Sent: Monday, February 17, 2025 11:34 PM
To: Kakuno, Akio/角野 秋男 ; 'devel@lists.libvirt.org'
Subject: Re: [PATCH 1/1] RFC: Add Arm CCA support for get
From: Chun Feng Wu
Defined new public APIs:
* virDomainSetThrottleGroup to add or update throttlegroup within specific
domain,
it will be referenced by throttlefilter later in disk to do limits
* virDomainGetThrottleGroup to get throttlegroup info, old-style is discarded
(APIs to query first
From: Chun Feng Wu
Introduce throttle filter along with corresponding operations.
* Define new struct 'virDomainThrottleFilterDef' and corresponding destructor
* Update _virDomainDiskDef to include virDomainThrottleFilterDef
* Support throttle filter "Parse" and "Format" for operations between D
From: Chun Feng Wu
ThrottleGroup lifecycle implementation, note, in QOM, throttlegroup name is
prefixed with
"throttle-" to clearly separate throttle group objects into their own namespace.
* "qemuDomainSetThrottleGroup", this method is to add("object-add") or
update("qom-set")
throttlegroup
From: Chun Feng Wu
Introduce schema for defining '' element which
references throttling groups to form filter chain in qemu for specific
disk
* Add new elements ''
* can include multiple throttlegroup references to
form filter chain in qemu
* Chained throttle filters feature in qemu is descri
From: Chun Feng Wu
Update "attach_disk" to support new option: throttle-groups to
form filter chain in QEMU for specific disk
Signed-off-by: Chun Feng Wu
* apply suggested coding style changes.
Signed-off-by: Harikumar Rajkumar
---
docs/manpages/virsh.rst| 3 ++-
tools/virsh-comple
From: Chun Feng Wu
Implement new throttle cmds
* Add new virsh cmds: domthrottlegroupset, domthrottlegrouplist,
domthrottlegroupinfo, domthrottlegroupdel
* Add doc for new cmds at docs/manpages/virsh.rst
* Add cmd helper "virshDomainThrottleGroupCompleter", which is used by
domthrottlegroups
From: Chun Feng Wu
Define macro for iotune options, this macro is used by opts_blkdeviotune and
later throttle group opts
Signed-off-by: Chun Feng Wu
---
tools/virsh-domain.c | 308 ++-
1 file changed, 156 insertions(+), 152 deletions(-)
diff --git a/to
From: Chun Feng Wu
Test throttle group APIs
* Extract common methods for both "testDomainSetThrottleGroup" and
"testDomainSetBlockIoTune":
testDomainValidateBlockIoTune, testDomainSetBlockIoTuneFields,
testDomainCheckBlockIoTuneMutualExclusion, testDomainCheckBlockIoTuneMax
* Test "Set": testD
* Add tests for throttlefilter nodename parse and format for statusxml
(disk/privateData/nodenames/nodename with type='throttle-filter')
* Add iotune limited disk tests to make sure iotune refactory works
Signed-off-by: Chun Feng Wu
* Isolate status xml test
Signed-off-by: Harikumar Rajkumar
-
From: Chun Feng Wu
* Add tests for throttlegroup domain xml processing, including
groups referenced and not referenced by filters
* Add tests for throttlefilter domain xml processing, including
throttle group referenced by different disks
* Add negative test case to report error when iotune is co
From: Chun Feng Wu
Refactor iotune verification, and verify some rules
* Disk iotune validation can be reused for throttle group validation,
refactor it into common method "virDomainDiskIoTuneValidate"
* Add "virDomainDefValidateThrottleGroups" to validate throttle groups,
which in turn call
From: Chun Feng Wu
For hot attaching/detaching
* Leverage qemuBlockThrottleFiltersData to prepare attaching/detaching
throttle filter data for qemuMonitorBlockdevAdd and qemuMonitorBlockdevDel
* For hot attaching, within qemuDomainAttachDiskGeneric,prepare throttle
filters json data, and crea
From: Chun Feng Wu
It contains throttle filter nodename processing(new nodename,
topnodename, parse and format nodename), throttle filter
attaching/detaching preparation and implementation.
* Updated "qemuDomainDiskGetTopNodename", so if throttlefilter is used
together with copyOnRead, top nod
From: Chun Feng Wu
extract common methods from "qemuDomainSetBlockIoTune" to be reused
by throttle handling later, common methods include:
* "qemuDomainValidateBlockIoTune", which is to validate that PARAMS
contains only recognized parameter names with correct types
* "qemuDomainSetBlockIoTuneF
From: Chun Feng Wu
Within "testQemuMonitorJSONqemuMonitorJSONUpdateThrottleGroup"
* Test qemuMonitorJSONGetThrottleGroup
* Test qemuMonitorJSONUpdateThrottleGroup, which updates limits through
"qom-set"
Signed-off-by: Chun Feng Wu
* fix test
Signed-off-by: Harikumar Rajkumar
---
tests/qemu
From: Chun Feng Wu
This change contains QMP requests for ThrottleGroup
* ThrottleGroup is updated through "qemuMonitorJSONUpdateThrottleGroup"
* ThrottleGroup is retrieved through "qemuMonitorJSONGetThrottleGroup"
* ThrottleGroup is deleted by reusing "qemuMonitorDelObject"
* ThrottleGroup is ad
From: Chun Feng Wu
Introduce throttlegroup into domain and provide corresponding methods
* Define new struct 'virDomainThrottleGroupDef' and corresponding destructor
* Add operations(Add, Update, Del, ByName, Copy, Free) for
'virDomainThrottleGroupDef'
* Update _virDomainDef to include virDomai
From: Chun Feng Wu
Introduce schema for defining '' element which
configures throttling groups which can be configured for multiple
disks.
* Refactor "diskIoTune" to extract common schema "iotune"
* Add new elements ''
* contains defintion, which references
"iotune"
Signed-off-by: Chun Feng
*** Support block disk along with throttle filters ***
Chun Feng Wu (17):
schema: Add new domain elements to support multiple throttle groups
schema: Add new domain elements to support multiple throttle filters
config: Introduce ThrottleGroup and corresponding XML parsing
config: Introduce
On 2/18/25 19:12, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> src/libxl/libxl_domain.c | 14 ++
> src/qemu/qemu_validate.c | 15 +++
> 2 files changed, 29 insertions(+)
>
Please consider squashing in the following:
diff --git a/src/libxl/libxl
On Wed, Feb 19, 2025 at 04:57:07PM +0100, Michal Prívozník wrote:
> On 2/18/25 19:12, Daniel P. Berrangé wrote:
> > Signed-off-by: Daniel P. Berrangé
> > ---
> > src/libxl/libxl_domain.c | 14 ++
> > src/qemu/qemu_validate.c | 15 +++
> > 2 files changed, 29 insertions(+)
On 2/18/25 19:12, Daniel P. Berrangé wrote:
> This was requested by KubeVirt in
>
> https://gitlab.com/libvirt/libvirt/-/issues/748
>
> I've not functionally tested this, since I lack any suitable guest
> windows environment this is looking for MSDM tables, nor does my
> machine have MSDM ACPI
On 2/18/25 19:12, Daniel P. Berrangé wrote:
> Currently we parse
>
>
>
>...path...
>
>
>
> into a flat 'char *slic_table' field which is rather an anti-pattern
> as it has special cased a single attribute type.
>
> This rewrites the internal design to permit multiple
On 2/18/25 19:12, Daniel P. Berrangé wrote:
> The MSDM ACPI table is a replacement for the SLIC table type, now
> preferred by Microsoft for Windows Licensing checks:
>
>
> https://learn.microsoft.com/en-us/previous-versions/windows/hardware/design/dn653305(v=vs.85)
>
> Signed-off-by: Daniel P
On Tue, Feb 18, 2025 at 07:45:45PM +0800, honglei.w...@smartx.com wrote:
> From: hongleiwang
>
> QEMU has supported nvme disk emulation for a long time,
> see: https://qemu-project.gitlab.io/qemu/system/devices/nvme.html.
>
> The following patches introduce nvme and nvme-ns disk bus type:
> A di
On Wed, Feb 19, 2025 at 10:44:25AM -, Harikumar Rajkumar wrote:
> > On Wed, Feb 12, 2025 at 04:05:22PM +0530, Harikumar Rajkumar wrote:
> >
> > When this patch was posted in v6:
> >
> >
> > https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/V...
> >
> > The authorship
> On Wed, Feb 12, 2025 at 04:05:22PM +0530, Harikumar Rajkumar wrote:
>
> When this patch was posted in v6:
>
>
> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/V...
>
> The authorship was credited to Chun Feng Wu, and also had
> their signed-off-by.
>
> If picking up
Hi,
On Wed, Feb 19, 2025 at 10:48:33AM +0100, Peter Krempa wrote:
> On Wed, Feb 19, 2025 at 09:48:30 +0100, Victor Toso wrote:
> > On Tue, Feb 18, 2025 at 07:35:33PM +0100, Jiri Denemark wrote:
> > > On Tue, Feb 18, 2025 at 19:21:56 +0100, Victor Toso wrote:
> > > > Hi,
> > > >
> > > > On Tue, Fe
On Wed, Feb 19, 2025 at 09:48:30 +0100, Victor Toso wrote:
> On Tue, Feb 18, 2025 at 07:35:33PM +0100, Jiri Denemark wrote:
> > On Tue, Feb 18, 2025 at 19:21:56 +0100, Victor Toso wrote:
> > > Hi,
> > >
> > > On Tue, Feb 18, 2025 at 07:11:45PM +0100, Jiri Denemark wrote:
> > > > On Tue, Feb 18, 20
On Tue, Feb 18, 2025 at 07:35:33PM +0100, Jiri Denemark wrote:
> On Tue, Feb 18, 2025 at 19:21:56 +0100, Victor Toso wrote:
> > Hi,
> >
> > On Tue, Feb 18, 2025 at 07:11:45PM +0100, Jiri Denemark wrote:
> > > On Tue, Feb 18, 2025 at 18:41:46 +0100, Victor Toso wrote:
> > > > Hi,
> > > >
> > > > I
31 matches
Mail list logo
