On 2/4/25 11:04 PM, Xuda Zhang wrote:
Could you help confirm the exact behavior in this case? Specifically:
1. If a target tap device already exists, does libvirt modify the MAC
address instead of recreating the device?
Sorry, I needed to qualify that detail a bit (and actually I probabl
ping for trivial review?
On 8/11/24 16:43, Philippe Mathieu-Daudé wrote:
When a property value is static (not provided by QMP or CLI),
error shouldn't happen, otherwise it is a programming error.
Therefore simplify and use &error_abort as this can't fail.
Reported-by: Richard Henderson
Signed-
On Tue, Feb 04, 2025 at 14:36:48 -0600, Praveen K Paladugu wrote:
> Enable SEV-SNP support for ch guests.
>
> Co-Authored-by: Smit Gardhariya
> Signed-off-by: Praveen K Paladugu
> ---
> src/ch/ch_monitor.c | 74 +
> 1 file changed, 62 insertions(+), 1
Enable SEV-SNP support for ch guests.
Co-Authored-by: Smit Gardhariya
Signed-off-by: Praveen K Paladugu
---
src/ch/ch_monitor.c | 74 +
1 file changed, 62 insertions(+), 12 deletions(-)
diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c
index bed
Consider also the destination of a block-copy job.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 2ef18b77fc..87f87bbe56 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_
Users can choose to copy a disk into a destination where they want to
use persistent reservations. Start the daemon if the configuration
requires it.
Resolves: https://issues.redhat.com/browse/RHEL-7342
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 5 +
1 file changed, 5 insertion
Check if the persistent reservations manager daemon is still needed
after a disk (sub)-chain was dropped after a blockjob.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index 4e7
Export qemuHotplugAttachManagedPR/qemuHotplugRemoveManagedPR for reuse
in blockjob code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 4 ++--
src/qemu/qemu_hotplug.h | 8
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu
Fix the mixed style by unifying the formatting.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.h | 167 ++--
1 file changed, 92 insertions(+), 75 deletions(-)
diff --git a/src/qemu/qemu_hotplug.h b/src/qemu/qemu_hotplug.h
index 4fe7f4923e..c6cea0fe69 1
See 5/5
Peter Krempa (5):
qemu_hotplug.h: Reformat according to new coding style
virDomainDefHasManagedPR: Consider also disk's 'mirror' chain
qemu: hotplug: Export persistent reservations manager helper functions
qemu: blockjob: Remove persistent reservations manager when dropping
dis
Add ccwgroup node device type supporting qeth generic driver.
Signed-off-by: Boris Fiuczynski
---
docs/manpages/virsh.rst | 6 +-
include/libvirt/libvirt-nodedev.h | 1 +
src/conf/node_device_conf.c | 212 ++
src/conf/node_d
Replace cssid, ssid and devno elements with virCCWDeviceAddress.
Reviewed-by: Marc Hartmayer
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 16 ++--
src/conf/node_device_conf.h | 4 +---
src/node_device/node_device_driver.c | 11 ++-
src
Refactor method to be only ccw state type depended to allow reuse in a
later patch.
Reviewed-by: Marc Hartmayer
Signed-off-by: Boris Fiuczynski
---
src/node_device/node_device_udev.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/node_device/node_device_udev.c
Refactor for reuse in the following patch.
Reviewed-by: Marc Hartmayer
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index 08a89942
Add the group membership information to a CCW device. Allow to filter
CCW devices based on a group membership.
Signed-off-by: Boris Fiuczynski
---
docs/manpages/virsh.rst | 19 ++--
include/libvirt/libvirt-nodedev.h | 1 +
src/conf/node_device_conf.c
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c| 8
src/conf/node_device_conf.h| 2 ++
src/conf/schemas/nodedev.rng | 6 +-
src/node_device/node_device_udev.c | 6 +-
4 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/src/conf/no
Directly use virCCWDeviceAddressFormat.
Reviewed-by: Marc Hartmayer
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index 85effb7d78..4
CCW group devices are devices that use multiple subchannels on the mainframe's
channel subsystem. A qeth group device maps to subchannels and their
corresponding device numbers and device bus-IDs.
The qeth device driver requires three I/O subchannels for each HiperSockets
CHPID or OSA-Express CHPI
Refactor to allow reuse in ccwgroup.
Reviewed-by: Marc Hartmayer
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index 44511f..bfd8
Update the data after the release.
Notable changes:
- the 6.2 machine types became deprecated
Signed-off-by: Peter Krempa
---
.../qemucapabilitiesdata/caps_9.2.0_x86_64.replies | 14 +++---
tests/qemucapabilitiesdata/caps_9.2.0_x86_64.xml | 12 ++--
2 files changed, 13 insert
Peter Krempa (2):
qemucapabilitiestest: Final update for qemu-9.2 release on x86_64
qemucapabilitiestest: Add data for the qemu-10.0 dev cycle on x86_64
.../domaincapsdata/qemu_10.0.0-q35.x86_64.xml | 1702 +
.../domaincapsdata/qemu_10.0.0-tcg.x86_64.xml | 1810 +
tests/domaincapsdata/qemu_
On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé wrote:
>
> Merge Raspi4bMachineState within RaspiMachineState by
> using an unnamed union.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/raspi.c | 21 +++--
> 1 file changed, 7 insertions(+), 14 deletions(-)
>
> diff
On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé wrote:
>
> Add the 'max_ramsize' field to the soc_property[] array,
> corresponding to the maximum DRAM size a SoC can map.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/raspi.c | 21 +
> 1 file changed, 17 insert
On Tue, 4 Feb 2025 at 00:22, Philippe Mathieu-Daudé wrote:
>
> We shouldn't access a QOM parent object directly.
> Use the appropriate type-cast macro.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/raspi.c | 2 +-
> hw/arm/raspi4b.c | 2 +-
> 2 files changed, 2 insertions(+), 2 dele
On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé wrote:
>
> Raspberry Pi 'B' models have an ethernet chipset (the LAN9512).
> Since we don't yet model it, add a /* TODO */ comment.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/raspi.c | 14 ++
> 1 file changed, 14 inser
On Tue, 4 Feb 2025 at 00:22, Philippe Mathieu-Daudé wrote:
>
> Except we alter the device tree blob, the 4B
> is just another raspi model.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/raspi.c | 114 -
> hw/arm/raspi4b.c | 136
On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé wrote:
>
> Expand the current type2model array to include the processor id.
>
> Since the BCM2838 is indistinctly used as BCM2711 (within the
> Linux community), add it as alias in RaspiProcessorId.
Can you explain this in more detail? Presumabl
On 4/2/25 14:52, Peter Maydell wrote:
On Tue, 4 Feb 2025 at 13:40, Philippe Mathieu-Daudé wrote:
On 4/2/25 12:13, Peter Maydell wrote:
On Tue, 4 Feb 2025 at 09:57, Daniel P. Berrangé wrote:
IMHO we can have distinct machines for each model, but
*NOT* have further machines for each RAM size
On Tue, 4 Feb 2025 at 13:40, Philippe Mathieu-Daudé wrote:
>
> On 4/2/25 12:13, Peter Maydell wrote:
> > On Tue, 4 Feb 2025 at 09:57, Daniel P. Berrangé wrote:
> >> IMHO we can have distinct machines for each model, but
> >> *NOT* have further machines for each RAM size within a
> >> model.
> >
>
On 4/2/25 12:13, Peter Maydell wrote:
On Tue, 4 Feb 2025 at 09:57, Daniel P. Berrangé wrote:
On Tue, Feb 04, 2025 at 10:51:04AM +0100, Philippe Mathieu-Daudé wrote:
On 4/2/25 10:22, Peter Maydell wrote:
On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé wrote:
All previous raspi machines
On Tue, 4 Feb 2025 at 09:57, Daniel P. Berrangé wrote:
>
> On Tue, Feb 04, 2025 at 10:51:04AM +0100, Philippe Mathieu-Daudé wrote:
> > On 4/2/25 10:22, Peter Maydell wrote:
> > > On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé
> > > wrote:
> > > >
> > > > All previous raspi machines can be c
On Tue, Feb 04, 2025 at 11:48:10AM +0100, Philippe Mathieu-Daudé wrote:
> On 4/2/25 10:57, Daniel P. Berrangé wrote:
> > On Tue, Feb 04, 2025 at 10:51:04AM +0100, Philippe Mathieu-Daudé wrote:
> > > On 4/2/25 10:22, Peter Maydell wrote:
> > > > On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé
On 4/2/25 10:57, Daniel P. Berrangé wrote:
On Tue, Feb 04, 2025 at 10:51:04AM +0100, Philippe Mathieu-Daudé wrote:
On 4/2/25 10:22, Peter Maydell wrote:
On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé wrote:
All previous raspi machines can be created using the
generic machine. Deprecate
On 2/4/25 11:04, David Hildenbrand wrote:
On 04.02.25 10:57, Boris Fiuczynski wrote:
On 2/4/25 10:06, David Hildenbrand wrote:
On 03.02.25 10:55, Michal Privoznik wrote:
v2 of:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/
thread/KA2DGRIY7DAMNMYM4MBKLOJCB7YYEUKU/
I shoul
On 04.02.25 10:57, Boris Fiuczynski wrote:
On 2/4/25 10:06, David Hildenbrand wrote:
On 03.02.25 10:55, Michal Privoznik wrote:
v2 of:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/
thread/KA2DGRIY7DAMNMYM4MBKLOJCB7YYEUKU/
I should probably play with this myself, but due t
On Tue, 4 Feb 2025, Philippe Mathieu-Daudé wrote:
On 4/2/25 10:22, Peter Maydell wrote:
On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé
wrote:
All previous raspi machines can be created using the
generic machine. Deprecate the old names to maintain
a single one. Update the tests.
Signed-
On Tue, Feb 04, 2025 at 10:51:04AM +0100, Philippe Mathieu-Daudé wrote:
> On 4/2/25 10:22, Peter Maydell wrote:
> > On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé
> > wrote:
> > >
> > > All previous raspi machines can be created using the
> > > generic machine. Deprecate the old names to ma
On 2/4/25 10:06, David Hildenbrand wrote:
On 03.02.25 10:55, Michal Privoznik wrote:
v2 of:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/
thread/KA2DGRIY7DAMNMYM4MBKLOJCB7YYEUKU/
I should probably play with this myself, but due to lack of a test
system where I can mess
On 4/2/25 10:22, Peter Maydell wrote:
On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé wrote:
All previous raspi machines can be created using the
generic machine. Deprecate the old names to maintain
a single one. Update the tests.
Signed-off-by: Philippe Mathieu-Daudé
diff --git a/doc
On 04.02.25 10:13, David Hildenbrand wrote:
On 03.02.25 10:55, Michal Privoznik wrote:
There are basically two differences between virtio-mem-ccw and
virtio-mem-pci. s390 doesn't allow mixing different page sizes
and there's no NUMA support in QEMU.
Signed-off-by: Michal Privoznik
Reviewed-by:
On Tue, 4 Feb 2025 at 00:23, Philippe Mathieu-Daudé wrote:
>
> All previous raspi machines can be created using the
> generic machine. Deprecate the old names to maintain
> a single one. Update the tests.
>
> Signed-off-by: Philippe Mathieu-Daudé
> diff --git a/docs/about/deprecated.rst b/docs/a
On 03.02.25 10:55, Michal Privoznik wrote:
There are basically two differences between virtio-mem-ccw and
virtio-mem-pci. s390 doesn't allow mixing different page sizes
and there's no NUMA support in QEMU.
Signed-off-by: Michal Privoznik
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_valida
On 03.02.25 10:55, Michal Privoznik wrote:
v2 of:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/KA2DGRIY7DAMNMYM4MBKLOJCB7YYEUKU/
I should probably play with this myself, but due to lack of a test
system where I can mess with systemd:
Assuming we're on a s390x host
43 matches
Mail list logo