[PATCH pushed] qemuDomainDiskChangeSupportedIothreads: Change error wording to fix grammar

Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 1fc4e2f33f..3366346624 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -6676,7 +6676,7 @@ qemuDomain

Re: [PATCH v2 0/5] Allow Guest CPU Model with Deprecated Features Disabled

On 11/26/24 11:59 AM, Jiri Denemark wrote: > On Mon, Nov 25, 2024 at 14:46:34 -0500, Collin Walling wrote: >> # Changelog >> >> v2 >> - rebased on latest master changes > > I started reviewing the v1 yesterday with a plan to push this in time > for the release, but I found a few issues and go

[PATCH v6 18/18] tests: Test qemuxmlactivetestThrottleGroup

* updated latest 11.0.0, qemu gitlab url, documents and change requests signed-off-by: Harikumar R --- docs/formatdomain.rst | 4 ++-- src/conf/domain_conf.c | 31 +++ 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/docs/formatdomain.rst b/docs/form

[PATCH v6 17/18] virsh: Add option "throttle-groups" to "attach_disk"

From: Chun Feng Wu Update "attach_disk" to support new option: throttle-groups to form filter chain in QEMU for specific disk Signed-off-by: Chun Feng Wu --- docs/manpages/virsh.rst| 3 ++- tools/virsh-completer-domain.c | 27 +++ tools/virsh-completer-domain.h

[PATCH v6 16/18] virsh: Add support for throttle group operations

From: Chun Feng Wu Implement new throttle cmds * Add new virsh cmds: domthrottlegroupset, domthrottlegrouplist, domthrottlegroupinfo, domthrottlegroupdel * Add doc for new cmds at docs/manpages/virsh.rst * Add cmd helper "virshDomainThrottleGroupCompleter", which is used by domthrottlegroups

[PATCH v6 15/18] virsh: Refactor iotune options for re-use

From: Chun Feng Wu Define macro for iotune options, this macro is used by opts_blkdeviotune and later throttle group opts Signed-off-by: Chun Feng Wu --- tools/virsh-domain.c | 308 ++- 1 file changed, 156 insertions(+), 152 deletions(-) diff --git a/to

[PATCH v6 14/18] test_driver: Test throttle group lifecycle APIs

From: Chun Feng Wu Test throttle group APIs * Extract common methods for both "testDomainSetThrottleGroup" and "testDomainSetBlockIoTune": testDomainValidateBlockIoTune, testDomainSetBlockIoTuneFields, testDomainCheckBlockIoTuneMutualExclusion, testDomainCheckBlockIoTuneMax * Test "Set": testD

[PATCH v6 13/18] qemuxmlconftest: Add 'throttlefilter' tests

From: Chun Feng Wu Test domain xml and status xml * Add tests for "throttlegroup" domain xml processing, including groups referenced and not referenced by filters * Add tests for "throttlefilter" domain xml processing, including throttle group referenced by different disks * Add negative tes

[PATCH v6 12/18] config: validate: Verify iotune, throttle group and filter

From: Chun Feng Wu Refactor iotune verification, and verify some rules * Disk iotune validation can be reused for throttle group validation, refactor it into common method "virDomainDiskIoTuneValidate" * Add "virDomainDefValidateThrottleGroups" to validate throttle groups, which in turn call

[PATCH v6 11/18] qemu: block: Support block disk along with throttle filters

From: Chun Feng Wu For hot attaching/detaching * Leverage qemuBlockThrottleFiltersData to prepare attaching/detaching throttle filter data for qemuMonitorBlockdevAdd and qemuMonitorBlockdevDel * For hot attaching, within qemuDomainAttachDiskGeneric,prepare throttle filters json data, and crea

[PATCH v6 10/18] qemu: helper: throttle filter nodename and preparation processing

From: Chun Feng Wu It contains throttle filter nodename processing(new nodename, topnodename, parse and format nodename), throttle filter attaching/detaching preparation and implementation. * Updated "qemuDomainDiskGetTopNodename", so if throttlefilter is used together with copyOnRead, top nod

[PATCH 1/1] virt-aa-helper: allow riscv64 EDK II

Debian has packaged EDK II for 64-bit RISC-V in directory /usr/share/qemu-efi-riscv64/. For usage with libvirt update the AppArmor helper. Signed-off-by: Heinrich Schuchardt --- src/security/virt-aa-helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/security/virt-aa-helper.c b/src

[PATCH v6 09/18] qemu: Implement qemu driver for throttle API

From: Chun Feng Wu ThrottleGroup lifecycle implementation, note, in QOM, throttlegroup name is prefixed with "throttle-" to clearly separate throttle group objects into their own namespace. * "qemuDomainSetThrottleGroup", this method is to add("object-add") or update("qom-set") throttlegroup

[PATCH v6 08/18] qemu: Refactor qemuDomainSetBlockIoTune to extract common methods

From: Chun Feng Wu extract common methods from "qemuDomainSetBlockIoTune" to be reused by throttle handling later, common methods include: * "qemuDomainValidateBlockIoTune", which is to validate that PARAMS contains only recognized parameter names with correct types * "qemuDomainSetBlockIoTuneF

[PATCH v6 07/18] remote: New APIs for ThrottleGroup lifecycle management

From: Chun Feng Wu Defined new public APIs: * virDomainSetThrottleGroup to add or update throttlegroup within specific domain, it will be referenced by throttlefilter later in disk to do limits * virDomainGetThrottleGroup to get throttlegroup info, old-style is discarded (APIs to query first

[PATCH v6 06/18] tests: Test qemuMonitorJSONGetThrottleGroup and qemuMonitorJSONUpdateThrottleGroup

From: Chun Feng Wu Within "testQemuMonitorJSONqemuMonitorJSONUpdateThrottleGroup" * Test qemuMonitorJSONGetThrottleGroup * Test qemuMonitorJSONUpdateThrottleGroup, which updates limits through "qom-set" Signed-off-by: Chun Feng Wu --- tests/qemumonitorjsontest.c | 86 +

[PATCH v6 05/18] qemu: monitor: Add support for ThrottleGroup operations

From: Chun Feng Wu This change contains QMP requests for ThrottleGroup * ThrottleGroup is updated through "qemuMonitorJSONUpdateThrottleGroup" * ThrottleGroup is retrieved through "qemuMonitorJSONGetThrottleGroup" * ThrottleGroup is deleted by reusing "qemuMonitorDelObject" * ThrottleGroup is ad

[PATCH v6 04/18] config: Introduce ThrottleFilter and corresponding XML parsing

From: Chun Feng Wu Introduce throttle filter along with corresponding operations. * Define new struct 'virDomainThrottleFilterDef' and corresponding destructor * Update _virDomainDiskDef to include virDomainThrottleFilterDef * Support throttle filter "Parse" and "Format" for operations between D

[PATCH v6 03/18] config: Introduce ThrottleGroup and corresponding XML parsing

From: Chun Feng Wu Introduce throttlegroup into domain and provide corresponding methods * Define new struct 'virDomainThrottleGroupDef' and corresponding destructor * Add operations(Add, Update, Del, ByName, Copy, Free) for 'virDomainThrottleGroupDef' * Update _virDomainDef to include virDomai

[PATCH v6 02/18] schema: Add new domain elements to support multiple throttle filters

From: Chun Feng Wu Introduce schema for defining '' element which references throttling groups to form filter chain in qemu for specific disk * Add new elements '' * can include multiple throttlegroup references to form filter chain in qemu * Chained throttle filters feature in qemu is descri

[PATCH v6 01/18] schema: Add new domain elements to support multiple throttle groups

From: Chun Feng Wu Introduce schema for defining '' element which configures throttling groups which can be configured for multiple disks. * Refactor "diskIoTune" to extract common schema "iotune" * Add new elements '' * contains defintion, which references "iotune" Signed-off-by: Chun Feng

[PATCH v6 00/18] *** qemu: block: Support block disk along with throttle filters ***

*** Support block disk along with throttle filters *** Chun Feng Wu (17): schema: Add new domain elements to support multiple throttle groups schema: Add new domain elements to support multiple throttle filters config: Introduce ThrottleGroup and corresponding XML parsing config: Introduce

[PATCH 1/1] virt-aa-helper: allow riscv64 EDK II

Debian has packaged EDK II for 64-bit RISC-V in directory /usr/share/qemu-efi-riscv64/. For usage with libvirt update the AppArmor helper. Signed-off-by: Heinrich Schuchardt --- src/security/virt-aa-helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/security/virt-aa-helper.c b/src