On Tue, Nov 26, 2024 at 14:36:55 +0800, Han Han wrote:
> Hi Jiri,
> I patched these patches to v10.9.0-159-ge9b8be23f7 then built and installed
> the rpms. After that, I hit an error when start a domain with host-model
> cpu:
>
> Version:
> libvirt v10.9.0-159-ge9b8be23f7 with this patch series
>
Hi Jiri,
I patched these patches to v10.9.0-159-ge9b8be23f7 then built and installed
the rpms. After that, I hit an error when start a domain with host-model
cpu:
Version:
libvirt v10.9.0-159-ge9b8be23f7 with this patch series
qemu-kvm-9.1.0-5.el9.x86_64
host CPU: Intel(R) Xeon(R) Gold 5218 CPU @
If the layer of a virFirewallCmd is "tc", then the "tc" utility will
be executed using the arguments that had been added to the
virFirewallCmd
tc layer doesn't support auto-rollback command creation (any rollback
needs to be added manually with virFirewallAddRollbackCmd()), and also
tc layer isn't
Please see the commit log for commit v10.9.0-rc1-1-g42ab0148dd for the
history and explanation of the problem that this patch is fixing.
A shorter explanation is that when a guest is connected to a libvirt
virtual network using a virtio-net adapter with in-kernel "vhost-net"
packet processing enab
There will soon be two separate users of tc on virtual networks, and
both will use the "qdisc root handle 1: htb" to add tx filters. One or the
other could get the first chance to add the qdisc, and then if at a
later time the other decides to use it, we need to prevent the 2nd
user from attempting
virNetDevBandwidthSet() adds a queue discipline (qdisc) for each
interface that it will need to add tc transmit filters to, and the
filters are then attached to the qdisc.
There are other circumstances where some other function will need to
add tc transmit filters to an interface (in particular an
virNetDevBandwidthSet() always clears all existing qdiscs and their
subordinate filters before adding all the new qdiscs/filters. This is
normally exactly what we want, but there is one case (the network
driver) where the Qdisc added by virNetDevBandwidthSet() may already
be in use by the nftables
Having two bools in the arg list is on the borderline of being
confusing to anyone trying to read the code, but we're about to add a
3rd. This patch replaces the two bools with a single flags argument
which will instead have one or more bits from virNetDevBandwidthFlags
set.
Signed-off-by: Laine S
Patch 6/6 explains the problem and how these patches fix it. Assuming
no problems are found (none so far) this should go into 10.10.0, as it
solves a regression caused by switching the network driver to the
nftables backend.
There was a prior attempt at fixing this that was accepted, pushed,
bugs
On 11/25/24 12:15 PM, Daniel P. Berrangé wrote:
On Mon, Nov 25, 2024 at 11:56:31AM -0500, Laine Stump wrote:
On 11/25/24 5:44 AM, Daniel P. Berrangé wrote:
On Fri, Nov 22, 2024 at 04:16:38PM -0500, Laine Stump wrote:
If the layer of a FirewallCmd is "raw", then the first arg is the name
of an
On Wed, Nov 20, 2024 at 18:48:35 +0300, Nikolai Barybin via Devel wrote:
> Hello everyone!
>
> Nikolai Barybin (15):
> conf: add data-file feature and related fields to virStorageSource
> Add VIR_STORAGE_FILE_FEATURE_DATA_FILE to virStorageFileFeature enum
> conf: schemas: add data-file stor
On Thu, Nov 21, 2024 at 15:11:46 +0100, Peter Krempa wrote:
> On Wed, Nov 20, 2024 at 18:48:42 +0300, Nikolai Barybin via Devel wrote:
> > Signed-off-by: Nikolai Barybin
> > ---
> > src/storage_file/storage_source.c | 39 +++
> > src/storage_file/storage_source.h | 4
On Wed, Nov 20, 2024 at 18:48:44 +0300, Nikolai Barybin via Devel wrote:
> Signed-off-by: Nikolai Barybin
> ---
> src/security/security_selinux.c | 27 +--
> 1 file changed, 25 insertions(+), 2 deletions(-)
[...]
> @@ -2067,6 +2075,14 @@ virSecuritySELinuxSetImageLabel(v
On Wed, Nov 20, 2024 at 18:48:45 +0300, Nikolai Barybin via Devel wrote:
> Signed-off-by: Nikolai Barybin
> ---
> src/security/virt-aa-helper.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
> index 067a17f331..a2914f22b
Add QEMU_CAPS_QUERY_CPU_MODEL_EXPANSION_DEPRECATED_PROPS for detecting
if query-cpu-model-expansion can report deprecated CPU model properties.
QEMU introduced this capability in 9.1 release. Add flag and deprecated
features to the capabilities test data for QEMU 9.1 and 9.2 replies/XML
since it c
Refactor the CPU Model parsing functions within
qemuMonitorJSONGetCPUModelExpansion. The new functions,
qemuMonitorJSONParseCPUModelExpansionData and
qemuMonitorJSONParseCPUModelExpansion invoke the functions they
replace and leave room for a subsequent patch to handle parsing the
(optional) depre
Add a new a attribute, deprecated_features='on|off' to the
element. This is used to toggle features flagged as deprecated on the
CPU model on or off. When this attribute is paired with 'on',
deprecated features will not be filtered. When paired with 'off', any
CPU features that are flagged as d
Add a new flag, --disable-deprecated-features, to the domcapabilities
command. This will modify the output to show the 'host-model' CPU
with features flagged as deprecated paired with the 'disable' policy.
virsh domcapabilities --disable-deprecated-features
Signed-off-by: Collin Walling
---
do
query-cpu-model-expansion may report an array of deprecated properties.
This array is optional, and may not be supported for a particular
architecture or reported for a particular CPU model. If the output is
present, then capture it and store in a qemuMonitorCPUModelInfo struct
for later use.
The
# Changelog
v2
- rebased on latest master changes
# Description
Add support for libvirt to query and cache an array of deprecated CPU features
(aka CPU properties) for the host-model. This data is queried via a full
query-cpu-model-expansion and cached in the QEMU capabilities file. This
On Wed, 2024-11-13 at 11:28 -0300, Georgia Garcia wrote:
> Some rules are generated dynamically during boot and added to the
> AppArmor policy. An example of that is macvtap devices that call the
> AppArmorSetFDLabel hook to add a rule for the tap device path.
>
> Since this information is dynamic
On Wed, Nov 20, 2024 at 18:48:50 +0300, Nikolai Barybin via Devel wrote:
> Signed-off-by: Nikolai Barybin
> ---
> docs/formatdomain.rst | 45 ---
> 1 file changed, 42 insertions(+), 3 deletions(-)
I'll adapt the docs to conform with the changes in naming a
On Fri, Nov 22, 2024 at 10:32:55PM +0100, Jiri Denemark wrote:
> Some models are just aliases to other models. Make this relation
> available to users via domain capabilities.
>
> Signed-off-by: Jiri Denemark
> ---
>
> Notes:
> Version 2:
> - new patch
>
> docs/formatdomaincaps.rst
On Wed, Nov 20, 2024 at 18:48:48 +0300, Nikolai Barybin via Devel wrote:
> - propogate data-file to cmdline
> - determine data-file within disk chain
> - enable live disk insertion
>
> Signed-off-by: Nikolai Barybin
> ---
> src/qemu/qemu_block.c | 14 ++
> src/qemu/qemu_command.c |
On Mon, Nov 25, 2024 at 11:56:31AM -0500, Laine Stump wrote:
> On 11/25/24 5:44 AM, Daniel P. Berrangé wrote:
> > On Fri, Nov 22, 2024 at 04:16:38PM -0500, Laine Stump wrote:
> > > If the layer of a FirewallCmd is "raw", then the first arg is the name
> > > of an arbitrary binary to exec, and the r
On 11/25/24 5:44 AM, Daniel P. Berrangé wrote:
On Fri, Nov 22, 2024 at 04:16:38PM -0500, Laine Stump wrote:
If the layer of a FirewallCmd is "raw", then the first arg is the name
of an arbitrary binary to exec, and the rest are the arguments to that
binary.
raw layer doesn't support auto-rollba
On Wed, Nov 20, 2024 at 18:48:39 +0300, Nikolai Barybin via Devel wrote:
> Data files are simple raw images. Thus, we don't need to parse
> too much. The main objectives are:
>
> - allow only RAW format
> - forbid storage slices
> - include this parsing/formatting into backing chain parse/format a
On 11/25/24 5:41 AM, Daniel P. Berrangé wrote:
On Fri, Nov 22, 2024 at 04:16:37PM -0500, Laine Stump wrote:
There will soon be two separate users of tc on virtual networks, and
both will use the "qdisc root handle 1: htb" to add tx filters. One or the
other could get the first chance to add the
On 11/25/24 5:38 AM, Daniel P. Berrangé wrote:
On Fri, Nov 22, 2024 at 04:16:35PM -0500, Laine Stump wrote:
virNetDevBandwidthSet() always clears all existing qdiscs and their
subordinate filters before adding all the new qdiscs/filters. This is
normally exactly what we want, but there is one ca
On Fri, Nov 22, 2024 at 04:16:38PM -0500, Laine Stump wrote:
> If the layer of a FirewallCmd is "raw", then the first arg is the name
> of an arbitrary binary to exec, and the rest are the arguments to that
> binary.
>
> raw layer doesn't support auto-rollback command creation (any rollback
> need
On Fri, Nov 22, 2024 at 04:16:37PM -0500, Laine Stump wrote:
> There will soon be two separate users of tc on virtual networks, and
> both will use the "qdisc root handle 1: htb" to add tx filters. One or the
> other could get the first chance to add the qdisc, and then if at a
> later time the oth
On Fri, Nov 22, 2024 at 04:16:35PM -0500, Laine Stump wrote:
> virNetDevBandwidthSet() always clears all existing qdiscs and their
> subordinate filters before adding all the new qdiscs/filters. This is
> normally exactly what we want, but there is one case (the network
> driver) where the Qdisc ad
On 11/22/24 22:16, Laine Stump wrote:
> Patch 4/4 explains the problem and how these patches fix it. Assuming
> no problems are found (none so far) this should go into 10.10.0, as it
> solves a regression caused by switching the network driver to the
> nftables backend.
>
> There was a prior attem
On 11/21/24 03:27, Han Han wrote:
> The previous example will cause the error like:
> error: Options --file and --base64 are mutually exclusive
>
> Reported-by: Yanqiu Zhang
> Signed-off-by: Han Han
> ---
> docs/formatsecret.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Review
Weekly container builds fail for almost 2 months now (last passed
container build was on 2nd of September) due to debian-11 being probably
broken when installing cross-arch packages. Debian 12 was released at
the 10th of June 2023, so we support debian-11 for 7 more months. But
the cross-builds
35 matches
Mail list logo
