On Thu, Nov 21, 2024 at 07:03:13PM +0100, Jiri Denemark wrote:
> On Thu, Nov 21, 2024 at 16:14:58 +0100, Jiri Denemark wrote:
> > On Wed, Nov 20, 2024 at 14:41:29 +, Daniel P. Berrangé wrote:
> > > $ virsh domcapabilities --xpath '//model' | grep Skylake-Client
> > > > > canonical="Skylake-C
On Thu, Nov 21, 2024 at 16:14:58 +0100, Jiri Denemark wrote:
> On Wed, Nov 20, 2024 at 14:41:29 +, Daniel P. Berrangé wrote:
> > $ virsh domcapabilities --xpath '//model' | grep Skylake-Client
> > > canonical="Skylake-Client-v1">Skylake-Client
> > > canonical="Skylake-Client-v2">Skylake-Cl
On Wed, Nov 20, 2024 at 03:30:54PM +0100, Ján Tomko wrote:
> + ``external``
> + For this backend, libvirt expects the TPM emulator to be started
> externally.
> + The path to the unix socket where the emulator is listening is passed
> + via the ``source`` element. Other ``backend`
On Thu, Nov 21, 2024 at 18:03:30 +0100, Peter Krempa wrote:
> On Wed, Nov 20, 2024 at 18:48:46 +0300, Nikolai Barybin via Devel wrote:
> > Signed-off-by: Nikolai Barybin
> > ---
> > src/qemu/qemu_cgroup.c| 13 -
> > src/qemu/qemu_namespace.c | 7 +++
> > 2 files changed, 19 i
On Wed, Nov 20, 2024 at 18:48:46 +0300, Nikolai Barybin via Devel wrote:
> Signed-off-by: Nikolai Barybin
> ---
> src/qemu/qemu_cgroup.c| 13 -
> src/qemu/qemu_namespace.c | 7 +++
> 2 files changed, 19 insertions(+), 1 deletion(-)
> diff --git a/src/qemu/qemu_namespace.c b/s
qemuDomainDiskByName() can return a NULL pointer on failure, but this
returned value in qemuSnapshotDeleteValidate is not checked.
It will make libvirtd crash.
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index 5b3aadcbf0..52312b4a7b 100644
--- a/src/qemu/qemu_snapshot.c
+++ b/
On Wed, Nov 20, 2024 at 18:48:44 +0300, Nikolai Barybin via Devel wrote:
> Signed-off-by: Nikolai Barybin
> ---
> src/security/security_selinux.c | 27 +--
> 1 file changed, 25 insertions(+), 2 deletions(-)
Reviewed-by: Peter Krempa
On Wed, Nov 20, 2024 at 18:48:43 +0300, Nikolai Barybin via Devel wrote:
> Signed-off-by: Nikolai Barybin
> ---
> src/security/security_dac.c | 27 +--
> 1 file changed, 25 insertions(+), 2 deletions(-)
Reviewed-by: Peter Krempa
On Wed, Nov 20, 2024 at 18:48:45 +0300, Nikolai Barybin via Devel wrote:
> Signed-off-by: Nikolai Barybin
> ---
> src/security/virt-aa-helper.c | 4
> 1 file changed, 4 insertions(+)
Reviewed-by: Peter Krempa
On 11/20/24 01:21, Norman wrote:
> Hello,
>
> Sorry for the inconvience. My SoB is: Signed-off-by: shenjiatong
>
>
> Please have a look. Thank you.
Reviewed-by: Michal Privoznik
and merged. Congratulations on your first libvirt contribution!
Michal
On Wed, Nov 20, 2024 at 14:41:29 +, Daniel P. Berrangé wrote:
> On Wed, Nov 20, 2024 at 12:39:17PM +, Daniel P. Berrangé wrote:
> > On Tue, Nov 19, 2024 at 07:49:36PM +0100, Jiri Denemark wrote:
> > > When parsing a domain XML which uses a non-versioned CPU model we want
> > > to replace it
On Thu, Nov 21, 2024 at 14:02:22 +, Daniel P. Berrangé wrote:
> On Thu, Nov 21, 2024 at 02:35:34PM +0100, Jiri Denemark wrote:
> > On Wed, Nov 20, 2024 at 12:11:19 +, Daniel P. Berrangé wrote:
> > > On Tue, Nov 19, 2024 at 07:49:45PM +0100, Jiri Denemark wrote:
> > > > We already visually g
On Wed, Nov 20, 2024 at 18:48:42 +0300, Nikolai Barybin via Devel wrote:
> Signed-off-by: Nikolai Barybin
> ---
> src/storage_file/storage_source.c | 39 +++
> src/storage_file/storage_source.h | 4
> 2 files changed, 43 insertions(+)
>
> diff --git a/src/storag
On Wed, Nov 20, 2024 at 12:16:26 +, Daniel P. Berrangé wrote:
> On Tue, Nov 19, 2024 at 07:49:47PM +0100, Jiri Denemark wrote:
> > The signatures in the CPU map are used for matching physical CPUs and
> > thus we need to cover all possible real world variants we know about.
> > When adding a ne
On Thu, Nov 21, 2024 at 02:35:34PM +0100, Jiri Denemark wrote:
> On Wed, Nov 20, 2024 at 12:11:19 +, Daniel P. Berrangé wrote:
> > On Tue, Nov 19, 2024 at 07:49:45PM +0100, Jiri Denemark wrote:
> > > We already visually group the included models according to vendor using
> > > comments. This pa
On Wed, Nov 20, 2024 at 18:48:40 +0300, Nikolai Barybin via Devel wrote:
> Signed-off-by: Nikolai Barybin
> ---
> src/storage_file/storage_file_probe.c | 34 ++-
> 1 file changed, 18 insertions(+), 16 deletions(-)
Reviewed-by: Peter Krempa
On Wed, Nov 20, 2024 at 18:48:41 +0300, Nikolai Barybin via Devel wrote:
> In qcow2 header data file is represented by incompitible feature bit
> and its path is saved to header extension table.
> Thus, we implement here the logic similar to backing file probing.
>
> Signed-off-by: Nikolai Barybin
On Wed, Nov 20, 2024 at 18:48:38 +0300, Nikolai Barybin via Devel wrote:
> Signed-off-by: Nikolai Barybin
> ---
> src/conf/schemas/domaincommon.rng | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/src/conf/schemas/domaincommon.rng
> b/src/conf/schemas/domaincommon.rng
>
On Wed, Nov 20, 2024 at 12:11:19 +, Daniel P. Berrangé wrote:
> On Tue, Nov 19, 2024 at 07:49:45PM +0100, Jiri Denemark wrote:
> > We already visually group the included models according to vendor using
> > comments. This patch introduces a new element for doing it
> > properly in a machine fr
On Wed, Nov 20, 2024 at 18:48:35 +0300, Nikolai Barybin via Devel wrote:
Hello everyone!
With help of Peter's comprehensive review I finally present 3rd version
of this series.
Changes since last revision:
- minor code improvements including memory leaks fixes
- splitted and regrouped
On 11/17/24 15:44, shenjiatong wrote:
> Virtio-serial-pci device is hot pluggable, losen the restriction and
> allow user to hot plug it.
> ---
> src/qemu/qemu_hotplug.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
>
On Wed, Nov 20, 2024 at 18:48:37 +0300, Nikolai Barybin via Devel wrote:
> Signed-off-by: Nikolai Barybin
> ---
> src/conf/storage_source_conf.c | 1 +
> src/conf/storage_source_conf.h | 1 +
> 2 files changed, 2 insertions(+)
I'll be considering squashing this one into 6/15 as it's not used
any
On Wed, Nov 20, 2024 at 18:48:35 +0300, Nikolai Barybin via Devel wrote:
> Hello everyone!
>
> With help of Peter's comprehensive review I finally present 3rd version
> of this series.
>
> Changes since last revision:
>
> - minor code improvements including memory leaks fixes
>
> - splitted a
On Wed, Nov 20, 2024 at 18:48:36 +0300, Nikolai Barybin via Devel wrote:
I'll be adding a commit message:
The 'data-file' is a qcow2 feature which allows storing the actual data
outside of the qcow2 image.
> Signed-off-by: Nikolai Barybin
> ---
> src/conf/storage_source_conf.c | 10 ++
24 matches
Mail list logo
