[PATCH] docs: formatsecret: Fix an example of secret-set-value

The previous example will cause the error like: error: Options --file and --base64 are mutually exclusive Reported-by: Yanqiu Zhang Signed-off-by: Han Han --- docs/formatsecret.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatsecret.rst b/docs/formatsecret.rst

Re: [PATCH 10/32] sync_qemu_models_i386: Update index.xml

On Tue, Nov 19, 2024 at 07:49:46PM +0100, Jiri Denemark wrote: > Add all newly generated CPU models to the appropriate section of > index.xml. > > Signed-off-by: Jiri Denemark > --- > src/cpu_map/sync_qemu_models_i386.py | 40 > 1 file changed, 40 insertions(+) > >

[PATCH 10/15] security: apparmor: handle qcow2 data-file

Signed-off-by: Nikolai Barybin --- src/security/virt-aa-helper.c | 4 1 file changed, 4 insertions(+) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 067a17f331..a2914f22b9 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -87

[PATCH 11/15] qemu: put data-file path to VM's cgroup and namespace

Signed-off-by: Nikolai Barybin --- src/qemu/qemu_cgroup.c| 13 - src/qemu/qemu_namespace.c | 7 +++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index be4b9a38ff..f3c85d65e8 100644 --- a/src/qemu/qemu_cgroup.c

[PATCH 02/15] Add VIR_STORAGE_FILE_FEATURE_DATA_FILE to virStorageFileFeature enum

Signed-off-by: Nikolai Barybin --- src/conf/storage_source_conf.c | 1 + src/conf/storage_source_conf.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/conf/storage_source_conf.c b/src/conf/storage_source_conf.c index d4e39b9b57..2b658dd485 100644 --- a/src/conf/storage_source_conf.c ++

[PATCH 13/15] qemu: enable basic qcow2 data-file feature support

- propogate data-file to cmdline - determine data-file within disk chain - enable live disk insertion Signed-off-by: Nikolai Barybin --- src/qemu/qemu_block.c | 14 ++ src/qemu/qemu_command.c | 5 + src/qemu/qemu_domain.c | 14 +- 3 files changed, 32 insertions(+)

[PATCH 15/15] docs: formatdomain: describe dataFileStore element of disk

Signed-off-by: Nikolai Barybin --- docs/formatdomain.rst | 45 --- 1 file changed, 42 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 18b60fe260..54a9e01034 100644 --- a/docs/formatdomain.rst +++ b/docs/format

[PATCH 04/15] conf: implement XML parsing/formating for dataFileStore

Data files are simple raw images. Thus, we don't need to parse too much. The main objectives are: - allow only RAW format - forbid storage slices - include this parsing/formatting into backing chain parse/format as well as into top storage source parse/format because data file can belong to ba

[PATCH 03/15] conf: schemas: add data-file store to domain rng schema

Signed-off-by: Nikolai Barybin --- src/conf/schemas/domaincommon.rng | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincommon.rng index bfd0044805..e70896b7ef 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/co

[PATCH 01/15] conf: add data-file feature and related fields to virStorageSource

Signed-off-by: Nikolai Barybin --- src/conf/storage_source_conf.c | 10 ++ src/conf/storage_source_conf.h | 4 2 files changed, 14 insertions(+) diff --git a/src/conf/storage_source_conf.c b/src/conf/storage_source_conf.c index 5b9a80f100..d4e39b9b57 100644 --- a/src/conf/storage_s

[PATCH 06/15] storage file: add qcow2 data-file path parsing from header

In qcow2 header data file is represented by incompitible feature bit and its path is saved to header extension table. Thus, we implement here the logic similar to backing file probing. Signed-off-by: Nikolai Barybin --- src/storage_file/storage_file_probe.c | 46 --- 1 fi

[PATCH 12/15] qemu: factor out qemuDomainPrepareStorageSource()

This refactoring will simplify next changes. Signed-off-by: Nikolai Barybin --- src/qemu/qemu_domain.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 66ab4baa8b..393c7dcac1 10064

[PATCH 14/15] tests: add qcow2 data-file tests

- qemuxmlconftest: check various xml definitions of dataFileStore: types file, block, network and the case when data-file belongs to qcow2 backing image - virstoragetest: create qcow2 image chains and check that data files are properly probed by metadata parser - qemuxmlactivetest: check that sta

[PATCH 08/15] security: DAC: handle qcow2 data-file on image label set/restore

Signed-off-by: Nikolai Barybin --- src/security/security_dac.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index a179378a78..0505f4e4a3 100644 --- a/src/security/security_dac.c +++ b/src

[PATCH 05/15] storage file: add getDataFile function to FileTypeInfo

Signed-off-by: Nikolai Barybin --- src/storage_file/storage_file_probe.c | 34 ++- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/src/storage_file/storage_file_probe.c b/src/storage_file/storage_file_probe.c index 243927d50a..ad14350edc 100644 --- a/src/s

[PATCH 09/15] security: selinux: handle qcow2 data-file on image label set/restore

Signed-off-by: Nikolai Barybin --- src/security/security_selinux.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 18daa521d1..05e24ff11b 100644 --- a/src/security/security_sel

[PATCH v3 00/15] Implement support for QCOW2 data files

Hello everyone! With help of Peter's comprehensive review I finally present 3rd version of this series. Changes since last revision: - minor code improvements including memory leaks fixes - splitted and regrouped some patches for more logical structure - fixed issue with erroneous disk with

[PATCH 07/15] storage file: fill in src->dataFileStore during file probe

Signed-off-by: Nikolai Barybin --- src/storage_file/storage_source.c | 39 +++ src/storage_file/storage_source.h | 4 2 files changed, 43 insertions(+) diff --git a/src/storage_file/storage_source.c b/src/storage_file/storage_source.c index 2cfe3bc325..b9d2d71a

Re: [PATCH 09/32] cpu_map: Group models in index.xml

On Tue, Nov 19, 2024 at 07:49:45PM +0100, Jiri Denemark wrote: > We already visually group the included models according to vendor using > comments. This patch introduces a new element for doing it > properly in a machine friendly way. AFAICT the has no functional effect > > Signed-off-by: Jir

Re: [PATCH 22/32] cpu_map: Add versions of Skylake-Client CPU model

On Wed, Nov 20, 2024 at 13:54:29 +0100, Jiri Denemark wrote: > On Wed, Nov 20, 2024 at 12:44:54 +, Daniel P. Berrangé wrote: > > On Tue, Nov 19, 2024 at 07:49:58PM +0100, Jiri Denemark wrote: > > > Signed-off-by: Jiri Denemark > > > > > diff --git a/src/cpu_map/x86_Skylake-Client-v1.xml > >

Re: [PATCH 00/32] Add support for versioned CPU models

On Wed, Nov 20, 2024 at 12:39:17PM +, Daniel P. Berrangé wrote: > On Tue, Nov 19, 2024 at 07:49:36PM +0100, Jiri Denemark wrote: > > When parsing a domain XML which uses a non-versioned CPU model we want > > to replace it with the appropriate version variant similarly to what we > > do with mac

Re: [PATCH 00/32] Add support for versioned CPU models

On Wed, Nov 20, 2024 at 02:32:42PM +0100, Jiri Denemark wrote: > On Wed, Nov 20, 2024 at 10:23:55 +, Daniel P. Berrangé wrote: > > FYI, I re-ran the sync script after applying this series: > > > > ./src/cpu_map/sync_qemu_models_i386.py ../qemu src/cpu_map > > > > and it adds a bunch more CPUs

[libvirt PATCH] docs: document external swtpm

When external swtpm support was added back in 9.0.0, I omitted the update of the XML docs. Add it now, especially since the 'emulator' backend can now also use the element. Signed-off-by: Ján Tomko --- docs/formatdomain.rst | 43 --- 1 file changed, 36 i

Re: [PATCH 00/32] Add support for versioned CPU models

On Wed, Nov 20, 2024 at 10:23:55 +, Daniel P. Berrangé wrote: > FYI, I re-ran the sync script after applying this series: > > ./src/cpu_map/sync_qemu_models_i386.py ../qemu src/cpu_map > > and it adds a bunch more CPUs from QEMU git master. > > > > > + filename=

Re: [PATCH 00/32] Add support for versioned CPU models

On Tue, Nov 19, 2024 at 07:49:36PM +0100, Jiri Denemark wrote: > When parsing a domain XML which uses a non-versioned CPU model we want > to replace it with the appropriate version variant similarly to what we > do with machine types. Theoretically QEMU supports per machine type > specification of

Re: [PATCH 22/32] cpu_map: Add versions of Skylake-Client CPU model

On Tue, Nov 19, 2024 at 07:49:58PM +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > diff --git a/src/cpu_map/x86_Skylake-Client-v1.xml > b/src/cpu_map/x86_Skylake-Client-v1.xml > new file mode 100644 > index 00..31e332b371 > --- /dev/null > +++ b/src/cpu_map/x86_Skylake-Clien

Re: [PATCH 22/32] cpu_map: Add versions of Skylake-Client CPU model

On Wed, Nov 20, 2024 at 12:44:54 +, Daniel P. Berrangé wrote: > On Tue, Nov 19, 2024 at 07:49:58PM +0100, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > > diff --git a/src/cpu_map/x86_Skylake-Client-v1.xml > > b/src/cpu_map/x86_Skylake-Client-v1.xml > > new file mode 100644 > > in

Re: [PATCH 02/32] sync_qemu_features_i386: Add some removed features back

On Tue, Nov 19, 2024 at 07:49:38PM +0100, Jiri Denemark wrote: > When removing features unknown to QEMU (they have a different name or > are completely missing as they are not configurable by a user) I should > not have removed them from the list of features unknown to QEMU in the > script for sync

Re: [PATCH 12/32] cpu: Introduce virCPUCheckModel

On Tue, Nov 19, 2024 at 07:49:48PM +0100, Jiri Denemark wrote: > A helper for checking whether a given CPU model is defined in the CPU > map. > > Signed-off-by: Jiri Denemark > --- > src/cpu/cpu.c| 25 + > src/cpu/cpu.h| 8 > src/cpu/cpu_

Re: [PATCH 11/32] sync_qemu_models_i386: Copy signatures from base model

On Tue, Nov 19, 2024 at 07:49:47PM +0100, Jiri Denemark wrote: > The signatures in the CPU map are used for matching physical CPUs and > thus we need to cover all possible real world variants we know about. > When adding a new version of an existing CPU model, we should copy the > signature(s) of t

Re: [PATCH 08/32] sync_qemu_models_i386: Switch to lxml

On Tue, Nov 19, 2024 at 07:49:44PM +0100, Jiri Denemark wrote: > XMLs parse/format round trip using lxml results in an XML document that > almost exactly matches the original (including comments). > > Signed-off-by: Jiri Denemark > --- > src/cpu_map/sync_qemu_models_i386.py | 4 ++-- > 1 file ch

Re: [PATCH v2] qemuDomainDiskChangeSupported: Add missing iothreads check

On 11/18/24 16:45, Peter Krempa wrote: > From: Adam Julis > > GSList of iothreads is not allowed to be changed while the > virtual machine is running. > > Resolves: https://issues.redhat.com/browse/RHEL-23607 > Signed-off-by: Adam Julis > Signed-off-by: Peter Krempa > --- > > Changes to v1: >

Re: [PATCH 00/32] Add support for versioned CPU models

FYI, I re-ran the sync script after applying this series: ./src/cpu_map/sync_qemu_models_i386.py ../qemu src/cpu_map and it adds a bunch more CPUs from QEMU git master. + + + + + + Also it is wierd that it added full paths, rathe

Re: [PATCH 05/32] sync_qemu_models_i386: Do not require full path to QEMU's cpu.c

On Tue, Nov 19, 2024 at 07:49:41PM +0100, Jiri Denemark wrote: > While the script for synchronizing CPU features expects a path to QEMU > source tree, this CPU model script insisted on getting a full patch to > cpu.c file, even though it could easily deduce it from the path to QEMU > source tree. >

Re: [PATCH 04/32] sync_qemu_models_i386: Do not overwrite existing models

On Tue, Nov 19, 2024 at 07:49:40PM +0100, Jiri Denemark wrote: > We don't change definitions of CPU models which were already included in > a libvirt release to maintain migration compatibility. Thus the script > can just skip existing models and save us from having to drop the > changes it would d

Re: [PATCH 03/32] sync_qemu_models_i386: Use f-strings

On Tue, Nov 19, 2024 at 07:49:39PM +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/cpu_map/sync_qemu_models_i386.py | 21 ++--- > 1 file changed, 10 insertions(+), 11 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berran