bubbling this up for reviews
On 10/22/2024 10:39 AM, Praveen K Paladugu wrote:
ping.. for review.
Praveen
On 10/11/2024 1:13 PM, Praveen K Paladugu wrote:
This patch series introduces PCI passthrough support for ch guests. While
enabling this feature I refactored a bunch of methods from qemu
When qemuDomainDeleteDevice() gets "DeviceNotFound" error it is a
special case as we're trying to remove a device which does not exists
any more. Such occasion is indicated by the return value -2.
Callers of the aforementioned function ought to base their behaviour on
the return value. However n
On a Monday in 2024, Michal Privoznik wrote:
I've noticed these why reviewing some other CH patches on the list.
Michal Prívozník (2):
ch_monitor: Avoid possible double free in virCHMonitorClose()
ch_monitor: Report OS error when removing socket fails
src/ch/ch_monitor.c | 9 +
1 file
When removing a socket in virCHMonitorClose() fails, a warning is
printed. But it doesn't contain errno nor g_strerror() which may
shed more light into why removing of the socket failed.
Oh, and since virCHMonitorClose() is registered as autoptr
cleanup for virCHMonitor() it may happen that virCHM
The virCHMonitorClose() is meant to be called when monitor to
cloud-hypervisor process closes. It removes the socket and frees
string containing path to the socket.
In general, there is a problem with the following pattern:
if (var) {
do_something();
g_free(var);
}
because if the
I've noticed these why reviewing some other CH patches on the list.
Michal Prívozník (2):
ch_monitor: Avoid possible double free in virCHMonitorClose()
ch_monitor: Report OS error when removing socket fails
src/ch/ch_monitor.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
-
On 10/23/24 10:02, Purna Pavan Chandra Aekkaladevi wrote:
> Implement `chReadProcessEvents` and `chProcessEvents` to read events from
> event monitor FIFO file and parse them accordingly.
>
> Signed-off-by: Purna Pavan Chandra Aekkaladevi
>
> Co-authored-by: Vineeth Pillai
> ---
> src/ch/ch_ev
On 10/23/24 10:02, Purna Pavan Chandra Aekkaladevi wrote:
> The `--event-monitor` option in cloud-hypervisor outputs events to a
> specified file. This file can then be used to monitor VM lifecycle,
> other vmm events and trigger appropriate actions.
>
> Signed-off-by: Purna Pavan Chandra Aekkalad
On 10/23/24 10:02, Purna Pavan Chandra Aekkaladevi wrote:
> changes from v2->v3:
> * Remove patch 'utils: Implement virFileIsNamedPipe' as it is no more needed.
> * Remove the eventmonitorpath only if it exists
> * Added domain name as a prefix to logs from ch_events.c. This will make
> debugging
On 10/23/24 10:02, Purna Pavan Chandra Aekkaladevi wrote:
> Use a FIFO(named pipe) for --event-monitor option in CH. Introduce a new
> thread, `virCHEventHandlerLoop`, to continuously monitor and handle
> events from cloud-hypervisor.
>
> Signed-off-by: Purna Pavan Chandra Aekkaladevi
>
> Co-aut
On 11/11/2024 12.59, Philippe Mathieu-Daudé wrote:
On 11/11/24 07:56, Thomas Huth wrote:
On 08/11/2024 16.43, Philippe Mathieu-Daudé wrote:
Introduce an abstract machine parent class which defines
the 'little_endian' property. Duplicate the current machine,
which endian is tied to the binary en
On 11/11/24 12:23, Peter Krempa wrote:
On Mon, Nov 11, 2024 at 05:57:13 -0500, Andrea Bolognani wrote:
On Mon, Nov 11, 2024 at 10:14:46AM +0100, Peter Krempa wrote:
On Fri, Nov 08, 2024 at 13:16:33 +0100, Boris Fiuczynski wrote:
Boris Fiuczynski (4):
qemu: capabilities: Add QEMU_CAPS_VIRTIO
On 11/11/24 07:56, Thomas Huth wrote:
On 08/11/2024 16.43, Philippe Mathieu-Daudé wrote:
Introduce an abstract machine parent class which defines
the 'little_endian' property. Duplicate the current machine,
which endian is tied to the binary endianness, to one big
endian and a little endian mach
On 8/11/24 16:05, Paolo Bonzini wrote:
On 11/8/24 16:43, Philippe Mathieu-Daudé wrote:
The Xilinx 'ethlite' device was added in commit b43848a100
("xilinx: Add ethlite emulation"), being only built back
then for a big-endian MicroBlaze target (see commit 72b675caac
"microblaze: Hook into the bui
On 11/11/24 07:57, Thomas Huth wrote:
On 08/11/2024 16.43, Philippe Mathieu-Daudé wrote:
Copy/paste the current tests, but call the opposite endianness
machines, testing:
- petalogix-s3adsp1800-le machine (little-endian CPU) on the
qemu-system-microblaze binary (big-endian)
- petalogix-s3adsp
On a Tuesday in 2024, Peter Krempa wrote:
This patch fixes a few quirks regarding block device use for NVRAM
backing and introduces support for populating the block device from
template.
Peter Krempa (13):
qemuPrepareNVRAM: Don't attempt to create NVRAM on block device
qemuFirmwareEnsureNVRAM:
On Mon, Nov 11, 2024 at 10:11:36AM +0100, Peter Krempa wrote:
On Mon, Nov 11, 2024 at 09:53:06 +0100, Martin Kletzander wrote:
Just don't.
Martin Kletzander (3):
qemu: Expose qemuChrIsPlatformDevice outside from qemu_command
qemu_hotplug: Report better error message for platform serial devi
On Mon, Nov 11, 2024 at 05:57:13 -0500, Andrea Bolognani wrote:
> On Mon, Nov 11, 2024 at 10:14:46AM +0100, Peter Krempa wrote:
> > On Fri, Nov 08, 2024 at 13:16:33 +0100, Boris Fiuczynski wrote:
> > > Boris Fiuczynski (4):
> > > qemu: capabilities: Add QEMU_CAPS_VIRTIO_CCW_DEVICE_LOADPARM
> > >
On Mon, Nov 11, 2024 at 10:14:46AM +0100, Peter Krempa wrote:
> On Fri, Nov 08, 2024 at 13:16:33 +0100, Boris Fiuczynski wrote:
> > Boris Fiuczynski (4):
> > qemu: capabilities: Add QEMU_CAPS_VIRTIO_CCW_DEVICE_LOADPARM
> > tests: add capabilities for QEMU 9.2.0 on s390x
> > qemu: command: add
On 11/11/24 10:13, Peter Krempa wrote:
On Fri, Nov 08, 2024 at 13:16:35 +0100, Boris Fiuczynski wrote:
Let us introduce the xml and reply files for QEMU 9.2.0 on s390x.
A QEMU at commit https://github.com/qemu/qemu/commit/11b8920ed2 was used
to generate this data.
I'll change this to:
A QEMU
On 11/11/24 10:14, Peter Krempa wrote:
On Fri, Nov 08, 2024 at 13:16:33 +0100, Boris Fiuczynski wrote:
This series adds on s390x full boot order support which has been
introduced recently in QEMU with the PR
https://lore.kernel.org/qemu-devel/20241023131710.906748-1-th...@redhat.com/
Changes in
On Mon, Nov 11, 2024 at 09:27:00AM +0100, Martin Kletzander wrote:
> On Thu, Nov 07, 2024 at 06:34:49PM +0100, Andrea Bolognani wrote:
> > When virtio-(non-)transitional models were introduced, the
> > documentation was updated to include them; at the same time,
> > language was introduced indicati
Hi,
Bumping this up for more reviews.
Thanks and Regards,
Purna Pavan Chandra
On Tue, Nov 05, 2024 at 03:29:56PM -0600, Praveen K Paladugu wrote:
> LGTM!!
>
> On 10/23/2024 3:02 AM, Purna Pavan Chandra Aekkaladevi wrote:
> >changes from v2->v3:
> >* Remove patch 'utils: Implement virFileIsNamed
This should be better than the current for both hotplug:
error: internal error: Invalid target model for serial device
and hot-unplug:
error: An error occurred, but the cause is unknown
which should not be reached at all.
Resolves: https://issues.redhat.com/browse/RHEL-66222
Resolves:
On Fri, Nov 08, 2024 at 13:16:33 +0100, Boris Fiuczynski wrote:
> This series adds on s390x full boot order support which has been
> introduced recently in QEMU with the PR
> https://lore.kernel.org/qemu-devel/20241023131710.906748-1-th...@redhat.com/
>
> Changes in v2:
> - fixed up patch 2 with
On Fri, Nov 08, 2024 at 13:16:35 +0100, Boris Fiuczynski wrote:
> Let us introduce the xml and reply files for QEMU 9.2.0 on s390x.
>
> A QEMU at commit https://github.com/qemu/qemu/commit/11b8920ed2 was used
> to generate this data.
I'll change this to:
A QEMU at commit v9.1.0-1348-g11b8920ed2
On Mon, Nov 11, 2024 at 09:53:06 +0100, Martin Kletzander wrote:
> Just don't.
>
> Martin Kletzander (3):
> qemu: Expose qemuChrIsPlatformDevice outside from qemu_command
> qemu_hotplug: Report better error message for platform serial devices
Reviewed-by: Peter Krempa
> qemu_hotplug: Do n
On Mon, Nov 11, 2024 at 09:53:09 +0100, Martin Kletzander wrote:
> The code just does not match the comment above which says we should
> claim success. And it makes sense since a removal from qemu was
> requested and qemu could not find the device. Without this patch such
> codepath would lead to
On Mon, Nov 11, 2024 at 09:53:08 +0100, Martin Kletzander wrote:
> This should be better than the current for both hotplug:
>
> error: internal error: Invalid target model for serial device
>
> and hot-unplug:
>
> error: An error occurred, but the cause is unknown
>
> which should not b
The code just does not match the comment above which says we should
claim success. And it makes sense since a removal from qemu was
requested and qemu could not find the device. Without this patch such
codepath would lead to libvirt not removing the device from the XML and
no error being set, but
Just don't.
Martin Kletzander (3):
qemu: Expose qemuChrIsPlatformDevice outside from qemu_command
qemu_hotplug: Report better error message for platform serial devices
qemu_hotplug: Do not report error for hot-unplugging non-existing
device
src/qemu/qemu_command.c | 2 +-
src/qemu/qem
Then it can be used from qemu_hotplug.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_command.h | 5 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index a5ff7695c375..0dbaa155fc28 100644
-
On Fri, Nov 08, 2024 at 15:58:35 -0300, Georgia Garcia wrote:
> Some rules are generated dynamically during boot and added to the
> AppArmor policy. An example of that is macvtap devices that call the
> AppArmorSetFDLabel hook to add a rule for the tap device path.
>
> Since this information is dy
On 11/5/24 08:57, Peter Krempa wrote:
> This patch fixes a few quirks regarding block device use for NVRAM
> backing and introduces support for populating the block device from
> template.
>
> Peter Krempa (13):
> qemuPrepareNVRAM: Don't attempt to create NVRAM on block device
> qemuFirmwareEn
On Thu, Nov 07, 2024 at 06:34:49PM +0100, Andrea Bolognani wrote:
When virtio-(non-)transitional models were introduced, the
documentation was updated to include them; at the same time,
language was introduced indicating that using the existing
virtio model is no longer recommended.
This is unne
35 matches
Mail list logo
