'qemuFirmwareEnsureNVRAM' which fills the NVRAM configuration bits which
may be missing was basing it's decision to do something based on whether
the 'path' field was set. This is insufficient if remote storage is to
be considered.
Use 'virStorageSourceIsEmpty()' instead as that properly considers
'virFileRewrite()' which is used to setup the NVRAM image if it doesn't
exist or when it is requested by the user forcibly replaces the
destination file by the file it creates. For block devices this
overwrites the device node file or the symlink pointing to the device
node by a regular file instea
This patch fixes a few quirks regarding block device use for NVRAM
backing and introduces support for populating the block device from
template.
Peter Krempa (13):
qemuPrepareNVRAM: Don't attempt to create NVRAM on block device
qemuFirmwareEnsureNVRAM: Don't try to setup non-local nvram
qemu
On Mon, Nov 04, 2024 at 12:39:24 +, Edward Arulanadam wrote:
> Hello Team,
>
> Originator of this libvirt change, Daniel Wu, will not be able to continue
> contributing to this requested change in libvirt. Another member in our team,
> Harikumar (harirajkumar), will continue working on this
On 11/4/24 15:14, Jiri Denemark wrote:
> The recent attempt to fix the attributes used wrong mode for some
> directories used by the QEMU driver. Only dbus and swtpm directories use
> 770, all other directories are created with 755.
>
> Fixes: 961fb8944d0c2d7d5cc0783888a20317e725a248
> Signed-off-
The recent attempt to fix the attributes used wrong mode for some
directories used by the QEMU driver. Only dbus and swtpm directories use
770, all other directories are created with 755.
Fixes: 961fb8944d0c2d7d5cc0783888a20317e725a248
Signed-off-by: Jiri Denemark
---
libvirt.spec.in | 6 +++---
Hello Team,
Originator of this libvirt change, Daniel Wu, will not be able to continue
contributing to this requested change in libvirt. Another member in our team,
Harikumar (harirajkumar), will continue working on this change request and
implement any review comment that may come in. We are a
On Mon, Nov 04, 2024 at 08:42:37AM +0100, Ján Tomko wrote:
> Add an error message for the rare case if json_tokener_new
> fails (allocation failure) and guard any use of json_tokener_free
> where tok might be NULL (this was possible in libvirt-nss
> when the json file could not be opened).
>
> htt
On Mon, Nov 04, 2024 at 08:42:37 +0100, Ján Tomko wrote:
> Add an error message for the rare case if json_tokener_new
> fails (allocation failure) and guard any use of json_tokener_free
> where tok might be NULL (this was possible in libvirt-nss
> when the json file could not be opened).
>
> https
