Re: [PATCH v2] network: add rule to nftables backend that zeroes checksum of DHCP responses

2024-10-25 Thread Daniel P . Berrangé
On Fri, Oct 25, 2024 at 12:18:14AM -0400, Laine Stump wrote: > Many long years ago (April 2010), soon after "vhost" in-kernel packet > processing was added to the virtio-net driver, people running RHEL5 > virtual machines with a virtio-net interface connected via a libvirt > virtual network noticed

[PATCH] virJSONValueFromString: Prefix error message from 'json-c'

2024-10-25 Thread Peter Krempa
The error message from 'json-c' was passed along without any libvirt string which makes it hard to find in the source and isn't exactly clear when present in logs: libvirtd[843]: internal error : invalid utf-8 string Prefix the message with 'failed to parse JSON'. Signed-off-by: Peter Krempa -

Re: [PATCH] virJSONValueFromString: Prefix error message from 'json-c'

2024-10-25 Thread Daniel P . Berrangé
On Fri, Oct 25, 2024 at 04:17:22PM +0200, Peter Krempa wrote: > The error message from 'json-c' was passed along without any libvirt > string which makes it hard to find in the source and isn't exactly clear > when present in logs: > > libvirtd[843]: internal error : invalid utf-8 string > > Pre

Re: [PATCH 0/2] finalize 'reconnect' deprecation

2024-10-25 Thread Marc-André Lureau
On Fri, Oct 25, 2024 at 11:36 AM Daniil Tatianin wrote: > > We've deprecated the 'reconnect' property in c8e2b6b4d7e, but all the > tests, as well as the stream netdev were still left using it. This > series finalizes the deprecation and replaces all local usage and docs > metions of 'reconnect' w

Re: [PATCH v1] tests: add capabilities for QEMU 9.1.0 on s390x

2024-10-25 Thread Boris Fiuczynski
On 10/24/24 19:00, Jiri Denemark wrote: On Wed, Oct 23, 2024 at 11:48:14 +0200, Boris Fiuczynski wrote: On 10/18/24 13:37, Shalini Chellathurai Saroja wrote: Let us introduce the xml and reply files for QEMU 9.1.0 on s390x. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by:Boris Fiuczynsk

[PATCH 2/2] virstring: Use 'g_new0' instead of improper use of 'g_malloc0_n'

2024-10-25 Thread Peter Krempa
Signed-off-by: Peter Krempa --- src/util/virstring.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/util/virstring.c b/src/util/virstring.c index bc9b6cd40e..15c3f7bdd1 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -1078,12 +1078,10 @@ void virString

[PATCH 1/2] Replace improper use of g_malloc(0) with g_new0

2024-10-25 Thread Peter Krempa
Completely remove use of g_malloc (without zeroing of the allocated memory) and forbid further use. Replace use of g_malloc0 in cases where the variable holding the pointer has proper type. In all of the above cases we can use g_new0 instead. Signed-off-by: Peter Krempa --- build-aux/syntax-ch

[PATCH 0/2] Cleanups of improper use of memory allocation APIs

2024-10-25 Thread Peter Krempa
Peter Krempa (2): Replace improper use of g_malloc(0) with g_new0 virstring: Use 'g_new0' instead of improper use of 'g_malloc0_n' build-aux/syntax-check.mk| 4 ++-- src/util/virpcivpd.c | 6 +++--- src/util/virstring.c | 4 +--- tools/wireshark/src

[PATCH 0/3] conf,qemu: add AIA support for RISC-V 'virt'

2024-10-25 Thread Daniel Henrique Barboza
Hi, This series adds official support for RISC-V AIA (Advanced Interrupt Architecture). AIA and has been supported by the 'virt' RISC-V board, as a machine property, since QEMU 7.0. Daniel Henrique Barboza (3): qemu: add capability for RISC-V AIA feature conf,qemu: implement RISC-V 'aia' vir

Re: [PATCH v2 1/4] util: Introduce virStringListRemoveDuplicates

2024-10-25 Thread Ján Tomko
On a Wednesday in 2024, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- Notes: Version 2: - new patch src/libvirt_private.syms | 1 + src/util/virstring.c | 29 + src/util/virstring.h | 2 ++ 3 files changed, 32 insertions(+) Reviewed-by: Ján T

Re: [PATCH 0/2] network: avoid logging unnecessary and misleading errors when failing to unset a zone

2024-10-25 Thread Ján Tomko
On a Monday in 2024, Laine Stump wrote: While testing a recent patch that unsets the zone of bridge interfaces when a virtual network is stopped, a side effect was noticed: when firewalld reloaded its rules, this would result in an error log from libvirt complaining about attempting to unset the

Re: [PATCH (RFC and a half?)] network: add rule to nftables backend that zeroes checksum of DHCP responses

2024-10-25 Thread Laine Stump
On 10/24/24 12:36 PM, Daniel P. Berrangé wrote: On Mon, Oct 21, 2024 at 12:14:38AM -0400, Laine Stump wrote: Many long years ago (April 2010), soon after "vhost" in-kernel packet processing was added to the virtio-net driver, people running RHEL5 virtual machines with a virtio-net interface conn

Re: [PATCH v2 1/4] util: Introduce virStringListRemoveDuplicates

2024-10-25 Thread Peter Krempa
On Wed, Oct 23, 2024 at 16:54:50 +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 2: > - new patch > > src/libvirt_private.syms | 1 + > src/util/virstring.c | 29 + > src/util/virstring.h | 2 ++ > 3 files chang