[PATCH] crypto: add support for sm4 without key length suffix and remove the restriction about ciper name in xml

2024-07-30 Thread luzhipeng
qemu add sm4 in release 9, but the name of sm4 doesn't have the key length suffix, So set size to 0, construct cipher name without key length as suffix. In order to support the snapshot of encrypted disks, it remove the restrictions about cipher names in XML Signed-off-by: luzhipeng --- docs/for

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Jason Wang
On Tue, Jul 30, 2024 at 6:23 PM Akihiko Odaki wrote: > > On 2024/07/30 12:45, Jason Wang wrote: > > On Tue, Jul 30, 2024 at 11:29 AM Akihiko Odaki > > wrote: > >> > >> On 2024/07/30 12:17, Jason Wang wrote: > >>> On Tue, Jul 30, 2024 at 11:12 AM Akihiko Odaki > >>> wrote: > > On 2024

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Jason Wang
On Wed, Jul 31, 2024 at 5:33 AM Michael S. Tsirkin wrote: > > On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > > On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > > > This is not what we did historically. Why should we start now? > > > > It's a matter of whether we s

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Tue, Jul 30, 2024 at 05:32:48PM -0400, Michael S. Tsirkin wrote: > On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > > On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > > > This is not what we did historically. Why should we start now? > > > > It's a matter of whet

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Michael S. Tsirkin
On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > > This is not what we did historically. Why should we start now? > > It's a matter of whether we still want migration to randomly fail, like > what this patch does. >

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > This is not what we did historically. Why should we start now? It's a matter of whether we still want migration to randomly fail, like what this patch does. Or any better suggestions? I'm definitely open to that. Thanks, --

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Michael S. Tsirkin
On Tue, Jul 30, 2024 at 03:11:03PM -0400, Peter Xu wrote: > On Tue, Jul 30, 2024 at 07:46:12PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jul 30, 2024 at 02:13:51PM -0400, Peter Xu wrote: > > > On Mon, Jul 29, 2024 at 06:26:41PM +0100, Daniel P. Berrangé wrote: > > > > On Mon, Jul 29, 2024 at 01:

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Tue, Jul 30, 2024 at 07:46:12PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 30, 2024 at 02:13:51PM -0400, Peter Xu wrote: > > On Mon, Jul 29, 2024 at 06:26:41PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Jul 29, 2024 at 01:00:30PM -0400, Peter Xu wrote: > > > > On Mon, Jul 29, 2024 at 04:

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Daniel P . Berrangé
On Tue, Jul 30, 2024 at 02:13:51PM -0400, Peter Xu wrote: > On Mon, Jul 29, 2024 at 06:26:41PM +0100, Daniel P. Berrangé wrote: > > On Mon, Jul 29, 2024 at 01:00:30PM -0400, Peter Xu wrote: > > > On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: > > > > > > > > We've got two mutu

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Mon, Jul 29, 2024 at 06:26:41PM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 29, 2024 at 01:00:30PM -0400, Peter Xu wrote: > > On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: > > > > > > We've got two mutually conflicting goals with the machine type > > > definitions. > >

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Tue, Jul 30, 2024 at 02:23:46AM +0900, Akihiko Odaki wrote: > On 2024/07/30 2:00, Peter Xu wrote: > > On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: > > > On Fri, Jul 26, 2024 at 04:47:40PM -0400, Peter Xu wrote: > > > > On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Be

[PATCH v2 for v10.6.0 0/2] Two pstore related fixes

2024-07-30 Thread Michal Privoznik
This is a v2 of the following patch: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/PP4WO2ZYB7UXMV6WQ2N4B33KCUUDIQFK/ NB, 1/2 from the original series is pushed already. diff to v1: - adjusted args to ftruncate() - empty line cleanup - new patch 2/2 (thanks Andrea for tes

[PATCH v2 2/2] security: Allow RW access to pstore device

2024-07-30 Thread Michal Privoznik
The whole point of pstore device is that the guest writes crash dumps into it. But the way SELinux label is set on the corresponding file warrants RO access only. This is due to a copy-paste from code around: kernel/initrd/DTB/SLIC - these are RO indeed, but pstore MUST be writable too. In a sense

[PATCH v2 1/2] qemu: Pre-create pstore device file

2024-07-30 Thread Michal Privoznik
So far we are relying on QEMU or sysadmin to create the file for pstore. This is suboptimal as in the case of the former we can not set proper seclabels (there's nothing to set seclabels on until QEMU is started). Therefore, make sure the file is created before launching QEMU and that it has the c

Re: [PATCH 1/2] qemu: Autofill pstore path if missing

2024-07-30 Thread Michal Prívozník
On 7/30/24 15:55, Andrea Bolognani wrote: > On Mon, Jul 29, 2024 at 11:31:35AM GMT, Michal Privoznik wrote: >> Introduced only a couple of commits ago (in >> v10.5.0-84-g90e50e67c6) the pstore device acts as a nonvolatile >> storage, where guest kernel can store information about crashes. >> This d

Re: [PATCH 2/2] qemu: Pre-create pstore device file

2024-07-30 Thread Michal Prívozník
On 7/30/24 16:04, Andrea Bolognani wrote: > On Mon, Jul 29, 2024 at 11:31:36AM GMT, Michal Privoznik wrote: >> +static int >> +qemuProcessPreparePstore(virDomainObj *vm) >> +{ >> +virDomainPstoreDef *pstore = vm->def->pstore; >> +VIR_AUTOCLOSE fd = -1; >> + >> +if (!pstore) >> +

Re: [PATCH 2/2] qemu: Pre-create pstore device file

2024-07-30 Thread Andrea Bolognani
On Mon, Jul 29, 2024 at 11:31:36AM GMT, Michal Privoznik wrote: > +static int > +qemuProcessPreparePstore(virDomainObj *vm) > +{ > +virDomainPstoreDef *pstore = vm->def->pstore; > +VIR_AUTOCLOSE fd = -1; > + > +if (!pstore) > +return 0; > + > +switch (pstore->backend) { > +

Re: [PATCH 1/2] qemu: Autofill pstore path if missing

2024-07-30 Thread Andrea Bolognani
On Mon, Jul 29, 2024 at 11:31:35AM GMT, Michal Privoznik wrote: > Introduced only a couple of commits ago (in > v10.5.0-84-g90e50e67c6) the pstore device acts as a nonvolatile > storage, where guest kernel can store information about crashes. > This device, however, expects a file in the host from

Re: [PATCH] NEWS: Document features/improvements/bug fixes I've participated in

2024-07-30 Thread Boris Fiuczynski
On 7/30/24 6:46 AM, Michal Privoznik wrote: There are some features/improvements/bug fixes I've either contributed or reviewed/merged. Document them for upcoming release. Signed-off-by: Michal Privoznik --- NEWS.rst | 34 ++ 1 file changed, 34 insertions(+) d

Re: [PATCH] NEWS: Document features/improvements/bug fixes I've participated in

2024-07-30 Thread Peter Krempa
On Tue, Jul 30, 2024 at 06:46:14 +0200, Michal Privoznik wrote: > There are some features/improvements/bug fixes I've either > contributed or reviewed/merged. Document them for upcoming > release. > > Signed-off-by: Michal Privoznik > --- > NEWS.rst | 34 ++ > 1 f

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Akihiko Odaki
On 2024/07/30 12:45, Jason Wang wrote: On Tue, Jul 30, 2024 at 11:29 AM Akihiko Odaki wrote: On 2024/07/30 12:17, Jason Wang wrote: On Tue, Jul 30, 2024 at 11:12 AM Akihiko Odaki wrote: On 2024/07/30 12:03, Jason Wang wrote: On Tue, Jul 30, 2024 at 10:57 AM Akihiko Odaki wrote: On 2024

Re: [PATCH 8/8] qemu: migration: Don't remember seclabel for images shared from current host

2024-07-30 Thread Peter Krempa
On Mon, Jul 29, 2024 at 08:29:42 -0700, Andrea Bolognani wrote: > On Mon, Jul 29, 2024 at 03:09:55PM GMT, Peter Krempa wrote: > > On Fri, Jul 26, 2024 at 07:47:57 -0700, Andrea Bolognani wrote: > > > For example, if the domain uses UEFI, local -> remote migration works > > > but when attempting to

incorrect-array-indexing fix is not present in latest libvirt.org/go/libvirt(v1.10005.0) - SendKey API

2024-07-30 Thread None via Devel
Hello, Due to incorrect-array-indexing bug(reported here:https://gitlab.com/libvirt/libvirt-go-module/-/issues/3) I can't send the keycodes to the guest VM using sendkey API. @berrange had fixed this issue 2year ago here: https://gitlab.com/berrange/libvirt-go-module/-/commit/72e49243e57a5f78e40