Re: [PATCH v3] qemu: add a monitor to /proc/$pid when killing times out

2024-07-23 Thread Boris Fiuczynski
On 7/22/24 2:01 PM, Jiri Denemark wrote: On Mon, Jul 22, 2024 at 10:55:05 +0200, Michal Prívozník wrote: On 7/19/24 17:44, Boris Fiuczynski wrote: In cases when a QEMU process takes longer than the time sigterm and sigkill are issued to kill the process do not simply fail and leave the VM in st

[PATCH v3] virsh: Provide completer for some pool-X-as commands

2024-07-23 Thread Abhiram Tilak
From: notpua Provides completers for auth-type and source-format commands for virsh pool-create-as and pool-define-as commands. Use Empty completers for options where completions are not required. Related Issue: https://gitlab.com/libvirt/libvirt/-/issues/9 Signed-off-by: Abhiram Tilak --- Chan

Re: [PATCH v2] virsh: Provide completer for some pool-X-as commands

2024-07-23 Thread atp exp
On Tue, 23 Jul 2024 at 12:42, Martin Kletzander wrote: > On Wed, May 29, 2024 at 06:49:06AM -0400, Abhiram Tilak wrote: > >Provides completers for auth-type and source-format commands for > >virsh pool-create-as and pool-define-as commands. Use Empty completers > >for options where completions ar

Re: [PATCH] qemuProcessStop: Don't unlock domain until most of the cleanup is done

2024-07-23 Thread Daniel P . Berrangé
On Tue, Jul 23, 2024 at 03:06:41PM +0200, Peter Krempa wrote: > On Tue, Jul 23, 2024 at 13:51:09 +0100, Daniel P. Berrangé wrote: > > On Tue, Jul 23, 2024 at 02:41:13PM +0200, Peter Krempa wrote: > > > Since I don't currently have a better idea of how to fix this I'm okay > > > with this patch give

Re: [PATCH] qemuProcessStop: Don't unlock domain until most of the cleanup is done

2024-07-23 Thread Peter Krempa
On Tue, Jul 23, 2024 at 13:51:09 +0100, Daniel P. Berrangé wrote: > On Tue, Jul 23, 2024 at 02:41:13PM +0200, Peter Krempa wrote: > > On Fri, Jul 19, 2024 at 14:46:49 +0200, Michal Privoznik wrote: > > > Imagine two threads. Thread A is executing qemuProcessStop() and > > > thread B is executing qe

Re: [PATCH] qemuProcessStop: Don't unlock domain until most of the cleanup is done

2024-07-23 Thread Daniel P . Berrangé
On Tue, Jul 23, 2024 at 02:41:13PM +0200, Peter Krempa wrote: > On Fri, Jul 19, 2024 at 14:46:49 +0200, Michal Privoznik wrote: > > Imagine two threads. Thread A is executing qemuProcessStop() and > > thread B is executing qemuDomainCreateXML(). To make things more > > interesting, the domain XML p

[PATCH] virtiofs: rename member to 'openfiles' for clarity

2024-07-23 Thread Adam Julis
New element 'openfiles' had confusing name. Since the patch with this new element wasn't propagate yet, old name ('rlimit_nofile') was changed. ... ... Signed-off-by: Adam Julis --- docs/formatdomain.rst | 6 +++--- src/conf/domain_conf.c

Re: [PATCH] qemuProcessStop: Don't unlock domain until most of the cleanup is done

2024-07-23 Thread Peter Krempa
On Fri, Jul 19, 2024 at 14:46:49 +0200, Michal Privoznik wrote: > Imagine two threads. Thread A is executing qemuProcessStop() and > thread B is executing qemuDomainCreateXML(). To make things more > interesting, the domain XML passed to qemuDomainCreateXML matches > name + UUID of that the virDoma

[libvirt PATCH] qemu: virtiofs: cache: use 'never' instead of 'none'

2024-07-23 Thread Ján Tomko
The new option style renamed one of the cache modes. Signed-off-by: Ján Tomko --- src/qemu/qemu_virtiofs.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c index 703f1226a2..db987ddfe1 100644 --- a/src/qemu/qemu_v

Re: [PATCH v2] virt-host-validate: Allow longer list of CPU flags

2024-07-23 Thread Jiri Denemark
On Tue, Jul 23, 2024 at 13:54:33 +0200, Michal Privoznik wrote: > On various occasions, virt-host-validate parses /proc/cpuinfo to > learn about CPU flags (see virHostValidateGetCPUFlags()). It does > so, by reading the file line by line until the line with CPU > flags is reached. Then the line is

Re: [PATCH] virt-host-validate: Allow longer list of CPU flags

2024-07-23 Thread Michal Prívozník
On 7/23/24 13:08, Jiri Denemark wrote: > On Tue, Jul 23, 2024 at 12:41:31 +0200, Michal Privoznik wrote: >> On various occasions, virt-host-validate parses /proc/cpuinfo to >> learn about CPU flags (see virHostValidateGetCPUFlags()). It does >> so, by reading the file line by line until the line wi

[PATCH v2] virt-host-validate: Allow longer list of CPU flags

2024-07-23 Thread Michal Privoznik
On various occasions, virt-host-validate parses /proc/cpuinfo to learn about CPU flags (see virHostValidateGetCPUFlags()). It does so, by reading the file line by line until the line with CPU flags is reached. Then the line is split into individual flags (using space as a delimiter) and the list of

Re: [PATCH] virt-host-validate: Allow longer list of CPU flags

2024-07-23 Thread Jiri Denemark
On Tue, Jul 23, 2024 at 12:41:31 +0200, Michal Privoznik wrote: > On various occasions, virt-host-validate parses /proc/cpuinfo to > learn about CPU flags (see virHostValidateGetCPUFlags()). It does > so, by reading the file line by line until the line with CPU > flags is reached. Then the line is

[PATCH] virt-host-validate: Allow longer list of CPU flags

2024-07-23 Thread Michal Privoznik
On various occasions, virt-host-validate parses /proc/cpuinfo to learn about CPU flags (see virHostValidateGetCPUFlags()). It does so, by reading the file line by line until the line with CPU flags is reached. Then the line is split into individual flags (using space as a delimiter) and the list of

Arm CCA instance creation fails

2024-07-23 Thread Itaru Kitayama
Hi, With the below virt-install options, I am trying to import a Realm VM: […] export LIBVIRT_QEMU=/home/realm/qemu-system-aarch64 virt-install --machine=virt --arch=aarch64 --name=test8 --disk path=/var/lib/libvirt/images/jammy.qcow2,format=qcow2,device=disk,bus=virtio,cache=none --memory=204

Re: [External] Re: [PATCH v3 0/2] security_manager: Fix security manager deadlock after libvirtd fork()

2024-07-23 Thread hongmainquan via Devel
在 2024/7/9 7:26 下午, Michal Prívozník 写道: On 7/5/24 10:01, hongmianquan wrote: We have the stack security driver, which internally manages other security drivers, just call them "top" and "nested". We call virSecurityStackPreFork() to lock the top one, and it also locks and then unlocks the

Re: [PATCH] formatstorage: Document qcow2 default version change

2024-07-23 Thread Martin Kletzander
On Tue, Mar 12, 2024 at 12:38:43PM +0100, Peter Krempa wrote: Based on discussion after commit f432114d9c was pushed it was pointed out that the documentation still mentions the older version. Fix the documentation to state the new version and introduce ambiguity for future updates. Fixes: f432

Re: [PATCH v2] virsh: Provide completer for some pool-X-as commands

2024-07-23 Thread Martin Kletzander
On Wed, May 29, 2024 at 06:49:06AM -0400, Abhiram Tilak wrote: Provides completers for auth-type and source-format commands for virsh pool-create-as and pool-define-as commands. Use Empty completers for options where completions are not required. Related Issue: https://gitlab.com/libvirt/libvirt