Re: [PATCH v2] qemu_block: Validate number of hosts for iSCSI disk device

2024-06-24 Thread Rayhan Faizel
ping v2

Re: [PATCH] qemu: add support for qemu switchover-ack

2024-06-24 Thread Jon Kohler
> On Jun 20, 2024, at 4:16 PM, Jon Kohler wrote: > > > >> On Jun 20, 2024, at 4:06 PM, Peter Xu wrote: >> >> !---| >> CAUTION: External Email >> >> |---! >> >> O

[PATCH v2] qemu: add support for qemu switchover-ack

2024-06-24 Thread Jon Kohler
Add plumbing for QEMU's switchover-ack migration capability, which helps lower the downtime during VFIO migrations. This capability is enabled by default as long as both the source and destination support it. Note: switchover-ack depends on the return path capability, so this may not be used when

Re: [PATCH] qemu: add support for qemu switchover-ack

2024-06-24 Thread Jon Kohler
> On Jun 20, 2024, at 4:06 PM, Peter Xu wrote: > > !---| > CAUTION: External Email > > |---! > > On Thu, Jun 20, 2024 at 07:45:42PM +, Jon Kohler wrote: >> >>

[PATCH] qemu: Fix migration with disabled vmx-* CPU features

2024-06-24 Thread Jiri Denemark
When starting a domain on a host which lacks a vmx-* CPU feature which is expected to be enabled by the CPU model specified in the domain XML, libvirt properly marks such feature as disabled in the active domain XML. But migrating the domain to a similar host which lacks the same vmx-* feature will

Re: [PATCH] network: add more firewall test cases

2024-06-24 Thread Daniel P . Berrangé
On Fri, Jun 21, 2024 at 08:17:58AM -0400, Laine Stump wrote: > This patch adds some previously missing test cases that test for > proper firewall rule creation when the following are included in the > network definition: > > * > * no forward element (an "isolated" network) > * nat port range when

Re: [PATCH] tests: fix broken nftables test data so that individual tests are successful

2024-06-24 Thread Daniel P . Berrangé
On Wed, Jun 12, 2024 at 03:25:46PM -0400, Laine Stump wrote: > When the chain names and table name used by the nftables firewall > backend were changed in commit > 958aa7f274904eb8e4678a43eac845044f0dcc38, I forgot to change the test > data file base.nftables, which has the extra "list" and "add >

Re: [PATCH] qemu: add support for qemu switchover-ack

2024-06-24 Thread Jon Kohler
> On Jun 20, 2024, at 4:30 AM, Jiri Denemark wrote: > > !---| > CAUTION: External Email > > |---! > > On Tue, Jun 18, 2024 at 16:14:29 +0100, Daniel P. Berrangé wro

Re: [PATCH] qemuDomainDiskChangeSupported: Fill in missing check

2024-06-24 Thread Michal Prívozník
On 6/21/24 18:16, Adam Julis wrote: > The attribute 'discard_no_unref' is not allowed to be changed while > the virtual machine is running. > > Resolves: https://issues.redhat.com/browse/RHEL-37542 > > Signed-off-by: Adam Julis > --- > src/qemu/qemu_domain.c | 1 + > 1 file changed, 1 insertion

Re: [PATCH] tests: fix broken nftables test data so that individual tests are successful

2024-06-24 Thread Michal Prívozník
On 6/12/24 21:25, Laine Stump wrote: > When the chain names and table name used by the nftables firewall > backend were changed in commit > 958aa7f274904eb8e4678a43eac845044f0dcc38, I forgot to change the test > data file base.nftables, which has the extra "list" and "add > chain/table" commands th

Re: [PATCH 00/10] Sync cpu features with qemu

2024-06-24 Thread Michal Prívozník
On 6/21/24 14:42, Tim Wiederhake wrote: > This brings libvirt in sync qith qemu commit > 02d9c38236cf8c9826e5c5be61780ccb4ae0. > > Tim Wiederhake (10): > cpu_map: Add missing feature "fred" > cpu_map: Add missing feature "lkgs" > cpu_map: Add missing feature "wrmsrns" > cpu_map: Add mi