Re: [RFC PATCH 0/1] support deprecated-props from query-cpu-model-expansion

On 6/13/24 7:22 AM, Jiri Denemark wrote: > On Tue, Jun 04, 2024 at 11:42:25 -0400, Collin Walling wrote: >> The QEMU portion is designed for s390x such that there is a static list >> of hardcoded feature bits that are flagged for deprecation. This list >> can be updated in follow-up patches as mor

[PATCH] Add a check that vmdisk and disk variables are not NULL

Hello, Thank you for your comments and explanations about disk states and snapshots in general. I agree that it is quite dangerous to always delete a snapshot in case one of the variables is NULL. I modified the patch based on Michal's comment that qemuSnapshotDeleteValidate should return

Re: [PATCH] qemu: add support for qemu switchover-ack

On Tue, Jun 18, 2024 at 03:26:03PM +, Jon Kohler wrote: > > > > On Jun 18, 2024, at 11:14 AM, Daniel P. Berrangé > > wrote: > > > > !---| > > CAUTION: External Email > > > > |-

Re: [PATCH 0/4] nodedev: adjust handling DASDs

On 6/19/24 5:10 PM, smitt...@redhat.com wrote: Thank you, Boris. Is the following test scenario sufficient to describe this change, are you aware of any other scenarios that might be at risk of seeing a regression, maybe some scenario for other storage devices like SCSI? Given a DASD disk wit

Re: [PATCH 0/4] nodedev: adjust handling DASDs

Thank you, Boris. Is the following test scenario sufficient to describe this change, are you aware of any other scenarios that might be at risk of seeing a regression, maybe some scenario for other storage devices like SCSI? Given a DASD disk with identifier 0.0.4024 on subchannel 0.0.0030 When

[PATCH 2/4] nodedev: improve DASD detection

In newer DASD driver versions the ID_TYPE tag is supported. This tag is missing after a system reboot but when the ccw device is set offline and online the tag is included. To fix this version independently we need to check if devices detected as type disk is actually a DASD to maintain the node ob

[PATCH 3/4] nodedev: prevent invalid DASD node object creation

Prevent the creation of a new DASD node object when the device does not exist. Resolves: https://issues.redhat.com/browse/RHEL-39497 Reviewed-by: Marc Hartmayer Signed-off-by: Boris Fiuczynski --- src/node_device/node_device_udev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/node

[PATCH 0/4] nodedev: adjust handling DASDs

Adjusting how DASDs are handled as recently ID_* tags are also included in the udev information which causes the problems reported by https://issues.redhat.com/browse/RHEL-39497 Removing the filtering of offline ccw devices as these devices are available in the system and also are used to set them

[PATCH 4/4] nodedev: add ccw device state and remove fencing

Instead of fencing offline ccw devices add the state to the ccw capability. Resolves: https://issues.redhat.com/browse/RHEL-39497 Signed-off-by: Boris Fiuczynski --- src/conf/node_device_conf.c| 24 src/conf/node_device_conf.h| 11 +++ src/conf/sc

[PATCH 1/4] nodedev: refactor storage type fixup

Refactor the storage type fixup into a reusable method. Reviewed-by: Marc Hartmayer Signed-off-by: Boris Fiuczynski --- src/node_device/node_device_udev.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/src/node_device/node_device_udev.c b/src/node_d

Re: [PATCH] conf: Drop unused declaration

On 6/19/24 12:48, Adam Julis wrote: > Remove unused declaration of the virDomainDiskFindByBusAndDst(). > > Signed-off-by: Adam Julis > --- > src/conf/domain_conf.h | 4 > 1 file changed, 4 deletions(-) Nice catch! I've tweaked the commit message a bit to point out how did we get here. Re

Re: [PATCH v2 00/20] node_dev_udev: use workerpool and improve nodedev events

On Tue, Jun 18, 2024 at 08:59 AM -0500, Jonathon Jongsma wrote: > On 6/18/24 6:33 AM, Boris Fiuczynski wrote: >> On 6/13/24 11:14 PM, Jonathon Jongsma wrote: >>> On 6/13/24 6:13 AM, Marc Hartmayer wrote: On Tue, Apr 23, 2024 at 08:08 PM +0200, Marc Hartmayer wrote: > When an udev

[PATCH] conf: Drop unused declaration

Remove unused declaration of the virDomainDiskFindByBusAndDst(). Signed-off-by: Adam Julis --- src/conf/domain_conf.h | 4 1 file changed, 4 deletions(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index a06f015444..cdab6ef2da 100644 --- a/src/conf/domain_conf.h +++ b/src/

Re: [PATCH 04/12] qemuDomainObjWait: Add documentation

On 6/13/24 17:11, Peter Krempa wrote: > Document why this function exists and meaning of return values. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_domain.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > index 9

Re: [PATCH 12/12] qemu: migration: Preserve error across qemuDomainSetMaxMemLock() on error paths

On 6/13/24 17:11, Peter Krempa wrote: > When a VM terminates itself while it's being migrated in running state > libvirt would report wrong error: > > error: cannot get locked memory limit of process 2502057: No such file or > directory > > rather than the proper error: > > error: operation f

Re: [PATCH 00/12] qemu: migration: Fix crashes when VM shutdowns itself during migration in active state

On 6/13/24 17:11, Peter Krempa wrote: > The daemon crashes due to unexpected cleanup happening due to bad > assumptions about locking and state. See patch 5. > > Peter Krempa (12): > qemuBlockJobProcessEventConcludedBackup: Handle potentially NULL > 'job->disk' > qemuDomainDiskPrivateDispo

Re: [PATCH] qemu: Don't specify vfio-pci.ramfb when ramfb is false

On 6/13/24 16:50, Jonathon Jongsma wrote: > Commit 7c8e606b64c73ca56d7134cb16d01257f39c53ef attempted to fix > the specification of the ramfb property for vfio-pci devices, but it > failed when ramfb is explicitly set to 'off'. This is because only the > 'vfio-pci-nohotplug' device supports the 'ra

Re: [PATCH v2] Pass shutoff reason to release hook

On 6/18/24 18:39, Swapnil Ingle wrote: > Sometimes in release hook it is useful to know if the VM shutdown was graceful > or not. This is especially useful to do cleanup based on the VM shutdown > failure > reason in release hook. This patch proposes to use the last argument 'extra' > to pass VM s