Re: Add iommu device when VM configured with > 255 vcpus

2024-05-29 Thread Sergio Durigan Junior
On Tuesday, May 28 2024, Jim Fehlig via Devel wrote: > Hi All, > > I vaguely recall a discussion about $subject, but can't find it > now. Perhaps buried in another thread. The topic has been raised > internally again, and I'd like to gauge the community's interest in > automatically adding the nec

Re: Add iommu device when VM configured with > 255 vcpus

2024-05-29 Thread Jim Fehlig via Devel
On 5/29/24 1:41 AM, Peter Krempa wrote: On Tue, May 28, 2024 at 16:26:18 -0600, Jim Fehlig via Devel wrote: Hi All, I vaguely recall a discussion about $subject, but can't find it now. Perhaps buried in another thread. The topic has been raised internally again, and I'd like to gauge the commun

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-29 Thread Peter Xu
Lei, On Wed, May 29, 2024 at 02:43:46AM +, Gonglei (Arei) wrote: > For rdma programming, the current mainstream implementation is to use > rdma_cm to establish a connection, and then use verbs to transmit data. > rdma_cm and ibverbs create two FDs respectively. The two FDs have > different res

Re: [PATCH v3 2/5] qemu: Introduce shared_filesystems configuration option

2024-05-29 Thread Peter Krempa
On Thu, May 09, 2024 at 17:51:59 +0100, Daniel P. Berrangé wrote: > On Thu, May 09, 2024 at 04:47:48PM +, Andrea Bolognani wrote: > > On Thu, May 09, 2024 at 05:10:50PM GMT, Peter Krempa wrote: > > > Now things I see as problem in case when NFS not supporting xattr is > > > used. This means tha

Re: [libvirt PATCH] qemu_snapshot: fix memory leak when reverting external snapshot

2024-05-29 Thread Jiri Denemark
On Mon, May 27, 2024 at 20:02:39 +0200, Pavel Hrdina wrote: > The code cleaning up virStorageSource doesn't free data allocated by > virStorageSourceInit() so we need to call virStorageSourceDeinit() > explicitly. > > Fixes: 8e664737813378d2a1bdeacc2ca8e942327e2cab > Resolves: https://issues.redha

Re: [PATCH v2] run.in: Detect binaries in builddir properly

2024-05-29 Thread Jiri Denemark
On Tue, May 28, 2024 at 10:49:34 +0200, Michal Privoznik wrote: > When attempting to run: > > libvirt.git/_build # ./run --selinux ./src/libvirtd > > the following error is thrown: > > Refusing to change selinux context of file './src/libvirtd' outside build > directory > > which is obviou

[PATCH v2] virsh: Provide completer for some pool-X-as commands

2024-05-29 Thread Abhiram Tilak
Provides completers for auth-type and source-format commands for virsh pool-create-as and pool-define-as commands. Use Empty completers for options where completions are not required. Related Issue: https://gitlab.com/libvirt/libvirt/-/issues/9 Signed-off-by: Abhiram Tilak --- Changes in v2: -

Re: [PATCH] virsh: Provide completer for some pool-X-as commands

2024-05-29 Thread atp exp
On Tue, 28 May 2024 at 17:35, Peter Krempa wrote: > On Mon, May 27, 2024 at 18:34:38 +, Abhiram Tilak wrote: > > Provides completers for auth-type and source-format commands for > > virsh pool-create-as and pool-define-as commands. Use Empty completers > > for options where completions are no

Re: Add iommu device when VM configured with > 255 vcpus

2024-05-29 Thread Michal Prívozník
On 5/29/24 09:41, Peter Krempa wrote: > On Tue, May 28, 2024 at 16:26:18 -0600, Jim Fehlig via Devel wrote: >> Hi All, >> >> I vaguely recall a discussion about $subject, but can't find it now. Perhaps >> buried in another thread. The topic has been raised internally again, and >> I'd like to gauge

Re: [PATCH] fix virLogCleanerParseFilename logic

2024-05-29 Thread Michal Prívozník
On 5/29/24 09:21, Michal Prívozník wrote: > On 5/29/24 09:04, David Negreira wrote: >> Gentle reminder >> > > Can you please send v2? Michal > > Oh, I thought you were going to send v2. But okay, let me do that. Done: https://lists.libvirt.org/archives/list/devel@lists.libv

[PATCH] log_cleaner: Detect rotated filenames properly

2024-05-29 Thread Michal Privoznik
When removing rotated log files, their name is matched against a regex (@log_regex) and if they contain '.N' suffix the 'N' is then parsed into an integer. Well, due to a bug in virLogCleanerParseFilename() this is not how the code works. If the suffix isn't found then g_match_info_fetch() returns

Re: Add iommu device when VM configured with > 255 vcpus

2024-05-29 Thread Peter Krempa
On Tue, May 28, 2024 at 16:26:18 -0600, Jim Fehlig via Devel wrote: > Hi All, > > I vaguely recall a discussion about $subject, but can't find it now. Perhaps > buried in another thread. The topic has been raised internally again, and > I'd like to gauge the community's interest in automatically a

Re: [PATCH] fix virLogCleanerParseFilename logic

2024-05-29 Thread Michal Prívozník
On 5/29/24 09:04, David Negreira wrote: > Gentle reminder > >>> >>> Can you please send v2? >>> >>> Michal Oh, I thought you were going to send v2. But okay, let me do that. Michal