Re: [libvirt PATCH V3 0/4] add loongarch support for libvirt

ping > Hello, Everyone: > This patch series adds libvirt support for loongarch.Although the bios > path and name has not been officially integrated into qemu and we think > there are still many shortcomings, we try to push a version of patch to > the community according to the opinions of the com

Re: [libvirt PATCH V3 0/4] add loongarch support for libvirt

ping ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH] Extend libvirt-guests to shutdown only persistent VMs

On Thu, Feb 29, 2024 at 04:00:37PM +0100, Martin Kletzander wrote: > On Mon, Nov 13, 2023 at 10:22:59AM +, Benjamin Taubmann wrote: > > At the moment, there is no configuration option for the libvirt-guests > > service that allows users to define that only persistent virtual machines > > should

[libvirt PATCH 3/5] remote: implement virDomainGraphicsReload

Signed-off-by: Ján Tomko --- src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 13 - src/remote_protocol-structs | 6 ++ 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index f156475bd2..7b7

[libvirt PATCH 5/5] virsh: Introduce domdisplay-reload command

From: Zheng Yan Introduce the domdisplay-reload command to make the domain reload its graphics certificates #virsh domdisplay-reload --type Signed-off-by: Zheng Yan Signed-off-by: Ján Tomko --- docs/manpages/virsh.rst | 15 ++ tools/virsh-domain.c| 45

[libvirt PATCH 4/5] qemu: implement qemuDomainGraphicsReload

From: Zheng Yan The 'display-reload' QMP command had been introduced from QEMU 6.0.0: https://gitlab.com/qemu-project/qemu/-/commit/9cc07651655ee86eca41059f5ead8c4e5607c734 Currently it only supports reloading TLS certificates for VNC. https://issues.redhat.com/browse/RHEL-16333 Signed-off-by

[libvirt PATCH 2/5] libvirt: Introduce virDomainGraphicsReload API

From: Zheng Yan The new virDomainGraphicsReload API is used to make the domain reload its certificates without restart, and avoid service interruption. Currently, only QEMU VNC TLS certificates are supported, but parameters and flags are also reserved for subsequent scenarios. To reload QEMU VN

[libvirt PATCH 1/5] qemu_capabilities: Add QEMU_CAPS_DISPLAY_RELOAD

From: Zheng Yan The 'display-reload' QMP command was introduced in QEMU 6.0.0, so we add a compatible capability to check if target QEMU binary supports it. {"execute":"display-reload", "arguments":{"type": "vnc", "tls-certs": true}} The new QMP refer to: https://gitlab.com/qemu-project/qemu/-/

[libvirt PATCH 0/5] implement virDomainGraphicsReload

https://issues.redhat.com/browse/RHEL-16333 Based on the patches Huawei sent back in 2021: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/LDTM3NIOBWCS2USQSHXEKASHJHDVPNDG/ * rebased * renamed * simplified (removed virTypedParams from the API and the requirement to

Re: [libvirt] [PATCH 0/4] virtlogd: timestamp option to prepend timestamp

On 2/29/24 07:46, Shaleen Bathla wrote: > Description > > Add timestamp option to virtlogd.conf > When timestamp=1, let virtlogd prepend timestamps at start of line, > i.e. append timestamp after '\n' character. > This can be a useful debugging f

Re: [libvirt] [PATCH 2/4] util: virrotatingfile: Introduce virRotatingFileWriterAppendTimestamp

On 2/29/24 07:46, Shaleen Bathla wrote: > virRotatingFileWriterAppendTimestamp function appends timestamp to a > file. > > Signed-off-by: Shaleen Bathla > --- > src/util/virrotatingfile.c | 35 +++ > 1 file changed, 35 insertions(+) > > diff --git a/src/util/virr

Re: [PATCH] Extend libvirt-guests to shutdown only persistent VMs

On Mon, Nov 13, 2023 at 10:22:59AM +, Benjamin Taubmann wrote: At the moment, there is no configuration option for the libvirt-guests service that allows users to define that only persistent virtual machines should be shutdown on host shutdown. Currently, the service config allows to choose

[PATCH 9/9] docs: newapi: Fix generation of type definition tables

Ensure that all rows have 3 columns and avoid generation of emtpy elements which would be turned by the XML formatter into non-pair td/tr tags which don't work properly with HTML5 parsers. Signed-off-by: Peter Krempa --- docs/newapi.xsl | 45 + 1 file

[PATCH 8/9] docs: newapi: Properly skip ACL entries if empty

The source document can contain an empty '@flags' attribute which passes the test but generates an empty element. Check that flags is non-empty to trigger the fallback. Signed-off-by: Peter Krempa --- docs/newapi.xsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/newapi

[PATCH 7/9] docs: newapi: Avoid table where every row has an cell with 'colspan'

The HTML standard requires that a table column must include at least one row which defines it exclusively, thus having a table where all rows unite it via 'colspan' is illegal. Modify the enum value generator to always output the description field even when it's empty rather than uniting it, as in

[PATCH 4/9] docs: index: Fix import of blog planet javascript

Similarly to previous commit drop the 'type' attribute which is frowned upon by the HTML standard. Signed-off-by: Peter Krempa --- docs/index.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/index.rst b/docs/index.rst index 79afae65da..6b2f2386ee 100644 --- a/docs/ind

[PATCH 6/9] docs: newapi: Avoid empty s when there is no description

The various objects we generate API for may have empty description in which case an empty div would be generated when processing the API description. As we're using XML output mode the generator would shorten such divs to the non-pair empty element version, which doesn't work well with HTML5 parser

[PATCH 5/9] docs: newapi: Don't generate empty in template for ACL permissions

If an API has no ACLs an empty would be generated which is mis-interpreted by browsers when creating DOM to nest any subsequent elements under it. Don't generate the ACL section div unless it will be filled. Best viewed with 'git show -w' Signed-off-by: Peter Krempa --- docs/newapi.xsl | 60 +

[PATCH 3/9] docs: page: Fix declaration of main javascript source

Per the w3 html validator a HTML/XML comment is not allowed inside the tag, use a space instead as it must be a pair tag. Additionally drop the 'type' attribute as it's not needed (validator warns about it). Signed-off-by: Peter Krempa --- docs/page.xsl | 5 +++-- 1 file ch

[PATCH 2/9] docs: page: Add 'lang="en"' for all HTML output documents

Per the w3 HTML validator the 'lang' attribute is suggested. Signed-off-by: Peter Krempa --- docs/page.xsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/page.xsl b/docs/page.xsl index a51587db6c..7dcbc2d7a4 100644 --- a/docs/page.xsl +++ b/docs/page.xsl @@ -21,7 +21,7

[PATCH 1/9] docs: site: Don't generate '

Skip the XML header as it's invalid with both for the RST-generated pages and for the API docs generated from the API XML. Additionally remove the spurious xsl:output directive from newapi.xsl which is ignored and thus misleading. Signed-off-by: Peter Krempa --- docs/newapi.xsl | 7 +++ do

[PATCH 0/9] Fix broken HTML in API docs

While checking API docs after recent migration to gitlab-pages I've noticed that the footer is not properly rendered. A deeper dig showed that the issue is that empty elements, while formatted by the XML output version of XSLT conversion is turned into the non-pair empty variant. This contradicts

Re: [PATCH 03/10] virtime: virTimeMillisNowRaw to void

On Mon, Dec 25, 2023 at 12:25:56AM +0300, Artem Chernyshev wrote: virTimeMillisNowRaw() function are invariant now, so, quite a few checks, dependent on it are become irrelevant. Fixes: f5e9bdb87f ("src: replace clock_gettime()/gettimeofday() with g_get_real_time()") Signed-off-by: Artem Cherny

Re: [PATCH] remote_protocol: Fix ACL on REMOTE_PROC_NODE_DEVICE_DEFINE_XML

On 2/28/24 19:46, Boris Fiuczynski wrote: > Adding 'save' ACL to REMOTE_PROC_NODE_DEVICE_DEFINE_XML to make > REMOTE_PROC_NODE_DEVICE_UPDATE ACLs meaningful. > > Fixes: 69f9e7dbc24657e85761f03574779540d0f18315 > Signed-off-by: Boris Fiuczynski > --- > src/remote/remote_protocol.x | 1 + > 1 file

[RFC 4/4] meson: Enable -Wundef

This will catch cases in which we try to use the value of a macro that is only defined when the corresponding feature is present. Signed-off-by: Andrea Bolognani --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 9628fbcd59..3a83fb992a 100644 ---

[RFC 2/4] meson: Always define WITH_*_DECL macros

Instead of only defining them when the corresponding declaration exists, define them all the time and make their value reflect the availability. Signed-off-by: Andrea Bolognani --- meson.build| 2 ++ tests/virmockstathelpers.c | 28 ++-- 2 files changed,

[RFC 3/4] syntax-check: Ensure WITH_ macros are used correctly

They are supposed to always be defined, with their value reflecting the availability of the corresponding feature, so using #ifdef or #if defined() with them is incorrect. Signed-off-by: Andrea Bolognani --- build-aux/syntax-check.mk | 5 + 1 file changed, 5 insertions(+) diff --git a/build

[RFC 0/4] meson: Enable -Wundef

A few days ago I have posted a patch[1] that addresses an issue introduced when a meson check was dropped but some uses of the corresponding WITH_ macro were not removed at the same time. That got me thinking about what we can do to prevent such scenarios from happening again in the future. I have

[RFC 1/4] configmake: Check for WIN32 correctly

The macro is only defined on Windows, so we shouldn't check its value but rather whether it's defined at all. Signed-off-by: Andrea Bolognani --- configmake.h.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configmake.h.in b/configmake.h.in index c9930b6049..6b309472e5 100

Re: [PATCH] NEWS: Document my contributions for upcoming release

On Thu, Feb 29, 2024 at 09:48:09AM +0100, Michal Privoznik wrote: > + * ch: Enable ``ethernet`` interface mode support > + > +The can now be used for CH domains. Use single quotes here for consistency, and consider dropping the leading "the". > + * qemu_hotplug: Don't lose 'created' fl

[PATCH] NEWS: Document my contributions for upcoming release

Signed-off-by: Michal Privoznik --- NEWS.rst | 42 ++ 1 file changed, 42 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index def5a5edd0..5e3a29eed6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -43,6 +43,13 @@ v10.1.0 (unreleased) to resolve names of the c