[PATCH] Add explanation about the attribute "delay"

2024-01-09 Thread Yalan Zhang
The libvirt created linux bridge has a configurable value "delay", the default value is "0", but it will not take effect. That's because kernel has a minimum value for linux bridge. Add some explanation about it in the document. Signed-off-by: Yalan Zhang --- docs/formatnetwork.rst | 3 ++- 1 fi

[PATCH 1/4] Add loongarch cpu support

2024-01-09 Thread Xianglai Li
From: xianglai li Add loongarch cpu support, Define new cpu type 'loongarch64' and implement it's driver functions. Signed-off-by: "Xianglai Li" Signed-off-by: Xianglai Li --- src/cpu/cpu.c| 2 + src/cpu/cpu_loongarch.c | 80 src/cpu/

[libvirt PATCH V2 1/4] Add loongarch cpu support

2024-01-09 Thread Xianglai Li
From: xianglai li Add loongarch cpu support, Define new cpu type 'loongarch64' and implement it's driver functions. Signed-off-by: "Xianglai Li" --- src/cpu/cpu.c| 2 + src/cpu/cpu_loongarch.c | 80 src/cpu/cpu_loongarch.h | 25 ++

[PATCH 2/4] Config some capabilities for loongarch virt machine

2024-01-09 Thread Xianglai Li
From: xianglai li Config some capabilities for loongarch virt machine such as PCI multi bus. Signed-off-by: "Xianglai Li" Signed-off-by: Xianglai Li --- src/qemu/qemu_capabilities.c | 10 -- src/qemu/qemu_domain.c | 29 - src/qemu/qemu_domain.h

[libvirt PATCH V2 2/4] Config some capabilities for loongarch virt machine

2024-01-09 Thread Xianglai Li
From: xianglai li Config some capabilities for loongarch virt machine such as PCI multi bus. Signed-off-by: "Xianglai Li" --- src/qemu/qemu_capabilities.c | 10 -- src/qemu/qemu_domain.c | 29 - src/qemu/qemu_domain.h | 1 + 3 files changed, 37

[PATCH 3/4] Implement the method of getting host info for loongarch

2024-01-09 Thread Xianglai Li
From: xianglai li Implement method for loongarch to get host info, such as cpu frequency, system info, etc. Signed-off-by: "Xianglai Li" Signed-off-by: Xianglai Li --- src/util/virarch.c| 2 ++ src/util/virhostcpu.c | 7 +-- src/util/virsysinfo.c | 3 ++- 3 files changed, 9 insertions

[libvirt PATCH V2 3/4] Implement the method of getting host info for loongarch

2024-01-09 Thread Xianglai Li
From: xianglai li Implement method for loongarch to get host info, such as cpu frequency, system info, etc. Signed-off-by: "Xianglai Li" --- src/util/virarch.c| 2 ++ src/util/virhostcpu.c | 7 +-- src/util/virsysinfo.c | 3 ++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --

[libvirt PATCH V2 0/4] add loongarch support for libvirt

2024-01-09 Thread Xianglai Li
Hello, Everyone: This patch series adds libvirt support for loongarch.Although the bios path and name has not been officially integrated into qemu and we think there are still many shortcomings, we try to push a version of patch to the community according to the opinions of the community, hoping

Re: [libvirt PATCH V2 0/4] add loongarch support for libvirt

2024-01-09 Thread lixianglai
Hi Andrea Bolognani : On Tue, Jan 09, 2024 at 01:25:16AM -0800, Andrea Bolognani wrote: On Tue, Jan 09, 2024 at 09:51:59AM +0800, lixianglai wrote: Hi Andrea: I'm so sorry to bother you. I modified the code according to your suggestion and sent the second version of patch to the community, b

Re: [PATCH] qemu: Be less aggressive when dropping channel source paths

2024-01-09 Thread Andrea Bolognani
On Tue, Jan 09, 2024 at 03:28:44PM +0100, Michal Privoznik wrote: > In v9.7.0-rc1~130 I've shortened the path that's generated for > source. With that, I had to adjust regex that matches > all versions of paths we have ever generated so that we can drop > them (see comment around qemuDomainChrDefD

Re: Re: [PATCH 0/2] ci: Update to Fedora 39

2024-01-09 Thread Andrea Bolognani
On Tue, Jan 09, 2024 at 12:14:38PM +, Daniel P. Berrangé wrote: > On Tue, Jan 09, 2024 at 01:12:35PM +0100, Peter Krempa wrote: > > On Tue, Jan 09, 2024 at 11:41:17 +, Daniel P. Berrangé wrote: > > > On Mon, Jan 08, 2024 at 10:48:58AM +0100, Peter Krempa wrote: > > > > Grrr, this broke beca

Re: [PATCH v2 00/14] Unreacheble code cleanup

2024-01-09 Thread Michal Prívozník
On 1/9/24 13:06, fro...@swemel.ru wrote: > ping Can you rebase and resend? I've merged some patches earlier that touch the same area and your patches no longer apply cleanly. Also, we've entered feature freeze earlier today [1] which means only bug fixes can be merged. Michal 1: https://lists.l

Re: [PATCH v2 0/2] Deprecate the shix machine and the TC58128 flash device

2024-01-09 Thread Philippe Mathieu-Daudé
On 9/1/24 09:30, Samuel Tardieu wrote: Samuel Tardieu (2): target/sh4: Deprecate the shix machine hw/block: Deprecate the TC58128 block device docs/about/deprecated.rst | 5 + hw/block/tc58128.c| 1 + hw/sh4/shix.c | 1 + 3 files changed, 7 insertions(+) Ser

[PATCH] qemu: Be less aggressive when dropping channel source paths

2024-01-09 Thread Michal Privoznik
In v9.7.0-rc1~130 I've shortened the path that's generated for source. With that, I had to adjust regex that matches all versions of paths we have ever generated so that we can drop them (see comment around qemuDomainChrDefDropDefaultPath()). But as it is usually the case with regexes - they are w

Re: [PATCH rfcv3 07/11] qemu: add hard reboot in QEMU driver

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:17PM +0800, Zhenzhong Duan wrote: > From: Chenyi Qiang > > Add the new flag VIR_DOMAIN_REBOOT_HARD/VIR_DOMAIN_SHUTDOWN_HARD to > carry out a hard reboot, which kills the QEMU process and creates a new > one with the same definition. AFAICT, the _HARD flags cause it

Re: [PATCH rfcv3 11/11] conf: Add support to keep same domid for hard reboot

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:21PM +0800, Zhenzhong Duan wrote: > After hard reboot, domid is increased by 1 as a new domain. > Hard reboot simulate TD-guest reboot by calling qemuProcessStop > and qemuProcessStart which will release and recreate domain > resource including domid. This is risky.

Re: [PATCH rfcv3 10/11] virsh: add new option "timekeep" to keep virsh console alive

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:20PM +0800, Zhenzhong Duan wrote: > From: Chenyi Qiang > > User can add a new option --timekeep to keep the virsh console alive for > several seconds. Then it would try to reconnenct the same domain. > > This option is mainly aimed to support hard reboot in Libvirt,

Re: [PATCH rfcv3 08/11] qemu: make hard reboot as the TDX default reboot mode

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:18PM +0800, Zhenzhong Duan wrote: > From: Chenyi Qiang > > Signed-off-by: Chenyi Qiang > --- > src/qemu/qemu_driver.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 86e8e

Re: [PATCH rfcv3 06/11] qemu: force special parameters enabled for TDX guest

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:16PM +0800, Zhenzhong Duan wrote: > TDX guest requires some special parameters to boot, They are: > > "-machine pc-q35-*" > "kernel_irqchip=split" > > Signed-off-by: Zhenzhong Duan > --- > src/qemu/qemu_validate.c | 10 ++ > 1 file changed, 10 insertions(

Re: [PATCH rfcv3 05/11] qemu: Add command line and validation for TDX type

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:15PM +0800, Zhenzhong Duan wrote: > QEMU will provides 'tdx-guest' object which is used to launch encrypted > VMs on Intel platform using TDX feature. > > Command line looks like: > $QEMU ... \ > -object > tdx-guest,id=lsec0,debug=on,sept-ve-disable=on,mrconfigid=x

Re: [PATCH rfcv3 04/11] conf: add tdx as launch security type

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:14PM +0800, Zhenzhong Duan wrote: > When 'tdx' is used, the VM will launched with Intel TDX feature enabled. > TDX feature supports running encrypted VM (Trust Domain, TD) under the > control of KVM. A TD runs in a CPU model which protects the > confidentiality of its

Re: [PATCH rfcv3 03/11] conf: expose TDX feature in domain capabilities

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:13PM +0800, Zhenzhong Duan wrote: > Extend qemu TDX capability to domain capabilities. > > Signed-off-by: Chenyi Qiang > Signed-off-by: Zhenzhong Duan > --- > docs/formatdomaincaps.rst | 1 + > src/conf/domain_capabilities.c | 1 + > src/conf/domain_capabi

Re: [PATCH rfcv3 02/11] qemu: Add TDX capability

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:12PM +0800, Zhenzhong Duan wrote: > QEMU_CAPS_TDX_GUEST set means TDX supported with this QEMU. > > Signed-off-by: Chenyi Qiang > Signed-off-by: Zhenzhong Duan > --- > src/qemu/qemu_capabilities.c | 2 ++ > src/qemu/qemu_capabilities.h | 1 + > 2 files changed, 3 i

Re: [PATCH rfcv3 01/11] qemu: Check if INTEL Trust Domain Extention support is enabled

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:11PM +0800, Zhenzhong Duan wrote: > Implement TDX check in order to generate domain feature capability > correctly in case the availability of the feature changed. > > For INTEL TDX the verification is: > - checking if "/sys/module/kvm_intel/parameters/tdx" contains

Re: [PATCH 0/2] ci: Update to Fedora 39

2024-01-09 Thread Daniel P . Berrangé
On Tue, Jan 09, 2024 at 01:12:35PM +0100, Peter Krempa wrote: > On Tue, Jan 09, 2024 at 11:41:17 +, Daniel P. Berrangé wrote: > > On Mon, Jan 08, 2024 at 10:48:58AM +0100, Peter Krempa wrote: > > > On Mon, Jan 08, 2024 at 10:35:53 +0100, Peter Krempa wrote: > > > > I've approved and merged > >

Re: [PATCH 0/2] ci: Update to Fedora 39

2024-01-09 Thread Peter Krempa
On Tue, Jan 09, 2024 at 11:41:17 +, Daniel P. Berrangé wrote: > On Mon, Jan 08, 2024 at 10:48:58AM +0100, Peter Krempa wrote: > > On Mon, Jan 08, 2024 at 10:35:53 +0100, Peter Krempa wrote: > > > I've approved and merged > > > > > > https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/109

Re: [PATCH v2 00/14] Unreacheble code cleanup

2024-01-09 Thread frolov
ping ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH] qemu: tighten semantics of 'size' when resizing block devices

2024-01-09 Thread Daniel P . Berrangé
On Thu, Jan 04, 2024 at 05:45:21PM +0100, Peter Krempa wrote: > On Wed, Jan 03, 2024 at 16:39:26 +, Daniel P. Berrangé wrote: > > When VIR_DOMAIN_BLOCK_RESIZE_CAPACITY is set, the 'size' parameter > > is currently ignored. Since applications must none the less pass a > > value for this paramete

Re: [PATCH 0/2] ci: Update to Fedora 39

2024-01-09 Thread Daniel P . Berrangé
On Mon, Jan 08, 2024 at 10:48:58AM +0100, Peter Krempa wrote: > On Mon, Jan 08, 2024 at 10:35:53 +0100, Peter Krempa wrote: > > I've approved and merged > > > > https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/109 > > > > and posted > > > > https://gitlab.com/libvirt/libvirt-python/-/mer

Entering freeze for libvirt-10.0.0

2024-01-09 Thread Jiri Denemark
I have just tagged v10.0.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to mak

Re: Re: Re: [libvirt PATCH V2 0/4] add loongarch support for libvirt

2024-01-09 Thread Andrea Bolognani
On Tue, Jan 09, 2024 at 01:25:16AM -0800, Andrea Bolognani wrote: > On Tue, Jan 09, 2024 at 09:51:59AM +0800, lixianglai wrote: > > Hi Andrea: > > > > I'm so sorry to bother you. > > > > I modified the code according to your suggestion and sent the second version > > of patch to the community, > >

Re: Re: Re: [PATCH 1/3] ci: Fix upstream-qemu job definitions

2024-01-09 Thread Daniel P . Berrangé
On Tue, Jan 09, 2024 at 01:02:38AM -0800, Andrea Bolognani wrote: > On Tue, Jan 09, 2024 at 12:41:25AM -0800, Andrea Bolognani wrote: > > On Mon, Jan 08, 2024 at 09:07:33PM +0100, Peter Krempa wrote: > > > On Mon, Jan 08, 2024 at 11:43:22 +0100, Andrea Bolognani wrote: > > > > These are jobs are su

Re: Re: Re: [PATCH 1/3] ci: Fix upstream-qemu job definitions

2024-01-09 Thread Andrea Bolognani
On Tue, Jan 09, 2024 at 12:41:25AM -0800, Andrea Bolognani wrote: > On Mon, Jan 08, 2024 at 09:07:33PM +0100, Peter Krempa wrote: > > On Mon, Jan 08, 2024 at 11:43:22 +0100, Andrea Bolognani wrote: > > > These are jobs are supposed to be running tests using a QEMU > > > binary built from the latest

Re: [PATCH v2 0/2] Deprecate the shix machine and the TC58128 flash device

2024-01-09 Thread Samuel Tardieu
Samuel Tardieu writes: The shix machine was a research project started around 2003 at Télécom Paris. Preliminary support in QEMU was added in 2005 back when the QEMU architecture was less structured than it is now. Unfortunately, the support for the shix machine and its peripherals, such as the

[PATCH v2 2/2] hw/block: Deprecate the TC58128 block device

2024-01-09 Thread Samuel Tardieu
The 16MiB flash device is only used by the deprecated shix machine. Its code it old and unmaintained, and has never been adapted to the QOM architecture. It still contains debug statements and uses global variables. It is time to deprecate it. Signed-off-by: Samuel Tardieu Reviewed-by: Cédric Le

[PATCH v2 1/2] target/sh4: Deprecate the shix machine

2024-01-09 Thread Samuel Tardieu
The shix machine has been designed and used at Télécom Paris from 2003 to 2010. It had been added to QEMU in 2005 and has not been maintained since. Since nobody is using the physical board anymore nor interested in maintaining the QEMU port, it is time to deprecate it. Signed-off-by: Samuel Tardi

[PATCH v2 0/2] Deprecate the shix machine and the TC58128 flash device

2024-01-09 Thread Samuel Tardieu
The shix machine was a research project started around 2003 at Télécom Paris. Preliminary support in QEMU was added in 2005 back when the QEMU architecture was less structured than it is now. Unfortunately, the support for the shix machine and its peripherals, such as the TC58128 16MiB flash device

Re: [PATCH 1/2] target/sh4: Deprecate the shix machine

2024-01-09 Thread Samuel Tardieu
Philippe Mathieu-Daudé writes: mc->default_cpu_type = TYPE_SH7750R_CPU; +mc->deprecation_reason = "old and unmaintained - use a newer machine instead"; "use a newer machine instead" bugs me, what would that be? Could we stick to "old and unmaintained"? You're right. I removed th

Re: [PATCH 1/2] target/sh4: Deprecate the shix machine

2024-01-09 Thread Yoshinori Sato
On Tue, 09 Jan 2024 02:15:21 +0900, Samuel Tardieu wrote: > > The shix machine has been designed and used at Télécom Paris from 2003 > to 2010. It had been added to QEMU in 2005 and has not been maintained > since. Since nobody is using the physical board anymore nor interested > in maintaining th

[PATCH 1/2] target/sh4: Deprecate the shix machine

2024-01-09 Thread Samuel Tardieu
The shix machine has been designed and used at Télécom Paris from 2003 to 2010. It had been added to QEMU in 2005 and has not been maintained since. Since nobody is using the physical board anymore nor interested in maintaining the QEMU port, it is time to deprecate it. Signed-off-by: Samuel Tardi

[PATCH 2/2] hw/block: Deprecate the TC58128 block device

2024-01-09 Thread Samuel Tardieu
The 16MiB flash device is only used by the deprecated shix machine. Its code it old and unmaintained, and has never been adapted to the QOM architecture. It still contains debug statements and uses global variables. It is time to deprecate it. Signed-off-by: Samuel Tardieu --- docs/about/depreca

[PATCH 0/2] Deprecate the shix machine and the TC58128 flash device

2024-01-09 Thread Samuel Tardieu
The shix machine was a research project started around 2003 at Télécom Paris. Preliminary support in QEMU was added in 2005 back when the QEMU architecture was less structured than it is now. Unfortunately, the support for the shix machine and its peripherals, such as the TC58128 16MiB flash device

Re: Re: [PATCH 2/3] ci: Move upstream-qemu job to Fedora 39

2024-01-09 Thread Andrea Bolognani
On Mon, Jan 08, 2024 at 09:11:12PM +0100, Peter Krempa wrote: > On Mon, Jan 08, 2024 at 11:43:23 +0100, Andrea Bolognani wrote: > > Signed-off-by: Andrea Bolognani > > --- > > ci/integration.yml | 42 +- > > 1 file changed, 21 insertions(+), 21 deletions(-)

Re: Re: [PATCH 1/3] ci: Fix upstream-qemu job definitions

2024-01-09 Thread Andrea Bolognani
On Mon, Jan 08, 2024 at 09:07:33PM +0100, Peter Krempa wrote: > On Mon, Jan 08, 2024 at 11:43:22 +0100, Andrea Bolognani wrote: > > These are jobs are supposed to be running tests using a QEMU > > binary built from the latest upstream sources, but right now > > they're just doing the same thing as

Re: Re: [PATCH 2/2] tests: Add capabilities for QEMU 8.2.0 on aarch64

2024-01-09 Thread Andrea Bolognani
On Mon, Jan 08, 2024 at 10:21:53PM +0100, Peter Krempa wrote: > removed: > ccid-card-emulated > ccid-card-passthru > exynos4210.irq_gate > vmware-svga > xlnx,bbram-ctrl > > So there's one more compile time difference in the support of 'ccid' > devices. CCID devices are implemented using libca