Re: [ PATCH vf-token 0/8] Introduce vf-token when using userspace PF

2024-01-08 Thread Vivek Kashyap
On Mon, 8 Jan 2024, Alex Williamson wrote: On Mon, 8 Jan 2024 23:32:04 +0530 (IST) Vivek Kashyap wrote: On Mon, 8 Jan 2024, Alex Williamson wrote: On Mon, 8 Jan 2024 18:42:19 +0530 (IST) Vivek Kashyap wrote: ... As I've stated above, for libvirt we should consider only passing it via

Re: [PATCH 1/2] target/sh4: Deprecate the shix machine

2024-01-08 Thread Philippe Mathieu-Daudé
Hi Samuel, On 8/1/24 18:15, Samuel Tardieu wrote: The shix machine has been designed and used at Télécom Paris from 2003 to 2010. It had been added to QEMU in 2005 and has not been maintained since. Since nobody is using the physical board anymore nor interested in maintaining the QEMU port, it

Re: [PATCH 2/2] tests: Add capabilities for QEMU 8.2.0 on aarch64

2024-01-08 Thread Peter Krempa
On Mon, Jan 08, 2024 at 17:59:06 +0100, Andrea Bolognani wrote: > Notable changes compared to 7.0.0, the most recent version that > we had capabilities for until now: > > * SPICE support is no longer compiled in; > > * uses of -no-acpi are replaced with -M virt,acpi=off; > > * -netdev uses

Re: [PATCH 1/2] tests: Don't use features with vexpress machine

2024-01-08 Thread Peter Krempa
On Mon, Jan 08, 2024 at 17:59:05 +0100, Andrea Bolognani wrote: > The vexpress machine has never supported ACPI. This fact has > been silently ignored by QEMU so far, but recent versions have > started reporting attempts to use the combination as an error. > > The other features (APIC, PAE) are al

Re: [PATCH 2/3] ci: Move upstream-qemu job to Fedora 39

2024-01-08 Thread Peter Krempa
On Mon, Jan 08, 2024 at 11:43:23 +0100, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > ci/integration.yml | 42 +- > 1 file changed, 21 insertions(+), 21 deletions(-) Reordering the entries made this very unpleasant to review. Reviewed

Re: [PATCH 1/3] ci: Fix upstream-qemu job definitions

2024-01-08 Thread Peter Krempa
On Mon, Jan 08, 2024 at 11:43:22 +0100, Andrea Bolognani wrote: > These are jobs are supposed to be running tests using a QEMU > binary built from the latest upstream sources, but right now > they're just doing the same thing as the other jobs for the > target. Use the correct job templates. > > S

Re: [libvirt PATCH 6/6] NEWS: Mention postcopy-preempt migration capability

2024-01-08 Thread Peter Krempa
On Mon, Jan 08, 2024 at 18:06:42 +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > NEWS.rst | 8 > 1 file changed, 8 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index dc40602c72..9675f12cb4 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -17,6 +17,14 @@ v10.0.0 (

Re: [libvirt PATCH 5/6] qemu: Enable postcopy-preempt migration capability

2024-01-08 Thread Peter Krempa
On Mon, Jan 08, 2024 at 18:06:41 +0100, Jiri Denemark wrote: > During post-copy migration (once it actually switches to post-copy mode) > dirty memory pages are continued to be migrated iteratively, while the > destination can explicitly request a specific page to be migrated before > the iterative

Re: [libvirt PATCH 4/6] qemu: Add support for optional migration capabilities

2024-01-08 Thread Peter Krempa
On Mon, Jan 08, 2024 at 18:06:40 +0100, Jiri Denemark wrote: > We enable various migration capabilities according to the flags passed > to a migration API. Missing support for such capabilities results in an > error because they are required by the corresponding flag. This patch > adds support for

Re: [libvirt PATCH 3/6] qemu: Rename remoteCaps parameter in qemuMigrationParamsCheck

2024-01-08 Thread Peter Krempa
On Mon, Jan 08, 2024 at 18:06:39 +0100, Jiri Denemark wrote: > The migration cookie contains two bitmaps of migration capabilities: > supported and automatic. qemuMigrationParamsCheck expects the letter so > lets make it more obvious by renaming the parameter as remoteAuto. > > Signed-off-by: Jiri

Re: [libvirt PATCH 2/6] qemu: Use C99 initializers for qemuMigrationParamsFlagMap

2024-01-08 Thread Peter Krempa
On Mon, Jan 08, 2024 at 18:06:38 +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_migration_params.c | 50 > 1 file changed, 25 insertions(+), 25 deletions(-) Reviewed-by: Peter Krempa _

Re: [libvirt PATCH 1/6] qemu: Document qemuMigrationParamsFlagMapItem fields

2024-01-08 Thread Peter Krempa
On Mon, Jan 08, 2024 at 18:06:37 +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_migration_params.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) Reviewed-by: Peter Krempa ___ Devel mailing list

[PATCH 11/11] news: Mention support for CPU clusters

2024-01-08 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index dc40602c72..b9e8f11aed 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,12 @@ v10.0.0 (unreleased) * **New features** + * qemu: Support clusters in CPU topology

[PATCH 10/11] docs: Document CPU clusters

2024-01-08 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- docs/formatcaps.rst | 2 +- docs/formatdomain.rst | 18 ++ 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/docs/formatcaps.rst b/docs/formatcaps.rst index 3cccf70882..5c678f0787 100644 --- a/docs/formatcaps.rst +++ b/docs/form

[PATCH 08/11] tests: Verify handling of CPU clusters in QMP data

2024-01-08 Thread Andrea Bolognani
Since aarch64 doesn't support CPU hotplug at the moment, we have to get a bit creative. While the 'query-cpus-fast' output is taken directly from a VM configured as 16 the 'query-hotpluggable-cpus' output is constructed by hand starting from the former and using the 'x86-dies' test

[PATCH 03/11] conf: Allow specifying CPU clusters

2024-01-08 Thread Andrea Bolognani
The default number of CPU clusters is 1, and values other than that one are currently rejected by all hypervisor drivers. Signed-off-by: Andrea Bolognani --- src/bhyve/bhyve_command.c| 5 + src/conf/cpu_conf.c | 16 +++- src/c

[PATCH 02/11] conf: Report CPU clusters in capabilities XML

2024-01-08 Thread Andrea Bolognani
For machines that don't expose useful information through sysfs, the dummy ID 0 is used. https://issues.redhat.com/browse/RHEL-7043 Signed-off-by: Andrea Bolognani --- src/conf/capabilities.c | 5 +- src/conf/capabilities.h | 1 + src/conf/schemas

[PATCH 05/11] qemu: Use CPU clusters for guests

2024-01-08 Thread Andrea Bolognani
https://issues.redhat.com/browse/RHEL-7043 Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 4 +++- tests/qemuxml2argvdata/cpu-hotplug-startup.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/cpu-numa-disjoint.x86_64-latest.args | 2 +- tests

[PATCH 09/11] docs: Tweak documentation for CPU topology

2024-01-08 Thread Andrea Bolognani
Mention that support for the "dies" attribute was introduced in libvirt 6.1.0 and clarify that the ability to use non-default values is subject to architecuture and machine limitations. Signed-off-by: Andrea Bolognani --- docs/formatdomain.rst | 16 ++-- 1 file changed, 10 insertions

[PATCH 07/11] qemu: Make monitor aware of CPU clusters

2024-01-08 Thread Andrea Bolognani
This makes it so libvirt can obtain accurate information about guest CPUs from QEMU, and should make it possible to correctly perform operations such as CPU hotplug. Of course this is mostly moot at the moment: only aarch64 can use CPU clusters, and CPU hotplug is not yet implemented on that archi

[PATCH 06/11] tests: Add test case for CPU clusters

2024-01-08 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- .../cpu-topology5.aarch64-latest.args | 31 +++ tests/qemuxml2argvdata/cpu-topology5.xml | 17 ++ tests/qemuxml2argvtest.c | 1 + 3 files changed, 49 insertions(+) create mode 100644 tests/qemuxml2argv

[PATCH 01/11] tests: Add hostcpudata for machine with CPU clusters

2024-01-08 Thread Andrea Bolognani
The data is taken from an HPE Apollo 70 machine, which uses aarch64 CPUs. It is interesting for us because non-dummy information about CPU clusters is exposed through sysfs. Signed-off-by: Andrea Bolognani --- .../linux-basic-clusters/system/cpu |1 + .../linux-basic-clusters/syste

[PATCH 04/11] qemu: Introduce QEMU_CAPS_SMP_CLUSTERS

2024-01-08 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_7.1.0_x86_64.xml | 1 + tests/qemucapabiliti

[PATCH 00/11] qemu: Add support for CPU clusters

2024-01-08 Thread Andrea Bolognani
Edited for brevity. Full version: $ git fetch https://gitlab.com/abologna/libvirt.git cpu-clusters Depends on: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/IDFVKTZ6SKD6X6NI4DHM6JMXMQEVNVDL/ Andrea Bolognani (11): tests: Add hostcpudata for machine with CPU clust

Re: [ PATCH vf-token 0/8] Introduce vf-token when using userspace PF

2024-01-08 Thread Alex Williamson
On Mon, 8 Jan 2024 23:32:04 +0530 (IST) Vivek Kashyap wrote: > On Mon, 8 Jan 2024, Alex Williamson wrote: > > > On Mon, 8 Jan 2024 18:42:19 +0530 (IST) > > Vivek Kashyap wrote: > > > >> ... > As I've stated above, for libvirt we should consider only passing it via > the 'secret' o

Re: Re: [PATCH 2/2] tests: Add capabilities for QEMU 8.2.0 on aarch64

2024-01-08 Thread Andrea Bolognani
On Mon, Jan 08, 2024 at 05:29:41PM +, Daniel P. Berrangé wrote: > On Mon, Jan 08, 2024 at 05:59:06PM +0100, Andrea Bolognani wrote: > > Notable changes compared to 7.0.0, the most recent version that > > we had capabilities for until now: > > > > * SPICE support is no longer compiled in; > >

Re: [ PATCH vf-token 0/8] Introduce vf-token when using userspace PF

2024-01-08 Thread Vivek Kashyap
On Mon, 8 Jan 2024, Alex Williamson wrote: On Mon, 8 Jan 2024 18:42:19 +0530 (IST) Vivek Kashyap wrote: ... As I've stated above, for libvirt we should consider only passing it via the 'secret' object. Sounds good. Will follow this up. Alex - will you be working on the qemu update? I

Re: [PATCH 2/2] tests: Add capabilities for QEMU 8.2.0 on aarch64

2024-01-08 Thread Daniel P . Berrangé
On Mon, Jan 08, 2024 at 05:59:06PM +0100, Andrea Bolognani wrote: > Notable changes compared to 7.0.0, the most recent version that > we had capabilities for until now: > > * SPICE support is no longer compiled in; Presumably that's just your dev machine lacking spice-server-devel, since upstre

Re: [PATCH 2/2] hw/block: Deprecate the TC58128 block device

2024-01-08 Thread Cédric Le Goater
On 1/8/24 18:15, Samuel Tardieu wrote: The 16MiB flash device is only used by the deprecated shix machine. Its code it old and unmaintained, and has never been adapted to the QOM architecture. It still contains debug statements and uses global variables. It is time to deprecate it. Signed-off-by

Re: [PATCH 1/2] target/sh4: Deprecate the shix machine

2024-01-08 Thread Cédric Le Goater
On 1/8/24 18:15, Samuel Tardieu wrote: The shix machine has been designed and used at Télécom Paris from 2003 to 2010. It had been added to QEMU in 2005 and has not been maintained since. Since nobody is using the physical board anymore nor interested in maintaining the QEMU port, it is time to d

[libvirt PATCH 6/6] NEWS: Mention postcopy-preempt migration capability

2024-01-08 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index dc40602c72..9675f12cb4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,14 @@ v10.0.0 (unreleased) * **New features** + * qemu: Enable postcopy-preempt migration

[libvirt PATCH 5/6] qemu: Enable postcopy-preempt migration capability

2024-01-08 Thread Jiri Denemark
During post-copy migration (once it actually switches to post-copy mode) dirty memory pages are continued to be migrated iteratively, while the destination can explicitly request a specific page to be migrated before the iterative process gets to it (which happens when a guest wants to read a page

[libvirt PATCH 4/6] qemu: Add support for optional migration capabilities

2024-01-08 Thread Jiri Denemark
We enable various migration capabilities according to the flags passed to a migration API. Missing support for such capabilities results in an error because they are required by the corresponding flag. This patch adds support for additional optional capability we may want to enable for a given API

[libvirt PATCH 3/6] qemu: Rename remoteCaps parameter in qemuMigrationParamsCheck

2024-01-08 Thread Jiri Denemark
The migration cookie contains two bitmaps of migration capabilities: supported and automatic. qemuMigrationParamsCheck expects the letter so lets make it more obvious by renaming the parameter as remoteAuto. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 6 +++--- src/qemu/q

[libvirt PATCH 1/6] qemu: Document qemuMigrationParamsFlagMapItem fields

2024-01-08 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c index 79fe6e97c8..9de6c08021 100644 --- a/src/qemu/qemu_migration_params.c +++ b/s

[libvirt PATCH 2/6] qemu: Use C99 initializers for qemuMigrationParamsFlagMap

2024-01-08 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 50 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c index 9de6c08021..b02a8af8d5 100644 --- a/src/qemu/qemu_migr

[libvirt PATCH 0/6] qemu: Enable postcopy-preempt migration capability

2024-01-08 Thread Jiri Denemark
This is technically a v2 of my recent "Introduce VIR_MIGRATE_POSTCOPY_PREEMPT flag", but the two series share exactly two lines of code (those defining a new QEMU_MIGRATION_CAP_POSTCOPY_PREEMPT enum item) so I'm just sending it as a separate series. More details about this feature can be found in

Re: Re: Re: [libvirt PATCH 1/3] Introduce VIR_MIGRATE_POSTCOPY_PREEMPT flag

2024-01-08 Thread Jiri Denemark
On Fri, Jan 05, 2024 at 17:31:50 +0100, Jiri Denemark wrote: > On Fri, Jan 05, 2024 at 17:11:57 +0100, Peter Krempa wrote: > > On Fri, Jan 5, 2024 at 4:55 PM Jiri Denemark wrote: > > > > > During post-copy migration (once it actually switches to post-copy mode) > > > dirty memory pages are contin

[PATCH 2/2] tests: Add capabilities for QEMU 8.2.0 on aarch64

2024-01-08 Thread Andrea Bolognani
Notable changes compared to 7.0.0, the most recent version that we had capabilities for until now: * SPICE support is no longer compiled in; * uses of -no-acpi are replaced with -M virt,acpi=off; * -netdev uses JSON. Signed-off-by: Andrea Bolognani --- .../qemu_8.2.0-virt.aarch64.xml

[PATCH 1/2] tests: Don't use features with vexpress machine

2024-01-08 Thread Andrea Bolognani
The vexpress machine has never supported ACPI. This fact has been silently ignored by QEMU so far, but recent versions have started reporting attempts to use the combination as an error. The other features (APIC, PAE) are also not relevant to the vexpress machine, or the QEMU driver. Signed-off-b

[PATCH 0/2] tests: Add capabilities for QEMU 8.2.0 on aarch64

2024-01-08 Thread Andrea Bolognani
Edited for brevity. Full version: $ git fetch https://gitlab.com/abologna/libvirt.git qemu-caps Andrea Bolognani (2): tests: Don't use features with vexpress machine tests: Add capabilities for QEMU 8.2.0 on aarch64 .../qemu_8.2.0-virt.aarch64.xml | 227 + tests/domaincaps

Re: [ PATCH vf-token 0/8] Introduce vf-token when using userspace PF

2024-01-08 Thread Alex Williamson
On Mon, 8 Jan 2024 18:42:19 +0530 (IST) Vivek Kashyap wrote: > ... > >> As I've stated above, for libvirt we should consider only passing it via > >> the 'secret' object. > > Sounds good. Will follow this up. > > Alex - will you be working on the qemu update? I'm not the one driving a use c

[PATCH 20/23] tests: Remove qemuxml2xmltest

2024-01-08 Thread Peter Krempa
The full functionality was merged into qemuxmlconftest. Signed-off-by: Peter Krempa --- docs/advanced-tests.rst | 2 +- tests/meson.build | 1 - tests/qemucapabilitiesdata/README.rst | 2 +- .../qemuxml2argvdata/mach-virt-serial-usb

[PATCH 23/23] tests: Rename 'qemuxml2argvtest' to 'qemuxmlconftest'

2024-01-08 Thread Peter Krempa
Since this tests inactive/config XML files rename it accordingly. Signed-off-by: Peter Krempa --- docs/advanced-tests.rst | 10 +- src/util/virsecret.c| 2 +- tests/meson.build | 2 +- tests/qemucapabilit

[PATCH 22/23] meson: tests: Allow 'timeout' override for all tests

2024-01-08 Thread Peter Krempa
Don't special-case qemuxml2argvtest's handling of timeout but rather allow each test array entry to have it's own. Signed-off-by: Peter Krempa --- tests/meson.build | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tests/meson.build b/tests/meson.build index 4a404237

[PATCH 19/23] qemuxml2argvtest: Test (inactive) def -> xml conversion

2024-01-08 Thread Peter Krempa
This is an intermediate step to merge qemuxml2xmltest into this common helper. This eliminates double setup/parsing of the input data as well as will ensure that all input XMLs are tested both for ARGV as well as XML output. For now we skip tests that don't have an output XML to show that the this

[PATCH 17/23] qemuxml2argvtest: Extract setup/parse step

2024-01-08 Thread Peter Krempa
Extract the common setup and parsing of the input XML into a separate helper testQemuConfXMLCommon(). The helper has semantics which will allow us to call it from multiple places so that VIR_TEST_RANGE will still work properly even when we'll add multiple steps reusing the prepared data. Signed-of

[PATCH 18/23] qemuxml2argvtest: Add parsing of the input XML as separate test

2024-01-08 Thread Peter Krempa
Get clean separation between the parsing and argv conversion so that it's obvious in the test output: 2409) QEMU XML def parse s390-async-teardown.s390x-6.0.0... libvirt: QEMU Driver error : unsupported configuration: asynchronous teardown is not available with this QEMU binary O

[PATCH 16/23] qemuxml2argvtest: Setup fake driver only once

2024-01-08 Thread Peter Krempa
Move the setup of the fake driver from testCompareXMLToArgv to 'mymain'. With this we also won't need to reset the fake drivers which was done only partially. Signed-off-by: Peter Krempa --- tests/qemuxml2argvtest.c | 34 -- 1 file changed, 16 insertions(+), 18 de

[PATCH 14/23] qemuxml2argvtest: Remove unused separate parsing of arch

2024-01-08 Thread Peter Krempa
Prior to all tests being converted to "DO_TEST_CAPS*" invocation the fake-caps tests required knowing the architecture, which was pre-parsed in qemuxml2argvtest. This code was now removed, but the arch parser was forgotten. Signed-off-by: Peter Krempa --- tests/qemuxml2argvtest.c | 8 1

[PATCH 11/23] qemuxml2xmltest: Parse all input files as inactive

2024-01-08 Thread Peter Krempa
In previous patches we've added testing of XML's explicitly parsed as active (ensuring that it e.g. has a domain id) formatted into both active and inactive versions. Now qemuxml2xmltest can be simplified by making it test only XMLs parsed as inactive. To do this we pass VIR_DOMAIN_DEF_PARSE_INAC

[PATCH 15/23] qemuxml2argvtest: Use virDomainDefParseFile instead of virXMLParse+virDomainDefParseNode

2024-01-08 Thread Peter Krempa
As we don't do any additional parsing of the input file in qemuxml2argvtest we can simplify the code. Signed-off-by: Peter Krempa --- tests/qemuxml2argvtest.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 226f

[PATCH 10/23] qemuxmlactivetest: Add qemu active XML to active/inactive XML tests

2024-01-08 Thread Peter Krempa
Add explicit test cases for XMLs from qemuxml2argvdata which historically had different output in qemuxml2xmltest. qemuxmlactivetest explicitly ensures that the input XMLs are parsed in 'live' state and formatted both in inactive as well as live state, rather than the previously present inactive->

[PATCH 13/23] qemuxml2xmltest: Remove pointless inactive->active testing

2024-01-08 Thread Peter Krempa
'virDomainDefFormatInternalSetRootName' which is the top level XML formatter function has the following condition as the very first thing: if (def->id == -1) flags |= VIR_DOMAIN_DEF_FORMAT_INACTIVE; This makes it pointless to separately do inactive->active and inactive->inactive XML

[PATCH 12/23] qemuxml2*test: Remove FLAG_SKIP_CONFIG_ACTIVE flag

2024-01-08 Thread Peter Krempa
Neither qemuxml2argvtest nor qemuxml2xmltest now test configs parsed as active, thus this flag is no longer needed. Signed-off-by: Peter Krempa --- tests/qemuxml2argvtest.c | 3 +-- tests/qemuxml2xmltest.c | 13 + tests/testutilsqemu.h| 3 +-- 3 files changed, 7 insertions(+),

[PATCH 09/23] qemuxmlactivetest: Prepare for proper active/inactive -> active/inactive testing

2024-01-08 Thread Peter Krempa
Currently the xml->xml testing we have in qemuxml2xmltest covers only 3 of the 4 possibilities: By invocation: active -> active; inactive -> inactive; by unintentionally: active -> inactive (for configs which don't set an 'id' as the formatter assumes it's inactive)

[PATCH 00/23] qemu XML testing improvements, part 2 - enforcement of xml->xml testing

2024-01-08 Thread Peter Krempa
TL;DR: Patch 23/23 is optional, read below! This patch saga aims to improve and simplify testing of qemu XML configs. Part 1 ensured that all input XMLs are invoked from qemuxml2argvtest In part 2 I've focused on untangling xml->xml testing, explaining and cleaning up cases which don't make sens

[PATCH 08/23] qemu*xml2*test: Invoke tests from a function

2024-01-08 Thread Peter Krempa
Refactor the code so that the test macros invoke a helper function with no additional steps. This change prevents regressions in compilation time when adding extra steps for the tests, which happen when the test macro gets too complicated. Signed-off-by: Peter Krempa --- tests/qemuxml2argvtest.c

[PATCH 07/23] testutilsqemu: Create a typedef for struct testQemuInfo

2024-01-08 Thread Peter Krempa
The typedef will come in handy to create an autoptr cleaning function later on. Signed-off-by: Peter Krempa --- tests/qemuxml2argvtest.c | 14 +++--- tests/qemuxml2xmltest.c | 12 ++-- tests/qemuxmlactivetest.c | 6 +++--- tests/testutilsqemu.c | 6 +++--- tests/testutil

[PATCH 06/23] tests: Rename 'qemustatusxml2xmltest' to 'qemuxmlactivetest'

2024-01-08 Thread Peter Krempa
The test will be testing both status XMLs and active XMLs. Rename it to a shorter name. Signed-off-by: Peter Krempa --- tests/meson.build | 2 +- tests/{qemustatusxml2xmltest.c => qemuxmlactivetest.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) renam

[PATCH 05/23] testCompareDomXML2XMLFiles: Sanitize handling of 'parse_flags'

2024-01-08 Thread Peter Krempa
Get rid of the extra temporary variable and set the parse and format flags based on liveness together. Signed-off-by: Peter Krempa --- tests/testutils.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index 6ee78cca3c..8d4e7f84bf

[PATCH 04/23] qemuxml2xmltest: Use same parameters as in qemuxml2argvtest for 'riscv64-virt'

2024-01-08 Thread Peter Krempa
The main idea of the test is to validate config when PCIe is compiled out. Signed-off-by: Peter Krempa --- .../riscv64-virt.riscv64-latest.xml | 20 ++- tests/qemuxml2xmltest.c | 5 - 2 files changed, 6 insertions(+), 19 deletions(-) diff --g

[PATCH 03/23] qemuxmlargvdata: disk-network-nfs: Drop 'index' attribute from backing store

2024-01-08 Thread Peter Krempa
Index is auto-allocated normally. Additionally we now don't need the extra active/inactive version of this test. Signed-off-by: Peter Krempa --- tests/qemuxml2argvdata/disk-network-nfs.xml | 2 +- ...isk-network-nfs-inactive.x86_64-latest.xml | 55 --- .../disk-network-nfs.x86

[PATCH 02/23] qemuxml2xmltest: Add invocation for 'numatune-auto-nodeset-invalid' case

2024-01-08 Thread Peter Krempa
The test case requires an exception in virschematest as the output file is no longer invalid. Signed-off-by: Peter Krempa --- ...une-auto-nodeset-invalid.x86_64-latest.xml | 44 +++ tests/qemuxml2xmltest.c | 1 + tests/virschematest.c

[PATCH 01/23] virschematest: Add possibility to have exceptions from the '-invalid' suffix

2024-01-08 Thread Peter Krempa
The exception is needed in qemuxml2xmltest which is in one instance testing update from an invalid config to a valid one. Currently the compliance with the test is achieved via a hack. As further patches will be simpler without the hack present we need a way to invert the expected output in specif

Re: [ PATCH vf-token 0/8] Introduce vf-token when using userspace PF

2024-01-08 Thread Vivek Kashyap
... As I've stated above, for libvirt we should consider only passing it via the 'secret' object. Sounds good. Will follow this up. Alex - will you be working on the qemu update? Forgot to add: If you need a way to test it with a libvirt-started VM in the interim until the qemu commandline

Re: Re: Re: [PATCH 3/3] ci: Add notes for integration jobs

2024-01-08 Thread Andrea Bolognani
On Mon, Jan 08, 2024 at 12:07:16PM +, Daniel P. Berrangé wrote: > On Mon, Jan 08, 2024 at 02:57:40AM -0800, Andrea Bolognani wrote: > > On Mon, Jan 08, 2024 at 11:54:00AM +0100, Peter Krempa wrote: > > > On Mon, Jan 08, 2024 at 11:43:24 +0100, Andrea Bolognani wrote: > > > > +++ b/ci/integratio

Re: Re: [PATCH 3/3] ci: Add notes for integration jobs

2024-01-08 Thread Daniel P . Berrangé
On Mon, Jan 08, 2024 at 02:57:40AM -0800, Andrea Bolognani wrote: > On Mon, Jan 08, 2024 at 11:54:00AM +0100, Peter Krempa wrote: > > On Mon, Jan 08, 2024 at 11:43:24 +0100, Andrea Bolognani wrote: > > > These are special in that, when a new target is introduced, some > > > preparation is needed be

Re: [ PATCH vf-token 0/8] Introduce vf-token when using userspace PF

2024-01-08 Thread Peter Krempa
On Mon, Jan 08, 2024 at 12:44:01 +0100, Peter Krempa wrote: > On Mon, Jan 08, 2024 at 17:05:45 +0530, Vivek Kashyap wrote: > > > > > > If there is even a slight expectation of confidentiality (IMO just > > > calling it a 'secret' in documentation is enough to justify that > > > expectation) it sho

Re: [ PATCH vf-token 0/8] Introduce vf-token when using userspace PF

2024-01-08 Thread Peter Krempa
On Mon, Jan 08, 2024 at 17:05:45 +0530, Vivek Kashyap wrote: > > > > If there is even a slight expectation of confidentiality (IMO just > > calling it a 'secret' in documentation is enough to justify that > > expectation) it should be treated as such. > > > > Thus qemu needs to add the possibilit

Re: [ PATCH vf-token 0/8] Introduce vf-token when using userspace PF

2024-01-08 Thread Vivek Kashyap
If there is even a slight expectation of confidentiality (IMO just calling it a 'secret' in documentation is enough to justify that expectation) it should be treated as such. Thus qemu needs to add the possibility to pass it via the 'secret' object, so that libvirt can pass it encrypted. On the

Re: Re: [PATCH 3/3] ci: Add notes for integration jobs

2024-01-08 Thread Andrea Bolognani
On Mon, Jan 08, 2024 at 11:54:00AM +0100, Peter Krempa wrote: > On Mon, Jan 08, 2024 at 11:43:24 +0100, Andrea Bolognani wrote: > > These are special in that, when a new target is introduced, some > > preparation is needed before the changes can be merged. Since > > this only happens every six mont

Re: [PATCH 3/3] ci: Add notes for integration jobs

2024-01-08 Thread Peter Krempa
On Mon, Jan 08, 2024 at 11:43:24 +0100, Andrea Bolognani wrote: > These are special in that, when a new target is introduced, some > preparation is needed before the changes can be merged. Since > this only happens every six months or so, it's unsurprising that > we keep messing it up and forgettin

Re: Re: [PATCH 0/2] ci: Update to Fedora 39

2024-01-08 Thread Andrea Bolognani
On Mon, Jan 08, 2024 at 10:48:58AM +0100, Peter Krempa wrote: > On Mon, Jan 08, 2024 at 10:35:53 +0100, Peter Krempa wrote: > > On Thu, Dec 14, 2023 at 09:28:15 +0100, Michal Privoznik wrote: > > > Green pipeline: > > > > > > https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1106643445 > > > >

[PATCH 3/3] ci: Add notes for integration jobs

2024-01-08 Thread Andrea Bolognani
These are special in that, when a new target is introduced, some preparation is needed before the changes can be merged. Since this only happens every six months or so, it's unsurprising that we keep messing it up and forgetting some steps. Having notes right in the file will hopefully help going f

[PATCH 1/3] ci: Fix upstream-qemu job definitions

2024-01-08 Thread Andrea Bolognani
These are jobs are supposed to be running tests using a QEMU binary built from the latest upstream sources, but right now they're just doing the same thing as the other jobs for the target. Use the correct job templates. Signed-off-by: Andrea Bolognani --- ci/integration.yml | 4 ++-- 1 file cha

[PATCH 2/3] ci: Move upstream-qemu job to Fedora 39

2024-01-08 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- ci/integration.yml | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/ci/integration.yml b/ci/integration.yml index c234696d10..ff1bb5d81d 100644 --- a/ci/integration.yml +++ b/ci/integration.yml @@

[PATCH 0/3] ci: Fixes for integration jobs

2024-01-08 Thread Andrea Bolognani
Andrea Bolognani (3): ci: Fix upstream-qemu job definitions ci: Move upstream-qemu job to Fedora 39 ci: Add notes for integration jobs ci/integration.yml | 58 +++--- 1 file changed, 39 insertions(+), 19 deletions(-) -- 2.43.0

Re: [PATCH 0/2] ci: Update to Fedora 39

2024-01-08 Thread Peter Krempa
On Mon, Jan 08, 2024 at 10:35:53 +0100, Peter Krempa wrote: > On Thu, Dec 14, 2023 at 09:28:15 +0100, Michal Privoznik wrote: > > Green pipeline: > > > > https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1106643445 > > > > Michal Prívozník (2): > > ci: integration: Switch upstream integrat

Re: [PATCH 0/2] ci: Update to Fedora 39

2024-01-08 Thread Peter Krempa
On Thu, Dec 14, 2023 at 09:28:15 +0100, Michal Privoznik wrote: > Green pipeline: > > https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1106643445 > > Michal Prívozník (2): > ci: integration: Switch upstream integration tests to Fedora 39 For future reference, please note that the integra

Re: [PATCH v2 1/4] conf: Introduce dynamicMemslots attribute for virtio-mem

2024-01-08 Thread David Hildenbrand
On 08.01.24 09:38, Peter Krempa wrote: On Fri, Jan 05, 2024 at 18:30:56 +0100, David Hildenbrand wrote: On 05.01.24 14:58, Peter Krempa wrote: On Fri, Jan 05, 2024 at 14:34:53 +0100, David Hildenbrand wrote: On 05.01.24 13:40, Peter Krempa wrote: On Fri, Jan 05, 2024 at 13:33:32 +0100, Michal

Re: [PATCH v2 1/4] conf: Introduce dynamicMemslots attribute for virtio-mem

2024-01-08 Thread Peter Krempa
On Fri, Jan 05, 2024 at 18:30:56 +0100, David Hildenbrand wrote: > On 05.01.24 14:58, Peter Krempa wrote: > > On Fri, Jan 05, 2024 at 14:34:53 +0100, David Hildenbrand wrote: > > > On 05.01.24 13:40, Peter Krempa wrote: > > > > On Fri, Jan 05, 2024 at 13:33:32 +0100, Michal Privoznik wrote: [...]