Re: [PATCH rfcv3 00/11] LIBVIRT: X86: TDX support

Hello, Thanks for the submission. A few initial general comments: On 11/27/23 2:55 AM, Zhenzhong Duan wrote: Hi, This series brings libvirt the x86 TDX support. * What's TDX? TDX stands for Trust Domain Extensions which isolates VMs from the virtual-machine manager (VMM)/hypervisor and any ot

[libvirt PATCH 1/9] rpm: Drop MinGW BuildRequires on libgcrypt/libgpg-error

They've been there since the start, but we don't seem to be using them for anything. The native part doesn't have BuildRequires on the native equivalents. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 4 1 file changed, 4 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in

[libvirt PATCH 9/9] ci: Stop passing --nodeps to rpmbuild

All BuildRequires should now be part of the build environment, so it's no longer needed. This ensures that, if we forget to add some BuildRequires to the build environment in the future, the mistake will be quickly detected. Signed-off-by: Andrea Bolognani --- ci/jobs.sh | 1 - 1 file changed,

[libvirt PATCH 8/9] ci: Refresh generated files

Add black, drop scrub. Signed-off-by: Andrea Bolognani --- ci/buildenv/almalinux-8.sh| 5 - ci/buildenv/alpine-317.sh | 1 + ci/buildenv/alpine-edge.sh| 1 + ci/buildenv/centos-stream-8.sh

[libvirt PATCH 7/9] rpm: Drop BuildDepends on passt

Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 3 --- 1 file changed, 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 5a5adf86bc..1d0ec5073d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -391,9 +391,6 @@ BuildRequires: libssh2-devel >= 1.3.0 %endif %i

[libvirt PATCH 6/9] rpm: Drop BuildDepends on scrub

Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 6f58ed3899..5a5adf86bc 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -408,8 +408,6 @@ BuildRequires: systemtap-sdt-devel BuildRequires: util-li

[libvirt PATCH 5/9] rpm: Add Requires on scrub

We currently have a BuildDepends on it, which doesn't help ensuring that the tool is available at runtime, when the storage driver might need to spawn it. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in i

[libvirt PATCH 0/9] rpm: Tweak dependencies

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1092535621 lcitool changes: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/447 Andrea Bolognani (9): rpm: Drop MinGW BuildRequires on libgcrypt/libgpg-error meson: Stop looking for udevadm at build time meson: Stop lookin

[libvirt PATCH 4/9] meson: Stop looking for passt at build time

We only use it at runtime, not during the build process. Signed-off-by: Andrea Bolognani --- meson.build | 1 - src/qemu/qemu_passt.c | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index fa4062df2f..4d96b32e58 100644 --- a/meson.build +

[libvirt PATCH 3/9] meson: Stop looking for scrub at build time

We only use it at runtime, not during the build process. Signed-off-by: Andrea Bolognani --- meson.build| 1 - src/storage/storage_util.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index fdff8dcb97..fa4062df2f 100644 --- a/meson.

[libvirt PATCH 2/9] meson: Stop looking for udevadm at build time

We only use it at runtime, not during the build process. Signed-off-by: Andrea Bolognani --- meson.build| 1 - src/util/virutil.c | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5fb827cca8..fdff8dcb97 100644 --- a/meson.build +++ b/me

[PATCH] gitpublish: Tweak prefix

Having the name of the project as part of the prefix was useful back when we used the mailing list for all subprojects, but these days the only patches that are sent to the list are for the main library so it no longer makes sense to include this. Signed-off-by: Andrea Bolognani --- .gitpublish

[PATCH] NEWS: Fix indentation

Signed-off-by: Andrea Bolognani --- Pushed as trivial. NEWS.rst | 39 --- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index c0a6d180a2..dc40602c72 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -176,10 +176,10 @@ v9.6.0 (2023-0

[PATCH] NEWS: Fix vertical spacing

Signed-off-by: Andrea Bolognani --- Pushed as trivial. NEWS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index 29b977565b..c0a6d180a2 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -89,6 +89,7 @@ v9.9.0 (2023-11-01) The ``virsh create --console``

Release of libvirt-9.10.0

The 9.10.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedba

Re: [libvirt PATCH 1/1] rpcgen: Skip generator tests on macOS

On Fri, Dec 01, 2023 at 11:58:05AM +, Daniel P. Berrangé wrote: > On Thu, Nov 30, 2023 at 08:29:55PM +0100, Andrea Bolognani wrote: > > The generator can produce different code on Linux and macOS: > > specifically, on the former we want to use xdr_uint64_t while > > the latter needs xdr_u_int64

Re: [PATCH 2/2] Report better error message in remoteGetUNIXSocket

On Fri, Dec 01, 2023 at 01:22:14PM +0100, Martin Kletzander wrote: > On Thu, Nov 30, 2023 at 09:48:10AM +, Richard W.M. Jones wrote: > >On Thu, Nov 30, 2023 at 10:06:38AM +0100, Peter Krempa wrote: > >>On Thu, Nov 30, 2023 at 09:49:56 +0100, Martin Kletzander wrote: > >>> On Wed, Nov 29, 2023 a

Re: [PATCH 2/2] Report better error message in remoteGetUNIXSocket

On Thu, Nov 30, 2023 at 09:48:10AM +, Richard W.M. Jones wrote: On Thu, Nov 30, 2023 at 10:06:38AM +0100, Peter Krempa wrote: On Thu, Nov 30, 2023 at 09:49:56 +0100, Martin Kletzander wrote: > On Wed, Nov 29, 2023 at 06:33:54PM +, Richard W.M. Jones wrote: > > > > Can we have the error m

Re: [libvirt PATCH 1/1] rpcgen: Skip generator tests on macOS

On Thu, Nov 30, 2023 at 08:29:55PM +0100, Andrea Bolognani wrote: > The generator can produce different code on Linux and macOS: > specifically, on the former we want to use xdr_uint64_t while > the latter needs xdr_u_int64_t instead. > > This is clearly a problem for tests that involve comparing

Re: [PATCH] NEWS: Mention image probing, snaphsot and hotplug fixes

On Fri, Dec 01, 2023 at 11:16:51 +0100, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > NEWS.rst | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index f12734c2a1..9739bcdc36 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -24,8 +24,3

Re: [PATCH for 9.9.0] qemuProcessStartWithMemoryState: Don't start qemu with '-loadvm SNAP' and '-incoming defer' together

On Fri, Dec 01, 2023 at 10:41:59AM +0100, Peter Krempa wrote: > A bug in qemuProcessStartWithMemoryState caused that we would start qemu > with '-loadvm SNAP' and '-incoming defer' together. qemu doesn't expect > that and crashes on an assertion failure [1]. > > [1]: https://issues.redhat.com/bro

[PATCH] NEWS: Mention image probing, snaphsot and hotplug fixes

Signed-off-by: Peter Krempa --- NEWS.rst | 22 ++ 1 file changed, 22 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index f12734c2a1..9739bcdc36 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -24,8 +24,30 @@ v9.10.0 (unreleased) * **Improvements** + * Adapt to qemu's use of prot

[PATCH for 9.9.0] qemuProcessStartWithMemoryState: Don't start qemu with '-loadvm SNAP' and '-incoming defer' together

A bug in qemuProcessStartWithMemoryState caused that we would start qemu with '-loadvm SNAP' and '-incoming defer' together. qemu doesn't expect that and crashes on an assertion failure [1]. [1]: https://issues.redhat.com/browse/RHEL-16782 Fixes: 8a88d3e5860881f430e528d3e5e8d6455ded4d1d Resolves