On Tue, Nov 28, 2023 at 07:03:13PM +0100, Andrea Bolognani wrote:
> We no longer use it, so commit a62486b95fee correctly dropped
> the Build-Requires; shortly afterwards, however, I accidentally
> re-introduced it by mistake.
>
> Fixes: 3df8cc658ed0ac2f84089ad0db61ba20eb8b8aa7
> Signed-off-by: An
On 11/28/2023 11:52 AM, Daniel P. Berrangé wrote:
On Tue, Nov 28, 2023 at 11:43:11AM -0600, Praveen K Paladugu wrote:
On 11/28/2023 9:59 AM, Michal Privoznik wrote:
During CH driver initialization (chStateInitialize()) the
driver's capabilities bitmap is allocated
(virCHCapsInitCHVersionCap
We no longer use it, so commit a62486b95fee correctly dropped
the Build-Requires; shortly afterwards, however, I accidentally
re-introduced it by mistake.
Fixes: 3df8cc658ed0ac2f84089ad0db61ba20eb8b8aa7
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 1 -
1 file changed, 1 deletion(-)
dif
On Tue, Nov 28, 2023 at 11:43:11AM -0600, Praveen K Paladugu wrote:
>
>
> On 11/28/2023 9:59 AM, Michal Privoznik wrote:
> > During CH driver initialization (chStateInitialize()) the
> > driver's capabilities bitmap is allocated
> > (virCHCapsInitCHVersionCaps()), but corresponding free call is
>
On 11/28/2023 9:59 AM, Michal Privoznik wrote:
During CH driver initialization (chStateInitialize()) the
driver's capabilities bitmap is allocated
(virCHCapsInitCHVersionCaps()), but corresponding free call is
missing in chStateCleanup().
And while at it, reorder calls to virObjectUnref() insi
On a Tuesday in 2023, Michal Privoznik wrote:
*** BLURB HERE ***
Michal Prívozník (4):
virpci: Decrease scope of VIR_PF_PHYS_PORT_NAME_REGEX macro
qemu_command: Don't open code virPCIDeviceAddressAsString()
vircpi: Decrease scope of VIR_PCI_DEVICE_ADDRESS_FMT macro
ch: Don't leak ch_driver->
On 11/28/23 9:59 AM, Michal Privoznik wrote:
*** BLURB HERE ***
Michal Prívozník (4):
virpci: Decrease scope of VIR_PF_PHYS_PORT_NAME_REGEX macro
qemu_command: Don't open code virPCIDeviceAddressAsString()
vircpi: Decrease scope of VIR_PCI_DEVICE_ADDRESS_FMT macro
ch: Don't leak ch_d
On 11/28/23 9:59 AM, Michal Privoznik wrote:
When building a hostdev props, its PCI address is formatted via
g_strdup_printf(VIR_PCI_DEVICE_ADDRESS_FMT, ...); Well, we have a
function that does exactly that: virPCIDeviceAddressAsString().
Us the latter.
s/Us/Use/
Signed-off-by: Michal Privoz
When building a hostdev props, its PCI address is formatted via
g_strdup_printf(VIR_PCI_DEVICE_ADDRESS_FMT, ...); Well, we have a
function that does exactly that: virPCIDeviceAddressAsString().
Us the latter.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_command.c | 6 +-
1 file changed,
During CH driver initialization (chStateInitialize()) the
driver's capabilities bitmap is allocated
(virCHCapsInitCHVersionCaps()), but corresponding free call is
missing in chStateCleanup().
And while at it, reorder calls to virObjectUnref() inside of
chStateCleanup() to be the reverse order of t
The VIR_PCI_DEVICE_ADDRESS_FMT macro is used only in virpci.c and
nowhere else. It's not necessary to expose it in the header file.
Signed-off-by: Michal Privoznik
---
src/util/virpci.c | 1 +
src/util/virpci.h | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/util/virpci
The VIR_PF_PHYS_PORT_NAME_REGEX macro is used only in
virPCIGetNetName() and nowhere else. It's not necessary to expose
it in the header file.
Signed-off-by: Michal Privoznik
---
src/util/virpci.c | 8
src/util/virpci.h | 5 -
2 files changed, 8 insertions(+), 5 deletions(-)
diff -
*** BLURB HERE ***
Michal Prívozník (4):
virpci: Decrease scope of VIR_PF_PHYS_PORT_NAME_REGEX macro
qemu_command: Don't open code virPCIDeviceAddressAsString()
vircpi: Decrease scope of VIR_PCI_DEVICE_ADDRESS_FMT macro
ch: Don't leak ch_driver->chCaps
src/ch/ch_driver.c | 5 +++--
[Cross-posted to KVM, Rust-VMM, QEMU, and libvirt lists)
Hi, the CFP for the "Virt & IaaS" DevRoom is out[+].
Something new this year is a new talk-submission system: so you need to
create a new account, even if you've had an account with the older
talk-submission system. Details in the "Submit
On Mon, Nov 06, 2023 at 02:38:58 -0500, Laine Stump wrote:
> Add a surprisingly missing simple function to the arsenal.
I'd almost prefer to have this simply inlined into the only user.
>
> Signed-off-by: Laine Stump
> ---
> src/libvirt_private.syms | 1 +
> src/util/virstring.c | 17
On Mon, Nov 06, 2023 at 02:39:00 -0500, Laine Stump wrote:
> Rather than always binding to the vfio-pci driver, use the new
> function virPCIDeviceFindBestVFIOVariant() to see if the running
> kernel has a VFIO variant driver available that is a better match for
> the device, and if one is found, u
On a Saturday in 2023, Guoyi Tu wrote:
Currently, libvirt creates a thread pool with only on thread to handle all
qemu monitor events for virtual machines, In the cases that if the thread
gets stuck while handling a monitor EOF event, such as unable to kill the
virtual machine process or release
On Mon, Nov 06, 2023 at 02:38:59 -0500, Laine Stump wrote:
> Only in qemuhotplug test, in order to not fail when running the
> test on macOS.
>
> This is a temporary measure until I decice how best to make a mock
> environment that allows virPCIDeviceFindBestVariant() to succeed on
> non-Linux pla
On Mon, Nov 06, 2023 at 02:38:57 -0500, Laine Stump wrote:
> This patch makes it possible to manually specify which VFIO variant
> driver to use for PCI hostdev device assignment, so that, e.g. you
> could force use of the generic vfio-pci driver with
>
>
>
> when libvirt would have normally (
On Tue, Nov 28, 2023 at 13:22:47 +, Daniel P. Berrangé wrote:
> On Tue, Nov 28, 2023 at 01:02:40PM +0100, Martin Kletzander wrote:
> > Before this patch users might be confused with the error when no daemon
> > nor systemd socket unit is running due to the error message being a bit
> > vague wh
On Tue, Nov 28, 2023 at 01:02:40PM +0100, Martin Kletzander wrote:
> Before this patch users might be confused with the error when no daemon
> nor systemd socket unit is running due to the error message being a bit
> vague when running as root with no URI:
>
> # virsh list
> error: failed to c
The commit message is longer than it needs to be and the long
explanation actually made it harder to comprehend for me.
On a Monday in 2023, Laine Stump wrote:
Historically libvirt has treated the concept of "loadable kernel
module" and "device driver" as being effectively the same (at least in
On 11/9/23 12:14, Thanos Makatos wrote:
> Signed-off-by: Thanos Makatos
>
> ---
>
> Changed since v4:
> * removed inadvertent calls to functions
> virNWFilterReadLockFilterUpdates/virNWFilterUnlockFilterUpdates
> (original patch was based on v8.0.0)
>
> ---
> src/test/test_driver.c | 382 ++
On Tue, Nov 28, 2023 at 14:04:12 +0100, Peter Krempa wrote:
> On Tue, Nov 28, 2023 at 13:02:39 +0100, Martin Kletzander wrote:
> > This will improve an error message later on.
> >
> > Signed-off-by: Martin Kletzander
> > ---
> > src/remote/remote_daemon_dispatch.c | 2 +-
> > src/remote/remote_
On Tue, Nov 28, 2023 at 13:02:39 +0100, Martin Kletzander wrote:
> This will improve an error message later on.
>
> Signed-off-by: Martin Kletzander
> ---
> src/remote/remote_daemon_dispatch.c | 2 +-
> src/remote/remote_sockets.c | 11 +--
> src/remote/remote_sockets.h
On Tue, Nov 28, 2023 at 01:02:39PM +0100, Martin Kletzander wrote:
> This will improve an error message later on.
>
> Signed-off-by: Martin Kletzander
> ---
> src/remote/remote_daemon_dispatch.c | 2 +-
> src/remote/remote_sockets.c | 11 +--
> src/remote/remote_sockets.h
On Tue, Nov 28, 2023 at 01:02:40PM +0100, Martin Kletzander wrote:
> Before this patch users might be confused with the error when no daemon
> nor systemd socket unit is running due to the error message being a bit
> vague when running as root with no URI:
>
> # virsh list
> error: failed to c
Before this patch users might be confused with the error when no daemon
nor systemd socket unit is running due to the error message being a bit
vague when running as root with no URI:
# virsh list
error: failed to connect to the hypervisor
error: Operation not supported: Cannot use direct so
When opening a libvirt connection with no URI set and no daemon running the
error message might be confusing at times, so these patches are trying to
mitigate such confusion.
Martin Kletzander (2):
Report first tried socket from remoteProbeSystemDriverFromSocket
Report better error message in
This will improve an error message later on.
Signed-off-by: Martin Kletzander
---
src/remote/remote_daemon_dispatch.c | 2 +-
src/remote/remote_sockets.c | 11 +--
src/remote/remote_sockets.h | 2 +-
3 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/re
30 matches
Mail list logo
